[PR PATCH] Remove package: librpcsecgss

[PR PATCH] Remove package: librpcsecgss

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1580 bytes --]

There is a new pull request by Johnnynator against master on the void-packages repository

https://github.com/Johnnynator/void-packages rm-librpcsecgss
https://github.com/void-linux/void-packages/pull/28212

Remove package: librpcsecgss
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28212.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rm-librpcsecgss-28212.patch --]
[-- Type: text/x-diff, Size: 2249 bytes --]

From 3b35cdab9c95ebdafd3ffa7864138b8b346dd09d Mon Sep 17 00:00:00 2001
From: John <me@johnnynator.dev>
Date: Mon, 25 Jan 2021 08:34:46 +0100
Subject: [PATCH] Remove package: librpcsecgss

broke with glibc-2.32
does not compile with libtirpc
---
 common/shlibs                 |  1 -
 srcpkgs/librpcsecgss-devel    |  1 -
 srcpkgs/librpcsecgss/template | 32 --------------------------------
 3 files changed, 34 deletions(-)
 delete mode 120000 srcpkgs/librpcsecgss-devel
 delete mode 100644 srcpkgs/librpcsecgss/template

diff --git a/common/shlibs b/common/shlibs
index 979daeddbf1..9aed87d3ce7 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -1034,7 +1034,6 @@ libobt.so.2 libopenbox-3.5.2_1
 libobrender.so.32 libopenbox-3.6.1_1
 libgssglue.so.1 libgssglue-0.3_1
 libtirpc.so.3 libtirpc-1.0.2_1
-librpcsecgss.so.3 librpcsecgss-0.19_1
 libnfsidmap.so.1 libnfsidmap-2.4.3_2
 libbind9.so.1600 bind-libs-9.16.2_1
 libdns.so.1607 bind-libs-9.16.7_1
diff --git a/srcpkgs/librpcsecgss-devel b/srcpkgs/librpcsecgss-devel
deleted file mode 120000
index 328b419146d..00000000000
--- a/srcpkgs/librpcsecgss-devel
+++ /dev/null
@@ -1 +0,0 @@
-librpcsecgss
\ No newline at end of file
diff --git a/srcpkgs/librpcsecgss/template b/srcpkgs/librpcsecgss/template
deleted file mode 100644
index d20446cb3ce..00000000000
--- a/srcpkgs/librpcsecgss/template
+++ /dev/null
@@ -1,32 +0,0 @@
-# Template file for 'librpcsecgss'
-pkgname=librpcsecgss
-version=0.19
-revision=5
-build_style=gnu-configure
-hostmakedepends="pkg-config"
-makedepends="libgssglue-devel"
-short_desc="Library for RPCSECGSS support"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="BSD-3-Clause"
-homepage="http://www.citi.umich.edu/projects/nfsv4/linux/"
-distfiles="$homepage/$pkgname/$pkgname-$version.tar.gz"
-checksum=0cafb86b67e5eb4c89e8abaaad9165298946bc164d258e8925fc6dc1fa913abd
-
-case "$XBPS_TARGET_LIBC" in
-	musl) broken="rpc/rpc.h header is not available on musl"
-esac
-
-post_install() {
-	vlicense COPYING
-}
-
-librpcsecgss-devel_package() {
-	depends="libgssglue-devel ${sourcepkg}>=${version}_${revision}"
-	short_desc+=" - development files"
-	pkg_install() {
-		vmove usr/include
-		vmove usr/lib/pkgconfig
-		vmove "usr/lib/*.a"
-		vmove "usr/lib/*.so"
-	}
-}

Re: [PR PATCH] [Updated] Remove package: librpcsecgss

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1585 bytes --]

There is an updated pull request by Johnnynator against master on the void-packages repository

https://github.com/Johnnynator/void-packages rm-librpcsecgss
https://github.com/void-linux/void-packages/pull/28212

Remove package: librpcsecgss
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28212.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rm-librpcsecgss-28212.patch --]
[-- Type: text/x-diff, Size: 2736 bytes --]

From 38afce2cecea2109239ccc2a7581b0d2c9ae66f4 Mon Sep 17 00:00:00 2001
From: John <me@johnnynator.dev>
Date: Mon, 25 Jan 2021 08:34:46 +0100
Subject: [PATCH] Remove package: librpcsecgss

broke with glibc-2.32
does not compile with libtirpc
---
 common/shlibs                     |  1 -
 srcpkgs/librpcsecgss-devel        |  1 -
 srcpkgs/librpcsecgss/template     | 32 -------------------------------
 srcpkgs/removed-packages/template |  2 ++
 4 files changed, 2 insertions(+), 34 deletions(-)
 delete mode 120000 srcpkgs/librpcsecgss-devel
 delete mode 100644 srcpkgs/librpcsecgss/template

diff --git a/common/shlibs b/common/shlibs
index 979daeddbf1..9aed87d3ce7 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -1034,7 +1034,6 @@ libobt.so.2 libopenbox-3.5.2_1
 libobrender.so.32 libopenbox-3.6.1_1
 libgssglue.so.1 libgssglue-0.3_1
 libtirpc.so.3 libtirpc-1.0.2_1
-librpcsecgss.so.3 librpcsecgss-0.19_1
 libnfsidmap.so.1 libnfsidmap-2.4.3_2
 libbind9.so.1600 bind-libs-9.16.2_1
 libdns.so.1607 bind-libs-9.16.7_1
diff --git a/srcpkgs/librpcsecgss-devel b/srcpkgs/librpcsecgss-devel
deleted file mode 120000
index 328b419146d..00000000000
--- a/srcpkgs/librpcsecgss-devel
+++ /dev/null
@@ -1 +0,0 @@
-librpcsecgss
\ No newline at end of file
diff --git a/srcpkgs/librpcsecgss/template b/srcpkgs/librpcsecgss/template
deleted file mode 100644
index d20446cb3ce..00000000000
--- a/srcpkgs/librpcsecgss/template
+++ /dev/null
@@ -1,32 +0,0 @@
-# Template file for 'librpcsecgss'
-pkgname=librpcsecgss
-version=0.19
-revision=5
-build_style=gnu-configure
-hostmakedepends="pkg-config"
-makedepends="libgssglue-devel"
-short_desc="Library for RPCSECGSS support"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="BSD-3-Clause"
-homepage="http://www.citi.umich.edu/projects/nfsv4/linux/"
-distfiles="$homepage/$pkgname/$pkgname-$version.tar.gz"
-checksum=0cafb86b67e5eb4c89e8abaaad9165298946bc164d258e8925fc6dc1fa913abd
-
-case "$XBPS_TARGET_LIBC" in
-	musl) broken="rpc/rpc.h header is not available on musl"
-esac
-
-post_install() {
-	vlicense COPYING
-}
-
-librpcsecgss-devel_package() {
-	depends="libgssglue-devel ${sourcepkg}>=${version}_${revision}"
-	short_desc+=" - development files"
-	pkg_install() {
-		vmove usr/include
-		vmove usr/lib/pkgconfig
-		vmove "usr/lib/*.a"
-		vmove "usr/lib/*.so"
-	}
-}
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 7fa5d31e349..9740cc5eff1 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -94,6 +94,8 @@ replaces="
  nvidia340-dkms<=340.108_4
  nvidia340-opencl<=340.108_4
  nvidia340-libs<=340.108_4
+ librpcsecgss<=0.19_6
+ librpcsecgss-devel<=0.19_6
 "
 
 if [ "$XBPS_TARGET_LIBC" = "musl" ]; then

Re: [PR REVIEW] Remove package: librpcsecgss

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28212#discussion_r564164637

Comment:
I think it follows alphabetical order. `nvidia340` is in the wrong place :p 

Re: Remove package: librpcsecgss

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/28212#issuecomment-767958273

Comment:
Wouldn't we use `librpcsecgss: remove package` for the commit name.

Also should we use a seperate commit for removed-packages, as we do for all others.

Re: Remove package: librpcsecgss

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28212#issuecomment-768323778

Comment:
I think a separate commit for removed-packages only makes sense if it's being revbumped (or being changed in ways unrelated to the specific package removal).

Re: [PR PATCH] [Updated] Remove package: librpcsecgss

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1585 bytes --]

There is an updated pull request by Johnnynator against master on the void-packages repository

https://github.com/Johnnynator/void-packages rm-librpcsecgss
https://github.com/void-linux/void-packages/pull/28212

Remove package: librpcsecgss
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28212.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rm-librpcsecgss-28212.patch --]
[-- Type: text/x-diff, Size: 2742 bytes --]

From e4e4f26297dba5303914065c57b9a28c9659e898 Mon Sep 17 00:00:00 2001
From: John <me@johnnynator.dev>
Date: Mon, 25 Jan 2021 08:34:46 +0100
Subject: [PATCH] librpcsecgss: remove package

broke with glibc-2.32
does not compile with libtirpc
---
 common/shlibs                     |  1 -
 srcpkgs/librpcsecgss-devel        |  1 -
 srcpkgs/librpcsecgss/template     | 32 -------------------------------
 srcpkgs/removed-packages/template |  2 ++
 4 files changed, 2 insertions(+), 34 deletions(-)
 delete mode 120000 srcpkgs/librpcsecgss-devel
 delete mode 100644 srcpkgs/librpcsecgss/template

diff --git a/common/shlibs b/common/shlibs
index 75075c2d259..2f298ff9ad3 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -1033,7 +1033,6 @@ libobt.so.2 libopenbox-3.5.2_1
 libobrender.so.32 libopenbox-3.6.1_1
 libgssglue.so.1 libgssglue-0.3_1
 libtirpc.so.3 libtirpc-1.0.2_1
-librpcsecgss.so.3 librpcsecgss-0.19_1
 libnfsidmap.so.1 libnfsidmap-2.4.3_2
 libbind9.so.1600 bind-libs-9.16.2_1
 libdns.so.1607 bind-libs-9.16.7_1
diff --git a/srcpkgs/librpcsecgss-devel b/srcpkgs/librpcsecgss-devel
deleted file mode 120000
index 328b419146d..00000000000
--- a/srcpkgs/librpcsecgss-devel
+++ /dev/null
@@ -1 +0,0 @@
-librpcsecgss
\ No newline at end of file
diff --git a/srcpkgs/librpcsecgss/template b/srcpkgs/librpcsecgss/template
deleted file mode 100644
index d20446cb3ce..00000000000
--- a/srcpkgs/librpcsecgss/template
+++ /dev/null
@@ -1,32 +0,0 @@
-# Template file for 'librpcsecgss'
-pkgname=librpcsecgss
-version=0.19
-revision=5
-build_style=gnu-configure
-hostmakedepends="pkg-config"
-makedepends="libgssglue-devel"
-short_desc="Library for RPCSECGSS support"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="BSD-3-Clause"
-homepage="http://www.citi.umich.edu/projects/nfsv4/linux/"
-distfiles="$homepage/$pkgname/$pkgname-$version.tar.gz"
-checksum=0cafb86b67e5eb4c89e8abaaad9165298946bc164d258e8925fc6dc1fa913abd
-
-case "$XBPS_TARGET_LIBC" in
-	musl) broken="rpc/rpc.h header is not available on musl"
-esac
-
-post_install() {
-	vlicense COPYING
-}
-
-librpcsecgss-devel_package() {
-	depends="libgssglue-devel ${sourcepkg}>=${version}_${revision}"
-	short_desc+=" - development files"
-	pkg_install() {
-		vmove usr/include
-		vmove usr/lib/pkgconfig
-		vmove "usr/lib/*.a"
-		vmove "usr/lib/*.so"
-	}
-}
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 30b4ac8b2bd..0a16d53a3c0 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -140,6 +140,8 @@ replaces="
  libdbusmenu-qt<=0.9.2_4
  libgksu<=2.0.12_5
  libqzeitgeist<=0.8.0_6
+ librpcsecgss<=0.19_6
+ librpcsecgss-devel<=0.19_6
  livewallpaper<=0.5.0_2
  llvm3.9<=3.9.1_5
  ls++-git<=20140919_3

Re: [PR PATCH] [Merged]: Remove package: librpcsecgss

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

There's a merged pull request on the void-packages repository

Remove package: librpcsecgss
https://github.com/void-linux/void-packages/pull/28212

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->