Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] oil: update to 0.8.7.
@ 2021-01-28 19:44 UsernameRandomlyGenerated
  2021-01-28 20:30 ` ericonr
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: UsernameRandomlyGenerated @ 2021-01-28 19:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]

There is a new pull request by UsernameRandomlyGenerated against master on the void-packages repository

https://github.com/UsernameRandomlyGenerated/void-packages oil
https://github.com/void-linux/void-packages/pull/28293

oil: update to 0.8.7.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28293.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-oil-28293.patch --]
[-- Type: text/x-diff, Size: 1048 bytes --]

From 5c6e12ec0c951b50ed5e8bbe2ee500557979d2af Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Thu, 28 Jan 2021 20:43:25 +0100
Subject: [PATCH] oil: update to 0.8.7.

---
 srcpkgs/oil/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/oil/template b/srcpkgs/oil/template
index df432c0f285..0eda6658b98 100644
--- a/srcpkgs/oil/template
+++ b/srcpkgs/oil/template
@@ -1,6 +1,6 @@
 # Template file for 'oil'
 pkgname=oil
-version=0.8.6
+version=0.8.7
 revision=1
 build_style=configure
 configure_args="--prefix=/usr $(vopt_with readline)"
@@ -11,7 +11,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="Apache-2.0"
 homepage="https://www.oilshell.org"
 distfiles="${homepage}/download/${pkgname}-${version}.tar.xz"
-checksum=7d7d66888f325f39ff4fd71b6d9ffb13afed2ecdd15ec5f73e07c2eec0712235
+checksum=29c5eed6efccbef6c22dbe5aec3d3d36f7c93da7a8d1cf19fc2cee93b5d1db73
 python_version=2
 register_shell="/usr/bin/osh"
 nocross="Binaries doesn't build if cross built"

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: oil: update to 0.8.7.
  2021-01-28 19:44 [PR PATCH] oil: update to 0.8.7 UsernameRandomlyGenerated
@ 2021-01-28 20:30 ` ericonr
  2021-01-28 20:30 ` ericonr
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-01-28 20:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28293#issuecomment-769366359

Comment:
I'm reasonably sure the `vsed` line isn't doing anything, I think we should remove it.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: oil: update to 0.8.7.
  2021-01-28 19:44 [PR PATCH] oil: update to 0.8.7 UsernameRandomlyGenerated
  2021-01-28 20:30 ` ericonr
@ 2021-01-28 20:30 ` ericonr
  2021-01-29 18:31 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-01-28 20:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28293#issuecomment-769366494

Comment:
This isn't linked against system python at all.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] oil: update to 0.8.7.
  2021-01-28 19:44 [PR PATCH] oil: update to 0.8.7 UsernameRandomlyGenerated
  2021-01-28 20:30 ` ericonr
  2021-01-28 20:30 ` ericonr
@ 2021-01-29 18:31 ` UsernameRandomlyGenerated
  2021-01-29 21:02 ` [PR REVIEW] " ericonr
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: UsernameRandomlyGenerated @ 2021-01-29 18:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

There is an updated pull request by UsernameRandomlyGenerated against master on the void-packages repository

https://github.com/UsernameRandomlyGenerated/void-packages oil
https://github.com/void-linux/void-packages/pull/28293

oil: update to 0.8.7.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28293.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-oil-28293.patch --]
[-- Type: text/x-diff, Size: 1502 bytes --]

From 8db9c3e9e8934de61f24d61a4e626dcb0f62fa7c Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Thu, 28 Jan 2021 20:43:25 +0100
Subject: [PATCH] oil: update to 0.8.7.

---
 srcpkgs/oil/template | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/oil/template b/srcpkgs/oil/template
index df432c0f285..9bbe6822283 100644
--- a/srcpkgs/oil/template
+++ b/srcpkgs/oil/template
@@ -1,18 +1,17 @@
 # Template file for 'oil'
 pkgname=oil
-version=0.8.6
+version=0.8.7
 revision=1
 build_style=configure
-configure_args="--prefix=/usr $(vopt_with readline)"
-hostmakedepends="$(vopt_if readline readline-devel) python"
+configure_args="--prefix=/usr"
+hostmakedepends="$(vopt_if readline readline-devel)"
 makedepends="$hostmakedepends"
 short_desc="Oil, a new unix shell"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="Apache-2.0"
 homepage="https://www.oilshell.org"
 distfiles="${homepage}/download/${pkgname}-${version}.tar.xz"
-checksum=7d7d66888f325f39ff4fd71b6d9ffb13afed2ecdd15ec5f73e07c2eec0712235
-python_version=2
+checksum=29c5eed6efccbef6c22dbe5aec3d3d36f7c93da7a8d1cf19fc2cee93b5d1db73
 register_shell="/usr/bin/osh"
 nocross="Binaries doesn't build if cross built"
 nostrip=yes
@@ -23,8 +22,6 @@ build_options_default="readline"
 pre_build() {
 	# Remove the strip wrapper
 	rm -f "${XBPS_WRAPPERDIR}"/strip
-	# Use system python
-	vsed -i 's|$PREPARE_DIR/python|python|g' build/actions.sh
 }
 
 do_install() {

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] oil: update to 0.8.7.
  2021-01-28 19:44 [PR PATCH] oil: update to 0.8.7 UsernameRandomlyGenerated
                   ` (2 preceding siblings ...)
  2021-01-29 18:31 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
@ 2021-01-29 21:02 ` ericonr
  2021-01-30  9:20 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-01-29 21:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28293#discussion_r567091629

Comment:
Why did you remove readline?

Also, the commit message should note that these changes are being made.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] oil: update to 0.8.7.
  2021-01-28 19:44 [PR PATCH] oil: update to 0.8.7 UsernameRandomlyGenerated
                   ` (3 preceding siblings ...)
  2021-01-29 21:02 ` [PR REVIEW] " ericonr
@ 2021-01-30  9:20 ` UsernameRandomlyGenerated
  2021-01-30  9:20 ` [PR REVIEW] " UsernameRandomlyGenerated
  2021-02-04  6:16 ` [PR PATCH] [Closed]: " ericonr
  6 siblings, 0 replies; 8+ messages in thread
From: UsernameRandomlyGenerated @ 2021-01-30  9:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

There is an updated pull request by UsernameRandomlyGenerated against master on the void-packages repository

https://github.com/UsernameRandomlyGenerated/void-packages oil
https://github.com/void-linux/void-packages/pull/28293

oil: update to 0.8.7.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28293.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-oil-28293.patch --]
[-- Type: text/x-diff, Size: 1499 bytes --]

From a3334beb2ab824e565820f1b1f3c076290a6799b Mon Sep 17 00:00:00 2001
From: UsernameRandomlyGenerated <coredavid@tutanota.com>
Date: Thu, 28 Jan 2021 20:43:25 +0100
Subject: [PATCH] oil: update to 0.8.7, remove unnecessary python links

---
 srcpkgs/oil/template | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/oil/template b/srcpkgs/oil/template
index df432c0f285..92bd1032b93 100644
--- a/srcpkgs/oil/template
+++ b/srcpkgs/oil/template
@@ -1,18 +1,17 @@
 # Template file for 'oil'
 pkgname=oil
-version=0.8.6
+version=0.8.7
 revision=1
 build_style=configure
 configure_args="--prefix=/usr $(vopt_with readline)"
-hostmakedepends="$(vopt_if readline readline-devel) python"
+hostmakedepends="$(vopt_if readline readline-devel)"
 makedepends="$hostmakedepends"
 short_desc="Oil, a new unix shell"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="Apache-2.0"
 homepage="https://www.oilshell.org"
 distfiles="${homepage}/download/${pkgname}-${version}.tar.xz"
-checksum=7d7d66888f325f39ff4fd71b6d9ffb13afed2ecdd15ec5f73e07c2eec0712235
-python_version=2
+checksum=29c5eed6efccbef6c22dbe5aec3d3d36f7c93da7a8d1cf19fc2cee93b5d1db73
 register_shell="/usr/bin/osh"
 nocross="Binaries doesn't build if cross built"
 nostrip=yes
@@ -23,8 +22,6 @@ build_options_default="readline"
 pre_build() {
 	# Remove the strip wrapper
 	rm -f "${XBPS_WRAPPERDIR}"/strip
-	# Use system python
-	vsed -i 's|$PREPARE_DIR/python|python|g' build/actions.sh
 }
 
 do_install() {

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] oil: update to 0.8.7.
  2021-01-28 19:44 [PR PATCH] oil: update to 0.8.7 UsernameRandomlyGenerated
                   ` (4 preceding siblings ...)
  2021-01-30  9:20 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
@ 2021-01-30  9:20 ` UsernameRandomlyGenerated
  2021-02-04  6:16 ` [PR PATCH] [Closed]: " ericonr
  6 siblings, 0 replies; 8+ messages in thread
From: UsernameRandomlyGenerated @ 2021-01-30  9:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New review comment by UsernameRandomlyGenerated on void-packages repository

https://github.com/void-linux/void-packages/pull/28293#discussion_r567222367

Comment:
My bad, I thought I did that one only on personal branch for testing.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Closed]: oil: update to 0.8.7.
  2021-01-28 19:44 [PR PATCH] oil: update to 0.8.7 UsernameRandomlyGenerated
                   ` (5 preceding siblings ...)
  2021-01-30  9:20 ` [PR REVIEW] " UsernameRandomlyGenerated
@ 2021-02-04  6:16 ` ericonr
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-02-04  6:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]

There's a closed pull request on the void-packages repository

oil: update to 0.8.7.
https://github.com/void-linux/void-packages/pull/28293

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-02-04  6:16 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-28 19:44 [PR PATCH] oil: update to 0.8.7 UsernameRandomlyGenerated
2021-01-28 20:30 ` ericonr
2021-01-28 20:30 ` ericonr
2021-01-29 18:31 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
2021-01-29 21:02 ` [PR REVIEW] " ericonr
2021-01-30  9:20 ` [PR PATCH] [Updated] " UsernameRandomlyGenerated
2021-01-30  9:20 ` [PR REVIEW] " UsernameRandomlyGenerated
2021-02-04  6:16 ` [PR PATCH] [Closed]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).