[PR PATCH] darktable: update to 3.4.0.

[PR PATCH] darktable: update to 3.4.0.

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

There is a new pull request by lemmi against master on the void-packages repository

https://github.com/lemmi/void-packages darktable
https://github.com/void-linux/void-packages/pull/27402

darktable: update to 3.4.0.


A patch file from https://github.com/void-linux/void-packages/pull/27402.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-darktable-27402.patch --]
[-- Type: text/x-diff, Size: 1082 bytes --]

From b61b7410baa461b73fa486d642889fe1da5498f2 Mon Sep 17 00:00:00 2001
From: lemmi <lemmi@nerd2nerd.org>
Date: Thu, 24 Dec 2020 13:45:47 +0100
Subject: [PATCH] darktable: update to 3.4.0.

---
 srcpkgs/darktable/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/darktable/template b/srcpkgs/darktable/template
index 20734edd8fc..eba6fd5a7c0 100644
--- a/srcpkgs/darktable/template
+++ b/srcpkgs/darktable/template
@@ -1,6 +1,6 @@
 # Template file for 'darktable'
 pkgname=darktable
-version=3.2.1
+version=3.4.0
 revision=1
 # upstream only supports these archs:
 archs="x86_64* aarch64* ppc64le*"
@@ -22,7 +22,7 @@ license="GPL-3.0-or-later"
 homepage="http://www.darktable.org/"
 changelog="https://github.com/darktable-org/darktable/releases"
 distfiles="https://github.com/darktable-org/darktable/releases/download/release-${version}/darktable-${version}.tar.xz"
-checksum=6e3683ea88dc0a0271be7eca4fd594b9e46b1b7194847825a8d0a0c12bdeb90c
+checksum=6dd3de1f5ea9f94af92838c0be5ff30fdaa599aa1d737dcb562f9e0b2b2dbdda
 
 build_options="gmic"
 

Re: darktable: update to 3.4.0.

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/27402#issuecomment-750888792

Comment:
For the brave and CI :)

Re: [PR PATCH] [Updated] darktable: update to 3.4.0.

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

There is an updated pull request by lemmi against master on the void-packages repository

https://github.com/lemmi/void-packages darktable
https://github.com/void-linux/void-packages/pull/27402

darktable: update to 3.4.0.


A patch file from https://github.com/void-linux/void-packages/pull/27402.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-darktable-27402.patch --]
[-- Type: text/x-diff, Size: 2285 bytes --]

From 957cf066a4956552375b416fa41875dacaa40a6f Mon Sep 17 00:00:00 2001
From: lemmi <lemmi@nerd2nerd.org>
Date: Thu, 24 Dec 2020 13:45:47 +0100
Subject: [PATCH] darktable: update to 3.4.0.

---
 .../patches/disable_sse_aarch64.patch         | 30 +++++++++++++++++++
 srcpkgs/darktable/template                    |  4 +--
 2 files changed, 32 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/darktable/patches/disable_sse_aarch64.patch

diff --git a/srcpkgs/darktable/patches/disable_sse_aarch64.patch b/srcpkgs/darktable/patches/disable_sse_aarch64.patch
new file mode 100644
index 00000000000..2e13ad859c8
--- /dev/null
+++ b/srcpkgs/darktable/patches/disable_sse_aarch64.patch
@@ -0,0 +1,30 @@
+From d10c290fb3b47bbc8fd90d6d1d7935b900c1caf6 Mon Sep 17 00:00:00 2001
+From: Pascal Obry <pascal@obry.net>
+Date: Thu, 24 Dec 2020 16:17:19 +0100
+Subject: [PATCH] guided_filter: include xmmintrin.h only if SSE defined.
+
+Fixes #7428.
+---
+ src/common/guided_filter.h | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/src/common/guided_filter.h b/src/common/guided_filter.h
+index 36be0de04b9..59c8b2af999 100644
+--- a/src/common/guided_filter.h
++++ b/src/common/guided_filter.h
+@@ -18,6 +18,7 @@
+ 
+ #pragma once
+ 
++#if defined(__SSE__)
+ #ifdef __PPC64__
+ #ifdef NO_WARN_X86_INTRINSICS
+ #include <xmmintrin.h>
+@@ -29,6 +30,7 @@
+ #else
+ #include <xmmintrin.h>
+ #endif // __PPC64__
++#endif
+ 
+ #include "common/darktable.h"
+ #include "common/opencl.h"
diff --git a/srcpkgs/darktable/template b/srcpkgs/darktable/template
index 20734edd8fc..eba6fd5a7c0 100644
--- a/srcpkgs/darktable/template
+++ b/srcpkgs/darktable/template
@@ -1,6 +1,6 @@
 # Template file for 'darktable'
 pkgname=darktable
-version=3.2.1
+version=3.4.0
 revision=1
 # upstream only supports these archs:
 archs="x86_64* aarch64* ppc64le*"
@@ -22,7 +22,7 @@ license="GPL-3.0-or-later"
 homepage="http://www.darktable.org/"
 changelog="https://github.com/darktable-org/darktable/releases"
 distfiles="https://github.com/darktable-org/darktable/releases/download/release-${version}/darktable-${version}.tar.xz"
-checksum=6e3683ea88dc0a0271be7eca4fd594b9e46b1b7194847825a8d0a0c12bdeb90c
+checksum=6dd3de1f5ea9f94af92838c0be5ff30fdaa599aa1d737dcb562f9e0b2b2dbdda
 
 build_options="gmic"
 

Re: [PR PATCH] [Updated] darktable: update to 3.4.0.

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

There is an updated pull request by lemmi against master on the void-packages repository

https://github.com/lemmi/void-packages darktable
https://github.com/void-linux/void-packages/pull/27402

darktable: update to 3.4.0.


A patch file from https://github.com/void-linux/void-packages/pull/27402.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-darktable-27402.patch --]
[-- Type: text/x-diff, Size: 2277 bytes --]

From ddcb6019ac9f7b4a4f6fb0d3d0a10afb862ce671 Mon Sep 17 00:00:00 2001
From: lemmi <lemmi@nerd2nerd.org>
Date: Thu, 24 Dec 2020 13:45:47 +0100
Subject: [PATCH] darktable: update to 3.4.0.

---
 .../patches/disable_sse_aarch64.patch         | 30 +++++++++++++++++++
 srcpkgs/darktable/template                    |  4 +--
 2 files changed, 32 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/darktable/patches/disable_sse_aarch64.patch

diff --git a/srcpkgs/darktable/patches/disable_sse_aarch64.patch b/srcpkgs/darktable/patches/disable_sse_aarch64.patch
new file mode 100644
index 00000000000..ca4fdb9d05a
--- /dev/null
+++ b/srcpkgs/darktable/patches/disable_sse_aarch64.patch
@@ -0,0 +1,30 @@
+From d10c290fb3b47bbc8fd90d6d1d7935b900c1caf6 Mon Sep 17 00:00:00 2001
+From: Pascal Obry <pascal@obry.net>
+Date: Thu, 24 Dec 2020 16:17:19 +0100
+Subject: [PATCH] guided_filter: include xmmintrin.h only if SSE defined.
+
+Fixes #7428.
+---
+ src/common/guided_filter.h | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git src/common/guided_filter.h src/common/guided_filter.h
+index 36be0de04b9..59c8b2af999 100644
+--- src/common/guided_filter.h
++++ src/common/guided_filter.h
+@@ -18,6 +18,7 @@
+ 
+ #pragma once
+ 
++#if defined(__SSE__)
+ #ifdef __PPC64__
+ #ifdef NO_WARN_X86_INTRINSICS
+ #include <xmmintrin.h>
+@@ -29,6 +30,7 @@
+ #else
+ #include <xmmintrin.h>
+ #endif // __PPC64__
++#endif
+ 
+ #include "common/darktable.h"
+ #include "common/opencl.h"
diff --git a/srcpkgs/darktable/template b/srcpkgs/darktable/template
index 20734edd8fc..eba6fd5a7c0 100644
--- a/srcpkgs/darktable/template
+++ b/srcpkgs/darktable/template
@@ -1,6 +1,6 @@
 # Template file for 'darktable'
 pkgname=darktable
-version=3.2.1
+version=3.4.0
 revision=1
 # upstream only supports these archs:
 archs="x86_64* aarch64* ppc64le*"
@@ -22,7 +22,7 @@ license="GPL-3.0-or-later"
 homepage="http://www.darktable.org/"
 changelog="https://github.com/darktable-org/darktable/releases"
 distfiles="https://github.com/darktable-org/darktable/releases/download/release-${version}/darktable-${version}.tar.xz"
-checksum=6e3683ea88dc0a0271be7eca4fd594b9e46b1b7194847825a8d0a0c12bdeb90c
+checksum=6dd3de1f5ea9f94af92838c0be5ff30fdaa599aa1d737dcb562f9e0b2b2dbdda
 
 build_options="gmic"
 

Re: darktable: update to 3.4.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27402#issuecomment-751318347

Comment:
Immediatelly segfaults at launch on musl :/ 

Backtrace: 
[darktable_bt_UTSIW0.txt](https://github.com/void-linux/void-packages/files/5742704/darktable_bt_UTSIW0.txt)

Re: darktable: update to 3.4.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27402#issuecomment-752260680

Comment:
Patch:

```
diff --git src/bauhaus/bauhaus.c src/bauhaus/bauhaus.c
index a7350bf..ff5a071 100644
--- src/bauhaus/bauhaus.c
+++ src/bauhaus/bauhaus.c
@@ -856,7 +856,7 @@ void dt_bauhaus_slider_enable_soft_boundaries(GtkWidget *widget, float hard_min,
 
 void dt_bauhaus_widget_set_label(GtkWidget *widget, const char *section_orig, const char *label_orig)
 {
-  const char *section = _(section_orig);
+  const char *section = section_orig ? _(section_orig) : NULL;
   const char *label = _(label_orig);
 
   dt_bauhaus_widget_t *w = DT_BAUHAUS_WIDGET(widget);
```

Re: darktable: update to 3.4.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27402#issuecomment-752660569

Comment:
My patch has been pulled into 3.4.1, if you want to wait for that.

Re: darktable: update to 3.4.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27402#issuecomment-769557720

Comment:
Ping

Re: darktable: update to 3.4.0.

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/27402#issuecomment-769664044

Comment:
I asked this week about the `3.4.1` release. Sounded like they wanted to cut a release soon. Although they were a little vague. I might just pick your patch and bump it this weekend.

Re: [PR PATCH] [Updated] darktable: update to 3.4.0.

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

There is an updated pull request by lemmi against master on the void-packages repository

https://github.com/lemmi/void-packages darktable
https://github.com/void-linux/void-packages/pull/27402

darktable: update to 3.4.0.


A patch file from https://github.com/void-linux/void-packages/pull/27402.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-darktable-27402.patch --]
[-- Type: text/x-diff, Size: 1081 bytes --]

From cccf880182a7bdb31a15043afa6f2afaa8e95674 Mon Sep 17 00:00:00 2001
From: lemmi <lemmi@nerd2nerd.org>
Date: Sat, 6 Feb 2021 17:20:40 +0100
Subject: [PATCH] darktable: update to 3.4.1.

---
 srcpkgs/darktable/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/darktable/template b/srcpkgs/darktable/template
index 20734edd8fc..24f17d36dda 100644
--- a/srcpkgs/darktable/template
+++ b/srcpkgs/darktable/template
@@ -1,6 +1,6 @@
 # Template file for 'darktable'
 pkgname=darktable
-version=3.2.1
+version=3.4.1
 revision=1
 # upstream only supports these archs:
 archs="x86_64* aarch64* ppc64le*"
@@ -22,7 +22,7 @@ license="GPL-3.0-or-later"
 homepage="http://www.darktable.org/"
 changelog="https://github.com/darktable-org/darktable/releases"
 distfiles="https://github.com/darktable-org/darktable/releases/download/release-${version}/darktable-${version}.tar.xz"
-checksum=6e3683ea88dc0a0271be7eca4fd594b9e46b1b7194847825a8d0a0c12bdeb90c
+checksum=7fc3f851da9bcd7c5053ecd09f21aa3eb6103be98a6c58f52010b6f22174941e
 
 build_options="gmic"
 

Re: [PR PATCH] [Closed]: darktable: update to 3.4.0.

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

There's a closed pull request on the void-packages repository

darktable: update to 3.4.0.
https://github.com/void-linux/void-packages/pull/27402

Description: