* [PR PATCH] qutebrowser: update to 2.0.0
@ 2021-01-28 15:06 Byl3x
2021-01-28 15:13 ` ericonr
` (28 more replies)
0 siblings, 29 replies; 30+ messages in thread
From: Byl3x @ 2021-01-28 15:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]
There is a new pull request by Byl3x against master on the void-packages repository
https://github.com/Byl3x/void-packages master
https://github.com/void-linux/void-packages/pull/28286
qutebrowser: update to 2.0.0
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH_LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28286.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-28286.patch --]
[-- Type: text/x-diff, Size: 1144 bytes --]
From 049a640f3bfd55cc2927e7cf3b5d56df3f253fc9 Mon Sep 17 00:00:00 2001
From: Byl3x <mbilek06@gmail.com>
Date: Thu, 28 Jan 2021 15:58:46 +0100
Subject: [PATCH] qutebrowser: update to 2.0.0
---
srcpkgs/qutebrowser/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/qutebrowser/template b/srcpkgs/qutebrowser/template
index 3ff0c7da5f0..c30325b4f22 100644
--- a/srcpkgs/qutebrowser/template
+++ b/srcpkgs/qutebrowser/template
@@ -1,6 +1,6 @@
# Template file for 'qutebrowser'
pkgname=qutebrowser
-version=1.14.1
+version=2.0.0
revision=1
build_style=python3-module
hostmakedepends="python3-setuptools asciidoc"
@@ -13,7 +13,7 @@ license="GPL-3.0-or-later"
homepage="https://qutebrowser.org/"
changelog="https://raw.githubusercontent.com/qutebrowser/qutebrowser/master/doc/changelog.asciidoc"
distfiles="https://github.com/qutebrowser/qutebrowser/releases/download/v${version}/qutebrowser-${version}.tar.gz"
-checksum=554c145ff64b1a92d4f53e3c624aaad51baafb7cb5b469bc815ae2e0e1958796
+checksum=bfa1336ec91f3bda946fa2e0634a6931763ae5948e33c3311bd7450fe1fc1c16
nostrip=yes
build_options="webengine"
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
@ 2021-01-28 15:13 ` ericonr
2021-01-28 15:16 ` [PR PATCH] [Updated] " Byl3x
` (27 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2021-01-28 15:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 194 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769152366
Comment:
Please add `checkdepends="$depends"` to the template.
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PR PATCH] [Updated] qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
2021-01-28 15:13 ` ericonr
@ 2021-01-28 15:16 ` Byl3x
2021-01-28 15:32 ` Byl3x
` (26 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Byl3x @ 2021-01-28 15:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]
There is an updated pull request by Byl3x against master on the void-packages repository
https://github.com/Byl3x/void-packages master
https://github.com/void-linux/void-packages/pull/28286
qutebrowser: update to 2.0.0
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH_LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28286.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-28286.patch --]
[-- Type: text/x-diff, Size: 2021 bytes --]
From 049a640f3bfd55cc2927e7cf3b5d56df3f253fc9 Mon Sep 17 00:00:00 2001
From: Byl3x <mbilek06@gmail.com>
Date: Thu, 28 Jan 2021 15:58:46 +0100
Subject: [PATCH 1/2] qutebrowser: update to 2.0.0
---
srcpkgs/qutebrowser/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/qutebrowser/template b/srcpkgs/qutebrowser/template
index 3ff0c7da5f0..c30325b4f22 100644
--- a/srcpkgs/qutebrowser/template
+++ b/srcpkgs/qutebrowser/template
@@ -1,6 +1,6 @@
# Template file for 'qutebrowser'
pkgname=qutebrowser
-version=1.14.1
+version=2.0.0
revision=1
build_style=python3-module
hostmakedepends="python3-setuptools asciidoc"
@@ -13,7 +13,7 @@ license="GPL-3.0-or-later"
homepage="https://qutebrowser.org/"
changelog="https://raw.githubusercontent.com/qutebrowser/qutebrowser/master/doc/changelog.asciidoc"
distfiles="https://github.com/qutebrowser/qutebrowser/releases/download/v${version}/qutebrowser-${version}.tar.gz"
-checksum=554c145ff64b1a92d4f53e3c624aaad51baafb7cb5b469bc815ae2e0e1958796
+checksum=bfa1336ec91f3bda946fa2e0634a6931763ae5948e33c3311bd7450fe1fc1c16
nostrip=yes
build_options="webengine"
From fb9be2f2d2e2fd090a5a4940ce2cff68ae04cb58 Mon Sep 17 00:00:00 2001
From: Byl3x <62291728+Byl3x@users.noreply.github.com>
Date: Thu, 28 Jan 2021 16:16:33 +0100
Subject: [PATCH 2/2] add checkdepends line
---
srcpkgs/qutebrowser/template | 1 +
1 file changed, 1 insertion(+)
diff --git a/srcpkgs/qutebrowser/template b/srcpkgs/qutebrowser/template
index c30325b4f22..df1ba019890 100644
--- a/srcpkgs/qutebrowser/template
+++ b/srcpkgs/qutebrowser/template
@@ -7,6 +7,7 @@ hostmakedepends="python3-setuptools asciidoc"
depends="python3-PyQt5-quick python3-Jinja2 python3-Pygments python3-pyPEG2
python3-yaml python3-attrs python3-PyQt5-opengl python3-PyQt5-sql
qt5-plugin-sqlite python3-setuptools"
+ checkdepends="$depends"
short_desc="Keyboard-focused browser with a minimal GUI"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="GPL-3.0-or-later"
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
2021-01-28 15:13 ` ericonr
2021-01-28 15:16 ` [PR PATCH] [Updated] " Byl3x
@ 2021-01-28 15:32 ` Byl3x
2021-01-28 15:36 ` ericonr
` (25 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Byl3x @ 2021-01-28 15:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 290 bytes --]
New comment by Byl3x on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769167153
Comment:
I don't understand, my native arch is x86_64 and building it in a vm(that didn't have the previous version or anything related) with xbps-src works too
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (2 preceding siblings ...)
2021-01-28 15:32 ` Byl3x
@ 2021-01-28 15:36 ` ericonr
2021-01-28 15:39 ` [PR REVIEW] " ericonr
` (24 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2021-01-28 15:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 264 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769169583
Comment:
This is running the tests, which you can do by running `./xbps-src -Q pkg qutebrowser`.
Also, please squash the commits.
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PR REVIEW] qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (3 preceding siblings ...)
2021-01-28 15:36 ` ericonr
@ 2021-01-28 15:39 ` ericonr
2021-01-28 15:51 ` [PR PATCH] [Updated] " Byl3x
` (23 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2021-01-28 15:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#discussion_r566191550
Comment:
try adding `python3-pytest`
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PR PATCH] [Updated] qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (4 preceding siblings ...)
2021-01-28 15:39 ` [PR REVIEW] " ericonr
@ 2021-01-28 15:51 ` Byl3x
2021-01-28 16:09 ` Byl3x
` (22 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Byl3x @ 2021-01-28 15:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]
There is an updated pull request by Byl3x against master on the void-packages repository
https://github.com/Byl3x/void-packages master
https://github.com/void-linux/void-packages/pull/28286
qutebrowser: update to 2.0.0
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH_LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28286.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-28286.patch --]
[-- Type: text/x-diff, Size: 1508 bytes --]
From 0a0499139a382166a30df82abb71f19f39b14719 Mon Sep 17 00:00:00 2001
From: Byl3x <mbilek06@gmail.com>
Date: Thu, 28 Jan 2021 15:58:46 +0100
Subject: [PATCH] qutebrowser: update to 2.0.0
add checkdepends line
add python3-pytest
---
srcpkgs/qutebrowser/template | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/qutebrowser/template b/srcpkgs/qutebrowser/template
index 3ff0c7da5f0..c80d32792f5 100644
--- a/srcpkgs/qutebrowser/template
+++ b/srcpkgs/qutebrowser/template
@@ -1,19 +1,20 @@
# Template file for 'qutebrowser'
pkgname=qutebrowser
-version=1.14.1
+version=2.0.0
revision=1
build_style=python3-module
hostmakedepends="python3-setuptools asciidoc"
depends="python3-PyQt5-quick python3-Jinja2 python3-Pygments python3-pyPEG2
python3-yaml python3-attrs python3-PyQt5-opengl python3-PyQt5-sql
qt5-plugin-sqlite python3-setuptools"
+ checkdepends="$depends python3-pytest"
short_desc="Keyboard-focused browser with a minimal GUI"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="GPL-3.0-or-later"
homepage="https://qutebrowser.org/"
changelog="https://raw.githubusercontent.com/qutebrowser/qutebrowser/master/doc/changelog.asciidoc"
distfiles="https://github.com/qutebrowser/qutebrowser/releases/download/v${version}/qutebrowser-${version}.tar.gz"
-checksum=554c145ff64b1a92d4f53e3c624aaad51baafb7cb5b469bc815ae2e0e1958796
+checksum=bfa1336ec91f3bda946fa2e0634a6931763ae5948e33c3311bd7450fe1fc1c16
nostrip=yes
build_options="webengine"
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (5 preceding siblings ...)
2021-01-28 15:51 ` [PR PATCH] [Updated] " Byl3x
@ 2021-01-28 16:09 ` Byl3x
2021-01-28 16:14 ` Byl3x
` (21 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Byl3x @ 2021-01-28 16:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 328 bytes --]
New comment by Byl3x on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769192511
Comment:
Well the tests are causing the issue and when I look at the build logs for the older versions they skipped the tests, so I'm wondering if the previous versions passed the tests, I'll try it
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (6 preceding siblings ...)
2021-01-28 16:09 ` Byl3x
@ 2021-01-28 16:14 ` Byl3x
2021-01-28 16:21 ` FollieHiyuki
` (20 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Byl3x @ 2021-01-28 16:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 376 bytes --]
New comment by Byl3x on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769192511
Comment:
Well the tests are causing the issue and when I look at the build logs for the older versions they skipped the tests, so I'm wondering if the previous versions passed the tests, I'll try it
edit: Checks also fail with 1.14.1_1 on x86_64
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (7 preceding siblings ...)
2021-01-28 16:14 ` Byl3x
@ 2021-01-28 16:21 ` FollieHiyuki
2021-01-28 18:07 ` pbui
` (19 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: FollieHiyuki @ 2021-01-28 16:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
New comment by FollieHiyuki on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769200681
Comment:
Should we do something to #27490 too? qutebrowser 2.0.0 comes with the adblocking feature
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (8 preceding siblings ...)
2021-01-28 16:21 ` FollieHiyuki
@ 2021-01-28 18:07 ` pbui
2021-01-28 22:29 ` Byl3x
` (18 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: pbui @ 2021-01-28 18:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
New comment by pbui on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769272705
Comment:
2.0.1 has been released: https://github.com/qutebrowser/qutebrowser/releases/tag/v2.0.1
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (9 preceding siblings ...)
2021-01-28 18:07 ` pbui
@ 2021-01-28 22:29 ` Byl3x
2021-01-29 0:07 ` ericonr
` (17 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Byl3x @ 2021-01-28 22:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
New comment by Byl3x on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769441700
Comment:
So I tried running the test and found out that the test needs a running Xorg server to function(it displays a window) and it is also deprecated, I'm not sure how to change the build so that it doesn't run the tests
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (10 preceding siblings ...)
2021-01-28 22:29 ` Byl3x
@ 2021-01-29 0:07 ` ericonr
2021-01-29 3:39 ` ahesford
` (16 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2021-01-29 0:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769480315
Comment:
Please apply this patch:
```diff
diff --git a/srcpkgs/qutebrowser/template b/srcpkgs/qutebrowser/template
index c80d32792f..4c160a1adf 100644
--- a/srcpkgs/qutebrowser/template
+++ b/srcpkgs/qutebrowser/template
@@ -7,7 +7,7 @@ hostmakedepends="python3-setuptools asciidoc"
depends="python3-PyQt5-quick python3-Jinja2 python3-Pygments python3-pyPEG2
python3-yaml python3-attrs python3-PyQt5-opengl python3-PyQt5-sql
qt5-plugin-sqlite python3-setuptools"
- checkdepends="$depends python3-pytest"
+checkdepends="$depends python3-pytest xvfb-run"
short_desc="Keyboard-focused browser with a minimal GUI"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="GPL-3.0-or-later"
@@ -37,6 +37,12 @@ pre_build() {
a2x -f manpage doc/qutebrowser.1.asciidoc
}
+do_check() {
+ # testing with pytest would be nice, but requires unpackaged plugins:
+ # pytest-bdd, pytest-benchmark, pytest-instafail, pytest-mock, pytest-qt, pytest-rerunfailures
+ :
+}
+
post_install() {
vman doc/qutebrowser.1
vinstall misc/org.qutebrowser.qutebrowser.desktop 644 usr/share/applications
```
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (11 preceding siblings ...)
2021-01-29 0:07 ` ericonr
@ 2021-01-29 3:39 ` ahesford
2021-01-29 3:40 ` ahesford
` (15 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: ahesford @ 2021-01-29 3:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769553543
Comment:
> +do_check() {
> + # testing with pytest would be nice, but requires unpackaged plugins:
> + # pytest-bdd, pytest-benchmark, pytest-instafail, pytest-mock, pytest-qt, pytest-rerunfailures
> + :
> +}
@ericonr We do provide `python3-pytest-mock`. As for the others, are the tests that depend on them so numerous that the entire check should be skipped, or would it be feasible to `--ignore` or `--ignore-glob` the affected tests?
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (12 preceding siblings ...)
2021-01-29 3:39 ` ahesford
@ 2021-01-29 3:40 ` ahesford
2021-01-29 3:45 ` ericonr
` (14 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: ahesford @ 2021-01-29 3:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769553543
Comment:
```
+do_check() {
+ # testing with pytest would be nice, but requires unpackaged plugins:
+ # pytest-bdd, pytest-benchmark, pytest-instafail, pytest-mock, pytest-qt, pytest-rerunfailures
+ :
+}
```
@ericonr We do provide `python3-pytest-mock`. As for the others, are the tests that depend on them so numerous that the entire check should be skipped, or would it be feasible to `--ignore` or `--ignore-glob` the affected tests?
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (13 preceding siblings ...)
2021-01-29 3:40 ` ahesford
@ 2021-01-29 3:45 ` ericonr
2021-01-29 10:37 ` [PR PATCH] [Updated] " Byl3x
` (13 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2021-01-29 3:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769555004
Comment:
@ahesford we also provide pytest-qt, fwiw.
The issue is that the tests seem to check for these plugins at startup, and it complains immediatelly about them not being there, instead of being runtime failures.
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PR PATCH] [Updated] qutebrowser: update to 2.0.0
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (14 preceding siblings ...)
2021-01-29 3:45 ` ericonr
@ 2021-01-29 10:37 ` Byl3x
2021-01-29 10:46 ` [PR PATCH] [Updated] qutebrowser: update to 2.0.1 Byl3x
` (12 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Byl3x @ 2021-01-29 10:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]
There is an updated pull request by Byl3x against master on the void-packages repository
https://github.com/Byl3x/void-packages master
https://github.com/void-linux/void-packages/pull/28286
qutebrowser: update to 2.0.0
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH_LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28286.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-28286.patch --]
[-- Type: text/x-diff, Size: 2021 bytes --]
From d901fe275de4d1ba1611ae7a7f1479a0a851bd6f Mon Sep 17 00:00:00 2001
From: Byl3x <mbilek06@gmail.com>
Date: Thu, 28 Jan 2021 15:58:46 +0100
Subject: [PATCH] qutebrowser: update to 2.0.1
add checkdepends line
add python3-pytest
update checksum, bump version to 2.0.1
add do_check() patch
---
srcpkgs/qutebrowser/template | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/qutebrowser/template b/srcpkgs/qutebrowser/template
index 3ff0c7da5f0..1da1ed4c52b 100644
--- a/srcpkgs/qutebrowser/template
+++ b/srcpkgs/qutebrowser/template
@@ -1,19 +1,21 @@
# Template file for 'qutebrowser'
pkgname=qutebrowser
-version=1.14.1
+version=2.0.1
revision=1
build_style=python3-module
hostmakedepends="python3-setuptools asciidoc"
depends="python3-PyQt5-quick python3-Jinja2 python3-Pygments python3-pyPEG2
python3-yaml python3-attrs python3-PyQt5-opengl python3-PyQt5-sql
qt5-plugin-sqlite python3-setuptools"
+checkdepends="$depends python3-pytest xvfb-run"
short_desc="Keyboard-focused browser with a minimal GUI"
+checkdepends="$depends python3-pytest"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="GPL-3.0-or-later"
homepage="https://qutebrowser.org/"
changelog="https://raw.githubusercontent.com/qutebrowser/qutebrowser/master/doc/changelog.asciidoc"
distfiles="https://github.com/qutebrowser/qutebrowser/releases/download/v${version}/qutebrowser-${version}.tar.gz"
-checksum=554c145ff64b1a92d4f53e3c624aaad51baafb7cb5b469bc815ae2e0e1958796
+checksum=aa988d61f1a396d7e7101054851291cf57e7cf19e7fc0eeffd30b672570ab242
nostrip=yes
build_options="webengine"
@@ -36,6 +38,12 @@ pre_build() {
a2x -f manpage doc/qutebrowser.1.asciidoc
}
+do_check() {
+ #testing with pytest would be nice, but requires unpackaged plugins:
+ #pytest-bdd, pytest-benchmark, pytest-instafail, pytest-mock, pytest-qt, pytest-rerunfailures
+ :
+}
+
post_install() {
vman doc/qutebrowser.1
vinstall misc/org.qutebrowser.qutebrowser.desktop 644 usr/share/applications
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PR PATCH] [Updated] qutebrowser: update to 2.0.1
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (15 preceding siblings ...)
2021-01-29 10:37 ` [PR PATCH] [Updated] " Byl3x
@ 2021-01-29 10:46 ` Byl3x
2021-01-29 11:00 ` Byl3x
` (11 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Byl3x @ 2021-01-29 10:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]
There is an updated pull request by Byl3x against master on the void-packages repository
https://github.com/Byl3x/void-packages master
https://github.com/void-linux/void-packages/pull/28286
qutebrowser: update to 2.0.1
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH_LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28286.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-28286.patch --]
[-- Type: text/x-diff, Size: 1999 bytes --]
From 09f1a250a8625a644b0a03456b611bc997905ec7 Mon Sep 17 00:00:00 2001
From: Byl3x <mbilek06@gmail.com>
Date: Thu, 28 Jan 2021 15:58:46 +0100
Subject: [PATCH] qutebrowser: update to 2.0.1
add checkdepends line
add python3-pytest
update checksum, bump version to 2.0.1
add do_check() patch
remove excess line
---
srcpkgs/qutebrowser/template | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/qutebrowser/template b/srcpkgs/qutebrowser/template
index 3ff0c7da5f0..35fdadee6b1 100644
--- a/srcpkgs/qutebrowser/template
+++ b/srcpkgs/qutebrowser/template
@@ -1,19 +1,20 @@
# Template file for 'qutebrowser'
pkgname=qutebrowser
-version=1.14.1
+version=2.0.1
revision=1
build_style=python3-module
hostmakedepends="python3-setuptools asciidoc"
depends="python3-PyQt5-quick python3-Jinja2 python3-Pygments python3-pyPEG2
python3-yaml python3-attrs python3-PyQt5-opengl python3-PyQt5-sql
qt5-plugin-sqlite python3-setuptools"
+checkdepends="$depends python3-pytest xvfb-run"
short_desc="Keyboard-focused browser with a minimal GUI"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="GPL-3.0-or-later"
homepage="https://qutebrowser.org/"
changelog="https://raw.githubusercontent.com/qutebrowser/qutebrowser/master/doc/changelog.asciidoc"
distfiles="https://github.com/qutebrowser/qutebrowser/releases/download/v${version}/qutebrowser-${version}.tar.gz"
-checksum=554c145ff64b1a92d4f53e3c624aaad51baafb7cb5b469bc815ae2e0e1958796
+checksum=aa988d61f1a396d7e7101054851291cf57e7cf19e7fc0eeffd30b672570ab242
nostrip=yes
build_options="webengine"
@@ -36,6 +37,12 @@ pre_build() {
a2x -f manpage doc/qutebrowser.1.asciidoc
}
+do_check() {
+ #testing with pytest would be nice, but requires unpackaged plugins:
+ #pytest-bdd, pytest-benchmark, pytest-instafail, pytest-mock, pytest-qt, pytest-rerunfailures
+ :
+}
+
post_install() {
vman doc/qutebrowser.1
vinstall misc/org.qutebrowser.qutebrowser.desktop 644 usr/share/applications
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.1
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (16 preceding siblings ...)
2021-01-29 10:46 ` [PR PATCH] [Updated] qutebrowser: update to 2.0.1 Byl3x
@ 2021-01-29 11:00 ` Byl3x
2021-01-29 12:17 ` ahesford
` (10 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Byl3x @ 2021-01-29 11:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
New comment by Byl3x on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769735867
Comment:
@ahesford python3-Pygments is used for syntax highlighting when viewing page source(only with :view-source --pygments or on WebKit) and also when formatting JSON files
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.1
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (17 preceding siblings ...)
2021-01-29 11:00 ` Byl3x
@ 2021-01-29 12:17 ` ahesford
2021-01-29 18:57 ` Byl3x
` (9 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: ahesford @ 2021-01-29 12:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769771822
Comment:
Syntax highlighting of source and JSON seems worth keeping the Pygments dependency. The other obsolete dependencies still need to be dropped.
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.1
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (18 preceding siblings ...)
2021-01-29 12:17 ` ahesford
@ 2021-01-29 18:57 ` Byl3x
2021-01-29 19:47 ` ahesford
` (8 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Byl3x @ 2021-01-29 18:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 412 bytes --]
New comment by Byl3x on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-769986974
Comment:
I checked the dependencies, only python3-pyPEG2 shouldn't be required. Also the python3-Pygments are only used if you choose to use :view-source with the --pygments flag or when using a userscript that is in the official repo or when you use QtWebKit instead of QtWebEngine
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.1
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (19 preceding siblings ...)
2021-01-29 18:57 ` Byl3x
@ 2021-01-29 19:47 ` ahesford
2021-01-29 21:27 ` Byl3x
` (7 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: ahesford @ 2021-01-29 19:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-770012017
Comment:
From the list:
> Remove the attrs (attr) dependency.
> Move the setuptools dependency from runtime (for pkg_resources) to build-time.
If the Pygments support really requires a `--pygments` flag (it doesn't in the current version---`:view-source` is definitely colored for me), then I would drop its requirement here, since having to explicitly opt in would mean that syntax coloring isn't the expected default behavior.
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.1
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (20 preceding siblings ...)
2021-01-29 19:47 ` ahesford
@ 2021-01-29 21:27 ` Byl3x
2021-01-29 22:46 ` paper42
` (6 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Byl3x @ 2021-01-29 21:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
New comment by Byl3x on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-770059572
Comment:
I didn't notice the attrs dependency removal, sorry. What I meant with the Pygments also was that to use it you have to do `:view-source --pygments` so I think that it's safe to drop the requirement
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.1
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (21 preceding siblings ...)
2021-01-29 21:27 ` Byl3x
@ 2021-01-29 22:46 ` paper42
2021-01-30 10:18 ` [PR PATCH] [Updated] " Byl3x
` (5 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: paper42 @ 2021-01-29 22:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-770090099
Comment:
python3-pyPEG2 isn't used anywhere else, so it should be safe to drop the package (upstream dead)
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PR PATCH] [Updated] qutebrowser: update to 2.0.1
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (22 preceding siblings ...)
2021-01-29 22:46 ` paper42
@ 2021-01-30 10:18 ` Byl3x
2021-01-30 12:25 ` [PR REVIEW] " ahesford
` (4 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Byl3x @ 2021-01-30 10:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]
There is an updated pull request by Byl3x against master on the void-packages repository
https://github.com/Byl3x/void-packages master
https://github.com/void-linux/void-packages/pull/28286
qutebrowser: update to 2.0.1
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH_LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28286.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-28286.patch --]
[-- Type: text/x-diff, Size: 2153 bytes --]
From 24f872d132be04f81ed0704ad12eb92f1a2cb208 Mon Sep 17 00:00:00 2001
From: Byl3x <mbilek06@gmail.com>
Date: Thu, 28 Jan 2021 15:58:46 +0100
Subject: [PATCH] qutebrowser: update to 2.0.1
add checkdepends line
add python3-pytest
update checksum, bump version to 2.0.1
add do_check() patch
remove excess line
remove unneeded dependencies
---
srcpkgs/qutebrowser/template | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/qutebrowser/template b/srcpkgs/qutebrowser/template
index 3ff0c7da5f0..16dd8e45e87 100644
--- a/srcpkgs/qutebrowser/template
+++ b/srcpkgs/qutebrowser/template
@@ -1,19 +1,19 @@
# Template file for 'qutebrowser'
pkgname=qutebrowser
-version=1.14.1
+version=2.0.1
revision=1
build_style=python3-module
hostmakedepends="python3-setuptools asciidoc"
-depends="python3-PyQt5-quick python3-Jinja2 python3-Pygments python3-pyPEG2
- python3-yaml python3-attrs python3-PyQt5-opengl python3-PyQt5-sql
- qt5-plugin-sqlite python3-setuptools"
+depends="python3-PyQt5-quick python3-Jinja2 python3-yaml python3-PyQt5-opengl python3-PyQt5-sql
+ qt5-plugin-sqlite"
+checkdepends="$depends python3-pytest xvfb-run"
short_desc="Keyboard-focused browser with a minimal GUI"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="GPL-3.0-or-later"
homepage="https://qutebrowser.org/"
changelog="https://raw.githubusercontent.com/qutebrowser/qutebrowser/master/doc/changelog.asciidoc"
distfiles="https://github.com/qutebrowser/qutebrowser/releases/download/v${version}/qutebrowser-${version}.tar.gz"
-checksum=554c145ff64b1a92d4f53e3c624aaad51baafb7cb5b469bc815ae2e0e1958796
+checksum=aa988d61f1a396d7e7101054851291cf57e7cf19e7fc0eeffd30b672570ab242
nostrip=yes
build_options="webengine"
@@ -36,6 +36,12 @@ pre_build() {
a2x -f manpage doc/qutebrowser.1.asciidoc
}
+do_check() {
+ #testing with pytest would be nice, but requires unpackaged plugins:
+ #pytest-bdd, pytest-benchmark, pytest-instafail, pytest-mock, pytest-qt, pytest-rerunfailures
+ :
+}
+
post_install() {
vman doc/qutebrowser.1
vinstall misc/org.qutebrowser.qutebrowser.desktop 644 usr/share/applications
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PR REVIEW] qutebrowser: update to 2.0.1
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (23 preceding siblings ...)
2021-01-30 10:18 ` [PR PATCH] [Updated] " Byl3x
@ 2021-01-30 12:25 ` ahesford
2021-01-30 12:28 ` [PR PATCH] [Updated] " Byl3x
` (3 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: ahesford @ 2021-01-30 12:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#discussion_r567239811
Comment:
If you're skipping tests, don't add checkdepends.
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PR PATCH] [Updated] qutebrowser: update to 2.0.1
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (24 preceding siblings ...)
2021-01-30 12:25 ` [PR REVIEW] " ahesford
@ 2021-01-30 12:28 ` Byl3x
2021-01-31 11:07 ` paper42
` (2 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Byl3x @ 2021-01-30 12:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]
There is an updated pull request by Byl3x against master on the void-packages repository
https://github.com/Byl3x/void-packages master
https://github.com/void-linux/void-packages/pull/28286
qutebrowser: update to 2.0.1
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH_LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/28286.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-28286.patch --]
[-- Type: text/x-diff, Size: 2120 bytes --]
From e6cd9f2e9f0461d428ca8827ece1cb0a5597172c Mon Sep 17 00:00:00 2001
From: Byl3x <mbilek06@gmail.com>
Date: Thu, 28 Jan 2021 15:58:46 +0100
Subject: [PATCH] qutebrowser: update to 2.0.1
add checkdepends line
add python3-pytest
update checksum, bump version to 2.0.1
add do_check() patch
remove excess line
remove unneeded dependencies
remove checkdepends
---
srcpkgs/qutebrowser/template | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/qutebrowser/template b/srcpkgs/qutebrowser/template
index 3ff0c7da5f0..7d728111d33 100644
--- a/srcpkgs/qutebrowser/template
+++ b/srcpkgs/qutebrowser/template
@@ -1,19 +1,17 @@
# Template file for 'qutebrowser'
pkgname=qutebrowser
-version=1.14.1
+version=2.0.1
revision=1
build_style=python3-module
hostmakedepends="python3-setuptools asciidoc"
-depends="python3-PyQt5-quick python3-Jinja2 python3-Pygments python3-pyPEG2
- python3-yaml python3-attrs python3-PyQt5-opengl python3-PyQt5-sql
- qt5-plugin-sqlite python3-setuptools"
+depends="python3-PyQt5-quick python3-Jinja2 python3-yaml python3-PyQt5-opengl python3-PyQt5-sql qt5-plugin-sqlite"
short_desc="Keyboard-focused browser with a minimal GUI"
maintainer="Érico Nogueira <ericonr@disroot.org>"
license="GPL-3.0-or-later"
homepage="https://qutebrowser.org/"
changelog="https://raw.githubusercontent.com/qutebrowser/qutebrowser/master/doc/changelog.asciidoc"
distfiles="https://github.com/qutebrowser/qutebrowser/releases/download/v${version}/qutebrowser-${version}.tar.gz"
-checksum=554c145ff64b1a92d4f53e3c624aaad51baafb7cb5b469bc815ae2e0e1958796
+checksum=aa988d61f1a396d7e7101054851291cf57e7cf19e7fc0eeffd30b672570ab242
nostrip=yes
build_options="webengine"
@@ -36,6 +34,12 @@ pre_build() {
a2x -f manpage doc/qutebrowser.1.asciidoc
}
+do_check() {
+ #testing with pytest would be nice, but requires unpackaged plugins:
+ #pytest-bdd, pytest-benchmark, pytest-instafail, pytest-mock, pytest-qt, pytest-rerunfailures
+ :
+}
+
post_install() {
vman doc/qutebrowser.1
vinstall misc/org.qutebrowser.qutebrowser.desktop 644 usr/share/applications
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.1
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (25 preceding siblings ...)
2021-01-30 12:28 ` [PR PATCH] [Updated] " Byl3x
@ 2021-01-31 11:07 ` paper42
2021-01-31 13:11 ` ahesford
2021-02-01 2:55 ` [PR PATCH] [Closed]: " ahesford
28 siblings, 0 replies; 30+ messages in thread
From: paper42 @ 2021-01-31 11:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-770364540
Comment:
What do you think about adding pdf.js as a dependency. It's an optional dependency which allows showing PDF files inside the browser (Ctrl+p in the download dialog).
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: qutebrowser: update to 2.0.1
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (26 preceding siblings ...)
2021-01-31 11:07 ` paper42
@ 2021-01-31 13:11 ` ahesford
2021-02-01 2:55 ` [PR PATCH] [Closed]: " ahesford
28 siblings, 0 replies; 30+ messages in thread
From: ahesford @ 2021-01-31 13:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 343 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/28286#issuecomment-770380542
Comment:
I wouldn't add that dependency. When the browser presents the option to display PDFs, I think it is pretty clear that it wants pdf.js, so users should know where to look if they want to enable support.
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PR PATCH] [Closed]: qutebrowser: update to 2.0.1
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
` (27 preceding siblings ...)
2021-01-31 13:11 ` ahesford
@ 2021-02-01 2:55 ` ahesford
28 siblings, 0 replies; 30+ messages in thread
From: ahesford @ 2021-02-01 2:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]
There's a closed pull request on the void-packages repository
qutebrowser: update to 2.0.1
https://github.com/void-linux/void-packages/pull/28286
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH_LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 30+ messages in thread
end of thread, other threads:[~2021-02-01 2:55 UTC | newest]
Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-28 15:06 [PR PATCH] qutebrowser: update to 2.0.0 Byl3x
2021-01-28 15:13 ` ericonr
2021-01-28 15:16 ` [PR PATCH] [Updated] " Byl3x
2021-01-28 15:32 ` Byl3x
2021-01-28 15:36 ` ericonr
2021-01-28 15:39 ` [PR REVIEW] " ericonr
2021-01-28 15:51 ` [PR PATCH] [Updated] " Byl3x
2021-01-28 16:09 ` Byl3x
2021-01-28 16:14 ` Byl3x
2021-01-28 16:21 ` FollieHiyuki
2021-01-28 18:07 ` pbui
2021-01-28 22:29 ` Byl3x
2021-01-29 0:07 ` ericonr
2021-01-29 3:39 ` ahesford
2021-01-29 3:40 ` ahesford
2021-01-29 3:45 ` ericonr
2021-01-29 10:37 ` [PR PATCH] [Updated] " Byl3x
2021-01-29 10:46 ` [PR PATCH] [Updated] qutebrowser: update to 2.0.1 Byl3x
2021-01-29 11:00 ` Byl3x
2021-01-29 12:17 ` ahesford
2021-01-29 18:57 ` Byl3x
2021-01-29 19:47 ` ahesford
2021-01-29 21:27 ` Byl3x
2021-01-29 22:46 ` paper42
2021-01-30 10:18 ` [PR PATCH] [Updated] " Byl3x
2021-01-30 12:25 ` [PR REVIEW] " ahesford
2021-01-30 12:28 ` [PR PATCH] [Updated] " Byl3x
2021-01-31 11:07 ` paper42
2021-01-31 13:11 ` ahesford
2021-02-01 2:55 ` [PR PATCH] [Closed]: " ahesford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).