Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [NEED TESTER] dracut update to 051
Date: Sat, 30 Jan 2021 23:18:05 +0100	[thread overview]
Message-ID: <20210130221805.e6kDQslwVZ7LL5pFcpsPyIyjMXNE9eT6NMjW_qnX7d0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28137@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/28137#issuecomment-770289140

Comment:
The `squash` module now errors out if `systemd-initrd` is not available:
> dracut: dracut-squash only supports systemd bases [sic] initramfs

This is because the `check` function in `/usr/lib/dracut/modules.d/99squash/module-setup.sh` was changed from always returning 255 (which means "only use this module if explicitly requested") to throwing a `derror` message without 
systemd and returning 1 (which means "omit this module"). The error is harmless but could be scary to those unfamiliar with dracut.

I suggest one of three changes:
1. Patch the `check` function to again always return 255 without complaining;
2. Drop the `derror` call in that function; or
3. Include a conf file in `/usr/lib/dracut/dracut.conf.d` that adds `omit_dracutmodules+=" squash "`.

Pick your favorite.

Also, I noticed we have `/usr/lib/dracut/dracut.conf.d/00-void.conf` coming from `base-files` and `/usr/lib/dracut/dracut.conf.d/10-runit-void.conf` coming from `runit-void`. It might be nice to move these files to the `dracut` package itself rather than scattering them around.



  parent reply	other threads:[~2021-01-30 22:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-24  9:52 [PR PATCH] " sgn
2021-01-24 10:07 ` [PR PATCH] [Updated] " sgn
2021-01-26  4:47 ` ahesford
2021-01-30  9:47 ` [PR PATCH] [Updated] " sgn
2021-01-30 22:18 ` ahesford [this message]
2021-01-31  0:09 ` ericonr
2021-01-31  0:11 ` ahesford
2021-02-02  1:17 ` sgn
2021-02-02  1:18 ` [PR PATCH] [Updated] " sgn
2021-02-03 15:23 ` sgn
2021-02-03 15:31 ` [PR PATCH] [Merged]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210130221805.e6kDQslwVZ7LL5pFcpsPyIyjMXNE9eT6NMjW_qnX7d0@z \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).