Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [NEED TESTER] dracut update to 051
Date: Tue, 02 Feb 2021 02:17:19 +0100	[thread overview]
Message-ID: <20210202011719.9ciaF0c7KgtcuXc1rBDH6udhWQQE1A6VV-k4Tg-tsgc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28137@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28137#issuecomment-771275959

Comment:

> 1. Patch the `check` function to again always return 255 without complaining;

I'll pick this route.

> Also, I noticed we have `/usr/lib/dracut/dracut.conf.d/00-void.conf` coming from `base-files`

I think this change could be postponed for a while, I think it's better to not move files around when updating the package, (which potentially break).
Moving file around require updating both package at the same time.

> and `/usr/lib/dracut/dracut.conf.d/10-runit-void.conf` coming from `runit-void`. It might be nice to move these files to the `dracut` package itself rather than scattering them around.

While it's nice to have everything in single location, `runit-void` is maintained in another repo.
I think we'll re-visit the file moving later.


  parent reply	other threads:[~2021-02-02  1:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-24  9:52 [PR PATCH] " sgn
2021-01-24 10:07 ` [PR PATCH] [Updated] " sgn
2021-01-26  4:47 ` ahesford
2021-01-30  9:47 ` [PR PATCH] [Updated] " sgn
2021-01-30 22:18 ` ahesford
2021-01-31  0:09 ` ericonr
2021-01-31  0:11 ` ahesford
2021-02-02  1:17 ` sgn [this message]
2021-02-02  1:18 ` [PR PATCH] [Updated] " sgn
2021-02-03 15:23 ` sgn
2021-02-03 15:31 ` [PR PATCH] [Merged]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210202011719.9ciaF0c7KgtcuXc1rBDH6udhWQQE1A6VV-k4Tg-tsgc@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).