[PR PATCH] bind: fix named service.

[PR PATCH] bind: fix named service.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1841 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages bind
https://github.com/void-linux/void-packages/pull/28352

bind: fix named service.
When used with the -f option, it can crash, likely due to a lack of
syslog. Using -g makes it work but still keeps it in the foreground, by
logging directly to stderr.

Fixes #18961.

Would appreciate confirmation from someone actively using named.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28352.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bind-28352.patch --]
[-- Type: text/x-diff, Size: 1269 bytes --]

From 5a1fe56c4186f5913d4cd710a2871c8ff0fd9ff2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 31 Jan 2021 00:50:04 -0300
Subject: [PATCH] bind: fix named service.

When used with the -f option, it can crash, likely due to a lack of
syslog. Using -g makes it work but still keeps it in the foreground, by
logging directly to stderr.

Fixes #18961.
---
 srcpkgs/bind/files/named/run | 2 +-
 srcpkgs/bind/template        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/bind/files/named/run b/srcpkgs/bind/files/named/run
index 9b510127a30..34fa224dd5c 100755
--- a/srcpkgs/bind/files/named/run
+++ b/srcpkgs/bind/files/named/run
@@ -1,4 +1,4 @@
 #!/bin/sh
 mkdir -p /var/run/named || exit 1
 chown named:named /var/run/named || exit 1
-exec named -u named -f -c /etc/named/named.conf
+exec named -u named -g -c /etc/named/named.conf
diff --git a/srcpkgs/bind/template b/srcpkgs/bind/template
index f0744606e44..57243a23f4f 100644
--- a/srcpkgs/bind/template
+++ b/srcpkgs/bind/template
@@ -1,7 +1,7 @@
 # Template file for 'bind'
 pkgname=bind
 version=9.16.7
-revision=2
+revision=3
 _fullver="${version}${_patchver:+-${_patchver}}"
 wrksrc="${pkgname}-${_fullver}"
 build_style=gnu-configure

Re: bind: fix named service.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/28352#issuecomment-770322254

Comment:
This seems like a reasonable change and is in keeping with common practice for runit services. I suggest redirecting `stderr` to `stdout` and adding a `log` sub-service to route these messages through `vlogger`.

Re: [PR PATCH] [Updated] bind: fix named service.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1846 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages bind
https://github.com/void-linux/void-packages/pull/28352

bind: fix named service.
When used with the -f option, it can crash, likely due to a lack of
syslog. Using -g makes it work but still keeps it in the foreground, by
logging directly to stderr.

Fixes #18961.

Would appreciate confirmation from someone actively using named.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28352.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bind-28352.patch --]
[-- Type: text/x-diff, Size: 1691 bytes --]

From 0473922a36585bebaf6ac96939f69607b25389ee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 31 Jan 2021 00:50:04 -0300
Subject: [PATCH] bind: fix named service.

When used with the -f option, it can crash, likely due to a lack of
syslog. Using -g makes it work but still keeps it in the foreground, by
logging directly to stderr. By adding a logger to it, we follow the
pattern of most other services.

Fixes #18961.
---
 srcpkgs/bind/files/named/log/run | 2 ++
 srcpkgs/bind/files/named/run     | 3 ++-
 srcpkgs/bind/template            | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/bind/files/named/log/run

diff --git a/srcpkgs/bind/files/named/log/run b/srcpkgs/bind/files/named/log/run
new file mode 100644
index 00000000000..142fbd4af3f
--- /dev/null
+++ b/srcpkgs/bind/files/named/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -t named
diff --git a/srcpkgs/bind/files/named/run b/srcpkgs/bind/files/named/run
index 9b510127a30..b6bf67c39e9 100755
--- a/srcpkgs/bind/files/named/run
+++ b/srcpkgs/bind/files/named/run
@@ -1,4 +1,5 @@
 #!/bin/sh
+exec 2>&1
 mkdir -p /var/run/named || exit 1
 chown named:named /var/run/named || exit 1
-exec named -u named -f -c /etc/named/named.conf
+exec named -u named -g -c /etc/named/named.conf
diff --git a/srcpkgs/bind/template b/srcpkgs/bind/template
index f0744606e44..57243a23f4f 100644
--- a/srcpkgs/bind/template
+++ b/srcpkgs/bind/template
@@ -1,7 +1,7 @@
 # Template file for 'bind'
 pkgname=bind
 version=9.16.7
-revision=2
+revision=3
 _fullver="${version}${_patchver:+-${_patchver}}"
 wrksrc="${pkgname}-${_fullver}"
 build_style=gnu-configure

Re: [PR PATCH] [Merged]: bind: fix named service.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1693 bytes --]

There's a merged pull request on the void-packages repository

bind: fix named service.
https://github.com/void-linux/void-packages/pull/28352

Description:
When used with the -f option, it can crash, likely due to a lack of
syslog. Using -g makes it work but still keeps it in the foreground, by
logging directly to stderr.

Fixes #18961.

Would appreciate confirmation from someone actively using named.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->