Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] dbeaver: update to 7.3.3.
@ 2021-01-30 17:59 ar-jan
  2021-01-30 18:04 ` [PR PATCH] [Updated] " ar-jan
                   ` (14 more replies)
  0 siblings, 15 replies; 16+ messages in thread
From: ar-jan @ 2021-01-30 17:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1861 bytes --]

There is a new pull request by ar-jan against master on the void-packages repository

https://github.com/ar-jan/void-packages dbeaver-733
https://github.com/void-linux/void-packages/pull/28340

dbeaver: update to 7.3.3.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

Added `eclipse` as dependency, because dbeaver does not run without it (errors like `org.osgi.framework.BundleException: Could not resolve module: org.eclipse.compare [27]
  Unresolved requirement: Require-Bundle: org.eclipse.ui.navigator; bundle-version="[3.2.0,4.0.0)";` etc.).

A patch file from https://github.com/void-linux/void-packages/pull/28340.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dbeaver-733-28340.patch --]
[-- Type: text/x-diff, Size: 1073 bytes --]

From ce5c5d2738dd8a86db2d87fd5b1ad2c41e6e2f86 Mon Sep 17 00:00:00 2001
From: Arjan Mossel <arjanmossel@gmail.com>
Date: Sat, 30 Jan 2021 18:46:07 +0100
Subject: [PATCH] dbeaver: update to 7.3.3.

---
 srcpkgs/dbeaver/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/dbeaver/template b/srcpkgs/dbeaver/template
index e09a1fdf757..f43838f0da0 100644
--- a/srcpkgs/dbeaver/template
+++ b/srcpkgs/dbeaver/template
@@ -1,16 +1,17 @@
 # Template file for 'dbeaver'
 pkgname=dbeaver
-version=7.3.2
+version=7.3.3
 revision=1
 # the build downloads binaries linked to glibc
 archs="x86_64"
+depends="eclipse"
 hostmakedepends="apache-maven"
 short_desc="Free Universal Database Tool"
 maintainer="Kyle Nusbaum <knusbaum+void@sdf.org>"
 license="Apache-2.0"
 homepage="https://dbeaver.io"
 distfiles="https://github.com/dbeaver/dbeaver/archive/${version}.tar.gz"
-checksum=9b37ef875771cfb34507d5423965ce1e79d263a31c245c46a89b44f01c4d9c85
+checksum=8b4cff6a1e172da763373ddc7df554569f53a0c529175e540d4b64ed2b7066d9
 nopie=true
 
 do_build() {

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
@ 2021-01-30 18:04 ` ar-jan
  2021-01-31  3:28 ` ericonr
                   ` (13 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ar-jan @ 2021-01-30 18:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1866 bytes --]

There is an updated pull request by ar-jan against master on the void-packages repository

https://github.com/ar-jan/void-packages dbeaver-733
https://github.com/void-linux/void-packages/pull/28340

dbeaver: update to 7.3.3.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

Added `eclipse` as dependency, because dbeaver does not run without it (errors like `org.osgi.framework.BundleException: Could not resolve module: org.eclipse.compare [27]
  Unresolved requirement: Require-Bundle: org.eclipse.ui.navigator; bundle-version="[3.2.0,4.0.0)";` etc.).

A patch file from https://github.com/void-linux/void-packages/pull/28340.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dbeaver-733-28340.patch --]
[-- Type: text/x-diff, Size: 1143 bytes --]

From a1fc4dd5d396dfaa21da4a1e9d4e5e993a5e90f7 Mon Sep 17 00:00:00 2001
From: Arjan Mossel <arjanmossel@gmail.com>
Date: Sat, 30 Jan 2021 18:46:07 +0100
Subject: [PATCH] dbeaver: update to 7.3.3.

also add eclipse as dependency, which is required for dbeaver to run.
---
 srcpkgs/dbeaver/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/dbeaver/template b/srcpkgs/dbeaver/template
index e09a1fdf757..64d8de4bc5d 100644
--- a/srcpkgs/dbeaver/template
+++ b/srcpkgs/dbeaver/template
@@ -1,16 +1,17 @@
 # Template file for 'dbeaver'
 pkgname=dbeaver
-version=7.3.2
+version=7.3.3
 revision=1
 # the build downloads binaries linked to glibc
 archs="x86_64"
 hostmakedepends="apache-maven"
+depends="eclipse"
 short_desc="Free Universal Database Tool"
 maintainer="Kyle Nusbaum <knusbaum+void@sdf.org>"
 license="Apache-2.0"
 homepage="https://dbeaver.io"
 distfiles="https://github.com/dbeaver/dbeaver/archive/${version}.tar.gz"
-checksum=9b37ef875771cfb34507d5423965ce1e79d263a31c245c46a89b44f01c4d9c85
+checksum=8b4cff6a1e172da763373ddc7df554569f53a0c529175e540d4b64ed2b7066d9
 nopie=true
 
 do_build() {

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
  2021-01-30 18:04 ` [PR PATCH] [Updated] " ar-jan
@ 2021-01-31  3:28 ` ericonr
  2021-01-31  4:10 ` kartikynwa
                   ` (12 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-01-31  3:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28340#issuecomment-770319299

Comment:
I don't see eclipse mentioned as a dependency anywhere in https://github.com/dbeaver/dbeaver ... Maybe it's missing some files?

@kartikynwa do you have eclipse installed?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
  2021-01-30 18:04 ` [PR PATCH] [Updated] " ar-jan
  2021-01-31  3:28 ` ericonr
@ 2021-01-31  4:10 ` kartikynwa
  2021-01-31  4:40 ` kartikynwa
                   ` (11 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: kartikynwa @ 2021-01-31  4:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/28340#issuecomment-770322288

Comment:
It doesn't need eclipse. Only openjdk11 or above. It used to work with openjdk8 until version 7.3.1 I think.

31-Jan-2021 08:59:02 Érico Nogueira Rolim <notifications@github.com>:

> I don't see eclipse mentioned as a dependency anywhere in https://github.com/dbeaver/dbeaver ... Maybe it's missing some files?
> 
> @kartikynwa[https://github.com/kartikynwa] do you have eclipse installed?
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub[https://github.com/void-linux/void-packages/pull/28340#issuecomment-770319299], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AB33RLDKDV3NWIHLPOWW7QTS4TE73ANCNFSM4W2QSXOQ].
>  [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAFQAAABUCAYAAAAcaxDBAAAABHNCSVQICAgIfAhkiAAAADJJREFUeJztwQENAAAAwqD3T20ON6AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAB4NW6UAAFvMNJxAAAAAElFTkSuQmCC###24x24:true###][Tracking image][https://github.com/notifications/beacon/AB33RLHZ6AUKK463RMRCXRDS4TE73A5CNFSM4W2QSXO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFXVCHQY.gif]
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
                   ` (2 preceding siblings ...)
  2021-01-31  4:10 ` kartikynwa
@ 2021-01-31  4:40 ` kartikynwa
  2021-01-31 14:47 ` [PR PATCH] [Updated] " ar-jan
                   ` (10 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: kartikynwa @ 2021-01-31  4:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/28340#issuecomment-770324674

Comment:
Yeah I just built it and it works without eclipse. You just need openjdk11 and have it set as the alternative (`xbps-alternative -s openjdk11`). I am guessing the reason they included eclipse is because the error messages it throws upon using a version of openjdk < 11 say something about something related to eclipse.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
                   ` (3 preceding siblings ...)
  2021-01-31  4:40 ` kartikynwa
@ 2021-01-31 14:47 ` ar-jan
  2021-01-31 16:04 ` ericonr
                   ` (9 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ar-jan @ 2021-01-31 14:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1866 bytes --]

There is an updated pull request by ar-jan against master on the void-packages repository

https://github.com/ar-jan/void-packages dbeaver-733
https://github.com/void-linux/void-packages/pull/28340

dbeaver: update to 7.3.3.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

Added `eclipse` as dependency, because dbeaver does not run without it (errors like `org.osgi.framework.BundleException: Could not resolve module: org.eclipse.compare [27]
  Unresolved requirement: Require-Bundle: org.eclipse.ui.navigator; bundle-version="[3.2.0,4.0.0)";` etc.).

A patch file from https://github.com/void-linux/void-packages/pull/28340.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dbeaver-733-28340.patch --]
[-- Type: text/x-diff, Size: 1145 bytes --]

From 908ac06f18850d49b25241c2a464097f013a9fc4 Mon Sep 17 00:00:00 2001
From: Arjan Mossel <arjanmossel@gmail.com>
Date: Sat, 30 Jan 2021 18:46:07 +0100
Subject: [PATCH] dbeaver: update to 7.3.3.

also add eclipse as dependency, which is required for dbeaver to run.
---
 srcpkgs/dbeaver/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/dbeaver/template b/srcpkgs/dbeaver/template
index e09a1fdf757..9eefc7d5300 100644
--- a/srcpkgs/dbeaver/template
+++ b/srcpkgs/dbeaver/template
@@ -1,16 +1,17 @@
 # Template file for 'dbeaver'
 pkgname=dbeaver
-version=7.3.2
+version=7.3.3
 revision=1
 # the build downloads binaries linked to glibc
 archs="x86_64"
 hostmakedepends="apache-maven"
+depends="openjdk11"
 short_desc="Free Universal Database Tool"
 maintainer="Kyle Nusbaum <knusbaum+void@sdf.org>"
 license="Apache-2.0"
 homepage="https://dbeaver.io"
 distfiles="https://github.com/dbeaver/dbeaver/archive/${version}.tar.gz"
-checksum=9b37ef875771cfb34507d5423965ce1e79d263a31c245c46a89b44f01c4d9c85
+checksum=8b4cff6a1e172da763373ddc7df554569f53a0c529175e540d4b64ed2b7066d9
 nopie=true
 
 do_build() {

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
                   ` (4 preceding siblings ...)
  2021-01-31 14:47 ` [PR PATCH] [Updated] " ar-jan
@ 2021-01-31 16:04 ` ericonr
  2021-01-31 16:05 ` [PR REVIEW] " ericonr
                   ` (8 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-01-31 16:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28340#issuecomment-770404850

Comment:
It should be ok to add a `README.voidlinux` file mentioning this requirement and `vdoc` it.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
                   ` (5 preceding siblings ...)
  2021-01-31 16:04 ` ericonr
@ 2021-01-31 16:05 ` ericonr
  2021-01-31 16:07 ` ar-jan
                   ` (7 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-01-31 16:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28340#discussion_r567446727

Comment:
This will have to change if we get new openjdk versions...

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
                   ` (6 preceding siblings ...)
  2021-01-31 16:05 ` [PR REVIEW] " ericonr
@ 2021-01-31 16:07 ` ar-jan
  2021-01-31 16:08 ` ar-jan
                   ` (6 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ar-jan @ 2021-01-31 16:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New review comment by ar-jan on void-packages repository

https://github.com/void-linux/void-packages/pull/28340#discussion_r567447047

Comment:
Ah, so what's the right way to do this? Add a message to the installer and leave this to the user?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
                   ` (7 preceding siblings ...)
  2021-01-31 16:07 ` ar-jan
@ 2021-01-31 16:08 ` ar-jan
  2021-01-31 16:08 ` ar-jan
                   ` (5 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ar-jan @ 2021-01-31 16:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New review comment by ar-jan on void-packages repository

https://github.com/void-linux/void-packages/pull/28340#discussion_r567447047

Comment:
Ah, so what's the right way to do this? Add a message to the installer and leave this to the user?

Oh, right, just saw your other comment.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
                   ` (8 preceding siblings ...)
  2021-01-31 16:08 ` ar-jan
@ 2021-01-31 16:08 ` ar-jan
  2021-01-31 16:08 ` ericonr
                   ` (4 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ar-jan @ 2021-01-31 16:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New review comment by ar-jan on void-packages repository

https://github.com/void-linux/void-packages/pull/28340#discussion_r567447047

Comment:
Ah, so what's the right way to do this? Add a message to the installer and leave this to the user?

Edit: Oh, right, just saw your other comment.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
                   ` (9 preceding siblings ...)
  2021-01-31 16:08 ` ar-jan
@ 2021-01-31 16:08 ` ericonr
  2021-01-31 16:43 ` [PR PATCH] [Updated] " ar-jan
                   ` (3 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-01-31 16:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28340#discussion_r567447240

Comment:
I think it's ok to leave as depends for now. Just something to note for the future (maybe leave a comment?)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
                   ` (10 preceding siblings ...)
  2021-01-31 16:08 ` ericonr
@ 2021-01-31 16:43 ` ar-jan
  2021-01-31 16:58 ` ar-jan
                   ` (2 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: ar-jan @ 2021-01-31 16:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1866 bytes --]

There is an updated pull request by ar-jan against master on the void-packages repository

https://github.com/ar-jan/void-packages dbeaver-733
https://github.com/void-linux/void-packages/pull/28340

dbeaver: update to 7.3.3.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

Added `eclipse` as dependency, because dbeaver does not run without it (errors like `org.osgi.framework.BundleException: Could not resolve module: org.eclipse.compare [27]
  Unresolved requirement: Require-Bundle: org.eclipse.ui.navigator; bundle-version="[3.2.0,4.0.0)";` etc.).

A patch file from https://github.com/void-linux/void-packages/pull/28340.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dbeaver-733-28340.patch --]
[-- Type: text/x-diff, Size: 1190 bytes --]

From 5dfe0f8299e7f97d7f82560ae3dc1b38a5fe1228 Mon Sep 17 00:00:00 2001
From: Arjan Mossel <arjanmossel@gmail.com>
Date: Sat, 30 Jan 2021 18:46:07 +0100
Subject: [PATCH] dbeaver: update to 7.3.3.

also add eclipse as dependency, which is required for dbeaver to run.
---
 srcpkgs/dbeaver/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/dbeaver/template b/srcpkgs/dbeaver/template
index e09a1fdf757..b7e98801631 100644
--- a/srcpkgs/dbeaver/template
+++ b/srcpkgs/dbeaver/template
@@ -1,16 +1,17 @@
 # Template file for 'dbeaver'
 pkgname=dbeaver
-version=7.3.2
+version=7.3.3
 revision=1
 # the build downloads binaries linked to glibc
 archs="x86_64"
 hostmakedepends="apache-maven"
+depends="openjdk11" # openjdk11 or later version, when available
 short_desc="Free Universal Database Tool"
 maintainer="Kyle Nusbaum <knusbaum+void@sdf.org>"
 license="Apache-2.0"
 homepage="https://dbeaver.io"
 distfiles="https://github.com/dbeaver/dbeaver/archive/${version}.tar.gz"
-checksum=9b37ef875771cfb34507d5423965ce1e79d263a31c245c46a89b44f01c4d9c85
+checksum=8b4cff6a1e172da763373ddc7df554569f53a0c529175e540d4b64ed2b7066d9
 nopie=true
 
 do_build() {

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
                   ` (11 preceding siblings ...)
  2021-01-31 16:43 ` [PR PATCH] [Updated] " ar-jan
@ 2021-01-31 16:58 ` ar-jan
  2021-01-31 17:09 ` ericonr
  2021-01-31 18:23 ` [PR PATCH] [Merged]: " ericonr
  14 siblings, 0 replies; 16+ messages in thread
From: ar-jan @ 2021-01-31 16:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

New comment by ar-jan on void-packages repository

https://github.com/void-linux/void-packages/pull/28340#issuecomment-770413112

Comment:
It looks like just listing `openjdk11` as dependency is sufficient then, without further instructions? At least it worked for me while also having `openjdk8` installed, without doing `sudo xbps-alternatives -s openjdk11`. But I'm still new to Void and xbps.

Otherwise, when to use README.voidlinux and when INSTALL.msg? The latter looks more intuitive because you see it right when installing.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
                   ` (12 preceding siblings ...)
  2021-01-31 16:58 ` ar-jan
@ 2021-01-31 17:09 ` ericonr
  2021-01-31 18:23 ` [PR PATCH] [Merged]: " ericonr
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-01-31 17:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28340#issuecomment-770414904

Comment:
If you think the dependency is enough, go for it. The idea with not having INSTALL.msg is that it should be used for "emergency" situations, because if you have too much stuff printed at install time, you'll end up not paying attention to them.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Merged]: dbeaver: update to 7.3.3.
  2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
                   ` (13 preceding siblings ...)
  2021-01-31 17:09 ` ericonr
@ 2021-01-31 18:23 ` ericonr
  14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-01-31 18:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1708 bytes --]

There's a merged pull request on the void-packages repository

dbeaver: update to 7.3.3.
https://github.com/void-linux/void-packages/pull/28340

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

Added `eclipse` as dependency, because dbeaver does not run without it (errors like `org.osgi.framework.BundleException: Could not resolve module: org.eclipse.compare [27]
  Unresolved requirement: Require-Bundle: org.eclipse.ui.navigator; bundle-version="[3.2.0,4.0.0)";` etc.).

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2021-01-31 18:23 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-30 17:59 [PR PATCH] dbeaver: update to 7.3.3 ar-jan
2021-01-30 18:04 ` [PR PATCH] [Updated] " ar-jan
2021-01-31  3:28 ` ericonr
2021-01-31  4:10 ` kartikynwa
2021-01-31  4:40 ` kartikynwa
2021-01-31 14:47 ` [PR PATCH] [Updated] " ar-jan
2021-01-31 16:04 ` ericonr
2021-01-31 16:05 ` [PR REVIEW] " ericonr
2021-01-31 16:07 ` ar-jan
2021-01-31 16:08 ` ar-jan
2021-01-31 16:08 ` ar-jan
2021-01-31 16:08 ` ericonr
2021-01-31 16:43 ` [PR PATCH] [Updated] " ar-jan
2021-01-31 16:58 ` ar-jan
2021-01-31 17:09 ` ericonr
2021-01-31 18:23 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).