* [PR PATCH] kops: update to 1.19.0
@ 2021-02-02 23:42 ScOut3R
2021-02-02 23:51 ` ericonr
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: ScOut3R @ 2021-02-02 23:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
There is a new pull request by ScOut3R against master on the void-packages repository
https://github.com/ScOut3R/void-packages kops
https://github.com/void-linux/void-packages/pull/28421
kops: update to 1.19.0
I had to change the checkout flow since they stopped publishing version related branches.
The new flow checks out the version tag.
A patch file from https://github.com/void-linux/void-packages/pull/28421.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kops-28421.patch --]
[-- Type: text/x-diff, Size: 930 bytes --]
From cb869c9fb1dabae9446ce00495abd276a8b3a54a Mon Sep 17 00:00:00 2001
From: Mate GABRI <mate.gabri@playhq.com>
Date: Wed, 3 Feb 2021 09:41:07 +1000
Subject: [PATCH] kops: update to 1.19.0
---
srcpkgs/kops/template | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/kops/template b/srcpkgs/kops/template
index 4959d6aa79c..bd49b331875 100644
--- a/srcpkgs/kops/template
+++ b/srcpkgs/kops/template
@@ -1,6 +1,6 @@
# Template file for 'kops'
pkgname=kops
-version=1.15.1
+version=1.19.0
revision=1
archs="x86_64*"
build_wrksrc=src/k8s.io/kops
@@ -18,8 +18,10 @@ do_fetch() {
# process expects the directory to be a git repository
rm -rf $wrksrc
mkdir -p $wrksrc/src/k8s.io
- git clone -b ${version} https://github.com/kubernetes/kops \
+ git clone https://github.com/kubernetes/kops \
$wrksrc/src/k8s.io/kops
+ cd $wrksrc/src/k8s.io/kops
+ git checkout v${version}
}
do_build() {
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: kops: update to 1.19.0
2021-02-02 23:42 [PR PATCH] kops: update to 1.19.0 ScOut3R
@ 2021-02-02 23:51 ` ericonr
2021-02-03 0:36 ` ScOut3R
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-02-02 23:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 290 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28421#issuecomment-772095613
Comment:
Does it need to be a git repository? Otherwise you can download a tarball of any repository with `https://github.com/user/project/archive/tag.tar.gz`
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: kops: update to 1.19.0
2021-02-02 23:42 [PR PATCH] kops: update to 1.19.0 ScOut3R
2021-02-02 23:51 ` ericonr
@ 2021-02-03 0:36 ` ScOut3R
2021-02-03 14:21 ` [PR REVIEW] " ericonr
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ScOut3R @ 2021-02-03 0:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
New comment by ScOut3R on void-packages repository
https://github.com/void-linux/void-packages/pull/28421#issuecomment-772115047
Comment:
> Does it need to be a git repository? Otherwise you can download a tarball of any repository with `https://github.com/user/project/archive/tag.tar.gz`
Good point!
Looks like the build process depends on the source being a git checkout? Getting this error when running `make bazel-build-kops-linux-amd64`
```fatal: not a git repository (or any of the parent directories): .git```
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR REVIEW] kops: update to 1.19.0
2021-02-02 23:42 [PR PATCH] kops: update to 1.19.0 ScOut3R
2021-02-02 23:51 ` ericonr
2021-02-03 0:36 ` ScOut3R
@ 2021-02-03 14:21 ` ericonr
2021-02-03 22:10 ` [PR PATCH] [Updated] " ScOut3R
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-02-03 14:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28421#discussion_r569452693
Comment:
I think this would work with `-b v${version}`. `git-clone(1)` claims `-b` can take tags, not only branch names.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Updated] kops: update to 1.19.0
2021-02-02 23:42 [PR PATCH] kops: update to 1.19.0 ScOut3R
` (2 preceding siblings ...)
2021-02-03 14:21 ` [PR REVIEW] " ericonr
@ 2021-02-03 22:10 ` ScOut3R
2021-02-03 22:10 ` [PR REVIEW] " ScOut3R
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ScOut3R @ 2021-02-03 22:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
There is an updated pull request by ScOut3R against master on the void-packages repository
https://github.com/ScOut3R/void-packages kops
https://github.com/void-linux/void-packages/pull/28421
kops: update to 1.19.0
I had to change the checkout flow since they stopped publishing version related branches.
The new flow checks out the version tag.
A patch file from https://github.com/void-linux/void-packages/pull/28421.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kops-28421.patch --]
[-- Type: text/x-diff, Size: 902 bytes --]
From 4a54b52ed5b251a34482b16362c141dafa136150 Mon Sep 17 00:00:00 2001
From: Mate GABRI <mate.gabri@playhq.com>
Date: Wed, 3 Feb 2021 09:41:07 +1000
Subject: [PATCH] kops: update to 1.19.0
---
srcpkgs/kops/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/kops/template b/srcpkgs/kops/template
index 4959d6aa79c..840902c5a4a 100644
--- a/srcpkgs/kops/template
+++ b/srcpkgs/kops/template
@@ -1,7 +1,7 @@
# Template file for 'kops'
pkgname=kops
-version=1.15.1
-revision=1
+version=1.19.0
+revision=2
archs="x86_64*"
build_wrksrc=src/k8s.io/kops
build_style=go
@@ -18,7 +18,7 @@ do_fetch() {
# process expects the directory to be a git repository
rm -rf $wrksrc
mkdir -p $wrksrc/src/k8s.io
- git clone -b ${version} https://github.com/kubernetes/kops \
+ git clone -b v${version} https://github.com/kubernetes/kops \
$wrksrc/src/k8s.io/kops
}
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR REVIEW] kops: update to 1.19.0
2021-02-02 23:42 [PR PATCH] kops: update to 1.19.0 ScOut3R
` (3 preceding siblings ...)
2021-02-03 22:10 ` [PR PATCH] [Updated] " ScOut3R
@ 2021-02-03 22:10 ` ScOut3R
2021-02-04 1:02 ` [PR PATCH] [Closed]: " ericonr
2021-02-04 1:02 ` ericonr
6 siblings, 0 replies; 8+ messages in thread
From: ScOut3R @ 2021-02-03 22:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 199 bytes --]
New review comment by ScOut3R on void-packages repository
https://github.com/void-linux/void-packages/pull/28421#discussion_r569787205
Comment:
Thank you for the suggestion, I have updated the PR.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Closed]: kops: update to 1.19.0
2021-02-02 23:42 [PR PATCH] kops: update to 1.19.0 ScOut3R
` (4 preceding siblings ...)
2021-02-03 22:10 ` [PR REVIEW] " ScOut3R
@ 2021-02-04 1:02 ` ericonr
2021-02-04 1:02 ` ericonr
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-02-04 1:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
There's a closed pull request on the void-packages repository
kops: update to 1.19.0
https://github.com/void-linux/void-packages/pull/28421
Description:
I had to change the checkout flow since they stopped publishing version related branches.
The new flow checks out the version tag.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: kops: update to 1.19.0
2021-02-02 23:42 [PR PATCH] kops: update to 1.19.0 ScOut3R
` (5 preceding siblings ...)
2021-02-04 1:02 ` [PR PATCH] [Closed]: " ericonr
@ 2021-02-04 1:02 ` ericonr
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-02-04 1:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/28421#issuecomment-772944221
Comment:
I fixed the revision and pushed :)
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-02-04 1:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-02 23:42 [PR PATCH] kops: update to 1.19.0 ScOut3R
2021-02-02 23:51 ` ericonr
2021-02-03 0:36 ` ScOut3R
2021-02-03 14:21 ` [PR REVIEW] " ericonr
2021-02-03 22:10 ` [PR PATCH] [Updated] " ScOut3R
2021-02-03 22:10 ` [PR REVIEW] " ScOut3R
2021-02-04 1:02 ` [PR PATCH] [Closed]: " ericonr
2021-02-04 1:02 ` ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).