[PR PATCH] [WIP] New package: linux-steam-integration-0.7.3

[PR PATCH] [WIP] New package: linux-steam-integration-0.7.3

[xolophreny]

[-- Attachment #1: Type: text/plain, Size: 2335 bytes --]

There is a new pull request by xolophreny against master on the void-packages repository

https://github.com/xolophreny/void-packages lsi
https://github.com/void-linux/void-packages/pull/28538

[WIP] New package: linux-steam-integration-0.7.3
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

Closes #19282, caveats:

- Needs both 64-bit and 32-bit packages installed to work properly
- Couldn't test if `liblsi-intercept.so` and `liblsi-redirect.so` work at all for the following reason:
- Manually installing replacements for steam runtime components is a challenge, at some point I got stuck with lsi-steam crashing at launch without meaningful errors, and regular steam with STEAM_RUNTIME=0 not launching with
```
src/clientdll/appdatacache.cpp (2640) : Assertion Failed: !bSharedKVSymbols
src/clientdll/appdatacache.cpp (2640) : Assertion Failed: !bSharedKVSymbols
```
whatever that might mean. I'm not sure if lsi-steam crash is related to lsi-steam or steam itself, any help would be appreciated.

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28538.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lsi-28538.patch --]
[-- Type: text/x-diff, Size: 1364 bytes --]

From 834efbc143335b8d9717bc51d7b9ee994e06ec78 Mon Sep 17 00:00:00 2001
From: xolophreny <xolophreny@protonmail.ch>
Date: Sat, 6 Feb 2021 03:43:16 +0500
Subject: [PATCH] New package: linux-steam-integration-0.7.3

---
 srcpkgs/linux-steam-integration/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/linux-steam-integration/template

diff --git a/srcpkgs/linux-steam-integration/template b/srcpkgs/linux-steam-integration/template
new file mode 100644
index 00000000000..df5246a3220
--- /dev/null
+++ b/srcpkgs/linux-steam-integration/template
@@ -0,0 +1,19 @@
+pkgname=linux-steam-integration
+version=0.7.3
+revision=1
+archs="x86_64 i686"
+build_style=meson
+configure_args="-Dwith-shim=co-exist \
+        -Dwith-steam-binary=/usr/bin/steam \
+        -Dwith-new-libcxx-abi=true \
+        -Dwith-libressl-mode=native \
+        -Dwith-frontend=true"
+hostmakedepends="pkg-config"
+makedepends="gtk+3-devel"
+depends="gtk+3 glib glibc steam"
+short_desc="Helper for enabling better Steam integration on Linux"
+maintainer="xolophreny <xolophreny@protonmail.ch>"
+license="LGPL-2.1-only"
+homepage="https://github.com/clearlinux/linux-steam-integration"
+distfiles="${homepage}/releases/download/v${version}/${pkgname}-${version}.tar.xz"
+checksum="be8f391ad786c09aa74aec83dc9077adf0863f92f297a1d361dfd61ed1108d41"

Re: [PR PATCH] [Updated] [WIP] New package: linux-steam-integration-0.7.3

[xolophreny]

[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]

There is an updated pull request by xolophreny against master on the void-packages repository

https://github.com/xolophreny/void-packages lsi
https://github.com/void-linux/void-packages/pull/28538

[WIP] New package: linux-steam-integration-0.7.3
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

Closes #19282, caveats:

- Needs both 64-bit and 32-bit packages installed to work properly
- Couldn't test if `liblsi-intercept.so` and `liblsi-redirect.so` work at all for the following reason:
- Manually installing replacements for steam runtime components is a challenge, at some point I got stuck with lsi-steam crashing at launch without meaningful errors, and regular steam with STEAM_RUNTIME=0 not launching with
```
src/clientdll/appdatacache.cpp (2640) : Assertion Failed: !bSharedKVSymbols
src/clientdll/appdatacache.cpp (2640) : Assertion Failed: !bSharedKVSymbols
```
whatever that might mean. I'm not sure if lsi-steam crash is related to lsi-steam or steam itself, any help would be appreciated.

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28538.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lsi-28538.patch --]
[-- Type: text/x-diff, Size: 1396 bytes --]

From f2967f79ca5822bd4bbdd87d9538e6b0dc1bd194 Mon Sep 17 00:00:00 2001
From: xolophreny <xolophreny@protonmail.ch>
Date: Sat, 6 Feb 2021 03:43:16 +0500
Subject: [PATCH] New package: linux-steam-integration-0.7.3

---
 srcpkgs/linux-steam-integration/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/linux-steam-integration/template

diff --git a/srcpkgs/linux-steam-integration/template b/srcpkgs/linux-steam-integration/template
new file mode 100644
index 00000000000..d00385ce4ef
--- /dev/null
+++ b/srcpkgs/linux-steam-integration/template
@@ -0,0 +1,20 @@
+# Template file for 'linux-steam-integration'
+pkgname=linux-steam-integration
+version=0.7.3
+revision=1
+archs="x86_64 i686"
+build_style=meson
+configure_args="-Dwith-shim=co-exist \
+    -Dwith-steam-binary=/usr/bin/steam \
+    -Dwith-new-libcxx-abi=true \
+    -Dwith-libressl-mode=native \
+    -Dwith-frontend=true"
+hostmakedepends="pkg-config"
+makedepends="gtk+3-devel"
+depends="gtk+3 glib glibc steam"
+short_desc="Helper for enabling better Steam integration on Linux"
+maintainer="xolophreny <xolophreny@protonmail.ch>"
+license="LGPL-2.1-only"
+homepage="https://github.com/clearlinux/linux-steam-integration"
+distfiles="${homepage}/releases/download/v${version}/${pkgname}-${version}.tar.xz"
+checksum="be8f391ad786c09aa74aec83dc9077adf0863f92f297a1d361dfd61ed1108d41"

Re: [PR REVIEW] [WIP] New package: linux-steam-integration-0.7.3

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28538#discussion_r571300134

Comment:
Indent multiline variables with a single space.

Re: [PR REVIEW] [WIP] New package: linux-steam-integration-0.7.3

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28538#discussion_r571300481

Comment:
Also no need for the back slashes.

Re: [PR REVIEW] [WIP] New package: linux-steam-integration-0.7.3

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28538#discussion_r571300023

Comment:
The first three should be detected automatically once the package is built. I'm not sure this should depend on steam either... Couldn't it still be useful if you use flatpak or install it manually some other way?

Re: [PR REVIEW] [WIP] New package: linux-steam-integration-0.7.3

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28538#discussion_r571300327

Comment:
If it works with flatpak steam, we should remove the limitation and allow `x86_64* i686*`.

Re: [PR PATCH] [Updated] [WIP] New package: linux-steam-integration-0.7.3

[xolophreny]

[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]

There is an updated pull request by xolophreny against master on the void-packages repository

https://github.com/xolophreny/void-packages lsi
https://github.com/void-linux/void-packages/pull/28538

[WIP] New package: linux-steam-integration-0.7.3
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

Closes #19282, caveats:

- Needs both 64-bit and 32-bit packages installed to work properly
- Couldn't test if `liblsi-intercept.so` and `liblsi-redirect.so` work at all for the following reason:
- Manually installing replacements for steam runtime components is a challenge, at some point I got stuck with lsi-steam crashing at launch without meaningful errors, and regular steam with STEAM_RUNTIME=0 not launching with
```
src/clientdll/appdatacache.cpp (2640) : Assertion Failed: !bSharedKVSymbols
src/clientdll/appdatacache.cpp (2640) : Assertion Failed: !bSharedKVSymbols
```
whatever that might mean. I'm not sure if lsi-steam crash is related to lsi-steam or steam itself, any help would be appreciated.

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28538.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lsi-28538.patch --]
[-- Type: text/x-diff, Size: 1384 bytes --]

From 7431f4f1a9b173d0cbaaaeaa925f01786216b4a1 Mon Sep 17 00:00:00 2001
From: xolophreny <xolophreny@protonmail.ch>
Date: Sat, 6 Feb 2021 03:43:16 +0500
Subject: [PATCH] New package: linux-steam-integration-0.7.3

---
 srcpkgs/linux-steam-integration/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/linux-steam-integration/template

diff --git a/srcpkgs/linux-steam-integration/template b/srcpkgs/linux-steam-integration/template
new file mode 100644
index 00000000000..cc48d2ea312
--- /dev/null
+++ b/srcpkgs/linux-steam-integration/template
@@ -0,0 +1,20 @@
+# Template file for 'linux-steam-integration'
+pkgname=linux-steam-integration
+version=0.7.3
+revision=1
+archs="x86_64 i686"
+build_style=meson
+configure_args="-Dwith-shim=co-exist \
+	-Dwith-steam-binary=/usr/bin/steam \
+	-Dwith-new-libcxx-abi=true \
+	-Dwith-libressl-mode=native \
+	-Dwith-frontend=true"
+hostmakedepends="pkg-config"
+makedepends="gtk+3-devel"
+depends="gtk+3 glib glibc steam"
+short_desc="Helper for enabling better Steam integration on Linux"
+maintainer="xolophreny <xolophreny@protonmail.ch>"
+license="LGPL-2.1-only"
+homepage="https://github.com/clearlinux/linux-steam-integration"
+distfiles="${homepage}/releases/download/v${version}/${pkgname}-${version}.tar.xz"
+checksum="be8f391ad786c09aa74aec83dc9077adf0863f92f297a1d361dfd61ed1108d41"

Re: [PR PATCH] [Updated] [WIP] New package: linux-steam-integration-0.7.3

[xolophreny]

[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]

There is an updated pull request by xolophreny against master on the void-packages repository

https://github.com/xolophreny/void-packages lsi
https://github.com/void-linux/void-packages/pull/28538

[WIP] New package: linux-steam-integration-0.7.3
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

Closes #19282, caveats:

- Needs both 64-bit and 32-bit packages installed to work properly
- Couldn't test if `liblsi-intercept.so` and `liblsi-redirect.so` work at all for the following reason:
- Manually installing replacements for steam runtime components is a challenge, at some point I got stuck with lsi-steam crashing at launch without meaningful errors, and regular steam with STEAM_RUNTIME=0 not launching with
```
src/clientdll/appdatacache.cpp (2640) : Assertion Failed: !bSharedKVSymbols
src/clientdll/appdatacache.cpp (2640) : Assertion Failed: !bSharedKVSymbols
```
whatever that might mean. I'm not sure if lsi-steam crash is related to lsi-steam or steam itself, any help would be appreciated.

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28538.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lsi-28538.patch --]
[-- Type: text/x-diff, Size: 1343 bytes --]

From 9a6d76ce2858b0ab7944fbfc717e9a5e51522777 Mon Sep 17 00:00:00 2001
From: xolophreny <xolophreny@protonmail.ch>
Date: Sat, 6 Feb 2021 03:43:16 +0500
Subject: [PATCH] New package: linux-steam-integration-0.7.3

---
 srcpkgs/linux-steam-integration/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/linux-steam-integration/template

diff --git a/srcpkgs/linux-steam-integration/template b/srcpkgs/linux-steam-integration/template
new file mode 100644
index 00000000000..e8702bed171
--- /dev/null
+++ b/srcpkgs/linux-steam-integration/template
@@ -0,0 +1,19 @@
+# Template file for 'linux-steam-integration'
+pkgname=linux-steam-integration
+version=0.7.3
+revision=1
+archs="x86_64* i686*"
+build_style=meson
+configure_args="-Dwith-shim=co-exist
+ -Dwith-steam-binary=/usr/bin/steam
+ -Dwith-new-libcxx-abi=true
+ -Dwith-libressl-mode=native
+ -Dwith-frontend=true"
+hostmakedepends="pkg-config"
+makedepends="gtk+3-devel"
+short_desc="Helper for enabling better Steam integration on Linux"
+maintainer="xolophreny <xolophreny@protonmail.ch>"
+license="LGPL-2.1-only"
+homepage="https://github.com/clearlinux/linux-steam-integration"
+distfiles="${homepage}/releases/download/v${version}/${pkgname}-${version}.tar.xz"
+checksum="be8f391ad786c09aa74aec83dc9077adf0863f92f297a1d361dfd61ed1108d41"

Re: [PR REVIEW] [WIP] New package: linux-steam-integration-0.7.3

[xolophreny]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New review comment by xolophreny on void-packages repository

https://github.com/void-linux/void-packages/pull/28538#discussion_r571302777

Comment:
It is built to assume that normal steam is at `/usr/bin/steam`, so if flatpak steam follows that, yeah, I guess it'd work

Re: [PR REVIEW] [WIP] New package: linux-steam-integration-0.7.3

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/28538#discussion_r571318914

Comment:
I'm pretty sure this does nothing for flatpak. (except ofc if you install it inside of flatpak).

Re: [WIP] New package: linux-steam-integration-0.7.3

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 695 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/28538#issuecomment-774359845

Comment:
I'm not sure at all if this package should be added to the repo.

For one it is not actively developed anymore, but it is guaranteed to require maintenance due to the way it is working. Furthermore it has an hard coded list of sonames and versions it can replace, so it also will get less usefull over time even if it doesn't break.

Furthermore this current version should at least run into this problem: https://github.com/solus-project/linux-steam-integration/issues/82

Furthermore, how many games do even really benefit from this nowadays?

Re: [WIP] New package: linux-steam-integration-0.7.3

[xolophreny]

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]

New comment by xolophreny on void-packages repository

https://github.com/void-linux/void-packages/pull/28538#issuecomment-774453616

Comment:
> I'm not sure at all if this package should be added to the repo.
> 
> For one it is not actively developed anymore, but it is guaranteed to require maintenance due to the way it is working. Furthermore it has an hard coded list of sonames and versions it can replace, so it also will get less usefull over time even if it doesn't break.
>
> Furthermore, how many games do even really benefit from this nowadays?

Agreed on all that. Even getting it to work at all, ideally, requires something like a `steam-runtime` meta-package that pulls runtime replacements in. Tried to cobble that together but that'd really need a clean system, which I don't have unfortunately.

> Furthermore this current version should at least run into this problem: solus-project/linux-steam-integration#82

Oh right, that... Well that specific issue luckily has a patch that could be introduced here, but yeah, LSI indeed seems not quite maintained and/or useful enough now.

Re: [PR PATCH] [Closed]: [WIP] New package: linux-steam-integration-0.7.3

[xolophreny]

[-- Attachment #1: Type: text/plain, Size: 2182 bytes --]

There's a closed pull request on the void-packages repository

[WIP] New package: linux-steam-integration-0.7.3
https://github.com/void-linux/void-packages/pull/28538

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

Closes #19282, caveats:

- Needs both 64-bit and 32-bit packages installed to work properly
- Couldn't test if `liblsi-intercept.so` and `liblsi-redirect.so` work at all for the following reason:
- Manually installing replacements for steam runtime components is a challenge, at some point I got stuck with lsi-steam crashing at launch without meaningful errors, and regular steam with STEAM_RUNTIME=0 not launching with
```
src/clientdll/appdatacache.cpp (2640) : Assertion Failed: !bSharedKVSymbols
src/clientdll/appdatacache.cpp (2640) : Assertion Failed: !bSharedKVSymbols
```
whatever that might mean. I'm not sure if lsi-steam crash is related to lsi-steam or steam itself, any help would be appreciated.

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->