Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] rhash: change build_style to configure
@ 2021-02-06 21:57 Johnnynator
  2021-02-07 13:46 ` [PR PATCH] [Merged]: " leahneukirchen
  0 siblings, 1 reply; 2+ messages in thread
From: Johnnynator @ 2021-02-06 21:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1761 bytes --]

There is a new pull request by Johnnynator against master on the void-packages repository

https://github.com/Johnnynator/void-packages rhash
https://github.com/void-linux/void-packages/pull/28556

rhash: change build_style to configure
The configure script is just a random shell script

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

@leahneukirchen noticed this while tasting some ( #28531 ) change to the gnu-configure build-style.

A patch file from https://github.com/void-linux/void-packages/pull/28556.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rhash-28556.patch --]
[-- Type: text/x-diff, Size: 1528 bytes --]

From e5c7053684da7d2e4058c6fb22d1b56f8cb5e266 Mon Sep 17 00:00:00 2001
From: John <me@johnnynator.dev>
Date: Sat, 6 Feb 2021 22:55:10 +0100
Subject: [PATCH] rhash: change build_style to configure

The configure script is just a random shell script
---
 srcpkgs/rhash/patches/configure.patch | 17 -----------------
 srcpkgs/rhash/template                |  5 +++--
 2 files changed, 3 insertions(+), 19 deletions(-)
 delete mode 100644 srcpkgs/rhash/patches/configure.patch

diff --git a/srcpkgs/rhash/patches/configure.patch b/srcpkgs/rhash/patches/configure.patch
deleted file mode 100644
index afd1aebd6fa..00000000000
--- a/srcpkgs/rhash/patches/configure.patch
+++ /dev/null
@@ -1,17 +0,0 @@
---- configure.orig
-+++ configure
-@@ -194,7 +194,6 @@
-     ;;
-   *)
-       echo "unknown option $OPT"
--      exit 1
-       ;;
-   esac
-   shift
-@@ -897,4 +896,4 @@
- Libs.private: ${OPENSSL_LDFLAGS}
- 
- EOF
--fi
-\ No newline at end of file
-+fi
diff --git a/srcpkgs/rhash/template b/srcpkgs/rhash/template
index 820963e9ede..749f9755106 100644
--- a/srcpkgs/rhash/template
+++ b/srcpkgs/rhash/template
@@ -3,8 +3,9 @@ pkgname=rhash
 version=1.4.1
 revision=1
 wrksrc="RHash-${version}"
-build_style=gnu-configure
-configure_args="--enable-openssl --disable-openssl-runtime"
+build_style=configure
+configure_args="--enable-openssl --disable-openssl-runtime
+ --prefix=/usr --sysconfdir=/etc"
 conf_files="/etc/rhashrc"
 makedepends="libressl-devel"
 short_desc="Utility for computing hash sums and creating magnet links"

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: rhash: change build_style to configure
  2021-02-06 21:57 [PR PATCH] rhash: change build_style to configure Johnnynator
@ 2021-02-07 13:46 ` leahneukirchen
  0 siblings, 0 replies; 2+ messages in thread
From: leahneukirchen @ 2021-02-07 13:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

There's a merged pull request on the void-packages repository

rhash: change build_style to configure
https://github.com/void-linux/void-packages/pull/28556

Description:
The configure script is just a random shell script

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

@leahneukirchen noticed this while testing some ( #28531 ) change to the gnu-configure build-style.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-07 13:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-06 21:57 [PR PATCH] rhash: change build_style to configure Johnnynator
2021-02-07 13:46 ` [PR PATCH] [Merged]: " leahneukirchen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).