Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: python3-curio-1.4
@ 2021-02-02 22:49 ar-jan
  2021-02-02 22:59 ` [PR PATCH] [Updated] " ar-jan
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: ar-jan @ 2021-02-02 22:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]

There is a new pull request by ar-jan against master on the void-packages repository

https://github.com/ar-jan/void-packages python3-curio
https://github.com/void-linux/void-packages/pull/28419

New package: python3-curio-1.4
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

### Reason

#28272 keeps getting stuck on CI so I want to see if adding dependencies one by one would pass tests.

A patch file from https://github.com/void-linux/void-packages/pull/28419.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-curio-28419.patch --]
[-- Type: text/x-diff, Size: 1217 bytes --]

From 26dc074aec7457efbe7a58c2410c140a444f37bd Mon Sep 17 00:00:00 2001
From: Arjan Mossel <arjanmossel@gmail.com>
Date: Thu, 28 Jan 2021 01:01:20 +0100
Subject: [PATCH] New package: python3-curio-1.4

---
 srcpkgs/python3-curio/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/python3-curio/template

diff --git a/srcpkgs/python3-curio/template b/srcpkgs/python3-curio/template
new file mode 100644
index 00000000000..c7e2c3ae643
--- /dev/null
+++ b/srcpkgs/python3-curio/template
@@ -0,0 +1,23 @@
+# Template file for 'python3-curio'
+pkgname=python3-curio
+version=1.4
+revision=1
+wrksrc="curio-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+checkdepends="python3-pytest"
+short_desc="Coroutine-based library for concurrent programming using async/await"
+maintainer="Arjan Mossel <arjanmossel@gmail.com>"
+license="BSD-3-Clause"
+homepage="https://github.com/dabeaz/curio"
+distfiles="${PYPI_SITE}/c/curio/curio-${version}.tar.gz"
+checksum=57edce81c837f3c2cf42fbb346dee26e537d1659e6605269fb13bd179e068744
+
+do_check() {
+	PYTHONPATH=$(cd build/lib* && pwd) pytest
+}
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-curio-1.4
  2021-02-02 22:49 [PR PATCH] New package: python3-curio-1.4 ar-jan
@ 2021-02-02 22:59 ` ar-jan
  2021-02-08 14:26 ` ar-jan
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ar-jan @ 2021-02-02 22:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1705 bytes --]

There is an updated pull request by ar-jan against master on the void-packages repository

https://github.com/ar-jan/void-packages python3-curio
https://github.com/void-linux/void-packages/pull/28419

New package: python3-curio-1.4
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

### Reason

#28272 keeps getting stuck on CI so I want to see if adding dependencies one by one would pass tests.

A patch file from https://github.com/void-linux/void-packages/pull/28419.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-curio-28419.patch --]
[-- Type: text/x-diff, Size: 1232 bytes --]

From 490f8c559dc2a0abcd8069c39a602d03ea69cda8 Mon Sep 17 00:00:00 2001
From: Arjan Mossel <arjanmossel@gmail.com>
Date: Thu, 28 Jan 2021 01:01:20 +0100
Subject: [PATCH] New package: python3-curio-1.4

---
 srcpkgs/python3-curio/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/python3-curio/template

diff --git a/srcpkgs/python3-curio/template b/srcpkgs/python3-curio/template
new file mode 100644
index 00000000000..b154cd6f83f
--- /dev/null
+++ b/srcpkgs/python3-curio/template
@@ -0,0 +1,23 @@
+# Template file for 'python3-curio'
+pkgname=python3-curio
+version=1.4
+revision=1
+wrksrc="curio-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+checkdepends="python3-pytest python3-Sphinx"
+short_desc="Coroutine-based library for concurrent programming using async/await"
+maintainer="Arjan Mossel <arjanmossel@gmail.com>"
+license="BSD-3-Clause"
+homepage="https://github.com/dabeaz/curio"
+distfiles="${PYPI_SITE}/c/curio/curio-${version}.tar.gz"
+checksum=57edce81c837f3c2cf42fbb346dee26e537d1659e6605269fb13bd179e068744
+
+do_check() {
+	PYTHONPATH=$(cd build/lib* && pwd) pytest
+}
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-curio-1.4
  2021-02-02 22:49 [PR PATCH] New package: python3-curio-1.4 ar-jan
  2021-02-02 22:59 ` [PR PATCH] [Updated] " ar-jan
@ 2021-02-08 14:26 ` ar-jan
  2021-02-08 15:32 ` ar-jan
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ar-jan @ 2021-02-08 14:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1705 bytes --]

There is an updated pull request by ar-jan against master on the void-packages repository

https://github.com/ar-jan/void-packages python3-curio
https://github.com/void-linux/void-packages/pull/28419

New package: python3-curio-1.4
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

### Reason

#28272 keeps getting stuck on CI so I want to see if adding dependencies one by one would pass tests.

A patch file from https://github.com/void-linux/void-packages/pull/28419.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-curio-28419.patch --]
[-- Type: text/x-diff, Size: 1232 bytes --]

From d555b5fa57f45da97de0e27ee54a39dd7decf33b Mon Sep 17 00:00:00 2001
From: Arjan Mossel <arjanmossel@gmail.com>
Date: Thu, 28 Jan 2021 01:01:20 +0100
Subject: [PATCH] New package: python3-curio-1.4

---
 srcpkgs/python3-curio/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/python3-curio/template

diff --git a/srcpkgs/python3-curio/template b/srcpkgs/python3-curio/template
new file mode 100644
index 00000000000..b154cd6f83f
--- /dev/null
+++ b/srcpkgs/python3-curio/template
@@ -0,0 +1,23 @@
+# Template file for 'python3-curio'
+pkgname=python3-curio
+version=1.4
+revision=1
+wrksrc="curio-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+checkdepends="python3-pytest python3-Sphinx"
+short_desc="Coroutine-based library for concurrent programming using async/await"
+maintainer="Arjan Mossel <arjanmossel@gmail.com>"
+license="BSD-3-Clause"
+homepage="https://github.com/dabeaz/curio"
+distfiles="${PYPI_SITE}/c/curio/curio-${version}.tar.gz"
+checksum=57edce81c837f3c2cf42fbb346dee26e537d1659e6605269fb13bd179e068744
+
+do_check() {
+	PYTHONPATH=$(cd build/lib* && pwd) pytest
+}
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-curio-1.4
  2021-02-02 22:49 [PR PATCH] New package: python3-curio-1.4 ar-jan
  2021-02-02 22:59 ` [PR PATCH] [Updated] " ar-jan
  2021-02-08 14:26 ` ar-jan
@ 2021-02-08 15:32 ` ar-jan
  2021-02-08 15:40 ` ar-jan
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ar-jan @ 2021-02-08 15:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1705 bytes --]

There is an updated pull request by ar-jan against master on the void-packages repository

https://github.com/ar-jan/void-packages python3-curio
https://github.com/void-linux/void-packages/pull/28419

New package: python3-curio-1.4
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

### Reason

#28272 keeps getting stuck on CI so I want to see if adding dependencies one by one would pass tests.

A patch file from https://github.com/void-linux/void-packages/pull/28419.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-curio-28419.patch --]
[-- Type: text/x-diff, Size: 1312 bytes --]

From 025cd4898c81dc070e54b441781464ef93c5c557 Mon Sep 17 00:00:00 2001
From: Arjan Mossel <arjanmossel@gmail.com>
Date: Thu, 28 Jan 2021 01:01:20 +0100
Subject: [PATCH] New package: python3-curio-1.4

---
 srcpkgs/python3-curio/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/python3-curio/template

diff --git a/srcpkgs/python3-curio/template b/srcpkgs/python3-curio/template
new file mode 100644
index 00000000000..9febedf497f
--- /dev/null
+++ b/srcpkgs/python3-curio/template
@@ -0,0 +1,25 @@
+# Template file for 'python3-curio'
+pkgname=python3-curio
+version=1.4
+revision=1
+wrksrc="curio-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+checkdepends="python3-pytest python3-Sphinx"
+short_desc="Coroutine-based library for concurrent programming using async/await"
+maintainer="Arjan Mossel <arjanmossel@gmail.com>"
+license="BSD-3-Clause"
+homepage="https://github.com/dabeaz/curio"
+distfiles="${PYPI_SITE}/c/curio/curio-${version}.tar.gz"
+checksum=57edce81c837f3c2cf42fbb346dee26e537d1659e6605269fb13bd179e068744
+
+do_check() {
+	# On some arches CI builds fail, possibly due to a connectivity issue
+	# PYTHONPATH=$(cd build/lib* && pwd) pytest
+	:
+}
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: python3-curio-1.4
  2021-02-02 22:49 [PR PATCH] New package: python3-curio-1.4 ar-jan
                   ` (2 preceding siblings ...)
  2021-02-08 15:32 ` ar-jan
@ 2021-02-08 15:40 ` ar-jan
  2021-02-08 17:40 ` Chocimier
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ar-jan @ 2021-02-08 15:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

New comment by ar-jan on void-packages repository

https://github.com/void-linux/void-packages/pull/28419#issuecomment-775237629

Comment:
On CI the following builds succeed:

    aarch64, x86_64
    armv7l, x86_64
    armv6l-musl, x86_64-musl
    aarch64-musl, x86_64-musl

Locally on an `x86_64` system the tests also pass. But for some reason `x86_64, x86_64`, `i686, i686`, and `x86_64-musl, x86_64-musl` run out of time on CI without any reported errors. On #voidlinux channel a CI connectivity problem was suggested as a possible reason. Since it builds successfully on most arches I've disabled tests and added a note.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: python3-curio-1.4
  2021-02-02 22:49 [PR PATCH] New package: python3-curio-1.4 ar-jan
                   ` (3 preceding siblings ...)
  2021-02-08 15:40 ` ar-jan
@ 2021-02-08 17:40 ` Chocimier
  2021-02-08 17:40 ` [PR PATCH] [Closed]: " Chocimier
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Chocimier @ 2021-02-08 17:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/28419#issuecomment-775319459

Comment:
Don't send here PRs that you do not want to be merged. To test things, send them to your own fork.

Please do not disable tests that pass locally. Please comment in template instead.

Here, failure in CI is because container have some privileges that https://github.com/dabeaz/curio/blob/1.4/tests/test_network.py#L317 don't expect - please disable that one test with `pytest -k`.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Closed]: New package: python3-curio-1.4
  2021-02-02 22:49 [PR PATCH] New package: python3-curio-1.4 ar-jan
                   ` (4 preceding siblings ...)
  2021-02-08 17:40 ` Chocimier
@ 2021-02-08 17:40 ` Chocimier
  2021-02-08 18:06 ` ar-jan
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Chocimier @ 2021-02-08 17:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]

There's a closed pull request on the void-packages repository

New package: python3-curio-1.4
https://github.com/void-linux/void-packages/pull/28419

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

### Reason

#28272 keeps getting stuck on CI so I want to see if adding dependencies one by one would pass tests.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: python3-curio-1.4
  2021-02-02 22:49 [PR PATCH] New package: python3-curio-1.4 ar-jan
                   ` (5 preceding siblings ...)
  2021-02-08 17:40 ` [PR PATCH] [Closed]: " Chocimier
@ 2021-02-08 18:06 ` ar-jan
  2021-02-08 18:06 ` ar-jan
  2021-02-08 18:19 ` Chocimier
  8 siblings, 0 replies; 10+ messages in thread
From: ar-jan @ 2021-02-08 18:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

New comment by ar-jan on void-packages repository

https://github.com/void-linux/void-packages/pull/28419#issuecomment-775336386

Comment:
OK, will do.

I thought the new dependencies might have to be added in separate pull requests because there was no way to proceed with the the original #28272 and find out which specific package was at issue.

> To test things, send them to your own fork.
I wanted to see CI test results for individual packages because it seemed there were no other options to find out what was going on. Are CI tests possible on individual forks, or what do you mean by testing?

> Here, failure in CI is because container have some privileges that https://github.com/dabeaz/curio/blob/1.4/tests/test_network.py#L317 don't expect - please disable that one test with pytest -k.

Aha! Any way I could have discovered that? There were no errors or warnings.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: python3-curio-1.4
  2021-02-02 22:49 [PR PATCH] New package: python3-curio-1.4 ar-jan
                   ` (6 preceding siblings ...)
  2021-02-08 18:06 ` ar-jan
@ 2021-02-08 18:06 ` ar-jan
  2021-02-08 18:19 ` Chocimier
  8 siblings, 0 replies; 10+ messages in thread
From: ar-jan @ 2021-02-08 18:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

New comment by ar-jan on void-packages repository

https://github.com/void-linux/void-packages/pull/28419#issuecomment-775336386

Comment:
OK, will do.

I thought the new dependencies might have to be added in separate pull requests because there was no way to proceed with the the original #28272 and find out which specific package was at issue.

> To test things, send them to your own fork.

I wanted to see CI test results for individual packages because it seemed there were no other options to find out what was going on. Are CI tests possible on individual forks, or what do you mean by testing?

> Here, failure in CI is because container have some privileges that https://github.com/dabeaz/curio/blob/1.4/tests/test_network.py#L317 don't expect - please disable that one test with pytest -k.

Aha! Any way I could have discovered that? There were no errors or warnings.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: python3-curio-1.4
  2021-02-02 22:49 [PR PATCH] New package: python3-curio-1.4 ar-jan
                   ` (7 preceding siblings ...)
  2021-02-08 18:06 ` ar-jan
@ 2021-02-08 18:19 ` Chocimier
  8 siblings, 0 replies; 10+ messages in thread
From: Chocimier @ 2021-02-08 18:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/28419#issuecomment-775344986

Comment:
> Any way I could have discovered that?

When you are logged in, there is a box above comment box at this page. Click "Details" for given architecture, then browse logs. There is a convenient text form of logs under three-dots-menu - "View raw logs".

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-02-08 18:19 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-02 22:49 [PR PATCH] New package: python3-curio-1.4 ar-jan
2021-02-02 22:59 ` [PR PATCH] [Updated] " ar-jan
2021-02-08 14:26 ` ar-jan
2021-02-08 15:32 ` ar-jan
2021-02-08 15:40 ` ar-jan
2021-02-08 17:40 ` Chocimier
2021-02-08 17:40 ` [PR PATCH] [Closed]: " Chocimier
2021-02-08 18:06 ` ar-jan
2021-02-08 18:06 ` ar-jan
2021-02-08 18:19 ` Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).