Re: [PR PATCH] [Updated] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.

[ericonr <ericonr@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1961 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages hooks
https://github.com/void-linux/void-packages/pull/28277

[WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
Files under /usr/share can't be stripped at all, since they shouldn't be
ELFs (if they are ELFs, they are unlikely to be ELFs for the target and
suitable for being stripped / debugged).

Since some big data packages have a lot of files /usr/share, this can
considerably speed up the hook, for no change in the package output.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28277.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hooks-28277.patch --]
[-- Type: text/x-diff, Size: 1352 bytes --]

From 6d1e1e62231a6f6dafa19fbc1e81f2f3a39b95b7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 27 Jan 2021 20:39:28 -0300
Subject: [PATCH] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.

Files under /usr/share can't be stripped at all, since they shouldn't be
ELFs (if they are ELFs, they are unlikely to be ELFs for the target and
suitable for being stripped / debugged).

Since some big data packages have a lot of files /usr/share, this can
considerably speed up the hook, for no change in the package output.
---
 common/hooks/post-install/06-strip-and-debug-pkgs.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/common/hooks/post-install/06-strip-and-debug-pkgs.sh b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
index 52591c38b31..1c03c5b8130 100644
--- a/common/hooks/post-install/06-strip-and-debug-pkgs.sh
+++ b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
@@ -65,10 +65,10 @@ hook() {
 
 	STRIPCMD=/usr/bin/$STRIP
 
-	find ${PKGDESTDIR} -type f | while read f; do
-		if [[ $f =~ ^${PKGDESTDIR}/usr/lib/debug/ ]]; then
-			continue
-		fi
+	find ${PKGDESTDIR} \
+		\( -path ${PKGDESTDIR}/usr/share -o -path ${PKGDESTDIR}/usr/lib/debug \) -prune \
+		-false -o -type f |
+		while read f; do
 
 		fname=${f##*/}
 		for x in ${nostrip_files}; do