Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] [WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
Date: Thu, 28 Jan 2021 00:49:25 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28277@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1956 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages hooks
https://github.com/void-linux/void-packages/pull/28277

[WIP] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.
Files under /usr/share can't be stripped at all, since they shouldn't be
ELFs (if they are ELFs, they are unlikely to be ELFs for the target and
suitable for being stripped / debugged).

Since some big data packages have a lot of files /usr/share, this can
considerably speed up the hook, for no change in the package output.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28277.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hooks-28277.patch --]
[-- Type: text/x-diff, Size: 1331 bytes --]

From e42a69de990e9cc069a5b71b97f0fb4b07e14b79 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 27 Jan 2021 20:39:28 -0300
Subject: [PATCH] hooks/post-install: speed up 06-strip-and-debug-pkgs.sh.

Files under /usr/share can't be stripped at all, since they shouldn't be
ELFs (if they are ELFs, they are unlikely to be ELFs for the target and
suitable for being stripped / debugged).

Since some big data packages have a lot of files /usr/share, this can
considerably speed up the hook, for no change in the package output.
---
 common/hooks/post-install/06-strip-and-debug-pkgs.sh | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/common/hooks/post-install/06-strip-and-debug-pkgs.sh b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
index b59dde5ab3c..51cfe87df99 100644
--- a/common/hooks/post-install/06-strip-and-debug-pkgs.sh
+++ b/common/hooks/post-install/06-strip-and-debug-pkgs.sh
@@ -65,11 +65,7 @@ hook() {
 
 	STRIPCMD=/usr/bin/$STRIP
 
-	find ${PKGDESTDIR} -type f | while read f; do
-		if [[ $f =~ ^${PKGDESTDIR}/usr/lib/debug/ ]]; then
-			continue
-		fi
-
+	find ${PKGDESTDIR} -prune ${PKGDESTDIR}/usr/share/ -prune ${PKGDESTDIR}/usr/lib/debug/ -type f | while read f; do
 		if [[ $(file -b "$f") =~ "no machine" ]]; then
 			continue
 		fi

             reply	other threads:[~2021-01-27 23:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 23:49 ericonr [this message]
2021-01-28  0:00 ` [PR PATCH] [Updated] " ericonr
2021-01-28  0:01 ` ericonr
2021-01-28  0:07 ` [PR REVIEW] " sgn
2021-01-28  0:11 ` ericonr
2021-01-28  0:12 ` ericonr
2021-01-28  0:29 ` sgn
2021-01-28  1:02 ` ericonr
2021-01-28  3:34 ` ericonr
2021-01-28  3:34 ` ericonr
2021-02-09  2:30 ` [PR PATCH] [Updated] " ericonr
2021-02-09  2:30 ` [PR REVIEW] " ericonr
2021-02-09  2:55 ` [PR PATCH] [Updated] " ericonr
2022-05-02  2:16 ` github-actions
2022-05-17  2:14 ` [PR PATCH] [Closed]: " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-28277@inbox.vuxu.org \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).