[PR PATCH] libtorrent: don't depend on libcppunit in the resulting package.

[PR PATCH] libtorrent: don't depend on libcppunit in the resulting package.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages libto
https://github.com/void-linux/void-packages/pull/28602

libtorrent: don't depend on libcppunit in the resulting package.
Probably some rebel linker options screwing things up and leaving
libcppunit as a required library in libtorrent. This isn't a proper fix,
because the final library doesn't use libcppunit symbols and
-Wl,--as-needed in LDFLAGS should have caught it.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28602.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libto-28602.patch --]
[-- Type: text/x-diff, Size: 1414 bytes --]

From a970c0925e5443b3aa5c1b9a2fdc972c0ec199f1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Tue, 9 Feb 2021 00:21:43 -0300
Subject: [PATCH] libtorrent: don't depend on libcppunit in the resulting
 package.

Probably some rebel linker options screwing things up and leaving
libcppunit as a required library in libtorrent. This isn't a proper fix,
because the final library doesn't use libcppunit symbols and
-Wl,--as-needed in LDFLAGS should have caught it.
---
 srcpkgs/libtorrent/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/libtorrent/template b/srcpkgs/libtorrent/template
index 92da1d727aa..5c7d4e74e8c 100644
--- a/srcpkgs/libtorrent/template
+++ b/srcpkgs/libtorrent/template
@@ -1,12 +1,14 @@
 # Template file for 'libtorrent'
 pkgname=libtorrent
 version=0.13.8
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="--enable-static --disable-debug --without-kqueue
  --enable-aligned --with-posix-fallocate"
 hostmakedepends="automake libtool pkg-config"
-makedepends="libcppunit-devel libressl-devel zlib-devel"
+makedepends="libressl-devel zlib-devel"
+# XXX: if built with XBPS_CHECK_PKGS, final binary will be dyn linked against libcppunit
+checkdepends="libcppunit-devel"
 short_desc="BitTorrent library written in C++"
 maintainer="Nathan Owens <ndowens04@gmail.com>"
 license="GPL-2.0-or-later"

Re: [PR PATCH] [Updated] libtorrent: don't depend on libcppunit in the resulting package.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1885 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages libto
https://github.com/void-linux/void-packages/pull/28602

libtorrent: don't depend on libcppunit in the resulting package.
Probably some rebel linker options screwing things up and leaving
libcppunit as a required library in libtorrent. This isn't a proper fix,
because the final library doesn't use libcppunit symbols and
-Wl,--as-needed in LDFLAGS should have caught it.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28602.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libto-28602.patch --]
[-- Type: text/x-diff, Size: 1807 bytes --]

From 9f76a6e67b9ec586f4c1b5e061a56bbca53bdaee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Tue, 9 Feb 2021 00:21:43 -0300
Subject: [PATCH] libtorrent: don't depend on libcppunit in the resulting
 package.

Probably some rebel linker options screwing things up and leaving
libcppunit as a required library in libtorrent. This isn't a proper fix,
because the final library doesn't use libcppunit symbols and
-Wl,--as-needed in LDFLAGS should have caught it.
---
 srcpkgs/libtorrent/template | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/libtorrent/template b/srcpkgs/libtorrent/template
index 92da1d727aa..fe2e4d73c21 100644
--- a/srcpkgs/libtorrent/template
+++ b/srcpkgs/libtorrent/template
@@ -1,17 +1,19 @@
 # Template file for 'libtorrent'
 pkgname=libtorrent
 version=0.13.8
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="--enable-static --disable-debug --without-kqueue
  --enable-aligned --with-posix-fallocate"
 hostmakedepends="automake libtool pkg-config"
-makedepends="libcppunit-devel libressl-devel zlib-devel"
+makedepends="libressl-devel zlib-devel"
+# XXX: if built with XBPS_CHECK_PKGS, final binary will be dyn linked against libcppunit
+checkdepends="libcppunit-devel"
 short_desc="BitTorrent library written in C++"
 maintainer="Nathan Owens <ndowens04@gmail.com>"
 license="GPL-2.0-or-later"
-homepage="https://github.com/rakshasa/${pkgname}"
-distfiles="https://github.com/rakshasa/${pkgname}/archive/v${version}.tar.gz"
+homepage="https://github.com/rakshasa/libtorrent"
+distfiles="https://github.com/rakshasa/libtorrent/archive/v${version}.tar.gz"
 checksum=0f6c2e7ffd3a1723ab47fdac785ec40f85c0a5b5a42c1d002272205b988be722
 
 # https://github.com/rakshasa/rtorrent/issues/156

Re: [PR PATCH] [Merged]: libtorrent: don't depend on libcppunit in the resulting package.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]

There's a merged pull request on the void-packages repository

libtorrent: don't depend on libcppunit in the resulting package.
https://github.com/void-linux/void-packages/pull/28602

Description:
Probably some rebel linker options screwing things up and leaving
libcppunit as a required library in libtorrent. This isn't a proper fix,
because the final library doesn't use libcppunit symbols and
-Wl,--as-needed in LDFLAGS should have caught it.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->