Re: New package: xdg-desktop-portal-wlr-0.1.0

Re: New package: xdg-desktop-portal-wlr-0.1.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-674470408

Comment:
@sgn I don't do desktop sharing, so I can't help much here.

I'm not sure this program is useful on a Void system, since we don't have a patched Firefox ( #23291 ) and I don't think our chromium is built against pipewire (which is required according to https://github.com/emersion/xdg-desktop-portal-wlr/wiki/Screencast-Compatibility). I believe we would need to accept the firefox patches in order for this package to make sense.

Re: New package: xdg-desktop-portal-wlr-0.1.0

[sgn]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-674470766

Comment:
Thanks, let's keep this open now.

Re: [PR REVIEW] New package: xdg-desktop-portal-wlr-0.1.0

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#discussion_r517022316

Comment:
`distfiles="https://github.com/emersion/${pkgname}/archive/v${version}.tar.gz"`

Re: [PR REVIEW] New package: xdg-desktop-portal-wlr-0.1.0

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New review comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#discussion_r517022299

Comment:
The absence of `systemd` is autodetected in `meson.build`, so this line is redundant IMHO.

Re: [PR REVIEW] New package: xdg-desktop-portal-wlr-0.1.0

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#discussion_r517524631

Comment:
Please don't. Using variables (besides of $version, that is necessity) in url makes it harder to copy from template and use, and leaks to other data sets (search for $ in https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt ).
Also $pkgname is best when used as *package name*, ie. where it would be still used, if preferred pkgname was taken/forbidden. 

Re: [PR REVIEW] New package: xdg-desktop-portal-wlr-0.1.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#discussion_r517525903

Comment:
If you want to make the line smaller, `distfiles="${homepage}/archive/...` is valid

Re: [PR REVIEW] New package: xdg-desktop-portal-wlr-0.1.0

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#discussion_r517527146

Comment:
$homepage have same downside of obfuscating real url.

Re: [PR REVIEW] New package: xdg-desktop-portal-wlr-0.1.0

[concatime]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New review comment by concatime on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#discussion_r519896110

Comment:
`distfiles="https://github.com/emersion/xdg-desktop-portal-wlr/archive/v${version}.tar.gz"` would be enough.

Re: [PR PATCH] [Updated] New package: xdg-desktop-portal-wlr-0.1.0

[absrd]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

There is an updated pull request by absrd against master on the void-packages repository

https://github.com/absrd/void-packages xdg-desktop-portal-wlr
https://github.com/void-linux/void-packages/pull/23296

New package: xdg-desktop-portal-wlr-0.1.0
Adds screensharing for wayland

A patch file from https://github.com/void-linux/void-packages/pull/23296.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xdg-desktop-portal-wlr-23296.patch --]
[-- Type: text/x-diff, Size: 1242 bytes --]

From 2640287901147464ebedce473b531a7508851623 Mon Sep 17 00:00:00 2001
From: Felix Kleinschmidt <fk@bsrd.io>
Date: Mon, 29 Jun 2020 07:41:57 +0200
Subject: [PATCH] New package: xdg-desktop-portal-wlr-0.1.0

---
 srcpkgs/xdg-desktop-portal-wlr/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/xdg-desktop-portal-wlr/template

diff --git a/srcpkgs/xdg-desktop-portal-wlr/template b/srcpkgs/xdg-desktop-portal-wlr/template
new file mode 100644
index 00000000000..d3095f773ea
--- /dev/null
+++ b/srcpkgs/xdg-desktop-portal-wlr/template
@@ -0,0 +1,17 @@
+# Template file for 'xdg-desktop-portal-wlr'
+pkgname=xdg-desktop-portal-wlr
+version=0.1.0
+revision=1
+build_style=meson
+hostmakedepends="pkg-config wayland-devel"
+makedepends="elogind-devel pipewire-devel wayland-devel wayland-protocols"
+short_desc="Backend implementation for xdg-desktop-portal using wlroots"
+maintainer="Felix Kleinschmidt <fk@bsrd.io>"
+license="MIT"
+homepage="https://github.com/emersion/xdg-desktop-portal-wlr"
+distfiles="https://github.com/emersion/xdg-desktop-portal-wlr/archive/v$version.tar.gz"
+checksum=69d67c236f4bd498323af509d44ec4a1b826da337f7ee64bbfbdb98bfda8e541
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: xdg-desktop-portal-wlr-0.1.0

[concatime]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by concatime on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-732545961

Comment:
Braces please. `v${version}.tar.gz"` instead of `v$version.tar.gz"`.

Re: [PR PATCH] [Updated] New package: xdg-desktop-portal-wlr-0.1.0

[absrd]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

There is an updated pull request by absrd against master on the void-packages repository

https://github.com/absrd/void-packages xdg-desktop-portal-wlr
https://github.com/void-linux/void-packages/pull/23296

New package: xdg-desktop-portal-wlr-0.1.0
Adds screensharing for wayland

A patch file from https://github.com/void-linux/void-packages/pull/23296.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xdg-desktop-portal-wlr-23296.patch --]
[-- Type: text/x-diff, Size: 1244 bytes --]

From 665a0125dc0ab9a93045976b42668f573c8e1b1b Mon Sep 17 00:00:00 2001
From: Felix Kleinschmidt <fk@bsrd.io>
Date: Mon, 29 Jun 2020 07:41:57 +0200
Subject: [PATCH] New package: xdg-desktop-portal-wlr-0.1.0

---
 srcpkgs/xdg-desktop-portal-wlr/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/xdg-desktop-portal-wlr/template

diff --git a/srcpkgs/xdg-desktop-portal-wlr/template b/srcpkgs/xdg-desktop-portal-wlr/template
new file mode 100644
index 00000000000..6c3bf16da9c
--- /dev/null
+++ b/srcpkgs/xdg-desktop-portal-wlr/template
@@ -0,0 +1,17 @@
+# Template file for 'xdg-desktop-portal-wlr'
+pkgname=xdg-desktop-portal-wlr
+version=0.1.0
+revision=1
+build_style=meson
+hostmakedepends="pkg-config wayland-devel"
+makedepends="elogind-devel pipewire-devel wayland-devel wayland-protocols"
+short_desc="Backend implementation for xdg-desktop-portal using wlroots"
+maintainer="Felix Kleinschmidt <fk@bsrd.io>"
+license="MIT"
+homepage="https://github.com/emersion/xdg-desktop-portal-wlr"
+distfiles="https://github.com/emersion/xdg-desktop-portal-wlr/archive/v${version}.tar.gz"
+checksum=69d67c236f4bd498323af509d44ec4a1b826da337f7ee64bbfbdb98bfda8e541
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: xdg-desktop-portal-wlr-0.1.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-744074883

Comment:
Now that chromium at least has pipewire support, we can try and merge this.

Re: New package: xdg-desktop-portal-wlr-0.1.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-744074994

Comment:
https://github.com/emersion/xdg-desktop-portal-wlr/releases says it's a pre-release, though :P  

Re: New package: xdg-desktop-portal-wlr-0.1.0

[Logarithmus]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-744075137

Comment:
> https://github.com/emersion/xdg-desktop-portal-wlr/releases says it's a pre-release, though :P

But it works like a charm so far with Sway

Re: New package: xdg-desktop-portal-wlr-0.1.0

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-758512752

Comment:
This works with current firefox from the repos

Re: New package: xdg-desktop-portal-wlr-0.1.0

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-758512752

Comment:
This works with current firefox from the repos (with XDG_CURRENT_DESKTOP=sway in the env)

Re: New package: xdg-desktop-portal-wlr-0.1.0

[gspe]

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

New comment by gspe on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-768119254

Comment:
I've tested with firefox and it works, but the template missing to specify dependency:
`depends="xdg-desktop-portal"`
without `xdg-desktop-portal` it doesn't woks and is useless.

Another thing that maybe it's nice to have is to add `configure_args="-Dsystemd=disabled"`
meson check for `systemd` and set it disabled if is not found but we can specify directly in configure

Re: [PR PATCH] [Updated] [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[absrd]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

There is an updated pull request by absrd against master on the void-packages repository

https://github.com/absrd/void-packages xdg-desktop-portal-wlr
https://github.com/void-linux/void-packages/pull/23296

[NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0
Adds screensharing for wayland

A patch file from https://github.com/void-linux/void-packages/pull/23296.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xdg-desktop-portal-wlr-23296.patch --]
[-- Type: text/x-diff, Size: 1275 bytes --]

From 8e4a52c5ea000feef5d420c20a585d485112c3db Mon Sep 17 00:00:00 2001
From: Felix Kleinschmidt <fk@bsrd.io>
Date: Mon, 29 Jun 2020 07:41:57 +0200
Subject: [PATCH] New package: xdg-desktop-portal-wlr-0.1.0

---
 srcpkgs/xdg-desktop-portal-wlr/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/xdg-desktop-portal-wlr/template

diff --git a/srcpkgs/xdg-desktop-portal-wlr/template b/srcpkgs/xdg-desktop-portal-wlr/template
new file mode 100644
index 00000000000..934885de63e
--- /dev/null
+++ b/srcpkgs/xdg-desktop-portal-wlr/template
@@ -0,0 +1,18 @@
+# Template file for 'xdg-desktop-portal-wlr'
+pkgname=xdg-desktop-portal-wlr
+version=0.1.0
+revision=1
+build_style=meson
+hostmakedepends="pkg-config wayland-devel"
+makedepends="elogind-devel pipewire-devel wayland-devel wayland-protocols"
+depends="xdg-desktop-portal"
+short_desc="Backend implementation for xdg-desktop-portal using wlroots"
+maintainer="Felix Kleinschmidt <fk@bsrd.io>"
+license="MIT"
+homepage="https://github.com/emersion/xdg-desktop-portal-wlr"
+distfiles="https://github.com/emersion/xdg-desktop-portal-wlr/archive/v${version}.tar.gz"
+checksum=69d67c236f4bd498323af509d44ec4a1b826da337f7ee64bbfbdb98bfda8e541
+
+post_install() {
+	vlicense LICENSE
+}

Re: [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[absrd]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

New comment by absrd on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-772643233

Comment:
> I've tested with firefox and it works, but the template missing to specify dependency:
> `depends="xdg-desktop-portal"`
> without `xdg-desktop-portal` it doesn't woks and is useless.

Fixed



> Another thing that maybe it's nice to have is to add `configure_args="-Dsystemd=disabled"`
> meson check for `systemd` and set it disabled if is not found but we can specify directly in configure

https://github.com/void-linux/void-packages/pull/23296#discussion_r517022299

Re: [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-772649342

Comment:
Just having this installed makes it possible to get 20s delays when opening GTK applications. I'm not sure how best to solve it, since the recommended solution is a whole bunch of environment exporting and re-importing.

Re: [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-777704336

Comment:
@ericonr Have you encountered these delays yourself or are there reports of these delays somewhere else? I ended up creating a template for `xdg-desktop-portal-wlr` myself with some differences because I didn't know this PR existed, and after installing the package and replacing `xdg-desktop-portal-gtk` with it I haven't encountered any delays so far.

Re: [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-777753831

Comment:
>  Have you encountered these delays yourself or are there reports of these delays somewhere else?

Myself, with wayfire 0.7.0. Didn't happen with wayfire 0.6.0.

Re: [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-777807078

Comment:
Ah, I haven't upgraded to 0.7.0 yet, though I will be doing so tomorrow. I'll let you know if I encounter the same delays. As for the template, shouldn't it be sufficient to have `wayland-devel` in "makedepends" only as opposed to in both "hostmakedepends" and "makedepends"? Also, the arch PKGBUILD for this package lists `pipewire` as a dependency, should we consider adding it to the template?

Re: [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-777815218

Comment:
> As for the template, shouldn't it be sufficient to have wayland-devel in "makedepends" only as opposed to in both "hostmakedepends" and "makedepends"?

It's needed in host for wayland-scanner iirc.

> Also, the arch PKGBUILD for this package lists pipewire as a dependency, should we consider adding it to the template?

Probably? I don't use this myself, and I don't know if it can be used in other situations.

Re: [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-778304086

Comment:
> It's needed in host for wayland-scanner iirc.

Is that for the cross-builds? I was able to build it natively without putting it in host.

As for the delays, I'm currently using wayfire 0.7.0 and xdg-desktop-portal-wlr and I'm not experiencing any delays. Would you mind giving me an example of a program that is experiencing delays to see if I can replicate it?

Re: [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-778320813

Comment:
Yes, for cross builds. What happens in native builds is that `makedepends` and `hostmakedepends` are installed the same way. In cross builds, `makedepends` will install the executable for the target, which we can't run locally ourselves.

> As for the delays, I'm currently using wayfire 0.7.0 and xdg-desktop-portal-wlr and I'm not experiencing any delays. Would you mind giving me an example of a program that is experiencing delays to see if I can replicate it?

Anything GTK, really. How do you start your session and the portal?

Re: [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-778366589

Comment:
> and replacing `xdg-desktop-portal-gtk` with it

^ maybe that's why

Re: [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-778390066

Comment:
I've only tried this template for a while. No delay (on `sway` and `wayfire`) with both `xdg-desktop-portal-gtk` and this installed.
I don't do screen sharing, but flatpak apps I use seems to work fine

Re: [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 2086 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-778544368

Comment:
> How do you start your session and the portal?

I start wayfire by running a script manually in a TTY after I log in. It sets some environment variables; you can see it in the collapsed section below.

<details>
<summary>startwayfire.sh</summary>

```shell
#!/bin/bash

# Functionality variables
# if $XDG_DATA_DIRS is not set, set it to the spec recommended value
[ -z "$XDG_DATA_DIRS" ] && export XDG_DATA_DIRS="/usr/local/share:/usr/share"
# path for wf-config and wlroots
export LD_LIBRARY_PATH=/usr/lib/wayfire
# path is needed for wf-shell clients
PATH=$PATH
# path to find .desktop files like wcm
export XDG_DATA_DIRS=$XDG_DATA_DIRS
# maybe necessary?
export XDG_SESSION_TYPE=wayland
export XDG_CURRENT_DESKTOP=sway

# Display scaling
export GDK_DPI_SCALE=1.4
export QT_SCALE_FACTOR=1.4
export QT_FONT_DPI=96
export XCURSOR_SIZE=36
export XCURSOR_THEME=capitaine-cursors

# Theming
export QT_QPA_PLATFORM=wayland-egl
export QT_QPA_PLATFORMTHEME=qt5ct
export SDL_VIDEODRIVER=wayland

# Application variables
export MOZ_ENABLE_WAYLAND=1

# Logging
if [ -d "$XDG_DATA_HOME" ]; then
    DEFAULT_LOG_DIR=$XDG_DATA_HOME/wayfire
else
    DEFAULT_LOG_DIR=$HOME/.local/share/wayfire
fi
mkdir -p $DEFAULT_LOG_DIR

# Running
if [ $? != 0 ]; then
    echo "Could not create log directory $DEFAULT_LOG_DIR"
    echo "Using stdout as log"
    #wayfire
    #exec dbus-launch --exit-with-session wayfire
    exec dbus-run-session /usr/bin/wayfire
else
    LOG_FILE=$DEFAULT_LOG_DIR/wayfire.log
    if [ -f $LOG_FILE ]; then
        cp $LOG_FILE $LOG_FILE.old
    fi
    echo "Using log file: $LOG_FILE"
    #wayfire &> $LOG_FILE
    exec dbus-run-session /usr/bin/wayfire &> $LOG_FILE
fi
```

</details>

As for the portal, I start it through wayfire's autostart plugin. I have the following line in the `[autostart]` section of `wayfire.ini`: `portal = /usr/libexec/xdg-desktop-portal`

Re: [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[travankor]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-779107620

Comment:
0.2.0 is released

Re: [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/23296#issuecomment-779421807

Comment:
I'm currently testing v0.2.0 and it's working well for me, no noticeable changes from v0.1.0.

Re: [PR PATCH] [Closed]: [NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

There's a closed pull request on the void-packages repository

[NOMERGE] New package: xdg-desktop-portal-wlr-0.1.0
https://github.com/void-linux/void-packages/pull/23296

Description:
Adds screensharing for wayland