[PR PATCH] tlsdate: remove package

[PR PATCH] tlsdate: remove package

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]

There is a new pull request by Johnnynator against master on the void-packages repository

https://github.com/Johnnynator/void-packages tlsdate
https://github.com/void-linux/void-packages/pull/28741

tlsdate: remove package
<!-- Mark items with [x] where applicable -->

#### General
@leahneukirchen the package is incompatible with the OpenSSL 1.1 API, okay to remove?

#### Have the results of the proposed changes been tested?
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28741.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tlsdate-28741.patch --]
[-- Type: text/x-diff, Size: 7389 bytes --]

From 8eae554e06a941fa16cec44e3787120c0a43498e Mon Sep 17 00:00:00 2001
From: John <me@johnnynator.dev>
Date: Sun, 14 Feb 2021 00:22:11 +0100
Subject: [PATCH] tlsdate: remove package

---
 srcpkgs/removed-packages/template             |  1 +
 srcpkgs/tlsdate/files/tlsdated/run            |  2 -
 .../tlsdate/patches/libressl-no-sslv3.patch   | 57 -------------------
 .../tlsdate/patches/libressl-sslstate.patch   | 11 ----
 srcpkgs/tlsdate/patches/sandbox.patch         | 27 ---------
 srcpkgs/tlsdate/template                      | 34 -----------
 6 files changed, 1 insertion(+), 131 deletions(-)
 delete mode 100755 srcpkgs/tlsdate/files/tlsdated/run
 delete mode 100644 srcpkgs/tlsdate/patches/libressl-no-sslv3.patch
 delete mode 100644 srcpkgs/tlsdate/patches/libressl-sslstate.patch
 delete mode 100644 srcpkgs/tlsdate/patches/sandbox.patch
 delete mode 100644 srcpkgs/tlsdate/template

diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 1c869a6950f..b97af966128 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -217,6 +217,7 @@ replaces="
  spacefm-ng<=1.0.6_3
  sqlite-replication<=3.32.3_2
  tagainijisho<=1.0.3_1
+ tlsdate<=0.0.13_16
  ttyload-git<=20141117_4
  tuxc<=1.1_3
  urlmatch-git<=20141116_2
diff --git a/srcpkgs/tlsdate/files/tlsdated/run b/srcpkgs/tlsdate/files/tlsdated/run
deleted file mode 100755
index 5ef7326d15d..00000000000
--- a/srcpkgs/tlsdate/files/tlsdated/run
+++ /dev/null
@@ -1,2 +0,0 @@
-#!/bin/sh
-exec tlsdated 2>/dev/null
diff --git a/srcpkgs/tlsdate/patches/libressl-no-sslv3.patch b/srcpkgs/tlsdate/patches/libressl-no-sslv3.patch
deleted file mode 100644
index 3865f71c2cb..00000000000
--- a/srcpkgs/tlsdate/patches/libressl-no-sslv3.patch
+++ /dev/null
@@ -1,57 +0,0 @@
---- src/tlsdate.c.orig	2016-03-30 23:41:39.121031885 +0200
-+++ src/tlsdate.c	2016-03-30 23:41:49.442032351 +0200
-@@ -88,7 +88,7 @@
-            " [-n|--dont-set-clock]\n"
-            " [-H|--host] [hostname|ip]\n"
-            " [-p|--port] [port number]\n"
--           " [-P|--protocol] [sslv23|sslv3|tlsv1]\n"
-+           " [-P|--protocol] [sslv23|tlsv1]\n"
-            " [-C|--certcontainer] [dirname|filename]\n"
-            " [-v|--verbose]\n"
-            " [-V|--showtime] [human|raw]\n"
---- man/tlsdate.1.orig	2016-03-30 23:42:18.100033647 +0200
-+++ man/tlsdate.1	2016-03-30 23:42:35.659034441 +0200
-@@ -5,7 +5,7 @@
- .SH NAME
- tlsdate \- secure parasitic rdate replacement
- .SH SYNOPSIS
--.B tlsdate [\-hnvVstlw] [\-H [hostname]] [\-p [port]] [\-P [sslv23|sslv3|tlsv1]] \
-+.B tlsdate [\-hnvVstlw] [\-H [hostname]] [\-p [port]] [\-P [sslv23|tlsv1]] \
- [\-\-certdir [dirname]] [\-x [\-\-proxy] proxy\-type://proxyhost:proxyport]
- .SH DESCRIPTION
- .B tlsdate
-@@ -30,7 +30,7 @@
- Do not set the system clock to the time of the remote server
- .IP "\-p | \-\-port [port]"
- Set remote port (default: '443')
--.IP "\-P | \-\-protocol [sslv23|sslv3|tlsv1]"
-+.IP "\-P | \-\-protocol [sslv23|tlsv1]"
- Set protocol to use when communicating with server (default: 'tlsv1')
- .IP "\-C | \-\-certdir [dirname]"
- Set the local directory where certificates are located
---- src/tlsdate-helper-plan9.c.orig	2016-03-30 23:43:12.577036110 +0200
-+++ src/tlsdate-helper-plan9.c	2016-03-30 23:43:32.403037006 +0200
-@@ -978,10 +978,6 @@
-   {
-     verb ("V: using SSLv23_client_method()\n");
-     ctx = SSL_CTX_new(SSLv23_client_method());
--  } else if (0 == strcmp("sslv3", protocol))
--  {
--    verb ("V: using SSLv3_client_method()\n");
--    ctx = SSL_CTX_new(SSLv3_client_method());
-   } else if (0 == strcmp("tlsv1", protocol))
-   {
-     verb ("V: using TLSv1_client_method()\n");
---- src/tlsdate-helper.c.orig	2016-03-30 23:33:02.056008510 +0200
-+++ src/tlsdate-helper.c	2016-03-30 23:34:46.400013227 +0200
-@@ -1133,10 +1133,6 @@
-   {
-     verb ("V: using SSLv23_client_method()");
-     ctx = SSL_CTX_new(SSLv23_client_method());
--  } else if (0 == strcmp("sslv3", protocol))
--  {
--    verb ("V: using SSLv3_client_method()");
--    ctx = SSL_CTX_new(SSLv3_client_method());
-   } else if (0 == strcmp("tlsv1", protocol))
-   {
-     verb ("V: using TLSv1_client_method()");
diff --git a/srcpkgs/tlsdate/patches/libressl-sslstate.patch b/srcpkgs/tlsdate/patches/libressl-sslstate.patch
deleted file mode 100644
index 5207753222b..00000000000
--- a/srcpkgs/tlsdate/patches/libressl-sslstate.patch
+++ /dev/null
@@ -1,11 +0,0 @@
---- src/tlsdate-helper.c.orig
-+++ src/tlsdate-helper.c
-@@ -374,7 +374,7 @@
- openssl_time_callback (const SSL* ssl, int where, int ret)
- {
-   if (where == SSL_CB_CONNECT_LOOP &&
--      (ssl->state == SSL3_ST_CR_SRVR_HELLO_A || ssl->state == SSL3_ST_CR_SRVR_HELLO_B))
-+      (SSL_state(ssl) == SSL3_ST_CR_SRVR_HELLO_A || SSL_state(ssl) == SSL3_ST_CR_SRVR_HELLO_B))
-   {
-     // XXX TODO: If we want to trust the remote system for time,
-     // can we just read that time out of the remote system and if the
diff --git a/srcpkgs/tlsdate/patches/sandbox.patch b/srcpkgs/tlsdate/patches/sandbox.patch
deleted file mode 100644
index f5afd54f28d..00000000000
--- a/srcpkgs/tlsdate/patches/sandbox.patch
+++ /dev/null
@@ -1,27 +0,0 @@
---- src/seccomp.c.orig	2018-12-20 16:56:30.070932156 +0100
-+++ src/seccomp.c	2018-12-20 16:57:19.849670660 +0100
-@@ -43,6 +43,14 @@
- #  define SECCOMP_AUDIT_ARCH AUDIT_ARCH_I386
- #elif defined(__x86_64__)
- #  define SECCOMP_AUDIT_ARCH AUDIT_ARCH_X86_64
-+#elif defined(__aarch64__)
-+#  define SECCOMP_AUDIT_ARCH AUDIT_ARCH_AARCH64
-+#elif defined(__powerpc64__) && defined(__LITTLE_ENDIAN__)
-+#  define SECCOMP_AUDIT_ARCH AUDIT_ARCH_PPC64LE
-+#elif defined(__powerpc64__)
-+#  define SECCOMP_AUDIT_ARCH AUDIT_ARCH_PPC64
-+#elif defined(__powerpc__)
-+#  define SECCOMP_AUDIT_ARCH AUDIT_ARCH_PPC
- #elif defined(__arm__)
- # ifndef EM_ARM
- #   define EM_ARM 40
-@@ -87,7 +89,9 @@
-     SC_ALLOW (exit_group),
-     SC_ALLOW (exit),
- 
-+#ifdef __NR_open
-     SC_DENY (open, EINVAL),
-+#endif
-     SC_DENY (fcntl, EINVAL),
-     SC_DENY (fstat, EINVAL),
- #ifdef __NR_mmap
diff --git a/srcpkgs/tlsdate/template b/srcpkgs/tlsdate/template
deleted file mode 100644
index ccdbef1a5d7..00000000000
--- a/srcpkgs/tlsdate/template
+++ /dev/null
@@ -1,34 +0,0 @@
-# Template file for 'tlsdate'
-pkgname=tlsdate
-version=0.0.13
-revision=15
-wrksrc="${pkgname}-${pkgname}-${version}"
-build_style=gnu-configure
-configure_args="--with-polarssl=no ac_cv_func_clock_gettime=yes"
-conf_files="/etc/tlsdate/tlsdated.conf"
-make_dirs="/var/cache/tlsdated 0755 root root"
-hostmakedepends="automake pkg-config libtool"
-makedepends="libressl-devel dbus-devel libevent-devel"
-depends="ca-certificates"
-short_desc="Secure parasitic rdate replacement using HTTPS"
-maintainer="Leah Neukirchen <leah@vuxu.org>"
-license="BSD-3-Clause"
-homepage="https://github.com/ioerror/tlsdate"
-distfiles="https://github.com/ioerror/tlsdate/archive/${pkgname}-${version}.tar.gz"
-checksum=90efdff87504b5159cb6a3eefa9ddd43723c073d49c4b3febba9e48fc1292bf9
-
-CFLAGS="-fcommon"
-
-pre_configure() {
-	# use system certs
-	sed -i Makefile.am \
-		-e 's|/tlsdate/ca-roots/tlsdate-ca-roots.conf|/ssl/certs/ca-certificates.crt|'
-	sh ./autogen.sh
-}
-
-post_install() {
-	vlicense LICENSE
-	rm ${DESTDIR}/etc/tlsdate/ca-roots/tlsdate-ca-roots.conf
-	rm ${DESTDIR}/usr/share/doc/${pkgname}/{TODO,LICENSE}
-	vsv tlsdated
-}

Re: tlsdate: remove package

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/28741#issuecomment-778767895

Comment:
Fine by me, it didn't work with many servers anyway.

Re: [PR PATCH] [Merged]: tlsdate: remove package

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

There's a merged pull request on the void-packages repository

tlsdate: remove package
https://github.com/void-linux/void-packages/pull/28741

Description:
<!-- Mark items with [x] where applicable -->

#### General
@leahneukirchen the package is incompatible with the OpenSSL 1.1 API, okay to remove?

#### Have the results of the proposed changes been tested?
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->