[PR PATCH] Add glib-devel to audacious-plugins build deps

[PR PATCH] Add glib-devel to audacious-plugins build deps

[vpzomtrrfrt]

[-- Attachment #1: Type: text/plain, Size: 1641 bytes --]

There is a new pull request by vpzomtrrfrt against master on the void-packages repository

https://github.com/vpzomtrrfrt/void-packages audacious-plugins-glib
https://github.com/void-linux/void-packages/pull/28768

Add glib-devel to audacious-plugins build deps
This seems to be required to build the mpris2 plugin

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28768.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-audacious-plugins-glib-28768.patch --]
[-- Type: text/x-diff, Size: 1312 bytes --]

From 4bb7cb39b38eaa2186929921a7ca7b06978cba9e Mon Sep 17 00:00:00 2001
From: Colin Reeder <colin@vpzom.click>
Date: Sun, 14 Feb 2021 15:26:05 -0700
Subject: [PATCH] Add glib-devel to audacious-plugins build deps

This seems to be required to build the mpris2 plugin
---
 srcpkgs/audacious-plugins/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/audacious-plugins/template b/srcpkgs/audacious-plugins/template
index 9cc976b2f23..2ecd2ad8767 100644
--- a/srcpkgs/audacious-plugins/template
+++ b/srcpkgs/audacious-plugins/template
@@ -2,7 +2,7 @@
 #Keep in sync with audacious!
 pkgname=audacious-plugins
 version=4.1
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="$(vopt_enable gtk) $(vopt_enable qt)"
 hostmakedepends="gettext pkg-config"
@@ -11,6 +11,7 @@ makedepends="audacious-devel alsa-lib-devel pulseaudio-devel jack-devel
  libmodplug-devel fluidsynth-devel libcdio-paranoia-devel wavpack-devel libnotify-devel
  libcurl-devel libmtp-devel neon-devel libmms-devel libxml2-devel
  libbs2b-devel libsoxr-devel libsidplayfp-devel libcue-devel libopenmpt-devel
+ glib-devel
  $(vopt_if gtk gtk+-devel) $(vopt_if qt 'qt5-devel qt5-multimedia-devel')"
 short_desc="Plugins for the Audacious media player"
 maintainer="Orphaned <orphan@voidlinux.org>"

Re: [PR PATCH] [Updated] audacious-plugins: Add glib-devel to build deps

[vpzomtrrfrt]

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

There is an updated pull request by vpzomtrrfrt against master on the void-packages repository

https://github.com/vpzomtrrfrt/void-packages audacious-plugins-glib
https://github.com/void-linux/void-packages/pull/28768

audacious-plugins: Add glib-devel to build deps
This seems to be required to build the mpris2 plugin

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28768.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-audacious-plugins-glib-28768.patch --]
[-- Type: text/x-diff, Size: 1313 bytes --]

From 097e46dad3af813ade3f76dfee83b15d08d5e1d6 Mon Sep 17 00:00:00 2001
From: Colin Reeder <colin@vpzom.click>
Date: Sun, 14 Feb 2021 15:26:05 -0700
Subject: [PATCH] audacious-plugins: Add glib-devel to build deps

This seems to be required to build the mpris2 plugin
---
 srcpkgs/audacious-plugins/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/audacious-plugins/template b/srcpkgs/audacious-plugins/template
index 9cc976b2f23..2ecd2ad8767 100644
--- a/srcpkgs/audacious-plugins/template
+++ b/srcpkgs/audacious-plugins/template
@@ -2,7 +2,7 @@
 #Keep in sync with audacious!
 pkgname=audacious-plugins
 version=4.1
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="$(vopt_enable gtk) $(vopt_enable qt)"
 hostmakedepends="gettext pkg-config"
@@ -11,6 +11,7 @@ makedepends="audacious-devel alsa-lib-devel pulseaudio-devel jack-devel
  libmodplug-devel fluidsynth-devel libcdio-paranoia-devel wavpack-devel libnotify-devel
  libcurl-devel libmtp-devel neon-devel libmms-devel libxml2-devel
  libbs2b-devel libsoxr-devel libsidplayfp-devel libcue-devel libopenmpt-devel
+ glib-devel
  $(vopt_if gtk gtk+-devel) $(vopt_if qt 'qt5-devel qt5-multimedia-devel')"
 short_desc="Plugins for the Audacious media player"
 maintainer="Orphaned <orphan@voidlinux.org>"

Re: audacious-plugins: Add glib-devel to build deps

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28768#issuecomment-778855851

Comment:
I'm fairly sure the previous build already detected this... The package even depends on `glib`. If you want to add it as an explicit dep, that's ok, but it doesn't need a revbump.

Re: audacious-plugins: Add glib-devel to build deps

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28768#issuecomment-778855897

Comment:
And from the old build:

```
2021-02-08T11:36:26.8224308Z checking for GLIB... yes
2021-02-08T11:36:26.8514961Z checking for GMODULE... yes
2021-02-08T11:36:26.8789392Z checking for GIO... yes
```

Re: [PR REVIEW] audacious-plugins: Add glib-devel to build deps

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28768#discussion_r575877946

Comment:
also please put it after libxml2, so it isn't alone in a single line.

Re: audacious-plugins: Add glib-devel to build deps

[vpzomtrrfrt]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New comment by vpzomtrrfrt on void-packages repository

https://github.com/void-linux/void-packages/pull/28768#issuecomment-778856059

Comment:
All I know is that the old package doesn't include mpris2.so and this one does

Re: audacious-plugins: Add glib-devel to build deps

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28768#issuecomment-778856315

Comment:
So you want to add `dbus-devel` :)

But adding `glib-devel dbus-devel` is harmless, and makes it clear that we want both.

Re: [PR PATCH] [Updated] audacious-plugins: Add glib-devel to build deps

[vpzomtrrfrt]

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

There is an updated pull request by vpzomtrrfrt against master on the void-packages repository

https://github.com/vpzomtrrfrt/void-packages audacious-plugins-glib
https://github.com/void-linux/void-packages/pull/28768

audacious-plugins: Add glib-devel to build deps
This seems to be required to build the mpris2 plugin

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28768.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-audacious-plugins-glib-28768.patch --]
[-- Type: text/x-diff, Size: 1400 bytes --]

From 94b2f70da47afb8272924db165baa96eea9e6cd0 Mon Sep 17 00:00:00 2001
From: Colin Reeder <colin@vpzom.click>
Date: Sun, 14 Feb 2021 15:26:05 -0700
Subject: [PATCH] audacious-plugins: Add glib-devel to build deps

This seems to be required to build the mpris2 plugin
---
 srcpkgs/audacious-plugins/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/audacious-plugins/template b/srcpkgs/audacious-plugins/template
index 9cc976b2f23..14037f75248 100644
--- a/srcpkgs/audacious-plugins/template
+++ b/srcpkgs/audacious-plugins/template
@@ -2,14 +2,14 @@
 #Keep in sync with audacious!
 pkgname=audacious-plugins
 version=4.1
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="$(vopt_enable gtk) $(vopt_enable qt)"
 hostmakedepends="gettext pkg-config"
 makedepends="audacious-devel alsa-lib-devel pulseaudio-devel jack-devel
  lame-devel libvorbis-devel libflac-devel mpg123-devel faad2-devel ffmpeg-devel
  libmodplug-devel fluidsynth-devel libcdio-paranoia-devel wavpack-devel libnotify-devel
- libcurl-devel libmtp-devel neon-devel libmms-devel libxml2-devel
+ libcurl-devel libmtp-devel neon-devel libmms-devel libxml2-devel glib-devel
  libbs2b-devel libsoxr-devel libsidplayfp-devel libcue-devel libopenmpt-devel
  $(vopt_if gtk gtk+-devel) $(vopt_if qt 'qt5-devel qt5-multimedia-devel')"
 short_desc="Plugins for the Audacious media player"

Re: audacious-plugins: Add glib-devel to build deps

[vpzomtrrfrt]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

New comment by vpzomtrrfrt on void-packages repository

https://github.com/void-linux/void-packages/pull/28768#issuecomment-778859375

Comment:
Moved location of change to existing line.

The check for whether to build this plugin appears to be based on the existence of `gdbus-codegen`, which is provided by glib-devel.

Re: audacious-plugins: Add glib-devel to build deps

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28768#issuecomment-778859687

Comment:
Hm, if it checks for a program to run, it needs to be in `hostmakedepends`...

Re: audacious-plugins: Add glib-devel to build deps

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28768#issuecomment-778859687

Comment:
Hm, if it checks for a program to run, it needs to be in `hostmakedepends`... (Because of the cross builds)

Re: audacious-plugins: Add glib-devel to build deps

[vpzomtrrfrt]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by vpzomtrrfrt on void-packages repository

https://github.com/void-linux/void-packages/pull/28768#issuecomment-778863845

Comment:
ah good point, it does appear to still be missing from crossbuilds

Re: [PR PATCH] [Updated] audacious-plugins: Add glib-devel to build deps

[vpzomtrrfrt]

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

There is an updated pull request by vpzomtrrfrt against master on the void-packages repository

https://github.com/vpzomtrrfrt/void-packages audacious-plugins-glib
https://github.com/void-linux/void-packages/pull/28768

audacious-plugins: Add glib-devel to build deps
This seems to be required to build the mpris2 plugin

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28768.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-audacious-plugins-glib-28768.patch --]
[-- Type: text/x-diff, Size: 1096 bytes --]

From 6e9cfbaaf68ae334694d79d51702da2beb651cea Mon Sep 17 00:00:00 2001
From: Colin Reeder <colin@vpzom.click>
Date: Sun, 14 Feb 2021 15:26:05 -0700
Subject: [PATCH] audacious-plugins: Add glib-devel to build deps

This seems to be required to build the mpris2 plugin
---
 srcpkgs/audacious-plugins/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/audacious-plugins/template b/srcpkgs/audacious-plugins/template
index 9cc976b2f23..84bcfd2113f 100644
--- a/srcpkgs/audacious-plugins/template
+++ b/srcpkgs/audacious-plugins/template
@@ -2,10 +2,10 @@
 #Keep in sync with audacious!
 pkgname=audacious-plugins
 version=4.1
-revision=2
+revision=3
 build_style=gnu-configure
 configure_args="$(vopt_enable gtk) $(vopt_enable qt)"
-hostmakedepends="gettext pkg-config"
+hostmakedepends="gettext pkg-config glib-devel"
 makedepends="audacious-devel alsa-lib-devel pulseaudio-devel jack-devel
  lame-devel libvorbis-devel libflac-devel mpg123-devel faad2-devel ffmpeg-devel
  libmodplug-devel fluidsynth-devel libcdio-paranoia-devel wavpack-devel libnotify-devel

Re: audacious-plugins: Add glib-devel to build deps

[vpzomtrrfrt]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by vpzomtrrfrt on void-packages repository

https://github.com/void-linux/void-packages/pull/28768#issuecomment-778865273

Comment:
moved to hostmakedepends

Re: [PR PATCH] [Merged]: audacious-plugins: Add glib-devel to build deps

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

There's a merged pull request on the void-packages repository

audacious-plugins: Add glib-devel to build deps
https://github.com/void-linux/void-packages/pull/28768

Description:
This seems to be required to build the mpris2 plugin

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->