[PR PATCH] environment/configure/gnu-configure-args.sh: do not expand exec_prefix

[PR PATCH] environment/configure/gnu-configure-args.sh: do not expand exec_prefix

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]

There is a new pull request by Johnnynator against master on the void-packages repository

https://github.com/Johnnynator/void-packages gnu-conf
https://github.com/void-linux/void-packages/pull/28531

environment/configure/gnu-configure-args.sh: do not expand exec_prefix
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/28531.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnu-conf-28531.patch --]
[-- Type: text/x-diff, Size: 1226 bytes --]

From 117475f6e9163bd57047e1517db371adc0c8de07 Mon Sep 17 00:00:00 2001
From: John <me@johnnynator.dev>
Date: Fri, 5 Feb 2021 20:22:52 +0100
Subject: [PATCH] environment/configure/gnu-configure-args.sh: do not expand
 exec_prefix

the expansion did at least result in invalid pkgconfig
and cmake files generated in xapian-core
---
 common/environment/configure/gnu-configure-args.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/environment/configure/gnu-configure-args.sh b/common/environment/configure/gnu-configure-args.sh
index c0a2f4602b9..dafbf5dc110 100644
--- a/common/environment/configure/gnu-configure-args.sh
+++ b/common/environment/configure/gnu-configure-args.sh
@@ -17,7 +17,7 @@ export configure_args+=" --host=$XBPS_TRIPLET --build=$XBPS_TRIPLET"
 # Always use wordsize-specific libdir even though the real path is lib
 # This is to make sure 32-bit and 64-bit libs can coexist when looking
 # up things (the opposite-libdir is always symlinked as libNN)
-export configure_args+=" --libdir=/usr/lib${XBPS_TARGET_WORDSIZE}"
+export configure_args+=" --libdir=\${exec_prefix}/lib${XBPS_TARGET_WORDSIZE}"
 
 _AUTOCONFCACHEDIR=${XBPS_COMMONDIR}/environment/configure/autoconf_cache
 

Re: environment/configure/gnu-configure-args.sh: do not expand exec_prefix

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/28531#issuecomment-774492493

Comment:
This break some pacakges that use the gnu-configure buildstyle but aren't actually gnu-configure. Like rhash.

Re: environment/configure/gnu-configure-args.sh: do not expand exec_prefix

[sgn]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/28531#issuecomment-780498919

Comment:
I think we should merge this PR now and fix whatever package that is failing?

Re: [PR PATCH] [Merged]: environment/configure/gnu-configure-args.sh: do not expand exec_prefix

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

There's a merged pull request on the void-packages repository

environment/configure/gnu-configure-args.sh: do not expand exec_prefix
https://github.com/void-linux/void-packages/pull/28531

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->