[PR PATCH] removed-packages: remove mozjs*.

[PR PATCH] removed-packages: remove mozjs*.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1965 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages rem
https://github.com/void-linux/void-packages/pull/28824

removed-packages: remove mozjs*.
XBPS's self update phase is too eager, and ends up pulling in
removed-packages. This means that a library added to removed-packages,
which should be cleanly replaced during the update phase, since its
dependants will ether be removed or moved to another dependency, will
instead stop the installation due to shlib errors.

Fixes #28779.

@Chocimier @Duncaen 

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl28779
-->


A patch file from https://github.com/void-linux/void-packages/pull/28824.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rem-28824.patch --]
[-- Type: text/x-diff, Size: 1308 bytes --]

From 729c9a810baabf261d4a75c598496b25c3b01da2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 17 Feb 2021 14:47:49 -0300
Subject: [PATCH] removed-packages: remove mozjs*.

XBPS's self update phase is too eager, and ends up pulling in
removed-packages. This means that a library added to removed-packages,
which should be cleanly replaced during the update phase, since its
dependants will ether be removed or moved to another dependency, will
instead stop the installation due to shlib errors.

Fixes #28779.
---
 srcpkgs/removed-packages/template | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 4869282733c..b1a22c361fa 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -1,7 +1,7 @@
 # Template file for 'removed-packages'
 pkgname=removed-packages
 version=0.1
-revision=26
+revision=27
 build_style=meta
 short_desc="Uninstalls packages removed from repository"
 maintainer="Piotr Wójcik <chocimier@tlen.pl>"
@@ -171,9 +171,6 @@ replaces="
  mdds0<=0.12.1_3
  mirrorbits<=0.5.1_1
  mongroup<=0.4.1_2
- mozjs52<=52.9.0_7
- mozjs60<=60.8.0_5
- mozjs68<=68.11.0_1
  orage<=4.12.1_7
  oce<=0.18.3_1
  oce-devel<=0.18.3_1

Re: [PR PATCH] [Updated] removed-packages: remove mozjs*.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1970 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages rem
https://github.com/void-linux/void-packages/pull/28824

removed-packages: remove mozjs*.
XBPS's self update phase is too eager, and ends up pulling in
removed-packages. This means that a library added to removed-packages,
which should be cleanly replaced during the update phase, since its
dependants will ether be removed or moved to another dependency, will
instead stop the installation due to shlib errors.

Fixes #28779.

@Chocimier @Duncaen 

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl28779
-->


A patch file from https://github.com/void-linux/void-packages/pull/28824.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rem-28824.patch --]
[-- Type: text/x-diff, Size: 1303 bytes --]

From 323b4e84a3dd8606e809ff07e0a240080567a49e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 17 Feb 2021 14:47:49 -0300
Subject: [PATCH] removed-packages: remove some mozjs from replaces.

XBPS's self update phase is too eager, and ends up pulling in
removed-packages. This means that a library added to removed-packages,
which should be cleanly replaced during the update phase, since its
dependants will ether be removed or moved to another dependency, will
instead stop the installation due to shlib errors.

Fixes #28779.
---
 srcpkgs/removed-packages/template | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 4869282733c..fd0328005a5 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -1,7 +1,7 @@
 # Template file for 'removed-packages'
 pkgname=removed-packages
 version=0.1
-revision=26
+revision=27
 build_style=meta
 short_desc="Uninstalls packages removed from repository"
 maintainer="Piotr Wójcik <chocimier@tlen.pl>"
@@ -171,8 +171,6 @@ replaces="
  mdds0<=0.12.1_3
  mirrorbits<=0.5.1_1
  mongroup<=0.4.1_2
- mozjs52<=52.9.0_7
- mozjs60<=60.8.0_5
  mozjs68<=68.11.0_1
  orage<=4.12.1_7
  oce<=0.18.3_1

Re: removed-packages: remove mozjs*.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28824#issuecomment-780742832

Comment:
Doing only mozjs52 and mozjs60 for now, then. Do you know of any other packages?

Re: removed-packages: remove mozjs*.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/28824#issuecomment-780744719

Comment:
Anything that possibly removes a package removing a shared library and is not part of base-system?
What does `removed-packages` solve?

Re: removed-packages: remove mozjs*.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/28824#issuecomment-780744719

Comment:
Anything that possibly removes a package providing a shared library and is not part of base-system?
What does `removed-packages` solve?

Re: removed-packages: remove mozjs*.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/28824#issuecomment-780744719

Comment:
Anything providing a shared library and is not part of base-system?
What does `removed-packages` solve?

Re: removed-packages: remove mozjs*.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28824#issuecomment-780746705

Comment:
> Anything providing a shared library and is not part of base-system?

Do you think we should remove all of these from `removed-packages`?

Re: removed-packages: remove mozjs*.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28824#issuecomment-780746705

Comment:
> Anything providing a shared library and is not part of base-system?

Do you think we should remove all of these from `removed-packages`?

It solves future `unresolved shlib` errors and avoids shipping empty meta packages, which are entirely silent uninstalls.

Re: removed-packages: remove mozjs*.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/28824#issuecomment-780747405

Comment:
That is the only solution that doesn't involve patching xbps, which does not really solve it until users can update xbps.

Re: removed-packages: remove mozjs*.

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/28824#issuecomment-780748846

Comment:
> future unresolved shlib errors

how do the problematic situation look like?

Re: removed-packages: remove mozjs*.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/28824#issuecomment-780750695

Comment:
> > future unresolved shlib errors
> 
> how do the problematic situation look like?

Basically the same, but that its something obsolete the user has installed which depends on some shared library that is being updated in the transaction.
The user just has to uninstall the package in this case.

Anything more complicated should be handled by replaces on the right packages.

Re: removed-packages: remove mozjs*.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/28824#issuecomment-780750695

Comment:
> > future unresolved shlib errors
> 
> how do the problematic situation look like?

Basically the same, but that its something obsolete the user has installed which depends on some shared library that is being updated in the transaction.
The user just has to uninstall the package in this case.

Anything more complicated should be handled by replaces on the right packages.

Edit:
I guess in same cases the uninstall is not easy i.e. a scenario would be:

`foo-1_1` depends on `old-1_1`, the dependency is removed in `foo-2_1` and a shared library `old-1_1` depends on is updated in the same transaction, now `old` blocks the `foo-2_1` update.
Then the issue is that you can't simply uninstall `old`, because `foo-1_1` still depends on it. 

Re: removed-packages: remove mozjs*.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/28824#issuecomment-780750695

Comment:
> > future unresolved shlib errors
> 
> how do the problematic situation look like?

Basically the same, but that its something obsolete the user has installed which depends on some shared library that is being updated in the transaction.
The user just has to uninstall the package in this case.

Anything more complicated should be handled by replaces on the right packages.

Edit:
I guess in some cases the uninstall is not easy i.e. a scenario would be:

`foo-1_1` depends on `old-1_1`, the dependency is removed in `foo-2_1` and a shared library `old-1_1` depends on is updated in the same transaction, now `old` blocks the `foo-2_1` update.
Then the issue is that you can't simply uninstall `old`, because `foo-1_1` still depends on it. 

Re: [PR PATCH] [Merged]: removed-packages: remove mozjs*.

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 1818 bytes --]

There's a merged pull request on the void-packages repository

removed-packages: remove mozjs*.
https://github.com/void-linux/void-packages/pull/28824

Description:
XBPS's self update phase is too eager, and ends up pulling in
removed-packages. This means that a library added to removed-packages,
which should be cleanly replaced during the update phase, since its
dependants will ether be removed or moved to another dependency, will
instead stop the installation due to shlib errors.

Fixes #28779.

@Chocimier @Duncaen 

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl28779
-->