Github messages for voidlinux
 help / color / mirror / Atom feed
From: bugcrazy <bugcrazy@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: devilutionX: update to 1.1.0
Date: Thu, 18 Feb 2021 23:23:29 +0100	[thread overview]
Message-ID: <20210218222329.RKGl7RzRn4N-coQlCnhymdLlcF-daJm-ABKStkKDBDk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25511@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/25511#issuecomment-781673988

Comment:
> @bugcrazy please don't tag me in multiple places, I did see your comment here.
> 
> Their cmake install includes all the files, as you can see here:
> 
> ```
> ➜ xbps-query -Rf devilutionX
> /usr/bin/devilutionx
> /usr/share/applications/devilutionx.desktop
> /usr/share/diasurgical/devilutionx/README.txt
> /usr/share/fonts/truetype/CharisSILB.ttf
> /usr/share/icons/hicolor/512x512/apps/devilutionx.png
> /usr/share/licenses/devilutionX/LICENSE
> ```
> 
> I removed the INSTALL.msg because they should be used for warnings about package changes or similar, not for general package information. For that, we can use a README.voidlinux. If you want to open a PR to add such a file, I will gladly merge it.

I understand now, the files were automatically added to the package, when I compiled, only the LICENSE file had been packaged, I don't see the need for PR, because INSTALL.msg is a warning, as not everyone is willing to seek information about installation, although the README.txt file, talk about it!
Thanks for answering!

      parent reply	other threads:[~2021-02-18 22:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-11  5:26 [PR PATCH] " bugcrazy
2020-10-11  8:25 ` bugcrazy
2021-02-15  4:26 ` [PR PATCH] [Closed]: " ericonr
2021-02-17  4:18 ` bugcrazy
2021-02-17 13:59 ` ericonr
2021-02-18 22:23 ` bugcrazy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210218222329.RKGl7RzRn4N-coQlCnhymdLlcF-daJm-ABKStkKDBDk@z \
    --to=bugcrazy@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).