* [PR PATCH] devilutionX: update to 1.1.0
@ 2020-10-11 5:26 bugcrazy
2020-10-11 8:25 ` bugcrazy
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: bugcrazy @ 2020-10-11 5:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
There is a new pull request by bugcrazy against master on the void-packages repository
https://github.com/bugcrazy/void-packages patch-5
https://github.com/void-linux/void-packages/pull/25511
devilutionX: update to 1.1.0
A patch file from https://github.com/void-linux/void-packages/pull/25511.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-5-25511.patch --]
[-- Type: text/x-diff, Size: 2088 bytes --]
From 0445ba54464ea6dd7858de8d7bdf5ae3b00f3eeb Mon Sep 17 00:00:00 2001
From: bugcrazy <39757967+bugcrazy@users.noreply.github.com>
Date: Sun, 11 Oct 2020 02:24:27 -0300
Subject: [PATCH] devilutionX: update to 1.1.0
---
srcpkgs/devilutionX/template | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index 43963071c58..ccfe1770e72 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -1,6 +1,6 @@
# Template file for 'devilutionX'
pkgname=devilutionX
-version=1.0.1
+version=1.1.0
revision=1
build_style=cmake
configure_args="-DBINARY_RELEASE=ON -DTTF_FONT_PATH=\"/usr/share/fonts/truetype/CharisSILB.ttf\""
@@ -10,7 +10,7 @@ maintainer="MarcoAPC <marcoaureliopc@gmail.com>"
license="Unlicense"
homepage="https://github.com/diasurgical/devilutionX"
distfiles="https://github.com/diasurgical/devilutionX/archive/${version}.tar.gz"
-checksum=165564fefdbfd0b4fbf74688ea1beb1d811eb1d8e200b9faad5b70ae2ac7564e
+checksum=395ec298df5383abe60550d45adba5e5811984589ccb1e504891b267b3c467c1
nocross="https://build.voidlinux.org/builders/aarch64-musl_builder/builds/25453/steps/shell_3/logs/stdio"
@@ -18,13 +18,9 @@ do_install() {
vbin build/devilutionx
vmkdir usr/share/applications
vmkdir usr/share/fonts/truetype
- vmkdir usr/share/icons/hicolor/16x16/apps
- vmkdir usr/share/icons/hicolor/32x32/apps
- vmkdir usr/share/icons/hicolor/48x48/apps
+ vmkdir usr/share/icons/hicolor/512x512/apps
vinstall Packaging/fedora/devilutionx.desktop 0644 usr/share/applications
vinstall Packaging/resources/CharisSILB.ttf 0644 usr/share/fonts/truetype
- cp Packaging/resources/16.png ${DESTDIR}/usr/share/icons/hicolor/16x16/apps/devilutionx.png
- cp Packaging/resources/Diablo_32.png ${DESTDIR}/usr/share/icons/hicolor/32x32/apps/devilutionx.png
- cp Packaging/resources/Diablo_48.png ${DESTDIR}/usr/share/icons/hicolor/48x48/apps/devilutionx.png
+ cp Packaging/resources/icon.png ${DESTDIR}/usr/share/icons/hicolor/512x512/apps/devilutionx.png
vlicense LICENSE
}
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: devilutionX: update to 1.1.0
2020-10-11 5:26 [PR PATCH] devilutionX: update to 1.1.0 bugcrazy
@ 2020-10-11 8:25 ` bugcrazy
2021-02-15 4:26 ` [PR PATCH] [Closed]: " ericonr
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: bugcrazy @ 2020-10-11 8:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
New comment by bugcrazy on void-packages repository
https://github.com/void-linux/void-packages/pull/25511#issuecomment-706669547
Comment:
The failure is the connection to the server's internal network, it is not a packet construction error, because the log shows this! This is a problem with travis.
"ERROR: [reposync] failed to fetch file http://alpha.us.repo.voidlinux.org/current/musl/debug/x86_64-musl-repodata: Not Found
https://github.com/diasurgical/devilutionX/archive/1.1.0.tar.gz: Transient resolver failure
ERROR: devilutionX-1.1.0_1: failed to fetch 1.1.0.tar.gz."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Closed]: devilutionX: update to 1.1.0
2020-10-11 5:26 [PR PATCH] devilutionX: update to 1.1.0 bugcrazy
2020-10-11 8:25 ` bugcrazy
@ 2021-02-15 4:26 ` ericonr
2021-02-17 4:18 ` bugcrazy
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-02-15 4:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
There's a closed pull request on the void-packages repository
devilutionX: update to 1.1.0
https://github.com/void-linux/void-packages/pull/25511
Description:
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: devilutionX: update to 1.1.0
2020-10-11 5:26 [PR PATCH] devilutionX: update to 1.1.0 bugcrazy
2020-10-11 8:25 ` bugcrazy
2021-02-15 4:26 ` [PR PATCH] [Closed]: " ericonr
@ 2021-02-17 4:18 ` bugcrazy
2021-02-17 13:59 ` ericonr
2021-02-18 22:23 ` bugcrazy
4 siblings, 0 replies; 6+ messages in thread
From: bugcrazy @ 2021-02-17 4:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
New comment by bugcrazy on void-packages repository
https://github.com/void-linux/void-packages/pull/25511#issuecomment-780286462
Comment:
@ericonr I didn't understand, why to remove INSTALL.msg, because as people will know, what is needed to run the game? I based on the INSTALL.msg game dhewm3, which also needs the data files to run! https://github.com/void-linux/void-packages/blob/master/srcpkgs/dhewm3/INSTALL.msg
I used do_install, because it is in the manual and has templates for other packages you use, the Fedora and Debian packages, use png and font icons, I also did not understand the removal of the code, in my compilations it was necessary, because the ttf font needed by the binary!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: devilutionX: update to 1.1.0
2020-10-11 5:26 [PR PATCH] devilutionX: update to 1.1.0 bugcrazy
` (2 preceding siblings ...)
2021-02-17 4:18 ` bugcrazy
@ 2021-02-17 13:59 ` ericonr
2021-02-18 22:23 ` bugcrazy
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-02-17 13:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25511#issuecomment-780574887
Comment:
@bugcrazy please don't tag me in multiple places, I did see your comment here.
Their cmake install includes all the files, as you can see here:
```
➜ xbps-query -Rf devilutionX
/usr/bin/devilutionx
/usr/share/applications/devilutionx.desktop
/usr/share/diasurgical/devilutionx/README.txt
/usr/share/fonts/truetype/CharisSILB.ttf
/usr/share/icons/hicolor/512x512/apps/devilutionx.png
/usr/share/licenses/devilutionX/LICENSE
```
I removed the INSTALL.msg because they should be used for warnings about package changes or similar, not for general package information. For that, we can use a README.voidlinux. If you want to open a PR to add such a file, I will gladly merge it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: devilutionX: update to 1.1.0
2020-10-11 5:26 [PR PATCH] devilutionX: update to 1.1.0 bugcrazy
` (3 preceding siblings ...)
2021-02-17 13:59 ` ericonr
@ 2021-02-18 22:23 ` bugcrazy
4 siblings, 0 replies; 6+ messages in thread
From: bugcrazy @ 2021-02-18 22:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]
New comment by bugcrazy on void-packages repository
https://github.com/void-linux/void-packages/pull/25511#issuecomment-781673988
Comment:
> @bugcrazy please don't tag me in multiple places, I did see your comment here.
>
> Their cmake install includes all the files, as you can see here:
>
> ```
> ➜ xbps-query -Rf devilutionX
> /usr/bin/devilutionx
> /usr/share/applications/devilutionx.desktop
> /usr/share/diasurgical/devilutionx/README.txt
> /usr/share/fonts/truetype/CharisSILB.ttf
> /usr/share/icons/hicolor/512x512/apps/devilutionx.png
> /usr/share/licenses/devilutionX/LICENSE
> ```
>
> I removed the INSTALL.msg because they should be used for warnings about package changes or similar, not for general package information. For that, we can use a README.voidlinux. If you want to open a PR to add such a file, I will gladly merge it.
I understand now, the files were automatically added to the package, when I compiled, only the LICENSE file had been packaged, I don't see the need for PR, because INSTALL.msg is a warning, as not everyone is willing to seek information about installation, although the README.txt file, talk about it!
Thanks for answering!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-18 22:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-11 5:26 [PR PATCH] devilutionX: update to 1.1.0 bugcrazy
2020-10-11 8:25 ` bugcrazy
2021-02-15 4:26 ` [PR PATCH] [Closed]: " ericonr
2021-02-17 4:18 ` bugcrazy
2021-02-17 13:59 ` ericonr
2021-02-18 22:23 ` bugcrazy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).