Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] zsh-syntax-highlighting: add .plugin.zsh
@ 2021-02-13 21:46 floyza
  2021-02-13 21:50 ` ericonr
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: floyza @ 2021-02-13 21:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1714 bytes --]

There is a new pull request by floyza against master on the void-packages repository

https://github.com/floyza/void-packages zsh-plugins
https://github.com/void-linux/void-packages/pull/28740

zsh-syntax-highlighting: add .plugin.zsh
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->
zsh-autosuggestions provides the zsh-autosuggestions.plugin.zsh file, this should provide its plugin file too.

A patch file from https://github.com/void-linux/void-packages/pull/28740.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zsh-plugins-28740.patch --]
[-- Type: text/x-diff, Size: 1209 bytes --]

From 5174b3db091a7d6758ac7ed1256dce8853897814 Mon Sep 17 00:00:00 2001
From: gavin <gavin@gavin-desktop.tds>
Date: Sat, 13 Feb 2021 13:14:50 -0800
Subject: [PATCH] zsh-syntax-highlighting: add .plugin.zsh

---
 srcpkgs/zsh-syntax-highlighting/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/zsh-syntax-highlighting/template b/srcpkgs/zsh-syntax-highlighting/template
index b655d88568a..9a78cb08d47 100644
--- a/srcpkgs/zsh-syntax-highlighting/template
+++ b/srcpkgs/zsh-syntax-highlighting/template
@@ -1,7 +1,7 @@
 # Template file for 'zsh-syntax-highlighting'
 pkgname=zsh-syntax-highlighting
 version=0.7.1
-revision=2
+revision=3
 depends="zsh"
 short_desc="Fish shell like syntax highlighting for Zsh"
 maintainer="Orphaned <orphan@voidlinux.org>"
@@ -13,6 +13,7 @@ checksum=f5044266ee198468b1bcec881a56e6399e209657d6ed9fa6d21175bc76afdefa
 
 do_install() {
 	vinstall ${pkgname}.zsh 644 usr/share/zsh/plugins/${pkgname}
+	vinstall ${pkgname}.plugin.zsh 644 usr/share/zsh/plugins/${pkgname}
 	vinstall .version 644 usr/share/zsh/plugins/${pkgname}
 	vinstall .revision-hash 644 usr/share/zsh/plugins/${pkgname}
 	vcopy highlighters usr/share/zsh/plugins/${pkgname}

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: zsh-syntax-highlighting: add .plugin.zsh
  2021-02-13 21:46 [PR PATCH] zsh-syntax-highlighting: add .plugin.zsh floyza
@ 2021-02-13 21:50 ` ericonr
  2021-02-14  2:21 ` [PR PATCH] [Updated] " floyza
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-02-13 21:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28740#issuecomment-778682938

Comment:
Why don't we use their Makefile? https://github.com/zsh-users/zsh-syntax-highlighting/blob/master/Makefile#L15

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] zsh-syntax-highlighting: add .plugin.zsh
  2021-02-13 21:46 [PR PATCH] zsh-syntax-highlighting: add .plugin.zsh floyza
  2021-02-13 21:50 ` ericonr
@ 2021-02-14  2:21 ` floyza
  2021-02-14  2:29 ` floyza
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: floyza @ 2021-02-14  2:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1719 bytes --]

There is an updated pull request by floyza against master on the void-packages repository

https://github.com/floyza/void-packages zsh-plugins
https://github.com/void-linux/void-packages/pull/28740

zsh-syntax-highlighting: add .plugin.zsh
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->
zsh-autosuggestions provides the zsh-autosuggestions.plugin.zsh file, this should provide its plugin file too.

A patch file from https://github.com/void-linux/void-packages/pull/28740.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zsh-plugins-28740.patch --]
[-- Type: text/x-diff, Size: 1447 bytes --]

From 4f3bfea4bb4d6bbf58063158aa478fd3ca69c63d Mon Sep 17 00:00:00 2001
From: gavin <gavin@gavin-desktop.tds>
Date: Sat, 13 Feb 2021 13:14:50 -0800
Subject: [PATCH] zsh-syntax-highlighting: add .plugin.zsh

---
 srcpkgs/zsh-syntax-highlighting/template | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/zsh-syntax-highlighting/template b/srcpkgs/zsh-syntax-highlighting/template
index b655d88568a..ab629886506 100644
--- a/srcpkgs/zsh-syntax-highlighting/template
+++ b/srcpkgs/zsh-syntax-highlighting/template
@@ -1,7 +1,7 @@
 # Template file for 'zsh-syntax-highlighting'
 pkgname=zsh-syntax-highlighting
 version=0.7.1
-revision=2
+revision=3
 depends="zsh"
 short_desc="Fish shell like syntax highlighting for Zsh"
 maintainer="Orphaned <orphan@voidlinux.org>"
@@ -12,9 +12,6 @@ distfiles="${homepage}/archive/${version}.tar.gz>${pkgname}-${version}.tar.gz"
 checksum=f5044266ee198468b1bcec881a56e6399e209657d6ed9fa6d21175bc76afdefa
 
 do_install() {
-	vinstall ${pkgname}.zsh 644 usr/share/zsh/plugins/${pkgname}
-	vinstall .version 644 usr/share/zsh/plugins/${pkgname}
-	vinstall .revision-hash 644 usr/share/zsh/plugins/${pkgname}
-	vcopy highlighters usr/share/zsh/plugins/${pkgname}
-	vlicense COPYING.md
+  make install SHARE_DIR=${DESTDIR}/usr/share/zsh/plugins/${pkgname} DOC_DIR=${DESTDIR}/usr/share/zsh/plugins/${pkgname}/doc
+	vinstall ${pkgname}.plugin.zsh 644 usr/share/zsh/plugins/${pkgname}
 }

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] zsh-syntax-highlighting: add .plugin.zsh
  2021-02-13 21:46 [PR PATCH] zsh-syntax-highlighting: add .plugin.zsh floyza
  2021-02-13 21:50 ` ericonr
  2021-02-14  2:21 ` [PR PATCH] [Updated] " floyza
@ 2021-02-14  2:29 ` floyza
  2021-02-14  2:31 ` floyza
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: floyza @ 2021-02-14  2:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1719 bytes --]

There is an updated pull request by floyza against master on the void-packages repository

https://github.com/floyza/void-packages zsh-plugins
https://github.com/void-linux/void-packages/pull/28740

zsh-syntax-highlighting: add .plugin.zsh
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->
zsh-autosuggestions provides the zsh-autosuggestions.plugin.zsh file, this should provide its plugin file too.

A patch file from https://github.com/void-linux/void-packages/pull/28740.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zsh-plugins-28740.patch --]
[-- Type: text/x-diff, Size: 1449 bytes --]

From a79ab640cbb59eb24ba2da545c28cef6b9fbd4c4 Mon Sep 17 00:00:00 2001
From: gavin <gavin.downard@runbox.com>
Date: Sat, 13 Feb 2021 18:28:49 -0800
Subject: [PATCH] zsh-syntax-highlighting: add .plugin.zsh

---
 srcpkgs/zsh-syntax-highlighting/template | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/zsh-syntax-highlighting/template b/srcpkgs/zsh-syntax-highlighting/template
index b655d88568a..c642fc812dc 100644
--- a/srcpkgs/zsh-syntax-highlighting/template
+++ b/srcpkgs/zsh-syntax-highlighting/template
@@ -1,7 +1,7 @@
 # Template file for 'zsh-syntax-highlighting'
 pkgname=zsh-syntax-highlighting
 version=0.7.1
-revision=2
+revision=3
 depends="zsh"
 short_desc="Fish shell like syntax highlighting for Zsh"
 maintainer="Orphaned <orphan@voidlinux.org>"
@@ -12,9 +12,6 @@ distfiles="${homepage}/archive/${version}.tar.gz>${pkgname}-${version}.tar.gz"
 checksum=f5044266ee198468b1bcec881a56e6399e209657d6ed9fa6d21175bc76afdefa
 
 do_install() {
-	vinstall ${pkgname}.zsh 644 usr/share/zsh/plugins/${pkgname}
-	vinstall .version 644 usr/share/zsh/plugins/${pkgname}
-	vinstall .revision-hash 644 usr/share/zsh/plugins/${pkgname}
-	vcopy highlighters usr/share/zsh/plugins/${pkgname}
-	vlicense COPYING.md
+  make install SHARE_DIR=${DESTDIR}/usr/share/zsh/plugins/${pkgname} DOC_DIR=${DESTDIR}/usr/share/zsh/plugins/${pkgname}/doc
+  vinstall ${pkgname}.plugin.zsh 644 usr/share/zsh/plugins/${pkgname}
 }

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] zsh-syntax-highlighting: add .plugin.zsh
  2021-02-13 21:46 [PR PATCH] zsh-syntax-highlighting: add .plugin.zsh floyza
                   ` (2 preceding siblings ...)
  2021-02-14  2:29 ` floyza
@ 2021-02-14  2:31 ` floyza
  2021-02-14  2:32 ` floyza
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: floyza @ 2021-02-14  2:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1719 bytes --]

There is an updated pull request by floyza against master on the void-packages repository

https://github.com/floyza/void-packages zsh-plugins
https://github.com/void-linux/void-packages/pull/28740

zsh-syntax-highlighting: add .plugin.zsh
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->
zsh-autosuggestions provides the zsh-autosuggestions.plugin.zsh file, this should provide its plugin file too.

A patch file from https://github.com/void-linux/void-packages/pull/28740.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zsh-plugins-28740.patch --]
[-- Type: text/x-diff, Size: 1447 bytes --]

From 458c970467673fe57d68f0b3a009b9fae79c914b Mon Sep 17 00:00:00 2001
From: gavin <gavin.downard@runbox.com>
Date: Sat, 13 Feb 2021 18:28:49 -0800
Subject: [PATCH] zsh-syntax-highlighting: add .plugin.zsh

---
 srcpkgs/zsh-syntax-highlighting/template | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/zsh-syntax-highlighting/template b/srcpkgs/zsh-syntax-highlighting/template
index b655d88568a..36711efd6e4 100644
--- a/srcpkgs/zsh-syntax-highlighting/template
+++ b/srcpkgs/zsh-syntax-highlighting/template
@@ -1,7 +1,7 @@
 # Template file for 'zsh-syntax-highlighting'
 pkgname=zsh-syntax-highlighting
 version=0.7.1
-revision=2
+revision=3
 depends="zsh"
 short_desc="Fish shell like syntax highlighting for Zsh"
 maintainer="Orphaned <orphan@voidlinux.org>"
@@ -12,9 +12,6 @@ distfiles="${homepage}/archive/${version}.tar.gz>${pkgname}-${version}.tar.gz"
 checksum=f5044266ee198468b1bcec881a56e6399e209657d6ed9fa6d21175bc76afdefa
 
 do_install() {
-	vinstall ${pkgname}.zsh 644 usr/share/zsh/plugins/${pkgname}
-	vinstall .version 644 usr/share/zsh/plugins/${pkgname}
-	vinstall .revision-hash 644 usr/share/zsh/plugins/${pkgname}
-	vcopy highlighters usr/share/zsh/plugins/${pkgname}
-	vlicense COPYING.md
+	make install SHARE_DIR=${DESTDIR}/usr/share/zsh/plugins/${pkgname} DOC_DIR=${DESTDIR}/usr/share/zsh/plugins/${pkgname}/doc
+	vinstall ${pkgname}.plugin.zsh 644 usr/share/zsh/plugins/${pkgname}
 }

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: zsh-syntax-highlighting: add .plugin.zsh
  2021-02-13 21:46 [PR PATCH] zsh-syntax-highlighting: add .plugin.zsh floyza
                   ` (3 preceding siblings ...)
  2021-02-14  2:31 ` floyza
@ 2021-02-14  2:32 ` floyza
  2021-02-19  6:08 ` [PR PATCH] [Closed]: " ericonr
  2021-02-19  6:09 ` ericonr
  6 siblings, 0 replies; 8+ messages in thread
From: floyza @ 2021-02-14  2:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New comment by floyza on void-packages repository

https://github.com/void-linux/void-packages/pull/28740#issuecomment-778711366

Comment:
We still need to manually install the zsh-autosuggestions.plugin.zsh file though, since their Makefile doesn't install it.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Closed]: zsh-syntax-highlighting: add .plugin.zsh
  2021-02-13 21:46 [PR PATCH] zsh-syntax-highlighting: add .plugin.zsh floyza
                   ` (4 preceding siblings ...)
  2021-02-14  2:32 ` floyza
@ 2021-02-19  6:08 ` ericonr
  2021-02-19  6:09 ` ericonr
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-02-19  6:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]

There's a closed pull request on the void-packages repository

zsh-syntax-highlighting: add .plugin.zsh
https://github.com/void-linux/void-packages/pull/28740

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->
zsh-autosuggestions provides the zsh-autosuggestions.plugin.zsh file, this should provide its plugin file too.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: zsh-syntax-highlighting: add .plugin.zsh
  2021-02-13 21:46 [PR PATCH] zsh-syntax-highlighting: add .plugin.zsh floyza
                   ` (5 preceding siblings ...)
  2021-02-19  6:08 ` [PR PATCH] [Closed]: " ericonr
@ 2021-02-19  6:09 ` ericonr
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-02-19  6:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28740#issuecomment-781851479

Comment:
I fixed the lint complaint and pushed, thanks!

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-02-19  6:09 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-13 21:46 [PR PATCH] zsh-syntax-highlighting: add .plugin.zsh floyza
2021-02-13 21:50 ` ericonr
2021-02-14  2:21 ` [PR PATCH] [Updated] " floyza
2021-02-14  2:29 ` floyza
2021-02-14  2:31 ` floyza
2021-02-14  2:32 ` floyza
2021-02-19  6:08 ` [PR PATCH] [Closed]: " ericonr
2021-02-19  6:09 ` ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).