Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] pinebookpro-base: depend on dracut
@ 2021-02-20 19:34 CameronNemo
  2021-02-20 19:39 ` ericonr
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: CameronNemo @ 2021-02-20 19:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1650 bytes --]

There is a new pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages pbp-base
https://github.com/void-linux/void-packages/pull/28937

pinebookpro-base: depend on dracut
https://github.com/void-linux/void-mklive/issues/180

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64 (cross)
  - [ ] armv7l
  - [ ] armv6l-musl

A patch file from https://github.com/void-linux/void-packages/pull/28937.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pbp-base-28937.patch --]
[-- Type: text/x-diff, Size: 1023 bytes --]

From 67d41f0b3ae495ad98f580acd2ebaab0516317f5 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Sat, 20 Feb 2021 11:32:12 -0800
Subject: [PATCH] pinebookpro-base: depend on dracut

https://github.com/void-linux/void-mklive/issues/180
---
 srcpkgs/pinebookpro-base/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/pinebookpro-base/template b/srcpkgs/pinebookpro-base/template
index a43345eaafa..42178af017e 100644
--- a/srcpkgs/pinebookpro-base/template
+++ b/srcpkgs/pinebookpro-base/template
@@ -1,10 +1,11 @@
 # Template file for 'pinebookpro-base'
 pkgname=pinebookpro-base
 version=0.4
-revision=1
+revision=2
 archs="aarch64*"
 build_style=meta
-depends="pinebookpro-kernel linux-firmware pinebookpro-firmware pinebookpro-uboot"
+depends="pinebookpro-kernel linux-firmware pinebookpro-firmware
+ pinebookpro-uboot dracut"
 short_desc="Void Linux Pinebook Pro platform package"
 maintainer="Renato Aguiar <renato@renatoaguiar.net>"
 license="Public Domain"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: pinebookpro-base: depend on dracut
  2021-02-20 19:34 [PR PATCH] pinebookpro-base: depend on dracut CameronNemo
@ 2021-02-20 19:39 ` ericonr
  2021-02-20 19:51 ` [PR PATCH] [Updated] " CameronNemo
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-02-20 19:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28937#issuecomment-782738413

Comment:
Could you mention explicitly in the commit that this became necessary because of the kernel package splitting more things into modules? Otherwise LGTM.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] pinebookpro-base: depend on dracut
  2021-02-20 19:34 [PR PATCH] pinebookpro-base: depend on dracut CameronNemo
  2021-02-20 19:39 ` ericonr
@ 2021-02-20 19:51 ` CameronNemo
  2021-02-20 19:51 ` CameronNemo
  2021-02-23 22:29 ` [PR PATCH] [Merged]: " ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: CameronNemo @ 2021-02-20 19:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1655 bytes --]

There is an updated pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages pbp-base
https://github.com/void-linux/void-packages/pull/28937

pinebookpro-base: depend on dracut
https://github.com/void-linux/void-mklive/issues/180

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64 (cross)
  - [ ] armv7l
  - [ ] armv6l-musl

A patch file from https://github.com/void-linux/void-packages/pull/28937.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pbp-base-28937.patch --]
[-- Type: text/x-diff, Size: 1165 bytes --]

From d741a8b111f0a7a855823973a3ca34d6749fdce4 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Sat, 20 Feb 2021 11:32:12 -0800
Subject: [PATCH] pinebookpro-base: depend on dracut

The PBP kernel has more modules, and thus needs an initramfs to boot.
Add dracut to ensure that PBP images created by mklive boot correctly.

https://github.com/void-linux/void-mklive/issues/180
---
 srcpkgs/pinebookpro-base/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/pinebookpro-base/template b/srcpkgs/pinebookpro-base/template
index a43345eaafa..42178af017e 100644
--- a/srcpkgs/pinebookpro-base/template
+++ b/srcpkgs/pinebookpro-base/template
@@ -1,10 +1,11 @@
 # Template file for 'pinebookpro-base'
 pkgname=pinebookpro-base
 version=0.4
-revision=1
+revision=2
 archs="aarch64*"
 build_style=meta
-depends="pinebookpro-kernel linux-firmware pinebookpro-firmware pinebookpro-uboot"
+depends="pinebookpro-kernel linux-firmware pinebookpro-firmware
+ pinebookpro-uboot dracut"
 short_desc="Void Linux Pinebook Pro platform package"
 maintainer="Renato Aguiar <renato@renatoaguiar.net>"
 license="Public Domain"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: pinebookpro-base: depend on dracut
  2021-02-20 19:34 [PR PATCH] pinebookpro-base: depend on dracut CameronNemo
  2021-02-20 19:39 ` ericonr
  2021-02-20 19:51 ` [PR PATCH] [Updated] " CameronNemo
@ 2021-02-20 19:51 ` CameronNemo
  2021-02-23 22:29 ` [PR PATCH] [Merged]: " ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: CameronNemo @ 2021-02-20 19:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/28937#issuecomment-782739890

Comment:
@ericonr done

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: pinebookpro-base: depend on dracut
  2021-02-20 19:34 [PR PATCH] pinebookpro-base: depend on dracut CameronNemo
                   ` (2 preceding siblings ...)
  2021-02-20 19:51 ` CameronNemo
@ 2021-02-23 22:29 ` ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-02-23 22:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]

There's a merged pull request on the void-packages repository

pinebookpro-base: depend on dracut
https://github.com/void-linux/void-packages/pull/28937

Description:
https://github.com/void-linux/void-mklive/issues/180

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64 (cross)
  - [ ] armv7l
  - [ ] armv6l-musl

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-02-23 22:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-20 19:34 [PR PATCH] pinebookpro-base: depend on dracut CameronNemo
2021-02-20 19:39 ` ericonr
2021-02-20 19:51 ` [PR PATCH] [Updated] " CameronNemo
2021-02-20 19:51 ` CameronNemo
2021-02-23 22:29 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).