* Re: New package: pipe-viewer-0.0.7
2021-02-23 22:41 [PR PATCH] New package: pipe-viewer-0.0.7 4ricci
@ 2021-02-23 22:48 ` ericonr
2021-02-23 23:02 ` 4ricci
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-02-23 22:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 254 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29014#issuecomment-784568882
Comment:
We already ship `youtube-viewer`, `straw-viewer` and a few others. Do you think this one is noticeably different?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: New package: pipe-viewer-0.0.7
2021-02-23 22:41 [PR PATCH] New package: pipe-viewer-0.0.7 4ricci
2021-02-23 22:48 ` ericonr
@ 2021-02-23 23:02 ` 4ricci
2021-02-24 3:39 ` [PR REVIEW] " ericonr
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: 4ricci @ 2021-02-23 23:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 159 bytes --]
New comment by 4ricci on void-packages repository
https://github.com/void-linux/void-packages/pull/29014#issuecomment-784575219
Comment:
@ericonr see #29015
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] New package: pipe-viewer-0.0.7
2021-02-23 22:41 [PR PATCH] New package: pipe-viewer-0.0.7 4ricci
2021-02-23 22:48 ` ericonr
2021-02-23 23:02 ` 4ricci
@ 2021-02-24 3:39 ` ericonr
2021-02-24 3:40 ` ericonr
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-02-24 3:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29014#discussion_r581595210
Comment:
This should be `sourcepkg>=`
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: New package: pipe-viewer-0.0.7
2021-02-23 22:41 [PR PATCH] New package: pipe-viewer-0.0.7 4ricci
` (2 preceding siblings ...)
2021-02-24 3:39 ` [PR REVIEW] " ericonr
@ 2021-02-24 3:40 ` ericonr
2021-02-24 9:15 ` [PR PATCH] [Updated] " 4ricci
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-02-24 3:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 275 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29014#issuecomment-784729044
Comment:
Interesting, thanks for the context!
Once straw-viewer is deprecated, do you think pipe-viewer could receive a meta package for it?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] New package: pipe-viewer-0.0.7
2021-02-23 22:41 [PR PATCH] New package: pipe-viewer-0.0.7 4ricci
` (3 preceding siblings ...)
2021-02-24 3:40 ` ericonr
@ 2021-02-24 9:15 ` 4ricci
2021-02-24 10:01 ` 4ricci
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: 4ricci @ 2021-02-24 9:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]
There is an updated pull request by 4ricci against master on the void-packages repository
https://github.com/4ricci/void-packages pipe-viewer
https://github.com/void-linux/void-packages/pull/29014
New package: pipe-viewer-0.0.7
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29014.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipe-viewer-29014.patch --]
[-- Type: text/x-diff, Size: 1950 bytes --]
From 98a7b6a459fc378f3a312bb151a1499d8c467f0e Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Tue, 23 Feb 2021 21:29:09 +0100
Subject: [PATCH] New package: pipe-viewer-0.0.7
---
srcpkgs/pipe-viewer-gtk | 1 +
srcpkgs/pipe-viewer/template | 28 ++++++++++++++++++++++++++++
2 files changed, 29 insertions(+)
create mode 120000 srcpkgs/pipe-viewer-gtk
create mode 100644 srcpkgs/pipe-viewer/template
diff --git a/srcpkgs/pipe-viewer-gtk b/srcpkgs/pipe-viewer-gtk
new file mode 120000
index 00000000000..672a26eb4bc
--- /dev/null
+++ b/srcpkgs/pipe-viewer-gtk
@@ -0,0 +1 @@
+pipe-viewer
\ No newline at end of file
diff --git a/srcpkgs/pipe-viewer/template b/srcpkgs/pipe-viewer/template
new file mode 100644
index 00000000000..581da7ed794
--- /dev/null
+++ b/srcpkgs/pipe-viewer/template
@@ -0,0 +1,28 @@
+# Template file for 'pipe-viewer'
+pkgname=pipe-viewer
+version=0.0.7
+revision=1
+build_style=perl-ModuleBuild
+configure_args="--gtk"
+hostmakedepends="perl-Module-Build"
+makedepends="perl"
+depends="perl-Data-Dump perl-JSON perl-LWP-Protocol-https perl-Term-ReadLine-Gnu
+ perl-Unicode-LineBreak perl-JSON-XS"
+checkdepends="perl-Test-Pod"
+short_desc="Search and play videos from YouTube"
+maintainer="Roberto Ricci <ricci@disroot.org>"
+license="Artistic-2.0"
+homepage="https://github.com/trizen/pipe-viewer"
+changelog="https://github.com/trizen/pipe-viewer/releases"
+distfiles="https://github.com/trizen/pipe-viewer/archive/${version}.tar.gz"
+checksum=5e1211ec963aa2a187bcb0983227c5667e6c580bfc9de93dcb582388cc1baf22
+
+pipe-viewer-gtk_package() {
+ depends="${sourcepkg}>=${version}_${revision} perl-Gtk3 perl-File-ShareDir"
+ short_desc="Search and play videos from YouTube - GTK interface"
+ pkg_install() {
+ vmove usr/bin/gtk-pipe-viewer
+ vmove "usr/share/perl5/vendor_perl/auto/share/dist/WWW-PipeViewer/gtk-*"
+ vmove usr/share/perl5/vendor_perl/auto/share/dist/WWW-PipeViewer/icons
+ }
+}
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] New package: pipe-viewer-0.0.7
2021-02-23 22:41 [PR PATCH] New package: pipe-viewer-0.0.7 4ricci
` (4 preceding siblings ...)
2021-02-24 9:15 ` [PR PATCH] [Updated] " 4ricci
@ 2021-02-24 10:01 ` 4ricci
2021-02-24 10:08 ` 4ricci
2021-02-24 14:57 ` [PR PATCH] [Merged]: " ericonr
7 siblings, 0 replies; 9+ messages in thread
From: 4ricci @ 2021-02-24 10:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]
There is an updated pull request by 4ricci against master on the void-packages repository
https://github.com/4ricci/void-packages pipe-viewer
https://github.com/void-linux/void-packages/pull/29014
New package: pipe-viewer-0.0.7
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29014.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipe-viewer-29014.patch --]
[-- Type: text/x-diff, Size: 1935 bytes --]
From 6a30d1d2a925b706f53c20dc5d010bb6ce65abbd Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Tue, 23 Feb 2021 21:29:09 +0100
Subject: [PATCH] New package: pipe-viewer-0.0.7
---
srcpkgs/pipe-viewer-gtk | 1 +
srcpkgs/pipe-viewer/template | 28 ++++++++++++++++++++++++++++
2 files changed, 29 insertions(+)
create mode 120000 srcpkgs/pipe-viewer-gtk
create mode 100644 srcpkgs/pipe-viewer/template
diff --git a/srcpkgs/pipe-viewer-gtk b/srcpkgs/pipe-viewer-gtk
new file mode 120000
index 00000000000..672a26eb4bc
--- /dev/null
+++ b/srcpkgs/pipe-viewer-gtk
@@ -0,0 +1 @@
+pipe-viewer
\ No newline at end of file
diff --git a/srcpkgs/pipe-viewer/template b/srcpkgs/pipe-viewer/template
new file mode 100644
index 00000000000..32991f6806b
--- /dev/null
+++ b/srcpkgs/pipe-viewer/template
@@ -0,0 +1,28 @@
+# Template file for 'pipe-viewer'
+pkgname=pipe-viewer
+version=0.0.7
+revision=1
+build_style=perl-ModuleBuild
+configure_args="--gtk"
+hostmakedepends="perl-Module-Build"
+makedepends="perl"
+depends="perl-Data-Dump perl-JSON perl-LWP-Protocol-https perl-Term-ReadLine-Gnu
+ perl-Unicode-LineBreak perl-JSON-XS"
+checkdepends="perl-Test-Pod"
+short_desc="Search and play videos from YouTube without an API key"
+maintainer="Roberto Ricci <ricci@disroot.org>"
+license="Artistic-2.0"
+homepage="https://github.com/trizen/pipe-viewer"
+changelog="https://github.com/trizen/pipe-viewer/releases"
+distfiles="https://github.com/trizen/pipe-viewer/archive/${version}.tar.gz"
+checksum=5e1211ec963aa2a187bcb0983227c5667e6c580bfc9de93dcb582388cc1baf22
+
+pipe-viewer-gtk_package() {
+ depends="${sourcepkg}>=${version}_${revision} perl-Gtk3 perl-File-ShareDir"
+ short_desc+=" - GTK interface"
+ pkg_install() {
+ vmove usr/bin/gtk-pipe-viewer
+ vmove "usr/share/perl5/vendor_perl/auto/share/dist/WWW-PipeViewer/gtk-*"
+ vmove usr/share/perl5/vendor_perl/auto/share/dist/WWW-PipeViewer/icons
+ }
+}
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: New package: pipe-viewer-0.0.7
2021-02-23 22:41 [PR PATCH] New package: pipe-viewer-0.0.7 4ricci
` (5 preceding siblings ...)
2021-02-24 10:01 ` 4ricci
@ 2021-02-24 10:08 ` 4ricci
2021-02-24 14:57 ` [PR PATCH] [Merged]: " ericonr
7 siblings, 0 replies; 9+ messages in thread
From: 4ricci @ 2021-02-24 10:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
New comment by 4ricci on void-packages repository
https://github.com/void-linux/void-packages/pull/29014#issuecomment-784962839
Comment:
Yes, I could add a dummy subpackage to pipe-viewer.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Merged]: New package: pipe-viewer-0.0.7
2021-02-23 22:41 [PR PATCH] New package: pipe-viewer-0.0.7 4ricci
` (6 preceding siblings ...)
2021-02-24 10:08 ` 4ricci
@ 2021-02-24 14:57 ` ericonr
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-02-24 14:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]
There's a merged pull request on the void-packages repository
New package: pipe-viewer-0.0.7
https://github.com/void-linux/void-packages/pull/29014
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 9+ messages in thread