* [PR PATCH] base-files: initialise empty etc/modules-load.d folder
@ 2021-02-27 21:25 NeelChotai
2021-02-27 21:59 ` [PR PATCH] [Updated] " NeelChotai
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: NeelChotai @ 2021-02-27 21:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1638 bytes --]
There is a new pull request by NeelChotai against master on the void-packages repository
https://github.com/NeelChotai/void-packages base-files-modules-load
https://github.com/void-linux/void-packages/pull/29099
base-files: initialise empty etc/modules-load.d folder
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29099.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-base-files-modules-load-29099.patch --]
[-- Type: text/x-diff, Size: 821 bytes --]
From 35dcc5e809bf373edc8cd4011f1aa8d4cf285175 Mon Sep 17 00:00:00 2001
From: Neel <neel@chot.ai>
Date: Sat, 27 Feb 2021 19:30:49 +0000
Subject: [PATCH] base-files: initialise empty etc/modules-load.d folder
---
srcpkgs/base-files/INSTALL | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/base-files/INSTALL b/srcpkgs/base-files/INSTALL
index 1be113b93cc..85a7f92cd4e 100644
--- a/srcpkgs/base-files/INSTALL
+++ b/srcpkgs/base-files/INSTALL
@@ -2,8 +2,8 @@ make_system_dirs() {
#
# Install FHS system directories.
#
- for d in boot etc etc/modprobe.d etc/skel \
- home dev proc usr mnt opt sys media var run/lock; do
+ for d in boot etc etc/modprobe.d etc/modules-load.d \
+ etc/skel home dev proc usr mnt opt sys media var run/lock; do
[ ! -d ${d} ] && install -d ${d}
done
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] base-files: initialise empty etc/modules-load.d folder
2021-02-27 21:25 [PR PATCH] base-files: initialise empty etc/modules-load.d folder NeelChotai
@ 2021-02-27 21:59 ` NeelChotai
2021-02-28 7:06 ` ericonr
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: NeelChotai @ 2021-02-27 21:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]
There is an updated pull request by NeelChotai against master on the void-packages repository
https://github.com/NeelChotai/void-packages base-files-modules-load
https://github.com/void-linux/void-packages/pull/29099
base-files: initialise empty etc/modules-load.d folder
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29099.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-base-files-modules-load-29099.patch --]
[-- Type: text/x-diff, Size: 1228 bytes --]
From 84957e05114c932138ca4ca3e3b779446572d389 Mon Sep 17 00:00:00 2001
From: Neel <neel@chot.ai>
Date: Sat, 27 Feb 2021 19:30:49 +0000
Subject: [PATCH] base-files: initialise empty etc/modules-load.d folder
---
srcpkgs/base-files/INSTALL | 4 ++--
srcpkgs/base-files/template | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/base-files/INSTALL b/srcpkgs/base-files/INSTALL
index 1be113b93cc..85a7f92cd4e 100644
--- a/srcpkgs/base-files/INSTALL
+++ b/srcpkgs/base-files/INSTALL
@@ -2,8 +2,8 @@ make_system_dirs() {
#
# Install FHS system directories.
#
- for d in boot etc etc/modprobe.d etc/skel \
- home dev proc usr mnt opt sys media var run/lock; do
+ for d in boot etc etc/modprobe.d etc/modules-load.d \
+ etc/skel home dev proc usr mnt opt sys media var run/lock; do
[ ! -d ${d} ] && install -d ${d}
done
diff --git a/srcpkgs/base-files/template b/srcpkgs/base-files/template
index 8040a801110..96725458925 100644
--- a/srcpkgs/base-files/template
+++ b/srcpkgs/base-files/template
@@ -1,7 +1,7 @@
# Template file for 'base-files'
pkgname=base-files
version=0.141
-revision=7
+revision=8
bootstrap=yes
depends="xbps-triggers"
short_desc="Void Linux base system files"
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: base-files: initialise empty etc/modules-load.d folder
2021-02-27 21:25 [PR PATCH] base-files: initialise empty etc/modules-load.d folder NeelChotai
2021-02-27 21:59 ` [PR PATCH] [Updated] " NeelChotai
@ 2021-02-28 7:06 ` ericonr
2021-02-28 17:45 ` [PR PATCH] [Updated] " NeelChotai
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-02-28 7:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29099#issuecomment-787407157
Comment:
Please rebase, and hold this change for a bit. I want to see if we can ship directories in XBPS.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] base-files: initialise empty etc/modules-load.d folder
2021-02-27 21:25 [PR PATCH] base-files: initialise empty etc/modules-load.d folder NeelChotai
2021-02-27 21:59 ` [PR PATCH] [Updated] " NeelChotai
2021-02-28 7:06 ` ericonr
@ 2021-02-28 17:45 ` NeelChotai
2021-03-01 8:43 ` fosslinux
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: NeelChotai @ 2021-02-28 17:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]
There is an updated pull request by NeelChotai against master on the void-packages repository
https://github.com/NeelChotai/void-packages base-files-modules-load
https://github.com/void-linux/void-packages/pull/29099
base-files: initialise empty etc/modules-load.d folder
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29099.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-base-files-modules-load-29099.patch --]
[-- Type: text/x-diff, Size: 1229 bytes --]
From ebfb2ea1460679c100e4e0cadc610b92c381d674 Mon Sep 17 00:00:00 2001
From: Neel <neel@chot.ai>
Date: Sat, 27 Feb 2021 19:30:49 +0000
Subject: [PATCH] base-files: initialise empty etc/modules-load.d folder
---
srcpkgs/base-files/INSTALL | 4 ++--
srcpkgs/base-files/template | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/base-files/INSTALL b/srcpkgs/base-files/INSTALL
index 1be113b93cc..85a7f92cd4e 100644
--- a/srcpkgs/base-files/INSTALL
+++ b/srcpkgs/base-files/INSTALL
@@ -2,8 +2,8 @@ make_system_dirs() {
#
# Install FHS system directories.
#
- for d in boot etc etc/modprobe.d etc/skel \
- home dev proc usr mnt opt sys media var run/lock; do
+ for d in boot etc etc/modprobe.d etc/modules-load.d \
+ etc/skel home dev proc usr mnt opt sys media var run/lock; do
[ ! -d ${d} ] && install -d ${d}
done
diff --git a/srcpkgs/base-files/template b/srcpkgs/base-files/template
index c143cf024a1..0683d19209c 100644
--- a/srcpkgs/base-files/template
+++ b/srcpkgs/base-files/template
@@ -1,7 +1,7 @@
# Template file for 'base-files'
pkgname=base-files
version=0.141
-revision=9
+revision=10
bootstrap=yes
depends="xbps-triggers"
short_desc="Void Linux base system files"
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: base-files: initialise empty etc/modules-load.d folder
2021-02-27 21:25 [PR PATCH] base-files: initialise empty etc/modules-load.d folder NeelChotai
` (2 preceding siblings ...)
2021-02-28 17:45 ` [PR PATCH] [Updated] " NeelChotai
@ 2021-03-01 8:43 ` fosslinux
2021-03-01 9:55 ` NeelChotai
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: fosslinux @ 2021-03-01 8:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
New comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/29099#issuecomment-787768831
Comment:
Is there a compelling reason for this? (I do not see one). It's very trivial to mkdir `/etc/modules-load.d` if you want that. This adds confusion to users, IMO, but that's just me. (Either way I don't really mind, though).
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: base-files: initialise empty etc/modules-load.d folder
2021-02-27 21:25 [PR PATCH] base-files: initialise empty etc/modules-load.d folder NeelChotai
` (3 preceding siblings ...)
2021-03-01 8:43 ` fosslinux
@ 2021-03-01 9:55 ` NeelChotai
2021-03-01 9:55 ` NeelChotai
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: NeelChotai @ 2021-03-01 9:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
New comment by NeelChotai on void-packages repository
https://github.com/void-linux/void-packages/pull/29099#issuecomment-787818519
Comment:
> Is there a compelling reason for this? (I do not see one). It's very trivial to mkdir `/etc/modules-load.d` if you want that. This adds confusion to users, IMO, but that's just me. (Either way I don't really mind, though).
If an empty `etc/modprobe.d` folder is initialised, it stands to reason that an empty `etc/modules-load.d` should also be initialised.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: base-files: initialise empty etc/modules-load.d folder
2021-02-27 21:25 [PR PATCH] base-files: initialise empty etc/modules-load.d folder NeelChotai
` (4 preceding siblings ...)
2021-03-01 9:55 ` NeelChotai
@ 2021-03-01 9:55 ` NeelChotai
2021-03-01 20:24 ` fosslinux
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: NeelChotai @ 2021-03-01 9:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
New comment by NeelChotai on void-packages repository
https://github.com/void-linux/void-packages/pull/29099#issuecomment-787818519
Comment:
> Is there a compelling reason for this? (I do not see one). It's very trivial to mkdir `/etc/modules-load.d` if you want that. This adds confusion to users, IMO, but that's just me. (Either way I don't really mind, though).
If an empty `/etc/modprobe.d` folder is initialised, it stands to reason that an empty `/etc/modules-load.d` should also be initialised.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: base-files: initialise empty etc/modules-load.d folder
2021-02-27 21:25 [PR PATCH] base-files: initialise empty etc/modules-load.d folder NeelChotai
` (5 preceding siblings ...)
2021-03-01 9:55 ` NeelChotai
@ 2021-03-01 20:24 ` fosslinux
2021-03-01 20:26 ` ericonr
2021-03-01 20:27 ` [PR PATCH] [Merged]: " ericonr
8 siblings, 0 replies; 10+ messages in thread
From: fosslinux @ 2021-03-01 20:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
New comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/29099#issuecomment-788247101
Comment:
Hm, ok, that's fair.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: base-files: initialise empty etc/modules-load.d folder
2021-02-27 21:25 [PR PATCH] base-files: initialise empty etc/modules-load.d folder NeelChotai
` (6 preceding siblings ...)
2021-03-01 20:24 ` fosslinux
@ 2021-03-01 20:26 ` ericonr
2021-03-01 20:27 ` [PR PATCH] [Merged]: " ericonr
8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-03-01 20:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 233 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29099#issuecomment-788249313
Comment:
To avoid holding this up indefinitely, I'm pushing as is. Doing a bigger fix can come later.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Merged]: base-files: initialise empty etc/modules-load.d folder
2021-02-27 21:25 [PR PATCH] base-files: initialise empty etc/modules-load.d folder NeelChotai
` (7 preceding siblings ...)
2021-03-01 20:26 ` ericonr
@ 2021-03-01 20:27 ` ericonr
8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-03-01 20:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]
There's a merged pull request on the void-packages repository
base-files: initialise empty etc/modules-load.d folder
https://github.com/void-linux/void-packages/pull/29099
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-03-01 20:27 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-27 21:25 [PR PATCH] base-files: initialise empty etc/modules-load.d folder NeelChotai
2021-02-27 21:59 ` [PR PATCH] [Updated] " NeelChotai
2021-02-28 7:06 ` ericonr
2021-02-28 17:45 ` [PR PATCH] [Updated] " NeelChotai
2021-03-01 8:43 ` fosslinux
2021-03-01 9:55 ` NeelChotai
2021-03-01 9:55 ` NeelChotai
2021-03-01 20:24 ` fosslinux
2021-03-01 20:26 ` ericonr
2021-03-01 20:27 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).