[PR PATCH] browserpass: remove forced addon installation

[PR PATCH] browserpass: remove forced addon installation

[endigma]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

There is a new pull request by endigma against master on the void-packages repository

https://github.com/endigma/void-packages patch-4
https://github.com/void-linux/void-packages/pull/29122

browserpass: remove forced addon installation
browserpass package should not have forced managed addon installation. This extension should be packaged separately or installed manually.

A patch file from https://github.com/void-linux/void-packages/pull/29122.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-4-29122.patch --]
[-- Type: text/x-diff, Size: 1604 bytes --]

From 421c98c305e338b454facb57825e31712270cfe7 Mon Sep 17 00:00:00 2001
From: endigma <endigma4426@gmail.com>
Date: Sun, 28 Feb 2021 12:05:54 -0400
Subject: [PATCH] browserpass: remove forced addon installation

browserpass package should not have forced managed addon installation. This extension should be packaged separately or installed manually.
---
 srcpkgs/browserpass/template | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/srcpkgs/browserpass/template b/srcpkgs/browserpass/template
index b6426a24975..d1327a0d400 100644
--- a/srcpkgs/browserpass/template
+++ b/srcpkgs/browserpass/template
@@ -6,7 +6,7 @@ wrksrc="browserpass-native-${version}"
 build_style=go
 go_import_path=github.com/browserpass/browserpass-native
 hostmakedepends="git"
-short_desc="Browser extension for pass"
+short_desc="Native messaging host for browserpass
 maintainer="John <me@johnnynator.dev>"
 license="MIT"
 homepage="https://github.com/browserpass/browserpass-native"
@@ -20,14 +20,8 @@ post_build() {
 
 post_install() {
 	vlicense LICENSE
-
 	local targetname=com.github.browserpass.native.json
-
 	vinstall browser-files/firefox-host.json 644 usr/lib/mozilla/native-messaging-hosts $targetname
-
 	vinstall browser-files/chromium-host.json 644 etc/chromium/native-messaging-hosts $targetname
-	vinstall browser-files/chromium-policy.json 644 etc/chromium/policies/managed $targetname
-
 	vinstall browser-files/chromium-host.json 644 etc/opt/chrome/native-messaging-hosts $targetname
-	vinstall browser-files/chromium-policy.json 644 etc/opt/chrome/policies/managed $targetname
 }

Re: [PR REVIEW] browserpass: remove forced addon installation

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/29122#discussion_r584341823

Comment:
You missed forgot to add a `"` at the end

Re: [PR REVIEW] browserpass: remove forced addon installation

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/29122#discussion_r584341823

Comment:
You forgot to add a `"` at the end

Re: browserpass: remove forced addon installation

[endigma]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by endigma on void-packages repository

https://github.com/void-linux/void-packages/pull/29122#issuecomment-787547412

Comment:
Thanks, didn't see that.

>

Re: browserpass: remove forced addon installation

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29122#issuecomment-792442228

Comment:
@endigma please ping when you are done with changes :)

Re: browserpass: remove forced addon installation

[endigma]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New comment by endigma on void-packages repository

https://github.com/void-linux/void-packages/pull/29122#issuecomment-803394951

Comment:
Funny story, I nuked this branch on my fork, so in order to fix this I'll have to redo this.

Re: [PR PATCH] [Closed]: browserpass: remove forced addon installation

[endigma]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

There's a closed pull request on the void-packages repository

browserpass: remove forced addon installation
https://github.com/void-linux/void-packages/pull/29122

Description:
browserpass package should not have forced managed addon installation. This extension should be packaged separately or installed manually.