[PR PATCH] Bear: update to 3.0.8.

[PR PATCH] Bear: update to 3.0.8.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1757 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages bear
https://github.com/void-linux/void-packages/pull/29169

Bear: update to 3.0.8.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

I'm a bit hesitant on this one, https://github.com/rizsotto/Bear/issues gives the impression that the C++ rewrite generated lots of issues.

@Piraty @Johnnynator @ackalker 

A patch file from https://github.com/void-linux/void-packages/pull/29169.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bear-29169.patch --]
[-- Type: text/x-diff, Size: 1552 bytes --]

From 28af197f6d62d942162ac83bb8b028f04003d830 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 1 Mar 2021 20:23:11 -0300
Subject: [PATCH] Bear: update to 3.0.8.

---
 srcpkgs/Bear/template | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/Bear/template b/srcpkgs/Bear/template
index b2d8cd33765..50de8ba89e5 100644
--- a/srcpkgs/Bear/template
+++ b/srcpkgs/Bear/template
@@ -1,14 +1,20 @@
 # Template file for 'Bear'
 pkgname=Bear
-version=2.4.3
+version=3.0.8
 revision=1
 build_style=cmake
-hostmakedepends="python3"
-depends="python3"
+hostmakedepends="pkg-config protobuf grpc"
+makedepends="grpc-devel libressl-devel protobuf-devel sqlite-devel fmt-devel
+ json-c++ spdlog"
+checkdepends="gtest-devel"
 short_desc="Tool that generates a compilation database for clang tooling"
 maintainer="Alain Kalker <a.c.kalker@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/rizsotto/Bear"
-changelog="https://raw.githubusercontent.com/rizsotto/Bear/master/ChangeLog.md"
-distfiles="https://github.com/rizsotto/Bear/archive/${version}.tar.gz>${pkgname}-${version}.tar.gz"
-checksum=74057678642080d193a9f65a804612e1d5b87da5a1f82ee487bbc44eb34993f2
+distfiles="https://github.com/rizsotto/Bear/archive/${version}.tar.gz"
+checksum=663ef2fcf359e1efb20831fae3901a3edbbb906dd0bc5e62af92e353651c5cec
+
+# paths in gtest.pc for cross are broken
+if [ -z "$XBPS_CHECK_PKGS" ]; then
+	configure_args="-DENABLE_UNIT_TESTS=OFF -DENABLE_FUNC_TESTS=OFF"
+fi

Re: [PR PATCH] [Updated] Bear: update to 3.0.8.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1762 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages bear
https://github.com/void-linux/void-packages/pull/29169

Bear: update to 3.0.8.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

I'm a bit hesitant on this one, https://github.com/rizsotto/Bear/issues gives the impression that the C++ rewrite generated lots of issues.

@Piraty @Johnnynator @ackalker 

A patch file from https://github.com/void-linux/void-packages/pull/29169.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bear-29169.patch --]
[-- Type: text/x-diff, Size: 3201 bytes --]

From f7848a24b0e0541f77cdba1a7ccbe99a37e4ea11 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 1 Mar 2021 20:28:53 -0300
Subject: [PATCH 1/2] grpc: add libressl-devel to grpc-devel.

Noticed dependency was required when building new Bear.
---
 srcpkgs/grpc/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/grpc/template b/srcpkgs/grpc/template
index e915c4322b8..a2d328497b0 100644
--- a/srcpkgs/grpc/template
+++ b/srcpkgs/grpc/template
@@ -1,7 +1,7 @@
 # Template file for 'grpc'
 pkgname=grpc
 version=1.36.0
-revision=1
+revision=2
 _abseilver=6f9d96a1f41439ac172ee2ef7ccd8edf0e5d068c
 build_style=cmake
 configure_args="-DBUILD_SHARED_LIBS=ON
@@ -10,8 +10,8 @@ configure_args="-DBUILD_SHARED_LIBS=ON
  -D_gRPC_RE2_LIBRARIES=${XBPS_CROSS_BASE}/usr/lib/libre2.so
  -D_gRPC_RE2_INCLUDE_DIR=${XBPS_CROSS_BASE}/usr/include"
 hostmakedepends="which protobuf"
-makedepends="zlib-devel c-ares-devel libressl-devel
- libprotoc-devel protobuf-devel gperftools-devel re2-devel"
+_devel_depends="c-ares-devel re2-devel zlib-devel libressl-devel"
+makedepends="libprotoc-devel protobuf-devel gperftools-devel ${_devel_depends}"
 short_desc="High performance, open source, general RPC framework"
 maintainer="Andrew J. Hesford <ajh@sideband.org>"
 license="Apache-2.0"
@@ -58,7 +58,7 @@ post_install() {
 
 grpc-devel_package() {
 	short_desc+=" - development files"
-	depends="${sourcepkg}>=${version}_${revision} c-ares-devel re2-devel zlib-devel"
+	depends="${sourcepkg}>=${version}_${revision} ${_devel_depends}"
 	pkg_install() {
 		vmove usr/include
 		vmove usr/lib/*.so

From cacd333e020016453f51de2f27f8bbf8634c89f1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 1 Mar 2021 20:23:11 -0300
Subject: [PATCH 2/2] Bear: update to 3.0.8.

---
 srcpkgs/Bear/template | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/Bear/template b/srcpkgs/Bear/template
index b2d8cd33765..e0f64aeec75 100644
--- a/srcpkgs/Bear/template
+++ b/srcpkgs/Bear/template
@@ -1,14 +1,20 @@
 # Template file for 'Bear'
 pkgname=Bear
-version=2.4.3
+version=3.0.8
 revision=1
 build_style=cmake
-hostmakedepends="python3"
-depends="python3"
+hostmakedepends="pkg-config protobuf grpc"
+makedepends="grpc-devel protobuf-devel sqlite-devel fmt-devel
+ json-c++ spdlog"
+checkdepends="gtest-devel"
 short_desc="Tool that generates a compilation database for clang tooling"
 maintainer="Alain Kalker <a.c.kalker@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/rizsotto/Bear"
-changelog="https://raw.githubusercontent.com/rizsotto/Bear/master/ChangeLog.md"
-distfiles="https://github.com/rizsotto/Bear/archive/${version}.tar.gz>${pkgname}-${version}.tar.gz"
-checksum=74057678642080d193a9f65a804612e1d5b87da5a1f82ee487bbc44eb34993f2
+distfiles="https://github.com/rizsotto/Bear/archive/${version}.tar.gz"
+checksum=663ef2fcf359e1efb20831fae3901a3edbbb906dd0bc5e62af92e353651c5cec
+
+# paths in gtest.pc for cross are broken
+if [ -z "$XBPS_CHECK_PKGS" ]; then
+	configure_args="-DENABLE_UNIT_TESTS=OFF -DENABLE_FUNC_TESTS=OFF"
+fi

Re: Bear: update to 3.0.8.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/29169#issuecomment-788424423

Comment:
The gRPC dependency changes are fine by me. 

Re: Bear: update to 3.0.8.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29169#issuecomment-789142233

Comment:
The new Bear version seems generally worse, so I am very hesitant to merge the udpate. Not sure there's anything we're missing by not having it.

Re: Bear: update to 3.0.8.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/29169#issuecomment-789197082

Comment:
> The new Bear version seems generally worse, so I am very hesitant to merge the udpate. Not sure there's anything we're missing by not having it.

Just update to 2.4.4. instead :P.
I haven't really used Bear in quite some time now, but reading the release notes, I do not see any "new" features, just mostly bug fixes of the c++ rewrite.

Re: Bear: update to 3.0.8.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/29169#issuecomment-789197082

Comment:
> The new Bear version seems generally worse, so I am very hesitant to merge the udpate. Not sure there's anything we're missing by not having it.

Just update to 2.4.4. instead :D.
I haven't really used Bear in quite some time now, but reading the release notes, I do not see any "new" features, just mostly bug fixes of the c++ rewrite.

Re: Bear: update to 3.0.8.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29169#issuecomment-789328037

Comment:
Closing for now.

Re: [PR PATCH] [Closed]: Bear: update to 3.0.8.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1609 bytes --]

There's a closed pull request on the void-packages repository

Bear: update to 3.0.8.
https://github.com/void-linux/void-packages/pull/29169

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

I'm a bit hesitant on this one, https://github.com/rizsotto/Bear/issues gives the impression that the C++ rewrite generated lots of issues.

@Piraty @Johnnynator @ackalker