Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] slirp4netns: update to 1.1.9.
@ 2021-03-01  0:02 CameronNemo
  2021-03-01 19:47 ` [PR REVIEW] " ericonr
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: CameronNemo @ 2021-03-01  0:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

There is a new pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages slirp4netns-1.1.9
https://github.com/void-linux/void-packages/pull/29144

slirp4netns: update to 1.1.9.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (`x86_64{,-musl}`)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64 (cross)
  - [x] aarch64-musl (cross)


A patch file from https://github.com/void-linux/void-packages/pull/29144.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-slirp4netns-1.1.9-29144.patch --]
[-- Type: text/x-diff, Size: 1192 bytes --]

From 9e70bc340bc1556f8b9b48ecebbbf14b99d32251 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Sun, 28 Feb 2021 15:56:41 -0800
Subject: [PATCH] slirp4netns: update to 1.1.9.

---
 srcpkgs/slirp4netns/template | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/slirp4netns/template b/srcpkgs/slirp4netns/template
index c228db1ecd0..f857e3713ac 100644
--- a/srcpkgs/slirp4netns/template
+++ b/srcpkgs/slirp4netns/template
@@ -1,6 +1,6 @@
 # Template file for 'slirp4netns'
 pkgname=slirp4netns
-version=1.1.7
+version=1.1.9
 revision=1
 build_style=gnu-configure
 hostmakedepends="autoconf automake pkg-config"
@@ -10,8 +10,12 @@ maintainer="Cameron Nemo <cnemo@tutanota.com>"
 license="GPL-2.0-only"
 homepage="https://github.com/rootless-containers/slirp4netns"
 distfiles="https://github.com/rootless-containers/slirp4netns/archive/v${version}.tar.gz"
-checksum=5c9e4dd7d99683a0c9ba8509aec865245604db83359ff1b7c99f9f3ae1569a28
+checksum=5ff0d3e4bf6b11c8a4fcf5bd3219b8d52096e3b8cc73ca760aa554bb1eb08768
 
 pre_configure() {
 	./autogen.sh
 }
+
+do_check() {
+	: # tests fail due to use of unshare (unavailable with chroot util-linux)
+}

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR REVIEW] slirp4netns: update to 1.1.9.
  2021-03-01  0:02 [PR PATCH] slirp4netns: update to 1.1.9 CameronNemo
@ 2021-03-01 19:47 ` ericonr
  2021-03-02  2:40 ` [PR PATCH] [Updated] " CameronNemo
  2021-03-02  2:41 ` [PR REVIEW] " CameronNemo
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2021-03-01 19:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29144#discussion_r585002142

Comment:
This should be using `make_check=no` or maybe `make_check=extended` if it works when ran locally.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Updated] slirp4netns: update to 1.1.9.
  2021-03-01  0:02 [PR PATCH] slirp4netns: update to 1.1.9 CameronNemo
  2021-03-01 19:47 ` [PR REVIEW] " ericonr
@ 2021-03-02  2:40 ` CameronNemo
  2021-03-02  2:41 ` [PR REVIEW] " CameronNemo
  2 siblings, 0 replies; 4+ messages in thread
From: CameronNemo @ 2021-03-02  2:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1582 bytes --]

There is an updated pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages slirp4netns-1.1.9
https://github.com/void-linux/void-packages/pull/29144

slirp4netns: update to 1.1.9.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (`x86_64{,-musl}`)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64 (cross)
  - [x] aarch64-musl (cross)


A patch file from https://github.com/void-linux/void-packages/pull/29144.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-slirp4netns-1.1.9-29144.patch --]
[-- Type: text/x-diff, Size: 1179 bytes --]

From 4a9d72ee89353058bad483d6ea8683668a183ed6 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Sun, 28 Feb 2021 15:56:41 -0800
Subject: [PATCH] slirp4netns: update to 1.1.9.

---
 srcpkgs/slirp4netns/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/slirp4netns/template b/srcpkgs/slirp4netns/template
index c228db1ecd0..c3dd3433214 100644
--- a/srcpkgs/slirp4netns/template
+++ b/srcpkgs/slirp4netns/template
@@ -1,6 +1,6 @@
 # Template file for 'slirp4netns'
 pkgname=slirp4netns
-version=1.1.7
+version=1.1.9
 revision=1
 build_style=gnu-configure
 hostmakedepends="autoconf automake pkg-config"
@@ -10,7 +10,9 @@ maintainer="Cameron Nemo <cnemo@tutanota.com>"
 license="GPL-2.0-only"
 homepage="https://github.com/rootless-containers/slirp4netns"
 distfiles="https://github.com/rootless-containers/slirp4netns/archive/v${version}.tar.gz"
-checksum=5c9e4dd7d99683a0c9ba8509aec865245604db83359ff1b7c99f9f3ae1569a28
+checksum=5ff0d3e4bf6b11c8a4fcf5bd3219b8d52096e3b8cc73ca760aa554bb1eb08768
+# tests fail due to use of unshare (unavailable with chroot util-linux)
+make_check=no
 
 pre_configure() {
 	./autogen.sh

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR REVIEW] slirp4netns: update to 1.1.9.
  2021-03-01  0:02 [PR PATCH] slirp4netns: update to 1.1.9 CameronNemo
  2021-03-01 19:47 ` [PR REVIEW] " ericonr
  2021-03-02  2:40 ` [PR PATCH] [Updated] " CameronNemo
@ 2021-03-02  2:41 ` CameronNemo
  2 siblings, 0 replies; 4+ messages in thread
From: CameronNemo @ 2021-03-02  2:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New review comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/29144#discussion_r585205518

Comment:
done

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-02  2:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01  0:02 [PR PATCH] slirp4netns: update to 1.1.9 CameronNemo
2021-03-01 19:47 ` [PR REVIEW] " ericonr
2021-03-02  2:40 ` [PR PATCH] [Updated] " CameronNemo
2021-03-02  2:41 ` [PR REVIEW] " CameronNemo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).