* [PR PATCH] fish-shell: update to 3.2.0
@ 2021-03-01 16:32 FollieHiyuki
2021-03-01 16:44 ` FollieHiyuki
` (9 more replies)
0 siblings, 10 replies; 11+ messages in thread
From: FollieHiyuki @ 2021-03-01 16:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1631 bytes --]
There is a new pull request by FollieHiyuki against master on the void-packages repository
https://github.com/FollieHiyuki/void-packages fish-shell
https://github.com/void-linux/void-packages/pull/29165
fish-shell: update to 3.2.0
From 3.2.0 onward, the distfiles will be in XZ format
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29165.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fish-shell-29165.patch --]
[-- Type: text/x-diff, Size: 1469 bytes --]
From c5ac569dedd5a8d68df1b3403875bd8ff4c0d0c8 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Mon, 1 Mar 2021 19:25:36 +0300
Subject: [PATCH] fish-shell: update to 3.2.0
From 3.2.0 onward, the distfiles will be in XZ format
---
srcpkgs/fish-shell/template | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/fish-shell/template b/srcpkgs/fish-shell/template
index 82c5969f599..55ecbdca12f 100644
--- a/srcpkgs/fish-shell/template
+++ b/srcpkgs/fish-shell/template
@@ -1,18 +1,19 @@
# Template file for 'fish-shell'
pkgname=fish-shell
-version=3.1.2
-revision=2
+version=3.2.0
+revision=1
wrksrc="fish-${version}"
build_style=cmake
hostmakedepends="gettext"
makedepends="ncurses-devel pcre2-devel gettext-devel"
depends="groff"
+checkdepends="python3-pexpect procps-ng"
short_desc="User friendly shell intended mostly for interactive use"
maintainer="Nathan Owens <ndowens04@gmail.com>"
license="GPL-2.0-only"
homepage="https://fishshell.com/"
-distfiles="https://github.com/fish-shell/fish-shell/releases/download/${version}/fish-${version}.tar.gz"
-checksum=d5b927203b5ca95da16f514969e2a91a537b2f75bec9b21a584c4cd1c7aa74ed
+distfiles="https://github.com/fish-shell/fish-shell/releases/download/${version}/fish-${version}.tar.xz"
+checksum=4f0293ed9f6a6b77e47d41efabe62f3319e86efc8bf83cc58733044fbc6f9211
register_shell="/bin/fish /usr/bin/fish"
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: fish-shell: update to 3.2.0
2021-03-01 16:32 [PR PATCH] fish-shell: update to 3.2.0 FollieHiyuki
@ 2021-03-01 16:44 ` FollieHiyuki
2021-03-01 18:30 ` FollieHiyuki
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: FollieHiyuki @ 2021-03-01 16:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
New comment by FollieHiyuki on void-packages repository
https://github.com/void-linux/void-packages/pull/29165#issuecomment-788096086
Comment:
The `cd` test fails because the build is in a root environment. All tests run successfully locally for me.
I have only used this for about an hour. No problem so far.
I don't use most of the stuff that are mentioned in the changelog regularly, so ping @ericonr for further testing ability, since I know he uses `fish-shell` too.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: fish-shell: update to 3.2.0
2021-03-01 16:32 [PR PATCH] fish-shell: update to 3.2.0 FollieHiyuki
2021-03-01 16:44 ` FollieHiyuki
@ 2021-03-01 18:30 ` FollieHiyuki
2021-03-01 18:38 ` ericonr
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: FollieHiyuki @ 2021-03-01 18:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
New comment by FollieHiyuki on void-packages repository
https://github.com/void-linux/void-packages/pull/29165#issuecomment-788171242
Comment:
Isn't `rm -f` better? I'm fine with either of them
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: fish-shell: update to 3.2.0
2021-03-01 16:32 [PR PATCH] fish-shell: update to 3.2.0 FollieHiyuki
2021-03-01 16:44 ` FollieHiyuki
2021-03-01 18:30 ` FollieHiyuki
@ 2021-03-01 18:38 ` ericonr
2021-03-01 18:38 ` ericonr
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-03-01 18:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 356 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29165#issuecomment-788176554
Comment:
I prefer to use `rm` because it errors out if the file stops being installed, which would mean we no longer need to have that command. That said, I think this file should be installed to `/etc`, not to `/usr/etc`...
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: fish-shell: update to 3.2.0
2021-03-01 16:32 [PR PATCH] fish-shell: update to 3.2.0 FollieHiyuki
` (2 preceding siblings ...)
2021-03-01 18:38 ` ericonr
@ 2021-03-01 18:38 ` ericonr
2021-03-01 19:06 ` FollieHiyuki
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-03-01 18:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 446 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29165#issuecomment-788176554
Comment:
I prefer to use `rm` because it errors out if the file stops being installed, which would mean we no longer need to have that command. That said, I think this file should be installed to `/etc`, not to `/usr/etc`...
But then it'd also have to become a conf file and ...
So easier to just rm for now.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: fish-shell: update to 3.2.0
2021-03-01 16:32 [PR PATCH] fish-shell: update to 3.2.0 FollieHiyuki
` (3 preceding siblings ...)
2021-03-01 18:38 ` ericonr
@ 2021-03-01 19:06 ` FollieHiyuki
2021-03-01 19:07 ` [PR PATCH] [Updated] " FollieHiyuki
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: FollieHiyuki @ 2021-03-01 19:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
New comment by FollieHiyuki on void-packages repository
https://github.com/void-linux/void-packages/pull/29165#issuecomment-788194451
Comment:
Ok I'll change to `rm`. Sounds reasonable :)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] fish-shell: update to 3.2.0
2021-03-01 16:32 [PR PATCH] fish-shell: update to 3.2.0 FollieHiyuki
` (4 preceding siblings ...)
2021-03-01 19:06 ` FollieHiyuki
@ 2021-03-01 19:07 ` FollieHiyuki
2021-03-02 19:07 ` [PR PATCH] [Merged]: " ericonr
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: FollieHiyuki @ 2021-03-01 19:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]
There is an updated pull request by FollieHiyuki against master on the void-packages repository
https://github.com/FollieHiyuki/void-packages fish-shell
https://github.com/void-linux/void-packages/pull/29165
fish-shell: update to 3.2.0
From 3.2.0 onward, the distfiles will be in XZ format
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29165.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fish-shell-29165.patch --]
[-- Type: text/x-diff, Size: 1677 bytes --]
From c884199cfe26be03db069b05cece59fea49b595f Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Mon, 1 Mar 2021 19:25:36 +0300
Subject: [PATCH] fish-shell: update to 3.2.0
From 3.2.0 onward, the distfiles will be in XZ format
---
srcpkgs/fish-shell/template | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/fish-shell/template b/srcpkgs/fish-shell/template
index 82c5969f599..250c07b7fe1 100644
--- a/srcpkgs/fish-shell/template
+++ b/srcpkgs/fish-shell/template
@@ -1,18 +1,19 @@
# Template file for 'fish-shell'
pkgname=fish-shell
-version=3.1.2
-revision=2
+version=3.2.0
+revision=1
wrksrc="fish-${version}"
build_style=cmake
hostmakedepends="gettext"
makedepends="ncurses-devel pcre2-devel gettext-devel"
depends="groff"
+checkdepends="python3-pexpect procps-ng"
short_desc="User friendly shell intended mostly for interactive use"
maintainer="Nathan Owens <ndowens04@gmail.com>"
license="GPL-2.0-only"
homepage="https://fishshell.com/"
-distfiles="https://github.com/fish-shell/fish-shell/releases/download/${version}/fish-${version}.tar.gz"
-checksum=d5b927203b5ca95da16f514969e2a91a537b2f75bec9b21a584c4cd1c7aa74ed
+distfiles="https://github.com/fish-shell/fish-shell/releases/download/${version}/fish-${version}.tar.xz"
+checksum=4f0293ed9f6a6b77e47d41efabe62f3319e86efc8bf83cc58733044fbc6f9211
register_shell="/bin/fish /usr/bin/fish"
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
@@ -21,5 +22,5 @@ fi
post_install() {
# Starting with fish-3.0.0 this is a skeleton file with only comments
- rm -f "${DESTDIR}/usr/etc/fish/config.fish"
+ rm "${DESTDIR}/usr/etc/fish/config.fish"
}
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Merged]: fish-shell: update to 3.2.0
2021-03-01 16:32 [PR PATCH] fish-shell: update to 3.2.0 FollieHiyuki
` (5 preceding siblings ...)
2021-03-01 19:07 ` [PR PATCH] [Updated] " FollieHiyuki
@ 2021-03-02 19:07 ` ericonr
2021-03-03 13:33 ` FollieHiyuki
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-03-02 19:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]
There's a merged pull request on the void-packages repository
fish-shell: update to 3.2.0
https://github.com/void-linux/void-packages/pull/29165
Description:
From 3.2.0 onward, the distfiles will be in XZ format
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: fish-shell: update to 3.2.0
2021-03-01 16:32 [PR PATCH] fish-shell: update to 3.2.0 FollieHiyuki
` (6 preceding siblings ...)
2021-03-02 19:07 ` [PR PATCH] [Merged]: " ericonr
@ 2021-03-03 13:33 ` FollieHiyuki
2021-03-03 13:36 ` FollieHiyuki
2021-03-03 14:36 ` ericonr
9 siblings, 0 replies; 11+ messages in thread
From: FollieHiyuki @ 2021-03-03 13:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New comment by FollieHiyuki on void-packages repository
https://github.com/void-linux/void-packages/pull/29165#issuecomment-789716619
Comment:
@ericonr `fish-shell` doesn't seem to get updated in the repo for musl
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: fish-shell: update to 3.2.0
2021-03-01 16:32 [PR PATCH] fish-shell: update to 3.2.0 FollieHiyuki
` (7 preceding siblings ...)
2021-03-03 13:33 ` FollieHiyuki
@ 2021-03-03 13:36 ` FollieHiyuki
2021-03-03 14:36 ` ericonr
9 siblings, 0 replies; 11+ messages in thread
From: FollieHiyuki @ 2021-03-03 13:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 319 bytes --]
New comment by FollieHiyuki on void-packages repository
https://github.com/void-linux/void-packages/pull/29165#issuecomment-789716619
Comment:
@ericonr `fish-shell` doesn't seem to get updated in the repo for musl.
Same as https://github.com/void-linux/void-packages/commit/e57831325203506743c062795009193c23c8023d?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: fish-shell: update to 3.2.0
2021-03-01 16:32 [PR PATCH] fish-shell: update to 3.2.0 FollieHiyuki
` (8 preceding siblings ...)
2021-03-03 13:36 ` FollieHiyuki
@ 2021-03-03 14:36 ` ericonr
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-03-03 14:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29165#issuecomment-789758795
Comment:
Indeed it wasn't, together with a few others, I'm checking which. Thanks for noticing.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-03-03 14:36 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 16:32 [PR PATCH] fish-shell: update to 3.2.0 FollieHiyuki
2021-03-01 16:44 ` FollieHiyuki
2021-03-01 18:30 ` FollieHiyuki
2021-03-01 18:38 ` ericonr
2021-03-01 18:38 ` ericonr
2021-03-01 19:06 ` FollieHiyuki
2021-03-01 19:07 ` [PR PATCH] [Updated] " FollieHiyuki
2021-03-02 19:07 ` [PR PATCH] [Merged]: " ericonr
2021-03-03 13:33 ` FollieHiyuki
2021-03-03 13:36 ` FollieHiyuki
2021-03-03 14:36 ` ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).