[PR PATCH] bind: remove obsolete configuration options

[PR PATCH] bind: remove obsolete configuration options

[heliocat]

[-- Attachment #1: Type: text/plain, Size: 1610 bytes --]

There is a new pull request by heliocat against master on the void-packages repository

https://github.com/heliocat/void-packages bind
https://github.com/void-linux/void-packages/pull/29241

bind: remove obsolete configuration options
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_84-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

Fixes #28351 

A patch file from https://github.com/void-linux/void-packages/pull/29241.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bind-29241.patch --]
[-- Type: text/x-diff, Size: 1613 bytes --]

From e9d2094364550fcafea2d5e054b0f94c531d7af8 Mon Sep 17 00:00:00 2001
From: Colin Booth <colin@heliocat.net>
Date: Thu, 4 Mar 2021 18:47:28 -0800
Subject: [PATCH] bind: remove obsolete configuration options

---
 srcpkgs/bind/template | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/bind/template b/srcpkgs/bind/template
index f7eb103ce98..25f32df7139 100644
--- a/srcpkgs/bind/template
+++ b/srcpkgs/bind/template
@@ -5,14 +5,10 @@ revision=1
 _fullver="${version}${_patchver:+-${_patchver}}"
 wrksrc="${pkgname}-${_fullver}"
 build_style=gnu-configure
-configure_args="--disable-static --enable-threads --enable-largefile
- --with-libtool --enable-atomic --sysconfdir=/etc/named --enable-epoll
- --enable-ipv6 --with-randomdev=/dev/random --with-ecdsa=yes --with-eddsa=no
- --with-libtool --with-openssl=${XBPS_CROSS_BASE}/usr --with-gssapi=/usr/bin
- --without-gost --enable-openssl-hash --with-readline --with-tuning=default
- --without-python --enable-fetchlimit --enable-sit
- --with-libidn2 --disable-backtrace
- $(vopt_if geoip "--with-geoip=${XBPS_CROSS_BASE}/usr" "--without-geoip")"
+configure_args="--disable-static --enable-largefile --with-libtool
+ --sysconfdir=/etc/named --enable-epoll --with-openssl=${XBPS_CROSS_BASE}/usr
+ --with-gssapi=/usr/bin --with-readline --with-tuning=default --without-python
+ --with-libidn2 --disable-backtrace"
 hostmakedepends="automake libtool perl pkg-config"
 makedepends="libressl-devel libxml2-devel libcap-devel readline-devel mit-krb5-devel
  libatomic-devel libidn2-devel libuv-devel $(vopt_if geoip geoip-devel)"

Re: bind: remove obsolete configuration options

[heliocat]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/29241#issuecomment-791114641

Comment:
@ericonr 

Re: [PR REVIEW] bind: remove obsolete configuration options

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29241#discussion_r588009175

Comment:
Is `geoip` automatically detected now?

Re: [PR REVIEW] bind: remove obsolete configuration options

[heliocat]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New review comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/29241#discussion_r588017278

Comment:
  --disable-geoip         support GeoIP2 geolocation ACLs if available [default=yes]

So yes. That reminds me, I was going to include my findings from the ticket in the commit message.

Re: [PR PATCH] [Updated] bind: remove obsolete configuration options

[heliocat]

[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]

There is an updated pull request by heliocat against master on the void-packages repository

https://github.com/heliocat/void-packages bind
https://github.com/void-linux/void-packages/pull/29241

bind: remove obsolete configuration options
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_84-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

Fixes #28351 

A patch file from https://github.com/void-linux/void-packages/pull/29241.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bind-29241.patch --]
[-- Type: text/x-diff, Size: 2436 bytes --]

From 3c1668b8f9035ece8af9887adf7c3bdfa71aa8e7 Mon Sep 17 00:00:00 2001
From: Colin Booth <colin@heliocat.net>
Date: Thu, 4 Mar 2021 18:47:28 -0800
Subject: [PATCH] bind: remove obsolete configuration options

Removed options:
--enable-atomic - removed 9.13.3 (commit 5024)
--enable-fetchlimit - removed pre-bind9
--enable-ipv6 - made default 9.14
--enable-openssl-hash - removed 9.14, default was already yes
--enable-seccomp - removed 9.13.0 (commit 4898)
--enable-sit - removed 9.11, replaced with DNS COOKIE option in configs (commit 4152)
--enable-threads - on-threaded support removed 9.13.3 (commit 5011)
--with-ecdsa - comes from openssl availability (removed 9.14)
--with-eddsa - comes from openssl availability (removed 9.14)
--with-geoip - marked as obsolete in 9.16
--with-randomdev - removed 9.13.0 (commit 4936)
--without-gost - GOST support removed 9.13.1 (commit 4961)

There don't seem to be any new options added that seem like must-haves,
so unless someone speaks up I'm not going to be adding anything right
now.
---
 srcpkgs/bind/template | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/bind/template b/srcpkgs/bind/template
index f7eb103ce98..25f32df7139 100644
--- a/srcpkgs/bind/template
+++ b/srcpkgs/bind/template
@@ -5,14 +5,10 @@ revision=1
 _fullver="${version}${_patchver:+-${_patchver}}"
 wrksrc="${pkgname}-${_fullver}"
 build_style=gnu-configure
-configure_args="--disable-static --enable-threads --enable-largefile
- --with-libtool --enable-atomic --sysconfdir=/etc/named --enable-epoll
- --enable-ipv6 --with-randomdev=/dev/random --with-ecdsa=yes --with-eddsa=no
- --with-libtool --with-openssl=${XBPS_CROSS_BASE}/usr --with-gssapi=/usr/bin
- --without-gost --enable-openssl-hash --with-readline --with-tuning=default
- --without-python --enable-fetchlimit --enable-sit
- --with-libidn2 --disable-backtrace
- $(vopt_if geoip "--with-geoip=${XBPS_CROSS_BASE}/usr" "--without-geoip")"
+configure_args="--disable-static --enable-largefile --with-libtool
+ --sysconfdir=/etc/named --enable-epoll --with-openssl=${XBPS_CROSS_BASE}/usr
+ --with-gssapi=/usr/bin --with-readline --with-tuning=default --without-python
+ --with-libidn2 --disable-backtrace"
 hostmakedepends="automake libtool perl pkg-config"
 makedepends="libressl-devel libxml2-devel libcap-devel readline-devel mit-krb5-devel
  libatomic-devel libidn2-devel libuv-devel $(vopt_if geoip geoip-devel)"

Re: bind: remove obsolete configuration options

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 143 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29241#issuecomment-792447374

Comment:
<3

Re: [PR PATCH] [Merged]: bind: remove obsolete configuration options

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]

There's a merged pull request on the void-packages repository

bind: remove obsolete configuration options
https://github.com/void-linux/void-packages/pull/29241

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_84-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

Fixes #28351