Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] pipewire: update to 0.3.23
@ 2021-03-04 20:35 st3r4g
  2021-03-08  3:25 ` ericonr
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: st3r4g @ 2021-03-04 20:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1956 bytes --]

There is a new pull request by st3r4g against master on the void-packages repository

https://github.com/st3r4g/void-packages pipewire-0.3.23
https://github.com/void-linux/void-packages/pull/29228

pipewire: update to 0.3.23
In 0.3.23 the config does not autostart pipewire-media-session anymore, which is essential for everything, from audio to screen-sharing. It cannot be started externally in a script since it needs the pipewire socket up, and void doesn't have a mechanism to ensure it (systemd socket activation). So let's "uncomment the comment" to keep the current behavior.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29228.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.23-29228.patch --]
[-- Type: text/x-diff, Size: 2115 bytes --]

From 51964548db4f4393192b9b072d67477c346d71a4 Mon Sep 17 00:00:00 2001
From: Stefano Ragni <stefano.ragni@outlook.com>
Date: Thu, 4 Mar 2021 16:33:30 +0100
Subject: [PATCH] pipewire: update to 0.3.23

---
 .../pipewire/patches/autostart-media-session.patch    | 11 +++++++++++
 srcpkgs/pipewire/template                             |  4 ++--
 2 files changed, 13 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/pipewire/patches/autostart-media-session.patch

diff --git a/srcpkgs/pipewire/patches/autostart-media-session.patch b/srcpkgs/pipewire/patches/autostart-media-session.patch
new file mode 100644
index 00000000000..2051a868d46
--- /dev/null
+++ b/srcpkgs/pipewire/patches/autostart-media-session.patch
@@ -0,0 +1,11 @@
+--- src/daemon/pipewire.conf.in.orig	2021-03-04 16:54:52.950015583 +0100
++++ src/daemon/pipewire.conf.in	2021-03-04 16:55:13.766016281 +0100
+@@ -203,7 +203,7 @@
+     # but it is better to start it as a systemd service.
+     # Run the session manager with -h for options.
+     #
+-    @comment@"@media_session_path@" = { args = "" }
++    "@media_session_path@" = { args = "" }
+     #
+     # You can optionally start the pulseaudio-server here as well
+     # but it is better to start it as a systemd service.
diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 7072e95fa01..7a7a6199a1b 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.22
+version=0.3.23
 revision=1
 build_style=meson
 configure_args="-Dman=true -Dgstreamer=true -Ddocs=true -Dsystemd=false
@@ -18,7 +18,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=5db2caf41af79cd9e343d07a3804c63b8b243c1d74e926181058e29771d4b691
+checksum=e9a9030032ba8f3b6f9e300dbf755ab439340cd4cbeb3e1bba6f1a18d2c9da92
 conf_files="/etc/pipewire/pipewire.conf"
 
 replaces="libpulseaudio-pipewire>=0"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: pipewire: update to 0.3.23
  2021-03-04 20:35 [PR PATCH] pipewire: update to 0.3.23 st3r4g
@ 2021-03-08  3:25 ` ericonr
  2021-03-08  3:26 ` [PR PATCH] [Merged]: " ericonr
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-03-08  3:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29228#issuecomment-792434646

Comment:
Could you talk to upstream about coming up with a better solution?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: pipewire: update to 0.3.23
  2021-03-04 20:35 [PR PATCH] pipewire: update to 0.3.23 st3r4g
  2021-03-08  3:25 ` ericonr
@ 2021-03-08  3:26 ` ericonr
  2021-03-08  8:18 ` st3r4g
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-03-08  3:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]

There's a merged pull request on the void-packages repository

pipewire: update to 0.3.23
https://github.com/void-linux/void-packages/pull/29228

Description:
In 0.3.23 the config does not autostart pipewire-media-session anymore, which is essential for everything, from audio to screen-sharing. It's not easy to start externally in a script since it needs the pipewire socket up, and void doesn't have a mechanism to ensure it (systemd socket activation). So let's "uncomment the comment" to keep the current behavior.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: pipewire: update to 0.3.23
  2021-03-04 20:35 [PR PATCH] pipewire: update to 0.3.23 st3r4g
  2021-03-08  3:25 ` ericonr
  2021-03-08  3:26 ` [PR PATCH] [Merged]: " ericonr
@ 2021-03-08  8:18 ` st3r4g
  2021-03-08 18:08 ` ericonr
  2021-03-08 18:08 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: st3r4g @ 2021-03-08  8:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/29228#issuecomment-792566970

Comment:
afaik there's no problem with launching it in the config, it is functionally equivalent and it's the intended way for systems without systemd.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: pipewire: update to 0.3.23
  2021-03-04 20:35 [PR PATCH] pipewire: update to 0.3.23 st3r4g
                   ` (2 preceding siblings ...)
  2021-03-08  8:18 ` st3r4g
@ 2021-03-08 18:08 ` ericonr
  2021-03-08 18:08 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-03-08 18:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29228#issuecomment-792960011

Comment:
Better solution in this case would be us not having to ship the patch forever :)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: pipewire: update to 0.3.23
  2021-03-04 20:35 [PR PATCH] pipewire: update to 0.3.23 st3r4g
                   ` (3 preceding siblings ...)
  2021-03-08 18:08 ` ericonr
@ 2021-03-08 18:08 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-03-08 18:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29228#issuecomment-792960339

Comment:
And add a comment to the patch for the next update as well, please.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-03-08 18:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-04 20:35 [PR PATCH] pipewire: update to 0.3.23 st3r4g
2021-03-08  3:25 ` ericonr
2021-03-08  3:26 ` [PR PATCH] [Merged]: " ericonr
2021-03-08  8:18 ` st3r4g
2021-03-08 18:08 ` ericonr
2021-03-08 18:08 ` ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).