Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] serd: update to 0.30.10.
@ 2021-03-08 14:35 tibequadorian
  2021-03-08 16:08 ` [PR REVIEW] " ericonr
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: tibequadorian @ 2021-03-08 14:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1611 bytes --]

There is a new pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages serd
https://github.com/void-linux/void-packages/pull/29317

serd: update to 0.30.10.
enable tests

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29317.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-serd-29317.patch --]
[-- Type: text/x-diff, Size: 1117 bytes --]

From 9e087206beb11b70b311ec84ca8cb4805f3001a7 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 8 Mar 2021 15:35:16 +0100
Subject: [PATCH] serd: update to 0.30.10.

enable tests
---
 srcpkgs/serd/template | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/serd/template b/srcpkgs/serd/template
index f639412f20c..b024f166830 100644
--- a/srcpkgs/serd/template
+++ b/srcpkgs/serd/template
@@ -1,6 +1,6 @@
 # Template file for 'serd'
 pkgname=serd
-version=0.30.6
+version=0.30.10
 revision=1
 build_style=waf3
 short_desc="Lightweight C library for RDF syntax"
@@ -8,7 +8,15 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="ISC"
 homepage="http://drobilla.net/software/serd/"
 distfiles="http://download.drobilla.net/${pkgname}-${version}.tar.bz2"
-checksum=f5a2c74c659d8b318059068f135a43a3771491c367b6947e053a713b23cd37ef
+checksum=affa80deec78921f86335e6fc3f18b80aefecf424f6a5755e9f2fa0eb0710edf
+
+if [ "${XBPS_CHECK_PKGS}" ]; then
+	configure_args+=" --test"
+fi
+
+do_check() {
+	./waf test
+}
 
 post_install() {
 	vlicense COPYING

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] serd: update to 0.30.10.
  2021-03-08 14:35 [PR PATCH] serd: update to 0.30.10 tibequadorian
@ 2021-03-08 16:08 ` ericonr
  2021-03-08 16:17 ` tibequadorian
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-03-08 16:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29317#discussion_r589544273

Comment:
Maybe we can add this to the build style? what do you think?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] serd: update to 0.30.10.
  2021-03-08 14:35 [PR PATCH] serd: update to 0.30.10 tibequadorian
  2021-03-08 16:08 ` [PR REVIEW] " ericonr
@ 2021-03-08 16:17 ` tibequadorian
  2021-03-08 16:23 ` tibequadorian
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: tibequadorian @ 2021-03-08 16:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New review comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/29317#discussion_r589551068

Comment:
Yes I think too! 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] serd: update to 0.30.10.
  2021-03-08 14:35 [PR PATCH] serd: update to 0.30.10 tibequadorian
  2021-03-08 16:08 ` [PR REVIEW] " ericonr
  2021-03-08 16:17 ` tibequadorian
@ 2021-03-08 16:23 ` tibequadorian
  2021-03-08 19:53 ` [PR PATCH] [Merged]: " ericonr
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: tibequadorian @ 2021-03-08 16:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New review comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/29317#discussion_r589556476

Comment:
But I don't know if I'm ready to mess around with the build styles :D

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: serd: update to 0.30.10.
  2021-03-08 14:35 [PR PATCH] serd: update to 0.30.10 tibequadorian
                   ` (2 preceding siblings ...)
  2021-03-08 16:23 ` tibequadorian
@ 2021-03-08 19:53 ` ericonr
  2021-03-08 19:53 ` [PR REVIEW] " ericonr
  2021-03-08 22:20 ` tibequadorian
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-03-08 19:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]

There's a merged pull request on the void-packages repository

serd: update to 0.30.10.
https://github.com/void-linux/void-packages/pull/29317

Description:
enable tests

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] serd: update to 0.30.10.
  2021-03-08 14:35 [PR PATCH] serd: update to 0.30.10 tibequadorian
                   ` (3 preceding siblings ...)
  2021-03-08 19:53 ` [PR PATCH] [Merged]: " ericonr
@ 2021-03-08 19:53 ` ericonr
  2021-03-08 22:20 ` tibequadorian
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-03-08 19:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29317#discussion_r589704608

Comment:
I will leave this as a future improvement, we can check if other waf stuff also has tests.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] serd: update to 0.30.10.
  2021-03-08 14:35 [PR PATCH] serd: update to 0.30.10 tibequadorian
                   ` (4 preceding siblings ...)
  2021-03-08 19:53 ` [PR REVIEW] " ericonr
@ 2021-03-08 22:20 ` tibequadorian
  5 siblings, 0 replies; 7+ messages in thread
From: tibequadorian @ 2021-03-08 22:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

New review comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/29317#discussion_r589790263

Comment:
It looks like `waf test` is officially documented, but doesn't always exist. And I didn't find a way to check if a build script contains a test task or not, like with `make -q`

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-03-08 22:20 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 14:35 [PR PATCH] serd: update to 0.30.10 tibequadorian
2021-03-08 16:08 ` [PR REVIEW] " ericonr
2021-03-08 16:17 ` tibequadorian
2021-03-08 16:23 ` tibequadorian
2021-03-08 19:53 ` [PR PATCH] [Merged]: " ericonr
2021-03-08 19:53 ` [PR REVIEW] " ericonr
2021-03-08 22:20 ` tibequadorian

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).