[PR PATCH] mumble: add portaudio build option

[PR PATCH] mumble: add portaudio build option

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

There is a new pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages mumble
https://github.com/void-linux/void-packages/pull/29306

mumble: add portaudio build option
jack option is already described

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29306.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mumble-29306.patch --]
[-- Type: text/x-diff, Size: 1971 bytes --]

From e221d04434202ca7a5235a6f7a6ec05e763da55e Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 1 Mar 2021 16:27:28 +0100
Subject: [PATCH] mumble: add portaudio build option

jack option is already described
---
 srcpkgs/mumble/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/mumble/template b/srcpkgs/mumble/template
index 7d2c8641571..c911fc02a0f 100644
--- a/srcpkgs/mumble/template
+++ b/srcpkgs/mumble/template
@@ -6,12 +6,13 @@ build_style=qmake
 configure_args="CONFIG+=bundled-celt CONFIG+=no-bundled-opus CONFIG+=no-update
  CONFIG+=no-bundled-speex CONFIG+=no-g15 CONFIG+=no-xevie CONFIG+=pulseaudio
  $(vopt_if jack CONFIG+=jackaudio) CONFIG+=no-embed-qt-translations
- CONFIG+=no-oss CONFIG+=portaudio DEFINES+=PLUGIN_PATH=/usr/lib/mumble"
+ CONFIG+=no-oss $(vopt_if portaudio CONFIG+=portaudio)
+ DEFINES+=PLUGIN_PATH=/usr/lib/mumble"
 hostmakedepends="Ice pkg-config protobuf qt5-host-tools qt5-qmake python3 which"
 makedepends="Ice-devel MesaLib-devel avahi-compat-libs-devel boost-devel
  libcap-devel openssl-devel libsndfile-devel opus-devel protobuf-devel
  pulseaudio-devel $(vopt_if jack jack-devel) qt5-devel qt5-svg-devel
- speech-dispatcher-devel speex-devel portaudio-devel"
+ speech-dispatcher-devel speex-devel $(vopt_if portaudio portaudio-devel)"
 depends="desktop-file-utils qt5-plugin-sqlite"
 short_desc="Open source, low-latency, high quality voice chat for gaming"
 maintainer="Helmut Pozimski <helmut@pozimski.eu>"
@@ -20,8 +21,8 @@ homepage="http://mumble.sourceforge.net/"
 distfiles="https://github.com/mumble-voip/${pkgname}/releases/download/${version}/${pkgname}-${version}.tar.gz"
 checksum=615f4ebfc3385d945163f369efd3e910c8b6d0f025797a7eed541515fccb6093
 
-build_options="jack"
-desc_option_jack="Enable support for the JACK sound server"
+build_options="jack portaudio"
+build_options_default="jack portaudio"
 
 do_install() {
 	vlicense LICENSE

Re: mumble: add portaudio build option

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29306#issuecomment-793456811

Comment:
This changes package metadata, so it should be revbumped. Can you explain why you want to make it optional?

Re: mumble: add portaudio build option

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/29306#issuecomment-793486740

Comment:
> why you want to make it optional?

I want to remove the portaudio dependency on my system and why not? JACK is optional too.

Re: [PR PATCH] [Updated] mumble: add portaudio build option

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages mumble
https://github.com/void-linux/void-packages/pull/29306

mumble: add portaudio build option
jack option is already described

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29306.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mumble-29306.patch --]
[-- Type: text/x-diff, Size: 2060 bytes --]

From f37dd1953759dfffedab454b1058882348c699af Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Mon, 1 Mar 2021 16:27:28 +0100
Subject: [PATCH] mumble: add portaudio build option

jack option is already described
---
 srcpkgs/mumble/template | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/mumble/template b/srcpkgs/mumble/template
index 7d2c8641571..3a0dca32d9e 100644
--- a/srcpkgs/mumble/template
+++ b/srcpkgs/mumble/template
@@ -1,17 +1,18 @@
 # Template file for 'mumble'
 pkgname=mumble
 version=1.3.4
-revision=4
+revision=5
 build_style=qmake
 configure_args="CONFIG+=bundled-celt CONFIG+=no-bundled-opus CONFIG+=no-update
  CONFIG+=no-bundled-speex CONFIG+=no-g15 CONFIG+=no-xevie CONFIG+=pulseaudio
  $(vopt_if jack CONFIG+=jackaudio) CONFIG+=no-embed-qt-translations
- CONFIG+=no-oss CONFIG+=portaudio DEFINES+=PLUGIN_PATH=/usr/lib/mumble"
+ CONFIG+=no-oss $(vopt_if portaudio CONFIG+=portaudio)
+ DEFINES+=PLUGIN_PATH=/usr/lib/mumble"
 hostmakedepends="Ice pkg-config protobuf qt5-host-tools qt5-qmake python3 which"
 makedepends="Ice-devel MesaLib-devel avahi-compat-libs-devel boost-devel
  libcap-devel openssl-devel libsndfile-devel opus-devel protobuf-devel
  pulseaudio-devel $(vopt_if jack jack-devel) qt5-devel qt5-svg-devel
- speech-dispatcher-devel speex-devel portaudio-devel"
+ speech-dispatcher-devel speex-devel $(vopt_if portaudio portaudio-devel)"
 depends="desktop-file-utils qt5-plugin-sqlite"
 short_desc="Open source, low-latency, high quality voice chat for gaming"
 maintainer="Helmut Pozimski <helmut@pozimski.eu>"
@@ -20,8 +21,8 @@ homepage="http://mumble.sourceforge.net/"
 distfiles="https://github.com/mumble-voip/${pkgname}/releases/download/${version}/${pkgname}-${version}.tar.gz"
 checksum=615f4ebfc3385d945163f369efd3e910c8b6d0f025797a7eed541515fccb6093
 
-build_options="jack"
-desc_option_jack="Enable support for the JACK sound server"
+build_options="jack portaudio"
+build_options_default="jack portaudio"
 
 do_install() {
 	vlicense LICENSE