* [PR PATCH] xbps: Remove reduntant patch
@ 2021-03-12 22:58 kawaiiamber
2021-03-12 23:08 ` Chocimier
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: kawaiiamber @ 2021-03-12 22:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
There is a new pull request by kawaiiamber against master on the void-packages repository
https://github.com/kawaiiamber/void-packages xbps
https://github.com/void-linux/void-packages/pull/29424
xbps: Remove reduntant patch
This patch no longer does anything as $(CFLAGS) is now included in the libxbps.so rule in the Makefile in lib/Makefile as seen [here](https://github.com/void-linux/xbps/blob/master/lib/Makefile).
A patch file from https://github.com/void-linux/void-packages/pull/29424.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xbps-29424.patch --]
[-- Type: text/x-diff, Size: 1203 bytes --]
From de8a4ae43a5ee94a30d3c9d377fe267baf7ddc24 Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Fri, 12 Mar 2021 15:55:11 -0700
Subject: [PATCH] xbps: Remove reduntant patch
---
srcpkgs/xbps/patches/cflags.patch | 17 -----------------
1 file changed, 17 deletions(-)
delete mode 100644 srcpkgs/xbps/patches/cflags.patch
diff --git a/srcpkgs/xbps/patches/cflags.patch b/srcpkgs/xbps/patches/cflags.patch
deleted file mode 100644
index 8e576f2a887..00000000000
--- a/srcpkgs/xbps/patches/cflags.patch
+++ /dev/null
@@ -1,17 +0,0 @@
-Both CFLAGS and LDFLAGS need to be passed during linkage as CFLAGS may contain
-things that influence linkage (e.g. ssp_nonshared may be necessary to link
-when using strong stack protector)
-
-diff --git lib/Makefile lib/Makefile
-index 65342ef..847bfdd 100644
---- lib/Makefile
-+++ lib/Makefile
-@@ -78,7 +78,7 @@ $(OBJS): %.o: %.c
-
- libxbps.so: $(LIBFETCH_OBJS) $(LIBPROP_OBJS) $(OBJS)
- @printf " [CCLD]\t\t$@\n"
-- ${SILENT}$(CC) $^ $(LDFLAGS) -o $(LIBXBPS_SHLIB)
-+ ${SILENT}$(CC) $^ $(CFLAGS) $(LDFLAGS) -o $(LIBXBPS_SHLIB)
- @-ln -sf $(LIBXBPS_SHLIB) libxbps.so.$(LIBXBPS_MAJOR)
- @-ln -sf $(LIBXBPS_SHLIB) libxbps.so
-
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: xbps: Remove reduntant patch
2021-03-12 22:58 [PR PATCH] xbps: Remove reduntant patch kawaiiamber
@ 2021-03-12 23:08 ` Chocimier
2021-03-12 23:08 ` [PR PATCH] [Closed]: " Chocimier
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Chocimier @ 2021-03-12 23:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/29424#issuecomment-797806086
Comment:
void-packages use release of xbps that do not contain that patch, not master.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Closed]: xbps: Remove reduntant patch
2021-03-12 22:58 [PR PATCH] xbps: Remove reduntant patch kawaiiamber
2021-03-12 23:08 ` Chocimier
@ 2021-03-12 23:08 ` Chocimier
2021-03-12 23:11 ` kawaiiamber
2021-03-12 23:15 ` kawaiiamber
3 siblings, 0 replies; 5+ messages in thread
From: Chocimier @ 2021-03-12 23:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
There's a closed pull request on the void-packages repository
xbps: Remove reduntant patch
https://github.com/void-linux/void-packages/pull/29424
Description:
This patch no longer does anything as $(CFLAGS) is now included in the libxbps.so rule in the Makefile in lib/Makefile as seen [here](https://github.com/void-linux/xbps/blob/master/lib/Makefile).
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: xbps: Remove reduntant patch
2021-03-12 22:58 [PR PATCH] xbps: Remove reduntant patch kawaiiamber
2021-03-12 23:08 ` Chocimier
2021-03-12 23:08 ` [PR PATCH] [Closed]: " Chocimier
@ 2021-03-12 23:11 ` kawaiiamber
2021-03-12 23:15 ` kawaiiamber
3 siblings, 0 replies; 5+ messages in thread
From: kawaiiamber @ 2021-03-12 23:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 224 bytes --]
New comment by kawaiiamber on void-packages repository
https://github.com/void-linux/void-packages/pull/29424#issuecomment-797807002
Comment:
Oops, I didn't notice that the released tag was behind commits from the master.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: xbps: Remove reduntant patch
2021-03-12 22:58 [PR PATCH] xbps: Remove reduntant patch kawaiiamber
` (2 preceding siblings ...)
2021-03-12 23:11 ` kawaiiamber
@ 2021-03-12 23:15 ` kawaiiamber
3 siblings, 0 replies; 5+ messages in thread
From: kawaiiamber @ 2021-03-12 23:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
New comment by kawaiiamber on void-packages repository
https://github.com/void-linux/void-packages/pull/29424#issuecomment-797807002
Comment:
Oops, I didn't notice that the released tag was behind commits from the master.
(It is a little funny that VOID patches its own software for the time being though ;p)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-12 23:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 22:58 [PR PATCH] xbps: Remove reduntant patch kawaiiamber
2021-03-12 23:08 ` Chocimier
2021-03-12 23:08 ` [PR PATCH] [Closed]: " Chocimier
2021-03-12 23:11 ` kawaiiamber
2021-03-12 23:15 ` kawaiiamber
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).