[PR PATCH] rpi-imager: update to 1.6.

[PR PATCH] rpi-imager: update to 1.6.

[agausmann]

[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]

There is a new pull request by agausmann against master on the void-packages repository

https://github.com/agausmann/void-packages rpi-imager-1.6
https://github.com/void-linux/void-packages/pull/29497

rpi-imager: update to 1.6.
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86-64-gnu)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/29497.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rpi-imager-1.6-29497.patch --]
[-- Type: text/x-diff, Size: 1176 bytes --]

From 8eb2a7eb7fa3a775570d16ced5f855e04e82b120 Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Mon, 15 Mar 2021 16:09:32 -0500
Subject: [PATCH] rpi-imager: update to 1.6.

---
 srcpkgs/rpi-imager/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/rpi-imager/template b/srcpkgs/rpi-imager/template
index b00e8ed63e98..8a5cfed44136 100644
--- a/srcpkgs/rpi-imager/template
+++ b/srcpkgs/rpi-imager/template
@@ -1,7 +1,7 @@
 # Template file for 'rpi-imager'
 pkgname=rpi-imager
-version=1.5
-revision=2
+version=1.6
+revision=1
 build_style=cmake
 hostmakedepends="qt5-host-tools qt5-qmake"
 makedepends="qt5-devel qt5-declarative-devel qt5-svg-devel qt5-tools-devel
@@ -12,7 +12,7 @@ maintainer="Adam Gausmann <agausmann@fastmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/raspberrypi/rpi-imager"
 distfiles="https://github.com/raspberrypi/rpi-imager/archive/v${version}.tar.gz"
-checksum="972592886b4ff448b34bd420817f7b019c40fdab6ccef7acbc69986c1904e39c"
+checksum="811f9c261f82f75eefb9129570c47ff6653c1e9af08d9ed0b877261b4d184685"
 
 pre_configure() {
 	ln -sf /bin/true $XBPS_WRAPPERDIR/lsblk

Re: rpi-imager: update to 1.6.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/29497#issuecomment-800400538

Comment:
is there a way you can address the telemetry issue?

Re: rpi-imager: update to 1.6.

[FollieHiyuki]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/29497#issuecomment-800408422

Comment:
```
/* Phone home the name of images downloaded for image popularity ranking */
#define TELEMETRY_URL                     "https://rpi-imager-stats.raspberrypi.org/downloads"
#define TELEMETRY_ENABLED_DEFAULT         true
```
I think we can patch their `config.h` to redirect to localhost and turn it off by default.

Re: rpi-imager: update to 1.6.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29497#issuecomment-800411792

Comment:
On 2021-03-16 09:24:51-0700, FollieHiyuki ***@***.***> wrote:
> ```
> /* Phone home the name of images downloaded for image popularity ranking */
> #define TELEMETRY_URL                     "https://rpi-imager-stats.raspberrypi.org/downloads"
> #define TELEMETRY_ENABLED_DEFAULT         true
> ```
> I think we can patch their `config.h` to redirect to localhost and turn it off by default.

How about 0.0.0.0? Send them to a black holes instead.

-- 
Danh

Re: rpi-imager: update to 1.6.

[agausmann]

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

New comment by agausmann on void-packages repository

https://github.com/void-linux/void-packages/pull/29497#issuecomment-800452781

Comment:
I'm fine with disabling telemetry by default, but I'd rather not functionally break it. AFAIK that isn't done to other packages with telemetry, for example Firefox.

It's open source, so it's entirely transparent about what data it collects. Plus there is an [official disclosure](https://github.com/raspberrypi/rpi-imager#telemetry) that we can copy to a prominent location if that would help.

Re: [PR PATCH] [Updated] rpi-imager: update to 1.6.

[agausmann]

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

There is an updated pull request by agausmann against master on the void-packages repository

https://github.com/agausmann/void-packages rpi-imager-1.6
https://github.com/void-linux/void-packages/pull/29497

rpi-imager: update to 1.6.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

<!--
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-gnu)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/29497.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rpi-imager-1.6-29497.patch --]
[-- Type: text/x-diff, Size: 2143 bytes --]

From 58e0fefa9c1628f0690b2a6500c46164d8df97db Mon Sep 17 00:00:00 2001
From: Adam Gausmann <agausmann@fastmail.com>
Date: Mon, 15 Mar 2021 16:09:32 -0500
Subject: [PATCH] rpi-imager: update to 1.6.

---
 srcpkgs/rpi-imager/patches/disable-telemetry.patch | 11 +++++++++++
 srcpkgs/rpi-imager/template                        |  6 +++---
 2 files changed, 14 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/rpi-imager/patches/disable-telemetry.patch

diff --git a/srcpkgs/rpi-imager/patches/disable-telemetry.patch b/srcpkgs/rpi-imager/patches/disable-telemetry.patch
new file mode 100644
index 000000000000..87dce16a58ce
--- /dev/null
+++ b/srcpkgs/rpi-imager/patches/disable-telemetry.patch
@@ -0,0 +1,11 @@
+--- config.h.orig	2021-03-16 12:22:48.315849306 -0500
++++ config.h	2021-03-16 12:23:00.273828304 -0500
+@@ -15,7 +15,7 @@
+ 
+ /* Phone home the name of images downloaded for image popularity ranking */
+ #define TELEMETRY_URL                     "https://rpi-imager-stats.raspberrypi.org/downloads"
+-#define TELEMETRY_ENABLED_DEFAULT         true
++#define TELEMETRY_ENABLED_DEFAULT         false
+ 
+ /* Hash algorithm for verifying (uncompressed image) checksum */
+ #define OSLIST_HASH_ALGORITHM             QCryptographicHash::Sha256
diff --git a/srcpkgs/rpi-imager/template b/srcpkgs/rpi-imager/template
index b00e8ed63e98..8a5cfed44136 100644
--- a/srcpkgs/rpi-imager/template
+++ b/srcpkgs/rpi-imager/template
@@ -1,7 +1,7 @@
 # Template file for 'rpi-imager'
 pkgname=rpi-imager
-version=1.5
-revision=2
+version=1.6
+revision=1
 build_style=cmake
 hostmakedepends="qt5-host-tools qt5-qmake"
 makedepends="qt5-devel qt5-declarative-devel qt5-svg-devel qt5-tools-devel
@@ -12,7 +12,7 @@ maintainer="Adam Gausmann <agausmann@fastmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/raspberrypi/rpi-imager"
 distfiles="https://github.com/raspberrypi/rpi-imager/archive/v${version}.tar.gz"
-checksum="972592886b4ff448b34bd420817f7b019c40fdab6ccef7acbc69986c1904e39c"
+checksum="811f9c261f82f75eefb9129570c47ff6653c1e9af08d9ed0b877261b4d184685"
 
 pre_configure() {
 	ln -sf /bin/true $XBPS_WRAPPERDIR/lsblk

Re: rpi-imager: update to 1.6.

[agausmann]

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

New comment by agausmann on void-packages repository

https://github.com/void-linux/void-packages/pull/29497#issuecomment-800452781

Comment:
I'm fine with disabling telemetry by default, but I'd rather not functionally break it. Changing `TELEMETRY_ENABLED_DEFAULT` just changes the default setting, but there is no runtime setting for `TELEMETRY_URL`; changing that will permanently break telemetry for that build. AFAIK that isn't done to other packages with telemetry, for example Firefox.

It's open source, so it's entirely transparent about what data it collects. Plus there is an [official disclosure](https://github.com/raspberrypi/rpi-imager#telemetry) that we can copy to a prominent location if that would help.

Re: rpi-imager: update to 1.6.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/29497#issuecomment-800557319

Comment:
let's switch it to opt-in but not break it

Re: [PR PATCH] [Merged]: rpi-imager: update to 1.6.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

There's a merged pull request on the void-packages repository

rpi-imager: update to 1.6.
https://github.com/void-linux/void-packages/pull/29497

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

<!--
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-gnu)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->