* [PR PATCH] openblas: choose generic target for x86 and x86_64.
@ 2021-03-21 4:16 gt7-void
2021-03-21 4:21 ` ericonr
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: gt7-void @ 2021-03-21 4:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]
There is a new pull request by gt7-void against master on the void-packages repository
https://github.com/gt7-void/void-packages openblas
https://github.com/void-linux/void-packages/pull/29645
openblas: choose generic target for x86 and x86_64.
The current template uses DYNAMIC_ARCH=1 to get multiple versions of some
functions to support different cpus. However, it will pick up the cpu it was
compiled in as a minimum requirement for the common code.
Adding TARGET=GENERIC fixes this, now the common code is compiled for a generic cpu.
See #29604 and https://github.com/xianyi/OpenBLAS/issues/3139.
<!-- Mark items with [x] where applicable -->
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29645.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-openblas-29645.patch --]
[-- Type: text/x-diff, Size: 1696 bytes --]
From 30f22da022fd196b8a319189e13b867e5515619d Mon Sep 17 00:00:00 2001
From: gt7-void <gt7@mail.com>
Date: Sun, 21 Mar 2021 01:07:12 -0300
Subject: [PATCH] openblas: choose generic target for x86 and x86_64.
The current template uses DYNAMIC_ARCH=1 to get multiple versions of some
functions to support different cpus. However, it will pick up the cpu it was
compiled in as a minimum requirement for the common code.
Adding TARGET=GENERIC fixes this, now the common code is compiled for a generic cpu.
See #29604 and https://github.com/xianyi/OpenBLAS/issues/3139.
---
srcpkgs/openblas/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/openblas/template b/srcpkgs/openblas/template
index ea5263838ccb..58a75941be47 100644
--- a/srcpkgs/openblas/template
+++ b/srcpkgs/openblas/template
@@ -1,7 +1,7 @@
# Template file for 'openblas'
pkgname=openblas
version=0.3.13
-revision=2
+revision=3
wrksrc="OpenBLAS-${version}"
build_style=gnu-makefile
make_build_args=" HOSTCC=gcc USE_OPENMP=1"
@@ -20,8 +20,8 @@ case "${XBPS_TARGET_MACHINE}" in
armv6*) make_build_args+=" TARGET=ARMV6" ;;
armv7*) make_build_args+=" TARGET=ARMV7" ;;
aarch64*) make_build_args+=" TARGET=ARMV8 DYNAMIC_ARCH=1" ;;
- i686*) make_build_args+=" BINARY=32 DYNAMIC_ARCH=1" ;;
- x86_64*) make_build_args+=" BINARY=64 DYNAMIC_ARCH=1" ;;
+ i686*) make_build_args+=" BINARY=32 TARGET=GENERIC DYNAMIC_ARCH=1" ;;
+ x86_64*) make_build_args+=" BINARY=64 TARGET=GENERIC DYNAMIC_ARCH=1" ;;
ppc64le*) make_build_args+=" TARGET=POWER8 DYNAMIC_ARCH=1" ;;
ppc64*) make_build_args+=" TARGET=PPC970MP" ;; # dynamic arch broken for <power6
ppc*) make_build_args+=" TARGET=PPCG4" ;;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: openblas: choose generic target for x86 and x86_64.
2021-03-21 4:16 [PR PATCH] openblas: choose generic target for x86 and x86_64 gt7-void
@ 2021-03-21 4:21 ` ericonr
2021-03-21 4:22 ` ericonr
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-03-21 4:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 359 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29645#issuecomment-803509915
Comment:
Can you confirm this fixed the issue you were experiencing? Should probably verify by building on a machine with AVX available and transferring to the other.
I'd consider using GENERIC for all builds, if applicable.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: openblas: choose generic target for x86 and x86_64.
2021-03-21 4:16 [PR PATCH] openblas: choose generic target for x86 and x86_64 gt7-void
2021-03-21 4:21 ` ericonr
@ 2021-03-21 4:22 ` ericonr
2021-03-21 4:28 ` gt7-void
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-03-21 4:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 372 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29645#issuecomment-803509915
Comment:
Can you confirm this fixed the issue you were experiencing? Should probably verify by building on a machine with AVX available and transferring to the other.
I'd consider using GENERIC for all DYNAMIC_ARCH builds, if applicable.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: openblas: choose generic target for x86 and x86_64.
2021-03-21 4:16 [PR PATCH] openblas: choose generic target for x86 and x86_64 gt7-void
2021-03-21 4:21 ` ericonr
2021-03-21 4:22 ` ericonr
@ 2021-03-21 4:28 ` gt7-void
2021-03-21 13:28 ` [PR PATCH] [Merged]: " ericonr
2021-03-21 13:28 ` ericonr
4 siblings, 0 replies; 6+ messages in thread
From: gt7-void @ 2021-03-21 4:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
New comment by gt7-void on void-packages repository
https://github.com/void-linux/void-packages/pull/29645#issuecomment-803510437
Comment:
> Can you confirm this fixed the issue you were experiencing? Should probably verify by building on a machine with AVX available and transferring to the other.
Yes, I built the package on a skylake, installed it on nehalem, and it works.
> I'd consider using GENERIC for all DYNAMIC_ARCH builds, if applicable.
I didn't want to touch the other archs because I don't have hardware to test. But since the other arches all set `TARGET` to some value, at least the output will not depend on the machine it's compiled on. Also, `TARGET=ARMV8` looks generic enough.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: openblas: choose generic target for x86 and x86_64.
2021-03-21 4:16 [PR PATCH] openblas: choose generic target for x86 and x86_64 gt7-void
` (2 preceding siblings ...)
2021-03-21 4:28 ` gt7-void
@ 2021-03-21 13:28 ` ericonr
2021-03-21 13:28 ` ericonr
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-03-21 13:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]
There's a merged pull request on the void-packages repository
openblas: choose generic target for x86 and x86_64.
https://github.com/void-linux/void-packages/pull/29645
Description:
The current template uses DYNAMIC_ARCH=1 to get multiple versions of some
functions to support different cpus. However, it will pick up the cpu it was
compiled in as a minimum requirement for the common code.
Adding TARGET=GENERIC fixes this, now the common code is compiled for a generic cpu.
See #29604 and https://github.com/xianyi/OpenBLAS/issues/3139.
<!-- Mark items with [x] where applicable -->
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: openblas: choose generic target for x86 and x86_64.
2021-03-21 4:16 [PR PATCH] openblas: choose generic target for x86 and x86_64 gt7-void
` (3 preceding siblings ...)
2021-03-21 13:28 ` [PR PATCH] [Merged]: " ericonr
@ 2021-03-21 13:28 ` ericonr
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-03-21 13:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 148 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29645#issuecomment-803580021
Comment:
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-21 13:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-21 4:16 [PR PATCH] openblas: choose generic target for x86 and x86_64 gt7-void
2021-03-21 4:21 ` ericonr
2021-03-21 4:22 ` ericonr
2021-03-21 4:28 ` gt7-void
2021-03-21 13:28 ` [PR PATCH] [Merged]: " ericonr
2021-03-21 13:28 ` ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).