* Re: [PR REVIEW] gopass: update to 1.12.4
2021-03-21 20:41 [PR PATCH] gopass: update to 1.12.4 dominikschulz
@ 2021-03-21 20:57 ` ericonr
2021-03-21 21:12 ` [PR PATCH] [Updated] " dominikschulz
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-03-21 20:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29669#discussion_r598336775
Comment:
Why did you remove this? The `vcompletion` calls below will fail because they can't find the file...
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Updated] gopass: update to 1.12.4
2021-03-21 20:41 [PR PATCH] gopass: update to 1.12.4 dominikschulz
2021-03-21 20:57 ` [PR REVIEW] " ericonr
@ 2021-03-21 21:12 ` dominikschulz
2021-03-21 21:13 ` [PR REVIEW] " dominikschulz
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: dominikschulz @ 2021-03-21 21:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
There is an updated pull request by dominikschulz against master on the void-packages repository
https://github.com/dominikschulz/void-packages gopass-1.12.4
https://github.com/void-linux/void-packages/pull/29669
gopass: update to 1.12.4
The shell completion files are now part of the source tarball and doesn't need to be generated.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
A patch file from https://github.com/void-linux/void-packages/pull/29669.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gopass-1.12.4-29669.patch --]
[-- Type: text/x-diff, Size: 1356 bytes --]
From 83b8e69f8d631bf318efed357a4b22845fe6dbd8 Mon Sep 17 00:00:00 2001
From: Dominik Schulz <mail@dschulz.eu>
Date: Sun, 21 Mar 2021 21:40:03 +0100
Subject: [PATCH] gopass: update to 1.12.4
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
---
srcpkgs/gopass/template | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/srcpkgs/gopass/template b/srcpkgs/gopass/template
index 2b3964146abc..dd69f2a8a1b9 100644
--- a/srcpkgs/gopass/template
+++ b/srcpkgs/gopass/template
@@ -1,6 +1,6 @@
# Template file for 'gopass'
pkgname=gopass
-version=1.12.0
+version=1.12.4
revision=1
build_style=go
build_helper=qemu
@@ -14,19 +14,12 @@ license="MIT"
homepage="https://www.gopass.pw/"
changelog="https://raw.githubusercontent.com/gopasspw/gopass/master/CHANGELOG.md"
distfiles="https://github.com/gopasspw/gopass/archive/v${version}.tar.gz"
-checksum=73b7c5c8367e664d85871fba88f4fa806ef0fb75047c767a72b8516dea6f64b3
-
-post_build() {
- gopass=$(find $GOPATH/bin -name gopass)
- for shell in bash fish zsh; do
- vtargetrun $gopass completion $shell > completion.$shell
- done
-}
+checksum=1e3d7ad389a8462256ff7e439de1fbed8012c38ec33bded63b11af74f0525279
post_install() {
vlicense LICENSE
for shell in bash fish zsh; do
- vcompletion completion.$shell $shell
+ vcompletion $shell.completion $shell
done
}
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR REVIEW] gopass: update to 1.12.4
2021-03-21 20:41 [PR PATCH] gopass: update to 1.12.4 dominikschulz
2021-03-21 20:57 ` [PR REVIEW] " ericonr
2021-03-21 21:12 ` [PR PATCH] [Updated] " dominikschulz
@ 2021-03-21 21:13 ` dominikschulz
2021-03-21 21:22 ` ericonr
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: dominikschulz @ 2021-03-21 21:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
New review comment by dominikschulz on void-packages repository
https://github.com/void-linux/void-packages/pull/29669#discussion_r598338704
Comment:
Generating the completion files during package build time cause trouble for some platforms so we decided to generate them when cutting a release and include them in the source package, see https://github.com/gopasspw/gopass/commit/2fdeb0fd42801026afe178a75ce68d0df29de9f7
But I didn't notice the slightly different naming of these files. Should be fixed now.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR REVIEW] gopass: update to 1.12.4
2021-03-21 20:41 [PR PATCH] gopass: update to 1.12.4 dominikschulz
` (2 preceding siblings ...)
2021-03-21 21:13 ` [PR REVIEW] " dominikschulz
@ 2021-03-21 21:22 ` ericonr
2021-03-21 21:37 ` [PR PATCH] [Updated] " dominikschulz
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-03-21 21:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29669#discussion_r598339882
Comment:
In that case, please also `vman gopass.1` in `post_install`.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Updated] gopass: update to 1.12.4
2021-03-21 20:41 [PR PATCH] gopass: update to 1.12.4 dominikschulz
` (3 preceding siblings ...)
2021-03-21 21:22 ` ericonr
@ 2021-03-21 21:37 ` dominikschulz
2021-03-21 21:38 ` [PR REVIEW] " dominikschulz
2021-03-22 12:48 ` [PR PATCH] [Merged]: " ericonr
6 siblings, 0 replies; 8+ messages in thread
From: dominikschulz @ 2021-03-21 21:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
There is an updated pull request by dominikschulz against master on the void-packages repository
https://github.com/dominikschulz/void-packages gopass-1.12.4
https://github.com/void-linux/void-packages/pull/29669
gopass: update to 1.12.4
The shell completion files are now part of the source tarball and doesn't need to be generated.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
A patch file from https://github.com/void-linux/void-packages/pull/29669.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gopass-1.12.4-29669.patch --]
[-- Type: text/x-diff, Size: 1373 bytes --]
From 3c790250f603bdba30c6939f400d9ce1c48f6a58 Mon Sep 17 00:00:00 2001
From: Dominik Schulz <mail@dschulz.eu>
Date: Sun, 21 Mar 2021 21:40:03 +0100
Subject: [PATCH] gopass: update to 1.12.4
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
---
srcpkgs/gopass/template | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/srcpkgs/gopass/template b/srcpkgs/gopass/template
index 2b3964146abc..887985426b3a 100644
--- a/srcpkgs/gopass/template
+++ b/srcpkgs/gopass/template
@@ -1,6 +1,6 @@
# Template file for 'gopass'
pkgname=gopass
-version=1.12.0
+version=1.12.4
revision=1
build_style=go
build_helper=qemu
@@ -14,19 +14,13 @@ license="MIT"
homepage="https://www.gopass.pw/"
changelog="https://raw.githubusercontent.com/gopasspw/gopass/master/CHANGELOG.md"
distfiles="https://github.com/gopasspw/gopass/archive/v${version}.tar.gz"
-checksum=73b7c5c8367e664d85871fba88f4fa806ef0fb75047c767a72b8516dea6f64b3
-
-post_build() {
- gopass=$(find $GOPATH/bin -name gopass)
- for shell in bash fish zsh; do
- vtargetrun $gopass completion $shell > completion.$shell
- done
-}
+checksum=1e3d7ad389a8462256ff7e439de1fbed8012c38ec33bded63b11af74f0525279
post_install() {
vlicense LICENSE
+ vman gopass.1
for shell in bash fish zsh; do
- vcompletion completion.$shell $shell
+ vcompletion $shell.completion $shell
done
}
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR REVIEW] gopass: update to 1.12.4
2021-03-21 20:41 [PR PATCH] gopass: update to 1.12.4 dominikschulz
` (4 preceding siblings ...)
2021-03-21 21:37 ` [PR PATCH] [Updated] " dominikschulz
@ 2021-03-21 21:38 ` dominikschulz
2021-03-22 12:48 ` [PR PATCH] [Merged]: " ericonr
6 siblings, 0 replies; 8+ messages in thread
From: dominikschulz @ 2021-03-21 21:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
New review comment by dominikschulz on void-packages repository
https://github.com/void-linux/void-packages/pull/29669#discussion_r598341860
Comment:
Indeed, good idea. Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PR PATCH] [Merged]: gopass: update to 1.12.4
2021-03-21 20:41 [PR PATCH] gopass: update to 1.12.4 dominikschulz
` (5 preceding siblings ...)
2021-03-21 21:38 ` [PR REVIEW] " dominikschulz
@ 2021-03-22 12:48 ` ericonr
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2021-03-22 12:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
There's a merged pull request on the void-packages repository
gopass: update to 1.12.4
https://github.com/void-linux/void-packages/pull/29669
Description:
The shell completion files are now part of the source tarball and doesn't need to be generated.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
^ permalink raw reply [flat|nested] 8+ messages in thread