* [PR PATCH] minikube: update to 1.18.1.
@ 2021-03-08 8:49 Gottox
2021-03-09 6:37 ` [PR REVIEW] " ericonr
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Gottox @ 2021-03-08 8:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]
There is a new pull request by Gottox against master on the void-packages repository
https://github.com/Gottox/void-packages minikube-1.18
https://github.com/void-linux/void-packages/pull/29303
minikube: update to 1.18.1.
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29303.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-minikube-1.18-29303.patch --]
[-- Type: text/x-diff, Size: 1515 bytes --]
From a80b05e51918ffe8607487c48f721b46cfd56f61 Mon Sep 17 00:00:00 2001
From: Enno Boland <gottox@voidlinux.org>
Date: Mon, 8 Mar 2021 09:49:28 +0100
Subject: [PATCH] minikube: update to 1.18.1.
---
srcpkgs/minikube/template | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/minikube/template b/srcpkgs/minikube/template
index a091708aa97..eb172b0c529 100644
--- a/srcpkgs/minikube/template
+++ b/srcpkgs/minikube/template
@@ -1,6 +1,6 @@
# Template file for 'minikube'
pkgname=minikube
-version=1.18.0
+version=1.18.1
revision=1
build_style=go
build_helper=qemu
@@ -14,7 +14,8 @@ license="Apache-2.0"
homepage="https://github.com/kubernetes/minikube"
changelog="https://raw.githubusercontent.com/kubernetes/minikube/master/CHANGELOG.md"
distfiles="https://github.com/kubernetes/minikube/archive/v$version.tar.gz"
-checksum="c3f0f60607bca0c2f1a118d6d5ce313ac0c6e56b5f9621cb00ca17271aceaff6"
+checksum=4ade34adf8d33ddd141d436b33cb66d4183e059f8a112ea1aeb1edeae9302594
+go_ldflags="-X k8s.io/minikube/pkg/version.version=$version -X k8s.io/minikube/pkg/version.isoVersion=$version"
pre_configure() {
case "$XBPS_TARGET_MACHINE" in
@@ -24,6 +25,8 @@ pre_configure() {
pre_build() {
make pkg/minikube/assets/assets.go pkg/minikube/translate/translations.go
+ local storage_provisioner_tag=$(sed -n '/^STORAGE_PROVISIONER_TAG/s/.*=\W*//p' Makefile)
+ go_ldflags+=" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=$storage_provisioner_tag"
}
do_install() {
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] minikube: update to 1.18.1.
2021-03-08 8:49 [PR PATCH] minikube: update to 1.18.1 Gottox
@ 2021-03-09 6:37 ` ericonr
2021-03-09 7:00 ` Gottox
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2021-03-09 6:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 215 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29303#discussion_r589978102
Comment:
I think this flag goes below `go_import_path` for xlint to be happy.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] minikube: update to 1.18.1.
2021-03-08 8:49 [PR PATCH] minikube: update to 1.18.1 Gottox
2021-03-09 6:37 ` [PR REVIEW] " ericonr
@ 2021-03-09 7:00 ` Gottox
2021-03-09 7:00 ` Gottox
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Gottox @ 2021-03-09 7:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
New review comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/29303#discussion_r589994467
Comment:
Yes, there's currently another issue I'd like to fix first before I care about xlint :wink:
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] minikube: update to 1.18.1.
2021-03-08 8:49 [PR PATCH] minikube: update to 1.18.1 Gottox
2021-03-09 6:37 ` [PR REVIEW] " ericonr
2021-03-09 7:00 ` Gottox
@ 2021-03-09 7:00 ` Gottox
2021-03-23 8:47 ` [PR PATCH] [Updated] " Gottox
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Gottox @ 2021-03-09 7:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
New review comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/29303#discussion_r589994806
Comment:
isoVersion seems to be ignored.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Updated] minikube: update to 1.18.1.
2021-03-08 8:49 [PR PATCH] minikube: update to 1.18.1 Gottox
` (2 preceding siblings ...)
2021-03-09 7:00 ` Gottox
@ 2021-03-23 8:47 ` Gottox
2021-03-23 8:49 ` Gottox
2021-03-23 10:31 ` [PR PATCH] [Merged]: " Gottox
5 siblings, 0 replies; 7+ messages in thread
From: Gottox @ 2021-03-23 8:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]
There is an updated pull request by Gottox against master on the void-packages repository
https://github.com/Gottox/void-packages minikube-1.18
https://github.com/void-linux/void-packages/pull/29303
minikube: update to 1.18.1.
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29303.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-minikube-1.18-29303.patch --]
[-- Type: text/x-diff, Size: 1648 bytes --]
From cd0119a12d4a4b3b90285d0110072e32b244218b Mon Sep 17 00:00:00 2001
From: Enno Boland <gottox@voidlinux.org>
Date: Mon, 8 Mar 2021 09:49:28 +0100
Subject: [PATCH] minikube: update to 1.18.1.
---
srcpkgs/minikube/template | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/minikube/template b/srcpkgs/minikube/template
index a091708aa979..2f5355891ba7 100644
--- a/srcpkgs/minikube/template
+++ b/srcpkgs/minikube/template
@@ -1,6 +1,6 @@
# Template file for 'minikube'
pkgname=minikube
-version=1.18.0
+version=1.18.1
revision=1
build_style=go
build_helper=qemu
@@ -14,7 +14,8 @@ license="Apache-2.0"
homepage="https://github.com/kubernetes/minikube"
changelog="https://raw.githubusercontent.com/kubernetes/minikube/master/CHANGELOG.md"
distfiles="https://github.com/kubernetes/minikube/archive/v$version.tar.gz"
-checksum="c3f0f60607bca0c2f1a118d6d5ce313ac0c6e56b5f9621cb00ca17271aceaff6"
+checksum=4ade34adf8d33ddd141d436b33cb66d4183e059f8a112ea1aeb1edeae9302594
+go_ldflags="-X k8s.io/minikube/pkg/version.version=$version"
pre_configure() {
case "$XBPS_TARGET_MACHINE" in
@@ -23,7 +24,16 @@ pre_configure() {
}
pre_build() {
+ local storage_provisioner_tag= iso_version=
+
make pkg/minikube/assets/assets.go pkg/minikube/translate/translations.go
+ storage_provisioner_tag=$(sed -n '/^STORAGE_PROVISIONER_TAG/s/.*=\W*//p' Makefile)
+ iso_version=$(sed -n '/^ISO_VERSION/s/.*=\W*//p' Makefile)
+
+ go_ldflags+="
+ -X k8s.io/minikube/pkg/version.isoVersion=$iso_version
+ -X k8s.io/minikube/pkg/version.storageProvisionerVersion=$storage_provisioner_tag
+ "
}
do_install() {
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Updated] minikube: update to 1.18.1.
2021-03-08 8:49 [PR PATCH] minikube: update to 1.18.1 Gottox
` (3 preceding siblings ...)
2021-03-23 8:47 ` [PR PATCH] [Updated] " Gottox
@ 2021-03-23 8:49 ` Gottox
2021-03-23 10:31 ` [PR PATCH] [Merged]: " Gottox
5 siblings, 0 replies; 7+ messages in thread
From: Gottox @ 2021-03-23 8:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]
There is an updated pull request by Gottox against master on the void-packages repository
https://github.com/Gottox/void-packages minikube-1.18
https://github.com/void-linux/void-packages/pull/29303
minikube: update to 1.18.1.
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29303.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-minikube-1.18-29303.patch --]
[-- Type: text/x-diff, Size: 1809 bytes --]
From 126ed935425a22c9d4fb1430d821d2a1f015837c Mon Sep 17 00:00:00 2001
From: Enno Boland <gottox@voidlinux.org>
Date: Mon, 8 Mar 2021 09:49:28 +0100
Subject: [PATCH] minikube: update to 1.18.1.
---
srcpkgs/minikube/template | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/minikube/template b/srcpkgs/minikube/template
index a091708aa979..7b35584e34a1 100644
--- a/srcpkgs/minikube/template
+++ b/srcpkgs/minikube/template
@@ -1,9 +1,10 @@
# Template file for 'minikube'
pkgname=minikube
-version=1.18.0
+version=1.18.1
revision=1
build_style=go
build_helper=qemu
+go_ldflags="-X k8s.io/minikube/pkg/version.version=$version"
go_import_path="k8s.io/minikube/cmd/minikube k8s.io/minikube/cmd/drivers/kvm"
hostmakedepends="go-bindata python pkg-config git"
makedepends="libvirt-devel"
@@ -14,7 +15,7 @@ license="Apache-2.0"
homepage="https://github.com/kubernetes/minikube"
changelog="https://raw.githubusercontent.com/kubernetes/minikube/master/CHANGELOG.md"
distfiles="https://github.com/kubernetes/minikube/archive/v$version.tar.gz"
-checksum="c3f0f60607bca0c2f1a118d6d5ce313ac0c6e56b5f9621cb00ca17271aceaff6"
+checksum=4ade34adf8d33ddd141d436b33cb66d4183e059f8a112ea1aeb1edeae9302594
pre_configure() {
case "$XBPS_TARGET_MACHINE" in
@@ -23,7 +24,16 @@ pre_configure() {
}
pre_build() {
+ local storage_provisioner_tag= iso_version=
+
make pkg/minikube/assets/assets.go pkg/minikube/translate/translations.go
+ storage_provisioner_tag=$(sed -n '/^STORAGE_PROVISIONER_TAG/s/.*=\W*//p' Makefile)
+ iso_version=$(sed -n '/^ISO_VERSION/s/.*=\W*//p' Makefile)
+
+ go_ldflags+="
+ -X k8s.io/minikube/pkg/version.isoVersion=$iso_version
+ -X k8s.io/minikube/pkg/version.storageProvisionerVersion=$storage_provisioner_tag
+ "
}
do_install() {
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Merged]: minikube: update to 1.18.1.
2021-03-08 8:49 [PR PATCH] minikube: update to 1.18.1 Gottox
` (4 preceding siblings ...)
2021-03-23 8:49 ` Gottox
@ 2021-03-23 10:31 ` Gottox
5 siblings, 0 replies; 7+ messages in thread
From: Gottox @ 2021-03-23 10:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]
There's a merged pull request on the void-packages repository
minikube: update to 1.18.1.
https://github.com/void-linux/void-packages/pull/29303
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-23 10:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 8:49 [PR PATCH] minikube: update to 1.18.1 Gottox
2021-03-09 6:37 ` [PR REVIEW] " ericonr
2021-03-09 7:00 ` Gottox
2021-03-09 7:00 ` Gottox
2021-03-23 8:47 ` [PR PATCH] [Updated] " Gottox
2021-03-23 8:49 ` Gottox
2021-03-23 10:31 ` [PR PATCH] [Merged]: " Gottox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).