[PR PATCH] New package: sane-airscan-0.99.24

[PR PATCH] New package: sane-airscan-0.99.24

[oynqr]

[-- Attachment #1: Type: text/plain, Size: 1704 bytes --]

There is a new pull request by oynqr against master on the void-packages repository

https://github.com/oynqr/void-packages sane-airscan
https://github.com/void-linux/void-packages/pull/29392

New package: sane-airscan-0.99.24
Just #27448 with changed maintainer and updated to the latest version.
Would go along well with #28945.

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29392.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sane-airscan-29392.patch --]
[-- Type: text/x-diff, Size: 1485 bytes --]

From 14f7b3e60ff7de8c031ec3714849657a27baaa86 Mon Sep 17 00:00:00 2001
From: Philipp David <pd@3b.pm>
Date: Thu, 11 Mar 2021 11:03:00 +0100
Subject: [PATCH] New package: sane-airscan-0.99.24

---
 common/shlibs                 |  1 +
 srcpkgs/sane-airscan/template | 13 +++++++++++++
 2 files changed, 14 insertions(+)
 create mode 100644 srcpkgs/sane-airscan/template

diff --git a/common/shlibs b/common/shlibs
index 42f37d8a08b..d53d82ba810 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3966,3 +3966,4 @@ libsimavrparts.so.1 simavr-1.6_2
 libsword-1.8.1.so libsword-1.8.1_6
 libpari-gmp.so.7 pari-2.13.0_1
 libtree-sitter.so.0 tree-sitter-0.19.0_1
+libsane-airscan.so.1 sane-airscan-0.99.24_1
diff --git a/srcpkgs/sane-airscan/template b/srcpkgs/sane-airscan/template
new file mode 100644
index 00000000000..98eedc6e29c
--- /dev/null
+++ b/srcpkgs/sane-airscan/template
@@ -0,0 +1,13 @@
+# Template file for 'sane-airscan'
+pkgname=sane-airscan
+version=0.99.24
+revision=1
+build_style=meson
+hostmakedepends="pkg-config"
+makedepends="avahi-libs-devel libxml2-devel libjpeg-turbo-devel libpng-devel sane-devel gnutls-devel"
+short_desc="SANE backend for AirScan (eSCL) and WSD document scanners"
+maintainer="Philipp David <pd@3b.pm>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/alexpevzner/sane-airscan"
+distfiles="https://github.com/alexpevzner/${pkgname}/archive/${version}.tar.gz"
+checksum=723ec0a139943d268615082d76ab860d7aa24a5d2b53763f49ecec4293b3d934

Re: [PR PATCH] [Updated] New package: sane-airscan-0.99.24

[oynqr]

[-- Attachment #1: Type: text/plain, Size: 1709 bytes --]

There is an updated pull request by oynqr against master on the void-packages repository

https://github.com/oynqr/void-packages sane-airscan
https://github.com/void-linux/void-packages/pull/29392

New package: sane-airscan-0.99.24
Just #27448 with changed maintainer and updated to the latest version.
Would go along well with #28945.

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/29392.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sane-airscan-29392.patch --]
[-- Type: text/x-diff, Size: 1523 bytes --]

From e511fc66cf9712fb1629a5ef2421f59ebf0ce8af Mon Sep 17 00:00:00 2001
From: Philipp David <pd@3b.pm>
Date: Thu, 11 Mar 2021 11:03:00 +0100
Subject: [PATCH] New package: sane-airscan-0.99.24

---
 common/shlibs                 |  1 +
 srcpkgs/sane-airscan/template | 13 +++++++++++++
 2 files changed, 14 insertions(+)
 create mode 100644 srcpkgs/sane-airscan/template

diff --git a/common/shlibs b/common/shlibs
index 4b82c3ced654..7ec960f8c214 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3971,3 +3971,4 @@ libwayland-cursor++.so.0 libwaylandpp-0.2.8_1
 libwayland-egl++.so.0 libwaylandpp-0.2.8_1
 libwayland-client-extra++.so.0 libwaylandpp-0.2.8_1
 libspdlog.so.1 libspdlog-1.8.2_2
+libsane-airscan.so.1 sane-airscan-0.99.24_1
diff --git a/srcpkgs/sane-airscan/template b/srcpkgs/sane-airscan/template
new file mode 100644
index 000000000000..98eedc6e29c0
--- /dev/null
+++ b/srcpkgs/sane-airscan/template
@@ -0,0 +1,13 @@
+# Template file for 'sane-airscan'
+pkgname=sane-airscan
+version=0.99.24
+revision=1
+build_style=meson
+hostmakedepends="pkg-config"
+makedepends="avahi-libs-devel libxml2-devel libjpeg-turbo-devel libpng-devel sane-devel gnutls-devel"
+short_desc="SANE backend for AirScan (eSCL) and WSD document scanners"
+maintainer="Philipp David <pd@3b.pm>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/alexpevzner/sane-airscan"
+distfiles="https://github.com/alexpevzner/${pkgname}/archive/${version}.tar.gz"
+checksum=723ec0a139943d268615082d76ab860d7aa24a5d2b53763f49ecec4293b3d934

Re: New package: sane-airscan-0.99.24

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29392#issuecomment-807852558

Comment:
Closing in favor of #29627, because meson isn't completely supported by upstream, unfortunately. Thanks!

Re: [PR PATCH] [Closed]: New package: sane-airscan-0.99.24

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1552 bytes --]

There's a closed pull request on the void-packages repository

New package: sane-airscan-0.99.24
https://github.com/void-linux/void-packages/pull/29392

Description:
Just #27448 with changed maintainer and updated to the latest version.
Would go along well with #28945.

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

Re: New package: sane-airscan-0.99.24

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29627#issuecomment-807478255

Comment:
In that case, I think we should go with the Makefile based build.

Re: New package: sane-airscan-0.99.24

[pudiva]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

New comment by pudiva on void-packages repository

https://github.com/void-linux/void-packages/pull/29627#issuecomment-806875028

Comment:
> Maybe report it upstream, but the makefile version is missing the unversioned symlink:
> 
> > /usr/lib/sane/libsane-airscan.so -> /usr/lib/sane/libsane-airscan.so.1

I submitted a PR, but upstream didn't like the unversioned symlink, and also shared that they don't really maintain the **meson** build, but just try to not break it ~ sounds like they prefer **make**. Their full response:

> Nobody links against these drivers directly, they are always loaded via sane-dll, which doesn't use unversioned symlink. So I believe that SANE itself creates these links only for legacy reasons and there is no need to reproduce this behaviour in the independent package.
> 
> Official packages for Fedora, Debian and Ubuntu come without this symlink and it causes no problems and no complains.
> 
> Regarding meson build, it was contributed by my users and I don't maintain it, I only keep it here for everybody's convenience and trying not to break when something changes in the project.
> 
> So really thank for your contribution, but in this particular case I don't think we really need it.

https://github.com/alexpevzner/sane-airscan/pull/132#issuecomment-806477624

Re: New package: sane-airscan-0.99.24

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29627#issuecomment-804182904

Comment:
Maybe report it upstream, but the makefile version is missing the unversioned symlink:

> /usr/lib/sane/libsane-airscan.so -> /usr/lib/sane/libsane-airscan.so.1

Re: New package: sane-airscan-0.99.24

[pudiva]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

New comment by pudiva on void-packages repository

https://github.com/void-linux/void-packages/pull/29627#issuecomment-804139492

Comment:
In case people prefer to go with my version (**make**) rather than #29392 (**meson**), I just added the line to _shlibs_ that I had forgotten...

...my template had to define the `do_install()` because the `gnu-makefile` style defines the variable `STRIP=true`, which breaks this particular pkg. I usually favour **make** over other build systems because it's a standard tool ~ which means less dependencies ~ but since void already suports **meson**, then perhaps it's better to go with it, as it requires less template code to maintain.

Re: New package: sane-airscan-0.99.24

[oynqr]

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

New comment by oynqr on void-packages repository

https://github.com/void-linux/void-packages/pull/29627#issuecomment-803847217

Comment:
#29392 uses meson and this uses make.
It seems like both are supported by upstream and other distros are not largely favoring one either, with Arch and Fedora using make and Nix and ALT using meson.

Re: New package: sane-airscan-0.99.24

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29627#issuecomment-803322793

Comment:
Duplicate of #29392, but I haven't looked at the difference between the templates yet.