Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Manual.md: indicate 80 character line limit
@ 2021-03-26 20:11 NeelChotai
  2021-03-26 20:20 ` ericonr
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: NeelChotai @ 2021-03-26 20:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

There is a new pull request by NeelChotai against master on the void-packages repository

https://github.com/NeelChotai/void-packages template-line-limit
https://github.com/void-linux/void-packages/pull/29765

Manual.md: indicate 80 character line limit
@ericonr do you think this is enough of an indication or would an example be helpful?

A patch file from https://github.com/void-linux/void-packages/pull/29765.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-template-line-limit-29765.patch --]
[-- Type: text/x-diff, Size: 744 bytes --]

From 613d7cca1b3c12a632cdade8dcf0f77f416e413f Mon Sep 17 00:00:00 2001
From: Neel Chotai <neel@chot.ai>
Date: Fri, 26 Mar 2021 20:05:46 +0000
Subject: [PATCH] Manual.md: indicate 80 character line limit

---
 Manual.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Manual.md b/Manual.md
index 4439865e1d73..e2979fbec51b 100644
--- a/Manual.md
+++ b/Manual.md
@@ -88,6 +88,9 @@ By convention, all templates start with a comment briefly explaining what they
 are. In addition, pkgname and version can't have any characters in them that
 would require them to be quoted, so they are not quoted.
 
+Try to break any lines over 80 characters where it makes sense, e.g. in
+dependencies.
+
 A simple `template` example is as follows:
 
 ```

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Manual.md: indicate 80 character line limit
  2021-03-26 20:11 [PR PATCH] Manual.md: indicate 80 character line limit NeelChotai
@ 2021-03-26 20:20 ` ericonr
  2021-03-26 21:40 ` [PR PATCH] [Closed]: " NeelChotai
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-03-26 20:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29765#issuecomment-808487333

Comment:
I don't think an example is necessary, but I'm not sure about the current phrasing either. Might try to rework this entire section so it can fit in more naturally.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: Manual.md: indicate 80 character line limit
  2021-03-26 20:11 [PR PATCH] Manual.md: indicate 80 character line limit NeelChotai
  2021-03-26 20:20 ` ericonr
@ 2021-03-26 21:40 ` NeelChotai
  2021-03-26 21:58 ` ericonr
  2021-03-26 22:04 ` NeelChotai
  3 siblings, 0 replies; 5+ messages in thread
From: NeelChotai @ 2021-03-26 21:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

There's a closed pull request on the void-packages repository

Manual.md: indicate 80 character line limit
https://github.com/void-linux/void-packages/pull/29765

Description:
@ericonr do you think this is enough of an indication or would an example be helpful?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Manual.md: indicate 80 character line limit
  2021-03-26 20:11 [PR PATCH] Manual.md: indicate 80 character line limit NeelChotai
  2021-03-26 20:20 ` ericonr
  2021-03-26 21:40 ` [PR PATCH] [Closed]: " NeelChotai
@ 2021-03-26 21:58 ` ericonr
  2021-03-26 22:04 ` NeelChotai
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-03-26 21:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29765#issuecomment-808547469

Comment:
Could have been left open for others to leave their opinion and as reminder too, but no worries :v 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Manual.md: indicate 80 character line limit
  2021-03-26 20:11 [PR PATCH] Manual.md: indicate 80 character line limit NeelChotai
                   ` (2 preceding siblings ...)
  2021-03-26 21:58 ` ericonr
@ 2021-03-26 22:04 ` NeelChotai
  3 siblings, 0 replies; 5+ messages in thread
From: NeelChotai @ 2021-03-26 22:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

New comment by NeelChotai on void-packages repository

https://github.com/void-linux/void-packages/pull/29765#issuecomment-808551776

Comment:
> Could have been left open for others to leave their opinion and as reminder too, but no worries :v

I definitely agree with you that a one line explanation won't help too much with making the intention clearer, I closed the PR because I misread and thought you were currently in the process of rewriting the whole section. I can reopen and try to mess with the language a bit if we want a quick fix!

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-03-26 22:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26 20:11 [PR PATCH] Manual.md: indicate 80 character line limit NeelChotai
2021-03-26 20:20 ` ericonr
2021-03-26 21:40 ` [PR PATCH] [Closed]: " NeelChotai
2021-03-26 21:58 ` ericonr
2021-03-26 22:04 ` NeelChotai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).