[PR PATCH] gumbo-parser: depend -devel package on the base and add it to shlibs

[PR PATCH] gumbo-parser: depend -devel package on the base and add it to shlibs

[krkk]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

There is a new pull request by krkk against master on the void-packages repository

https://github.com/krkk/void-packages gumbo
https://github.com/void-linux/void-packages/pull/29926

gumbo-parser: depend -devel package on the base and add it to shlibs
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/29926.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gumbo-29926.patch --]
[-- Type: text/x-diff, Size: 2212 bytes --]

From 9d33daf556b7243ba9aee5f863bb88aa73b398cb Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 1 Apr 2021 11:31:53 +0200
Subject: [PATCH 1/2] gumbo-parser: depend -devel package on the base and add
 it to shlibs

Installing gumbo-parser-devel didn't provide .so files,
because they are in the base package, so packages depending on
this library used the static one instead.
---
 common/shlibs                 | 1 +
 srcpkgs/gumbo-parser/template | 1 +
 2 files changed, 2 insertions(+)

diff --git a/common/shlibs b/common/shlibs
index 0f3cd7161b1b..9cc5873cdaed 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3973,3 +3973,4 @@ libspdlog.so.1 libspdlog-1.8.2_2
 libmd.so.0 libmd-1.0.3_1
 libldacBT_abr.so.2 ldacBT-2.0.2.3_1
 libldacBT_enc.so.2 ldacBT-2.0.2.3_1
+libgumbo.so.1 gumbo-parser-0.10.1_2
diff --git a/srcpkgs/gumbo-parser/template b/srcpkgs/gumbo-parser/template
index 40daed6dbdda..93b78fd5a5a6 100644
--- a/srcpkgs/gumbo-parser/template
+++ b/srcpkgs/gumbo-parser/template
@@ -19,6 +19,7 @@ pre_configure() {
 
 gumbo-parser-devel_package() {
 	short_desc+=" - development files"
+	depends="${sourcepkg}>=${version}_${revision}"
 	pkg_install() {
 		vmove usr/include
 		vmove usr/lib/pkgconfig

From 5852667445c9c0196a48deb72a255f14fc96aa96 Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 1 Apr 2021 11:56:07 +0200
Subject: [PATCH 2/2] httpdirfs: revbump for gumbo-parser and remove depends

Libraries are detected automatically by xbps-src anyway.
---
 srcpkgs/httpdirfs/template | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/srcpkgs/httpdirfs/template b/srcpkgs/httpdirfs/template
index cbff9e7ae259..642e893c0435 100644
--- a/srcpkgs/httpdirfs/template
+++ b/srcpkgs/httpdirfs/template
@@ -1,12 +1,11 @@
 # Template file for 'httpdirfs'
 pkgname=httpdirfs
 version=1.2.0
-revision=3
+revision=4
 build_style=gnu-makefile
 make_install_args="prefix=/usr"
 makedepends="libcurl-devel fuse-devel gumbo-parser-devel
  libuuid-devel expat-devel"
-depends="libcurl fuse gumbo-parser"
 short_desc="Mount HTTP directory listings, with a permanent cache"
 maintainer="Nathan Owens <ndowens04@gmail.com>"
 license="GPL-3.0-only"

Re: [PR PATCH] [Updated] gumbo-parser: depend -devel package on the base and add it to shlibs

[krkk]

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

There is an updated pull request by krkk against master on the void-packages repository

https://github.com/krkk/void-packages gumbo
https://github.com/void-linux/void-packages/pull/29926

gumbo-parser: depend -devel package on the base and add it to shlibs
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/29926.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gumbo-29926.patch --]
[-- Type: text/x-diff, Size: 2659 bytes --]

From 8eb7b1e5c1ed8bb6c1a6751ae9034e7913eaf697 Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 1 Apr 2021 11:31:53 +0200
Subject: [PATCH 1/2] gumbo-parser: depend -devel package on the base and fixes

- Installing gumbo-parser-devel didn't provide .so files,
  because they are in the base package, so packages depending on
  this library used the static one instead.

- add libgumbo to shlibs

- fix checks

- remove starting an article
---
 common/shlibs                 | 1 +
 srcpkgs/gumbo-parser/template | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/common/shlibs b/common/shlibs
index 0f3cd7161b1b..9cc5873cdaed 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3973,3 +3973,4 @@ libspdlog.so.1 libspdlog-1.8.2_2
 libmd.so.0 libmd-1.0.3_1
 libldacBT_abr.so.2 ldacBT-2.0.2.3_1
 libldacBT_enc.so.2 ldacBT-2.0.2.3_1
+libgumbo.so.1 gumbo-parser-0.10.1_2
diff --git a/srcpkgs/gumbo-parser/template b/srcpkgs/gumbo-parser/template
index 40daed6dbdda..db546f7640f1 100644
--- a/srcpkgs/gumbo-parser/template
+++ b/srcpkgs/gumbo-parser/template
@@ -4,7 +4,8 @@ version=0.10.1
 revision=2
 build_style=gnu-configure
 hostmakedepends="autoconf automake libtool"
-short_desc="An HTML5 parsing library in pure C99"
+checkdepends="gtest-devel"
+short_desc="HTML5 parsing library in pure C99"
 maintainer="Oliver Kiddle <okiddle@yahoo.co.uk>"
 license="Apache-2.0"
 homepage="https://github.com/google/gumbo-parser"
@@ -19,6 +20,7 @@ pre_configure() {
 
 gumbo-parser-devel_package() {
 	short_desc+=" - development files"
+	depends="${sourcepkg}>=${version}_${revision}"
 	pkg_install() {
 		vmove usr/include
 		vmove usr/lib/pkgconfig

From e0ed3c5d601574a446ad21d13809c8d28d8d8a91 Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 1 Apr 2021 11:56:07 +0200
Subject: [PATCH 2/2] httpdirfs: revbump for gumbo-parser and remove depends

Libraries are detected automatically by xbps-src anyway.
---
 srcpkgs/httpdirfs/template | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/srcpkgs/httpdirfs/template b/srcpkgs/httpdirfs/template
index cbff9e7ae259..642e893c0435 100644
--- a/srcpkgs/httpdirfs/template
+++ b/srcpkgs/httpdirfs/template
@@ -1,12 +1,11 @@
 # Template file for 'httpdirfs'
 pkgname=httpdirfs
 version=1.2.0
-revision=3
+revision=4
 build_style=gnu-makefile
 make_install_args="prefix=/usr"
 makedepends="libcurl-devel fuse-devel gumbo-parser-devel
  libuuid-devel expat-devel"
-depends="libcurl fuse gumbo-parser"
 short_desc="Mount HTTP directory listings, with a permanent cache"
 maintainer="Nathan Owens <ndowens04@gmail.com>"
 license="GPL-3.0-only"

Re: gumbo-parser: depend -devel package on the base and add it to shlibs

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29926#issuecomment-811928698

Comment:
Nice find!

If you have the time, please consider fixing the other packages that have `gumbo-parser-devel` as well :)

They are `mupdf`, `FeedReader`, `fbpdf` and `zimwriterfs`.

Re: [PR PATCH] [Merged]: gumbo-parser: depend -devel package on the base and add it to shlibs

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

There's a merged pull request on the void-packages repository

gumbo-parser: depend -devel package on the base and add it to shlibs
https://github.com/void-linux/void-packages/pull/29926

Description:
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

Re: gumbo-parser: depend -devel package on the base and add it to shlibs

[krkk]

[-- Attachment #1: Type: text/plain, Size: 632 bytes --]

New comment by krkk on void-packages repository

https://github.com/void-linux/void-packages/pull/29926#issuecomment-811949893

Comment:
> If you have the time, please consider fixing the other packages that have `gumbo-parser-devel` as well :)
> 
> They are `mupdf`, `FeedReader`, `fbpdf` and `zimwriterfs`.

Sure thing! I used `xbps-query -RX gumbo-parser` to find the packages, but it gave only `httpdirfs`, so I thought it was the only package that uses it (which now makes sense, because they didn't set it in `depends=`like`httpdirfs` and `xbps-src` didn't detect the soname, because the library was linked statically…)