[PR PATCH] Use linked gumbo-parser library for other packages

[PR PATCH] Use linked gumbo-parser library for other packages

[krkk]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

There is a new pull request by krkk against master on the void-packages repository

https://github.com/krkk/void-packages gumbo-bumps
https://github.com/void-linux/void-packages/pull/29936

Use linked gumbo-parser library for other packages
#### General
Continuation of #29926

- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/29936.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gumbo-bumps-29936.patch --]
[-- Type: text/x-diff, Size: 2825 bytes --]

From 9855be36cf2447f2bc1d1d05bb937132da67bf6f Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 1 Apr 2021 16:35:10 +0200
Subject: [PATCH 1/4] mupdf: revbump for gumbo-parser

---
 srcpkgs/mupdf/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/mupdf/template b/srcpkgs/mupdf/template
index c8f05d1d3459..1279d8c680d4 100644
--- a/srcpkgs/mupdf/template
+++ b/srcpkgs/mupdf/template
@@ -1,7 +1,7 @@
 # Template file for 'mupdf'
 pkgname=mupdf
 version=1.18.0
-revision=2
+revision=3
 wrksrc="${pkgname}-${version}-source"
 hostmakedepends="pkg-config zlib-devel libcurl-devel freetype-devel
  libjpeg-turbo-devel jbig2dec-devel libXext-devel libXcursor-devel

From 4fb0fd34c486b38b21c6cf909f0689e771d72521 Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 1 Apr 2021 16:35:10 +0200
Subject: [PATCH 2/4] FeedReader: revbump for gumbo-parser

---
 srcpkgs/FeedReader/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/FeedReader/template b/srcpkgs/FeedReader/template
index 53dc7acb745f..ab71a0c6f042 100644
--- a/srcpkgs/FeedReader/template
+++ b/srcpkgs/FeedReader/template
@@ -1,7 +1,7 @@
 # Template file for 'FeedReader'
 pkgname=FeedReader
 version=2.11.0
-revision=1
+revision=2
 build_style=meson
 hostmakedepends="glib-devel intltool itstool pkg-config vala"
 makedepends="gnome-online-accounts-devel gst-plugins-base1-devel json-glib-devel

From 2332a3704de6913c10d07d562de11f32429c1302 Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 1 Apr 2021 16:35:10 +0200
Subject: [PATCH 3/4] fbpdf: revbump for gumbo-parser

---
 srcpkgs/fbpdf/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/fbpdf/template b/srcpkgs/fbpdf/template
index 805f90a4ca17..ec6965ef45a8 100644
--- a/srcpkgs/fbpdf/template
+++ b/srcpkgs/fbpdf/template
@@ -1,7 +1,7 @@
 # Template file for 'fbpdf'
 pkgname=fbpdf
 version=0.0.20200616
-revision=1
+revision=2
 _githash=f59002487edba502aaa93e9aec3bb6ebbbe41b0e
 _gitshort="${_githash:0:7}"
 wrksrc="fbpdf-${_gitshort}"

From 08750c89a93ddfd92e98a57d4bba4f65849e313b Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 1 Apr 2021 16:35:11 +0200
Subject: [PATCH 4/4] zimwriterfs: revbump for gumbo-parser

---
 srcpkgs/zimwriterfs/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/zimwriterfs/template b/srcpkgs/zimwriterfs/template
index 5d42e16a119d..bf13bf7e65bc 100644
--- a/srcpkgs/zimwriterfs/template
+++ b/srcpkgs/zimwriterfs/template
@@ -1,7 +1,7 @@
 # Template file for 'zimwriterfs'
 pkgname=zimwriterfs
 version=1.3.7
-revision=2
+revision=3
 build_style=meson
 hostmakedepends="pkg-config"
 makedepends="file-devel gumbo-parser-devel icu-devel libzim-devel

Re: Use linked gumbo-parser library for other packages

[krkk]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by krkk on void-packages repository

https://github.com/void-linux/void-packages/pull/29936#issuecomment-811997414

Comment:
Build logs still seem to use the static library. Do I have to rebuild the gumbo-parser first?

Re: Use linked gumbo-parser library for other packages

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29936#issuecomment-812012019

Comment:
Oh damn! I got fooled by the CI results in the previous PR. `gumbo-parser` should be revbumped here, and so should `httpdirfs`, because the version in the builders used the old still static gumbo-parser.

Re: Use linked gumbo-parser library for other packages

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29936#issuecomment-812012356

Comment:
And please say "revbump to use dynamic gumbo-parser" in the commit messages :)

Re: [PR PATCH] [Updated] Use linked gumbo-parser library for other packages

[krkk]

[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]

There is an updated pull request by krkk against master on the void-packages repository

https://github.com/krkk/void-packages gumbo-bumps
https://github.com/void-linux/void-packages/pull/29936

Use linked gumbo-parser library for other packages
#### General
Continuation of #29926

- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/29936.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gumbo-bumps-29936.patch --]
[-- Type: text/x-diff, Size: 4287 bytes --]

From 9fbc0b081a4f97924ed9663a1a10508210b4d51f Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 1 Apr 2021 17:39:55 +0200
Subject: [PATCH 1/6] gumbo-parser: rebuild to let packages use dynamic library

---
 srcpkgs/gumbo-parser/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/gumbo-parser/template b/srcpkgs/gumbo-parser/template
index db546f7640f1..c742091fd7d7 100644
--- a/srcpkgs/gumbo-parser/template
+++ b/srcpkgs/gumbo-parser/template
@@ -1,7 +1,7 @@
 # Template file for 'gumbo-parser'
 pkgname=gumbo-parser
 version=0.10.1
-revision=2
+revision=3
 build_style=gnu-configure
 hostmakedepends="autoconf automake libtool"
 checkdepends="gtest-devel"

From 9175c39880c71d5fa031c82ee88e12d0a89324a9 Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 1 Apr 2021 17:40:40 +0200
Subject: [PATCH 2/6] httpdirfs: revbump to use dynamic gumbo-parser

---
 srcpkgs/httpdirfs/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/httpdirfs/template b/srcpkgs/httpdirfs/template
index 642e893c0435..0028d235c5db 100644
--- a/srcpkgs/httpdirfs/template
+++ b/srcpkgs/httpdirfs/template
@@ -1,7 +1,7 @@
 # Template file for 'httpdirfs'
 pkgname=httpdirfs
 version=1.2.0
-revision=4
+revision=5
 build_style=gnu-makefile
 make_install_args="prefix=/usr"
 makedepends="libcurl-devel fuse-devel gumbo-parser-devel

From 9a6b47ebba112ddbcf628a27855976053520a7d7 Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 1 Apr 2021 16:35:10 +0200
Subject: [PATCH 3/6] mupdf: revbump to use dynamic gumbo-parser

---
 srcpkgs/mupdf/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/mupdf/template b/srcpkgs/mupdf/template
index c8f05d1d3459..1279d8c680d4 100644
--- a/srcpkgs/mupdf/template
+++ b/srcpkgs/mupdf/template
@@ -1,7 +1,7 @@
 # Template file for 'mupdf'
 pkgname=mupdf
 version=1.18.0
-revision=2
+revision=3
 wrksrc="${pkgname}-${version}-source"
 hostmakedepends="pkg-config zlib-devel libcurl-devel freetype-devel
  libjpeg-turbo-devel jbig2dec-devel libXext-devel libXcursor-devel

From ff0ca33f384f53a318ff87440a3fb6588a5377e1 Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 1 Apr 2021 16:35:10 +0200
Subject: [PATCH 4/6] FeedReader: revbump to use dynamic gumbo-parser

---
 srcpkgs/FeedReader/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/FeedReader/template b/srcpkgs/FeedReader/template
index 53dc7acb745f..ab71a0c6f042 100644
--- a/srcpkgs/FeedReader/template
+++ b/srcpkgs/FeedReader/template
@@ -1,7 +1,7 @@
 # Template file for 'FeedReader'
 pkgname=FeedReader
 version=2.11.0
-revision=1
+revision=2
 build_style=meson
 hostmakedepends="glib-devel intltool itstool pkg-config vala"
 makedepends="gnome-online-accounts-devel gst-plugins-base1-devel json-glib-devel

From 5ca32d05be96f422da30737d9d76cf4e68432eac Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 1 Apr 2021 16:35:10 +0200
Subject: [PATCH 5/6] fbpdf: revbump to use dynamic gumbo-parser

---
 srcpkgs/fbpdf/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/fbpdf/template b/srcpkgs/fbpdf/template
index 805f90a4ca17..ec6965ef45a8 100644
--- a/srcpkgs/fbpdf/template
+++ b/srcpkgs/fbpdf/template
@@ -1,7 +1,7 @@
 # Template file for 'fbpdf'
 pkgname=fbpdf
 version=0.0.20200616
-revision=1
+revision=2
 _githash=f59002487edba502aaa93e9aec3bb6ebbbe41b0e
 _gitshort="${_githash:0:7}"
 wrksrc="fbpdf-${_gitshort}"

From 9878c87e19cc9e30e45477dd8a71674926daec87 Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Thu, 1 Apr 2021 16:35:11 +0200
Subject: [PATCH 6/6] zimwriterfs: revbump to use dynamic gumbo-parser

---
 srcpkgs/zimwriterfs/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/zimwriterfs/template b/srcpkgs/zimwriterfs/template
index 5d42e16a119d..bf13bf7e65bc 100644
--- a/srcpkgs/zimwriterfs/template
+++ b/srcpkgs/zimwriterfs/template
@@ -1,7 +1,7 @@
 # Template file for 'zimwriterfs'
 pkgname=zimwriterfs
 version=1.3.7
-revision=2
+revision=3
 build_style=meson
 hostmakedepends="pkg-config"
 makedepends="file-devel gumbo-parser-devel icu-devel libzim-devel

Re: Use linked gumbo-parser library for other packages

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29936#issuecomment-812125277

Comment:
There's a conflict somewhere in the branch, it won't allow me to merge from the web UI.

Looks good to me, I'd like to test building something using mupdf first tho.

Re: Use linked gumbo-parser library for other packages

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29936#issuecomment-812126074

Comment:
Seems to be an issue with GH, so don't worry.

Re: [PR PATCH] [Closed]: Use linked gumbo-parser library for other packages

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

There's a closed pull request on the void-packages repository

Use linked gumbo-parser library for other packages
https://github.com/void-linux/void-packages/pull/29936

Description:
#### General
Continuation of #29926

- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

Re: Use linked gumbo-parser library for other packages

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29936#issuecomment-812806255

Comment:
Had to merge manually because of the GH bug, thanks :D