* Re: [PR REVIEW] starship: update to 0.51.0
2021-03-23 18:06 [PR PATCH] starship: update to 0.51.0 FollieHiyuki
@ 2021-03-23 18:25 ` ericonr
2021-03-23 18:25 ` ericonr
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-03-23 18:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29705#discussion_r599828188
Comment:
Can you check if
```suggestion
site='https://github.com/starship/starship'
```
works?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] starship: update to 0.51.0
2021-03-23 18:06 [PR PATCH] starship: update to 0.51.0 FollieHiyuki
2021-03-23 18:25 ` [PR REVIEW] " ericonr
@ 2021-03-23 18:25 ` ericonr
2021-03-23 18:43 ` ericonr
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-03-23 18:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 172 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29705#discussion_r599829039
Comment:
Why remove `libgit2` now?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] starship: update to 0.51.0
2021-03-23 18:06 [PR PATCH] starship: update to 0.51.0 FollieHiyuki
2021-03-23 18:25 ` [PR REVIEW] " ericonr
2021-03-23 18:25 ` ericonr
@ 2021-03-23 18:43 ` ericonr
2021-03-23 19:26 ` [PR PATCH] [Updated] " FollieHiyuki
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-03-23 18:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29705#discussion_r599841086
Comment:
It is probably not picking up because we have 1.0 (see #28456), which means it builds a statically linked libgit2. But `libgit2-devel` also pulls in `zlib-devel`, which is necessary here, otherwise it will also build a statically linked copy of zlib.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Updated] starship: update to 0.51.0
2021-03-23 18:06 [PR PATCH] starship: update to 0.51.0 FollieHiyuki
` (2 preceding siblings ...)
2021-03-23 18:43 ` ericonr
@ 2021-03-23 19:26 ` FollieHiyuki
2021-03-23 19:26 ` [PR REVIEW] " FollieHiyuki
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: FollieHiyuki @ 2021-03-23 19:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1611 bytes --]
There is an updated pull request by FollieHiyuki against master on the void-packages repository
https://github.com/FollieHiyuki/void-packages starship-update
https://github.com/void-linux/void-packages/pull/29705
starship: update to 0.51.0
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29705.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-starship-update-29705.patch --]
[-- Type: text/x-diff, Size: 1445 bytes --]
From dd360205a2690c799101d686eb9ea33ec622f8d7 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Tue, 23 Mar 2021 21:02:24 +0300
Subject: [PATCH] starship: update to 0.51.0
---
srcpkgs/starship/template | 6 +++---
srcpkgs/starship/update | 2 ++
2 files changed, 5 insertions(+), 3 deletions(-)
create mode 100644 srcpkgs/starship/update
diff --git a/srcpkgs/starship/template b/srcpkgs/starship/template
index 9362f5664cba..f7e0d45bd71b 100644
--- a/srcpkgs/starship/template
+++ b/srcpkgs/starship/template
@@ -1,7 +1,7 @@
# Template file for 'starship'
pkgname=starship
-version=0.50.0
-revision=2
+version=0.51.0
+revision=1
build_style=cargo
build_helper=qemu
hostmakedepends="pkg-config libgit2-devel"
@@ -12,7 +12,7 @@ maintainer="Aluísio Augusto Silva Gonçalves <aluisio@aasg.name>"
license="ISC"
homepage="https://starship.rs"
distfiles="https://github.com/starship/starship/archive/v${version}.tar.gz"
-checksum=d8f4dc9bd266f2a5c34926d361c62fdddb61cd7da4acadba5f9c175eb07602e5
+checksum=87a9e2ad206a7397e52e00a0a650d364ca2ea941cb9fbe75704d56a43f11cef9
post_build() {
STARSHIP="target/${RUST_TARGET}/release/starship"
diff --git a/srcpkgs/starship/update b/srcpkgs/starship/update
new file mode 100644
index 000000000000..342ead75d332
--- /dev/null
+++ b/srcpkgs/starship/update
@@ -0,0 +1,2 @@
+site='https://github.com/starship/starship/releases'
+pattern='v\K[\d]+\.[\d]+\.[\d]+'
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] starship: update to 0.51.0
2021-03-23 18:06 [PR PATCH] starship: update to 0.51.0 FollieHiyuki
` (3 preceding siblings ...)
2021-03-23 19:26 ` [PR PATCH] [Updated] " FollieHiyuki
@ 2021-03-23 19:26 ` FollieHiyuki
2021-03-23 19:27 ` FollieHiyuki
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: FollieHiyuki @ 2021-03-23 19:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
New review comment by FollieHiyuki on void-packages repository
https://github.com/void-linux/void-packages/pull/29705#discussion_r599869366
Comment:
Ah yes my mistake. I forgot that PR hasn't been merged
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] starship: update to 0.51.0
2021-03-23 18:06 [PR PATCH] starship: update to 0.51.0 FollieHiyuki
` (4 preceding siblings ...)
2021-03-23 19:26 ` [PR REVIEW] " FollieHiyuki
@ 2021-03-23 19:27 ` FollieHiyuki
2021-04-04 23:25 ` ericonr
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: FollieHiyuki @ 2021-03-23 19:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 172 bytes --]
New review comment by FollieHiyuki on void-packages repository
https://github.com/void-linux/void-packages/pull/29705#discussion_r599869459
Comment:
Doesn't seem to work
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: starship: update to 0.51.0
2021-03-23 18:06 [PR PATCH] starship: update to 0.51.0 FollieHiyuki
` (5 preceding siblings ...)
2021-03-23 19:27 ` FollieHiyuki
@ 2021-04-04 23:25 ` ericonr
2021-04-04 23:31 ` [PR PATCH] [Updated] " FollieHiyuki
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-04-04 23:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 192 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29705#issuecomment-813115582
Comment:
I don't think the update file is necessary anymore?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Updated] starship: update to 0.51.0
2021-03-23 18:06 [PR PATCH] starship: update to 0.51.0 FollieHiyuki
` (6 preceding siblings ...)
2021-04-04 23:25 ` ericonr
@ 2021-04-04 23:31 ` FollieHiyuki
2021-04-04 23:31 ` FollieHiyuki
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: FollieHiyuki @ 2021-04-04 23:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1611 bytes --]
There is an updated pull request by FollieHiyuki against master on the void-packages repository
https://github.com/FollieHiyuki/void-packages starship-update
https://github.com/void-linux/void-packages/pull/29705
starship: update to 0.51.0
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/29705.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-starship-update-29705.patch --]
[-- Type: text/x-diff, Size: 1101 bytes --]
From d0173acb256a38bbdf29de3cc73710e998e52343 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Tue, 23 Mar 2021 21:02:24 +0300
Subject: [PATCH] starship: update to 0.51.0
---
srcpkgs/starship/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/starship/template b/srcpkgs/starship/template
index 9362f5664cba..f7e0d45bd71b 100644
--- a/srcpkgs/starship/template
+++ b/srcpkgs/starship/template
@@ -1,7 +1,7 @@
# Template file for 'starship'
pkgname=starship
-version=0.50.0
-revision=2
+version=0.51.0
+revision=1
build_style=cargo
build_helper=qemu
hostmakedepends="pkg-config libgit2-devel"
@@ -12,7 +12,7 @@ maintainer="Aluísio Augusto Silva Gonçalves <aluisio@aasg.name>"
license="ISC"
homepage="https://starship.rs"
distfiles="https://github.com/starship/starship/archive/v${version}.tar.gz"
-checksum=d8f4dc9bd266f2a5c34926d361c62fdddb61cd7da4acadba5f9c175eb07602e5
+checksum=87a9e2ad206a7397e52e00a0a650d364ca2ea941cb9fbe75704d56a43f11cef9
post_build() {
STARSHIP="target/${RUST_TARGET}/release/starship"
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: starship: update to 0.51.0
2021-03-23 18:06 [PR PATCH] starship: update to 0.51.0 FollieHiyuki
` (7 preceding siblings ...)
2021-04-04 23:31 ` [PR PATCH] [Updated] " FollieHiyuki
@ 2021-04-04 23:31 ` FollieHiyuki
2021-04-04 23:46 ` ericonr
2021-04-04 23:47 ` [PR PATCH] [Closed]: " ericonr
10 siblings, 0 replies; 12+ messages in thread
From: FollieHiyuki @ 2021-04-04 23:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 157 bytes --]
New comment by FollieHiyuki on void-packages repository
https://github.com/void-linux/void-packages/pull/29705#issuecomment-813116226
Comment:
Yes deleted
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: starship: update to 0.51.0
2021-03-23 18:06 [PR PATCH] starship: update to 0.51.0 FollieHiyuki
` (8 preceding siblings ...)
2021-04-04 23:31 ` FollieHiyuki
@ 2021-04-04 23:46 ` ericonr
2021-04-04 23:47 ` [PR PATCH] [Closed]: " ericonr
10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-04-04 23:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/29705#issuecomment-813118005
Comment:
Maybe report
```
left: `Some("\u{1b}[1;33mastronaut\u{1b}[0m in ")`,
right: `Some("\u{1b}[1;31mastronaut\u{1b}[0m in ")`', src/modules/username.rs:156:9
```
their way?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Closed]: starship: update to 0.51.0
2021-03-23 18:06 [PR PATCH] starship: update to 0.51.0 FollieHiyuki
` (9 preceding siblings ...)
2021-04-04 23:46 ` ericonr
@ 2021-04-04 23:47 ` ericonr
10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-04-04 23:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
There's a closed pull request on the void-packages repository
starship: update to 0.51.0
https://github.com/void-linux/void-packages/pull/29705
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 12+ messages in thread