Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] MultiMC: added qt5-svg as dependency for proper rendering of icons
@ 2021-04-09  3:38 faerryn
  2021-04-09  3:40 ` faerryn
  2021-04-09 15:08 ` [PR PATCH] [Merged]: " ericonr
  0 siblings, 2 replies; 3+ messages in thread
From: faerryn @ 2021-04-09  3:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]

There is a new pull request by faerryn against master on the void-packages repository

https://github.com/faerryn/void-packages MultiMC_qt5-svg
https://github.com/void-linux/void-packages/pull/30103

MultiMC: added qt5-svg as dependency for proper rendering of icons
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30103.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-MultiMC_qt5-svg-30103.patch --]
[-- Type: text/x-diff, Size: 1172 bytes --]

From aaf17c01a0d1a8b9727f5a038e4dc94d91732f67 Mon Sep 17 00:00:00 2001
From: "Jiang Meng Liao (Faerryn)" <alexandre.liao@gmail.com>
Date: Thu, 8 Apr 2021 23:29:27 -0400
Subject: [PATCH] MultiMC: added qt5-svg as dependency for proper rendering of
 icons

---
 srcpkgs/MultiMC/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/MultiMC/template b/srcpkgs/MultiMC/template
index 162472b00022..6f19fc623d0a 100644
--- a/srcpkgs/MultiMC/template
+++ b/srcpkgs/MultiMC/template
@@ -1,7 +1,7 @@
 # Template file for 'MultiMC'
 pkgname=MultiMC
 version=0.6.12
-revision=1
+revision=2
 wrksrc="${pkgname}5-${version}"
 _commithashnbt="4b305bbd2ac0e7a26987baf7949a484a87b474d4"
 _nbtversion="multimc-0.6.1"
@@ -10,7 +10,7 @@ build_style=cmake
 configure_args='-DMultiMC_BUILD_PLATFORM=Void -DMultiMC_LAYOUT=lin-system'
 hostmakedepends="openjdk8 xxd git qt5-qmake qt5-host-tools tar"
 makedepends="qt5-devel qt5-x11extras-devel qt5-svg-devel gtk+-devel"
-depends="virtual?java-environment"
+depends="virtual?java-environment qt5-svg"
 short_desc="Instanced Minecraft client"
 maintainer="Henry Naguski <henry@nilsu.org>"
 license="Apache-2.0"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: MultiMC: added qt5-svg as dependency for proper rendering of icons
  2021-04-09  3:38 [PR PATCH] MultiMC: added qt5-svg as dependency for proper rendering of icons faerryn
@ 2021-04-09  3:40 ` faerryn
  2021-04-09 15:08 ` [PR PATCH] [Merged]: " ericonr
  1 sibling, 0 replies; 3+ messages in thread
From: faerryn @ 2021-04-09  3:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New comment by faerryn on void-packages repository

https://github.com/void-linux/void-packages/pull/30103#issuecomment-816378592

Comment:
In MultiMC, changing the icons in Settings/MultiMC/User Interface/Icons provides no icons other than the default. qt5-svg is needed to render the other MultiMC icon sets.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: MultiMC: added qt5-svg as dependency for proper rendering of icons
  2021-04-09  3:38 [PR PATCH] MultiMC: added qt5-svg as dependency for proper rendering of icons faerryn
  2021-04-09  3:40 ` faerryn
@ 2021-04-09 15:08 ` ericonr
  1 sibling, 0 replies; 3+ messages in thread
From: ericonr @ 2021-04-09 15:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]

There's a merged pull request on the void-packages repository

MultiMC: added qt5-svg as dependency for proper rendering of icons
https://github.com/void-linux/void-packages/pull/30103

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-09 15:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09  3:38 [PR PATCH] MultiMC: added qt5-svg as dependency for proper rendering of icons faerryn
2021-04-09  3:40 ` faerryn
2021-04-09 15:08 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).