[PR PATCH] bottom: shell completions

[PR PATCH] bottom: shell completions

[zweimach]

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]

There is a new pull request by zweimach against master on the void-packages repository

https://github.com/zweimach/void-packages bottom-completions
https://github.com/void-linux/void-packages/pull/29455

bottom: shell completions
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR (tested on bash and zsh)

NOTE: I follow `ripgrep/template` file for installing shell completions

A patch file from https://github.com/void-linux/void-packages/pull/29455.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bottom-completions-29455.patch --]
[-- Type: text/x-diff, Size: 818 bytes --]

From dd8fe379ec6c380db7865e4506313a81ea7a8815 Mon Sep 17 00:00:00 2001
From: Ananda Umamil <zweimach@zweimach.org>
Date: Sun, 14 Mar 2021 17:37:44 +0700
Subject: [PATCH] bottom: shell completions

---
 srcpkgs/bottom/template | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/srcpkgs/bottom/template b/srcpkgs/bottom/template
index 9d5fbd8dbfd0..00bf04a1b368 100644
--- a/srcpkgs/bottom/template
+++ b/srcpkgs/bottom/template
@@ -13,4 +13,9 @@ checksum=49e01a2930d913dba2a1329389faddb4b3971a6b0c08f7482d2759475d5cc27c
 post_install() {
 	vdoc README.md
 	vlicense LICENSE
+
+	cd "target/${RUST_TARGET}/release/build/bottom-"*/out
+	vinstall _btm 0644 usr/share/zsh/site-functions
+	vinstall btm.bash 0644 usr/share/bash-completion/completions btm
+	vinstall btm.fish 0644 usr/share/fish/vendor_completions.d
 }

Re: bottom: shell completions

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29455#issuecomment-798925623

Comment:
Please use `vcompletion` for new completions.

Re: bottom: shell completions

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29455#issuecomment-798925706

Comment:
Also, the PR needs to revbump the package for a new package to be built with the changes.

Re: [PR PATCH] [Updated] bottom: shell completions

[zweimach]

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

There is an updated pull request by zweimach against master on the void-packages repository

https://github.com/zweimach/void-packages bottom-completions
https://github.com/void-linux/void-packages/pull/29455

bottom: shell completions
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR (tested on bash and zsh)

NOTE: I follow `ripgrep/template` file for installing shell completions

A patch file from https://github.com/void-linux/void-packages/pull/29455.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bottom-completions-29455.patch --]
[-- Type: text/x-diff, Size: 992 bytes --]

From a23fe075c255943913e8e19925cf0d8c12d4341d Mon Sep 17 00:00:00 2001
From: Ananda Umamil <zweimach@zweimach.org>
Date: Sun, 14 Mar 2021 17:37:44 +0700
Subject: [PATCH] bottom: shell completions

---
 srcpkgs/bottom/template | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/bottom/template b/srcpkgs/bottom/template
index 9d5fbd8dbfd0..4e7c974401c5 100644
--- a/srcpkgs/bottom/template
+++ b/srcpkgs/bottom/template
@@ -1,7 +1,7 @@
 # Template file for 'bottom'
 pkgname=bottom
 version=0.5.7
-revision=1
+revision=2
 build_style=cargo
 short_desc="Yet another cross-platform graphical process/system monitor"
 maintainer="Neel Chotai <neel@chot.ai>"
@@ -13,4 +13,9 @@ checksum=49e01a2930d913dba2a1329389faddb4b3971a6b0c08f7482d2759475d5cc27c
 post_install() {
 	vdoc README.md
 	vlicense LICENSE
+
+	cd "target/${RUST_TARGET}/release/build/bottom-"*/out
+	vcompletion btm.bash bash bottom
+	vcompletion btm.fish fish bottom
+	vcompletion _btm zsh bottom
 }

Re: [PR PATCH] [Updated] bottom: shell completions

[zweimach]

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

There is an updated pull request by zweimach against master on the void-packages repository

https://github.com/zweimach/void-packages bottom-completions
https://github.com/void-linux/void-packages/pull/29455

bottom: shell completions
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/29455.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bottom-completions-29455.patch --]
[-- Type: text/x-diff, Size: 971 bytes --]

From b18cd8c3fb6f2f21425b8c2059a23a045dc2685b Mon Sep 17 00:00:00 2001
From: Ananda Umamil <zweimach@zweimach.org>
Date: Sun, 14 Mar 2021 17:37:44 +0700
Subject: [PATCH] bottom: shell completions

---
 srcpkgs/bottom/template | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/bottom/template b/srcpkgs/bottom/template
index 9d5fbd8dbfd0..2351b243f4f8 100644
--- a/srcpkgs/bottom/template
+++ b/srcpkgs/bottom/template
@@ -1,7 +1,7 @@
 # Template file for 'bottom'
 pkgname=bottom
 version=0.5.7
-revision=1
+revision=2
 build_style=cargo
 short_desc="Yet another cross-platform graphical process/system monitor"
 maintainer="Neel Chotai <neel@chot.ai>"
@@ -13,4 +13,9 @@ checksum=49e01a2930d913dba2a1329389faddb4b3971a6b0c08f7482d2759475d5cc27c
 post_install() {
 	vdoc README.md
 	vlicense LICENSE
+
+	cd "target/${RUST_TARGET}/release/build/bottom-"*/out
+	vcompletion btm.bash bash
+	vcompletion btm.fish fish
+	vcompletion _btm zsh
 }

Re: [PR PATCH] [Updated] bottom: shell completions

[zweimach]

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

There is an updated pull request by zweimach against master on the void-packages repository

https://github.com/zweimach/void-packages bottom-completions
https://github.com/void-linux/void-packages/pull/29455

bottom: shell completions
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/29455.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bottom-completions-29455.patch --]
[-- Type: text/x-diff, Size: 983 bytes --]

From e0a0e3e77bd5385984e58914abbd333c6e73a273 Mon Sep 17 00:00:00 2001
From: Ananda Umamil <zweimach@zweimach.org>
Date: Sun, 14 Mar 2021 17:37:44 +0700
Subject: [PATCH] bottom: shell completions

---
 srcpkgs/bottom/template | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/bottom/template b/srcpkgs/bottom/template
index 9d5fbd8dbfd0..8155e0cd36d9 100644
--- a/srcpkgs/bottom/template
+++ b/srcpkgs/bottom/template
@@ -1,7 +1,7 @@
 # Template file for 'bottom'
 pkgname=bottom
 version=0.5.7
-revision=1
+revision=2
 build_style=cargo
 short_desc="Yet another cross-platform graphical process/system monitor"
 maintainer="Neel Chotai <neel@chot.ai>"
@@ -13,4 +13,9 @@ checksum=49e01a2930d913dba2a1329389faddb4b3971a6b0c08f7482d2759475d5cc27c
 post_install() {
 	vdoc README.md
 	vlicense LICENSE
+
+	cd "target/${RUST_TARGET}/release/build/bottom-"*/out
+	vcompletion btm.bash bash btm
+	vcompletion btm.fish fish btm
+	vcompletion _btm zsh btm
 }

Re: bottom: shell completions

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29455#issuecomment-801099407

Comment:
> /void-packages/srcpkgs/bottom/template: line 17: cd: too many arguments

Any idea how to fix? Happens for all native builds...

Would be nice if Cargo had minimally sane output directories for build artifacts.

Re: bottom: shell completions

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29455#issuecomment-817241571

Comment:
Ping?

Re: bottom: shell completions

[zweimach]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

New comment by zweimach on void-packages repository

https://github.com/void-linux/void-packages/pull/29455#issuecomment-835889261

Comment:
> > /void-packages/srcpkgs/bottom/template: line 17: cd: too many arguments
> 
> Any idea how to fix? Happens for all native builds...
> 
> Would be nice if Cargo had minimally sane output directories for build artifacts.

Sorry, I know nothing about Rust and Cargo.

Re: bottom: shell completions

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29455#issuecomment-835890544

Comment:
You can try using `find` to find (heh) the pages...

Re: bottom: shell completions

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29455#issuecomment-841574312

Comment:
Closed by df9082f5e5282ea7c74dd5251432d45767e32d22

Re: [PR PATCH] [Closed]: bottom: shell completions

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

There's a closed pull request on the void-packages repository

bottom: shell completions
https://github.com/void-linux/void-packages/pull/29455

Description:
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR