* [PR PATCH] kubernetes-kind: set up shell completions.
@ 2021-04-12 21:23 gbrlsnchs
2021-04-13 15:28 ` [PR REVIEW] " ericonr
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: gbrlsnchs @ 2021-04-12 21:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]
There is a new pull request by gbrlsnchs against master on the void-packages repository
https://github.com/gbrlsnchs/void-packages kubernetes-kind
https://github.com/void-linux/void-packages/pull/30192
kubernetes-kind: set up shell completions.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/30192.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kubernetes-kind-30192.patch --]
[-- Type: text/x-diff, Size: 1442 bytes --]
From 89aa6f1f773853a2812cb3f23fd912d05311cb14 Mon Sep 17 00:00:00 2001
From: Gabriel Sanches <gabriel@gsr.dev>
Date: Mon, 12 Apr 2021 18:12:19 -0300
Subject: [PATCH] kubernetes-kind: set up shell completions.
---
srcpkgs/kubernetes-kind/template | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/kubernetes-kind/template b/srcpkgs/kubernetes-kind/template
index 4bc298a46685..93e391b7b97f 100644
--- a/srcpkgs/kubernetes-kind/template
+++ b/srcpkgs/kubernetes-kind/template
@@ -1,9 +1,10 @@
# Template file for 'kubernetes-kind'
pkgname=kubernetes-kind
version=0.10.0
-revision=1
+revision=2
wrksrc="kind-${version}"
build_style=go
+build_helper=qemu
go_import_path="sigs.k8s.io/kind"
short_desc="Kind is a tool for running local Kubernetes clusters using Docker"
maintainer="Andy Cobaugh <andrew.cobaugh@gmail.com>"
@@ -11,3 +12,18 @@ license="Apache-2.0"
homepage="https://kind.sigs.k8s.io/"
distfiles="https://github.com/kubernetes-sigs/kind/archive/v${version}.tar.gz"
checksum=@e5511659e3e1735531d4845405782d869d4fb425b545ea89151fd76208a12a49
+_completions="bash zsh fish"
+_pkgname="kind"
+
+post_build() {
+ local cli=$(find $GOPATH/bin -name $_pkgname)
+ for shell in $_completions; do
+ vtargetrun $cli completion $shell > "${_pkgname}.${shell}"
+ done
+}
+
+post_install() {
+ for shell in $_completions; do
+ vcompletion "${_pkgname}.${shell}" $shell $_pkgname
+ done
+}
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] kubernetes-kind: set up shell completions.
2021-04-12 21:23 [PR PATCH] kubernetes-kind: set up shell completions gbrlsnchs
@ 2021-04-13 15:28 ` ericonr
2021-04-13 15:32 ` gbrlsnchs
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-04-13 15:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 214 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30192#discussion_r612553180
Comment:
I'd rather see `kind` used directly instead of `_pkgname`, I think.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] kubernetes-kind: set up shell completions.
2021-04-12 21:23 [PR PATCH] kubernetes-kind: set up shell completions gbrlsnchs
2021-04-13 15:28 ` [PR REVIEW] " ericonr
@ 2021-04-13 15:32 ` gbrlsnchs
2021-04-13 15:34 ` [PR PATCH] [Updated] " gbrlsnchs
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: gbrlsnchs @ 2021-04-13 15:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
New review comment by gbrlsnchs on void-packages repository
https://github.com/void-linux/void-packages/pull/30192#discussion_r612557164
Comment:
I did that in order to avoid errors and repetitions, but sure, I can use "kind" directly.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] kubernetes-kind: set up shell completions.
2021-04-12 21:23 [PR PATCH] kubernetes-kind: set up shell completions gbrlsnchs
2021-04-13 15:28 ` [PR REVIEW] " ericonr
2021-04-13 15:32 ` gbrlsnchs
@ 2021-04-13 15:34 ` gbrlsnchs
2021-04-13 15:36 ` gbrlsnchs
2021-04-13 21:06 ` [PR PATCH] [Merged]: " ericonr
4 siblings, 0 replies; 6+ messages in thread
From: gbrlsnchs @ 2021-04-13 15:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]
There is an updated pull request by gbrlsnchs against master on the void-packages repository
https://github.com/gbrlsnchs/void-packages kubernetes-kind
https://github.com/void-linux/void-packages/pull/30192
kubernetes-kind: set up shell completions.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/30192.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kubernetes-kind-30192.patch --]
[-- Type: text/x-diff, Size: 1420 bytes --]
From 30535816cd27c4e6621e8bf7cc2117455f16299e Mon Sep 17 00:00:00 2001
From: Gabriel Sanches <gabriel@gsr.dev>
Date: Mon, 12 Apr 2021 18:12:19 -0300
Subject: [PATCH] kubernetes-kind: set up shell completions.
---
srcpkgs/kubernetes-kind/template | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/kubernetes-kind/template b/srcpkgs/kubernetes-kind/template
index 4bc298a46685..49d51031e3ae 100644
--- a/srcpkgs/kubernetes-kind/template
+++ b/srcpkgs/kubernetes-kind/template
@@ -1,9 +1,10 @@
# Template file for 'kubernetes-kind'
pkgname=kubernetes-kind
version=0.10.0
-revision=1
+revision=2
wrksrc="kind-${version}"
build_style=go
+build_helper=qemu
go_import_path="sigs.k8s.io/kind"
short_desc="Kind is a tool for running local Kubernetes clusters using Docker"
maintainer="Andy Cobaugh <andrew.cobaugh@gmail.com>"
@@ -11,3 +12,18 @@ license="Apache-2.0"
homepage="https://kind.sigs.k8s.io/"
distfiles="https://github.com/kubernetes-sigs/kind/archive/v${version}.tar.gz"
checksum=@e5511659e3e1735531d4845405782d869d4fb425b545ea89151fd76208a12a49
+patch_args="-Np1"
+_completions="bash zsh fish"
+
+post_build() {
+ local cli=$(find $GOPATH/bin -name kind)
+ for shell in $_completions; do
+ vtargetrun $cli completion $shell > "kind.${shell}"
+ done
+}
+
+post_install() {
+ for shell in $_completions; do
+ vcompletion "kind.${shell}" $shell kind
+ done
+}
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] kubernetes-kind: set up shell completions.
2021-04-12 21:23 [PR PATCH] kubernetes-kind: set up shell completions gbrlsnchs
` (2 preceding siblings ...)
2021-04-13 15:34 ` [PR PATCH] [Updated] " gbrlsnchs
@ 2021-04-13 15:36 ` gbrlsnchs
2021-04-13 21:06 ` [PR PATCH] [Merged]: " ericonr
4 siblings, 0 replies; 6+ messages in thread
From: gbrlsnchs @ 2021-04-13 15:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]
There is an updated pull request by gbrlsnchs against master on the void-packages repository
https://github.com/gbrlsnchs/void-packages kubernetes-kind
https://github.com/void-linux/void-packages/pull/30192
kubernetes-kind: set up shell completions.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/30192.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kubernetes-kind-30192.patch --]
[-- Type: text/x-diff, Size: 1400 bytes --]
From 925194c7f4e0ee46e10438a1d7f846bf3a05ed9c Mon Sep 17 00:00:00 2001
From: Gabriel Sanches <gabriel@gsr.dev>
Date: Mon, 12 Apr 2021 18:12:19 -0300
Subject: [PATCH] kubernetes-kind: set up shell completions.
---
srcpkgs/kubernetes-kind/template | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/kubernetes-kind/template b/srcpkgs/kubernetes-kind/template
index 4bc298a46685..018127c7818b 100644
--- a/srcpkgs/kubernetes-kind/template
+++ b/srcpkgs/kubernetes-kind/template
@@ -1,9 +1,10 @@
# Template file for 'kubernetes-kind'
pkgname=kubernetes-kind
version=0.10.0
-revision=1
+revision=2
wrksrc="kind-${version}"
build_style=go
+build_helper=qemu
go_import_path="sigs.k8s.io/kind"
short_desc="Kind is a tool for running local Kubernetes clusters using Docker"
maintainer="Andy Cobaugh <andrew.cobaugh@gmail.com>"
@@ -11,3 +12,17 @@ license="Apache-2.0"
homepage="https://kind.sigs.k8s.io/"
distfiles="https://github.com/kubernetes-sigs/kind/archive/v${version}.tar.gz"
checksum=@e5511659e3e1735531d4845405782d869d4fb425b545ea89151fd76208a12a49
+_completions="bash zsh fish"
+
+post_build() {
+ local cli=$(find $GOPATH/bin -name kind)
+ for shell in $_completions; do
+ vtargetrun $cli completion $shell > "kind.${shell}"
+ done
+}
+
+post_install() {
+ for shell in $_completions; do
+ vcompletion "kind.${shell}" $shell kind
+ done
+}
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: kubernetes-kind: set up shell completions.
2021-04-12 21:23 [PR PATCH] kubernetes-kind: set up shell completions gbrlsnchs
` (3 preceding siblings ...)
2021-04-13 15:36 ` gbrlsnchs
@ 2021-04-13 21:06 ` ericonr
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-04-13 21:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]
There's a merged pull request on the void-packages repository
kubernetes-kind: set up shell completions.
https://github.com/void-linux/void-packages/pull/30192
Description:
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-13 21:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-12 21:23 [PR PATCH] kubernetes-kind: set up shell completions gbrlsnchs
2021-04-13 15:28 ` [PR REVIEW] " ericonr
2021-04-13 15:32 ` gbrlsnchs
2021-04-13 15:34 ` [PR PATCH] [Updated] " gbrlsnchs
2021-04-13 15:36 ` gbrlsnchs
2021-04-13 21:06 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).