[PR PATCH] OpenRCT2: fix build type

[PR PATCH] OpenRCT2: fix build type

[Skirmisher]

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

There is a new pull request by Skirmisher against master on the void-packages repository

https://github.com/Skirmisher/void-packages upstream-master
https://github.com/void-linux/void-packages/pull/30201

OpenRCT2: fix build type
By default it produces a debug build, which crashes on assertions insetad of discarding them.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/30201.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-upstream-master-30201.patch --]
[-- Type: text/x-diff, Size: 865 bytes --]

From 0fce91676b69a3bad9c7842ba92b221b362cf40c Mon Sep 17 00:00:00 2001
From: Will Springer <skirmisher@protonmail.com>
Date: Tue, 13 Apr 2021 01:17:10 -0700
Subject: [PATCH] OpenRCT2: fix build type

By default it produces a debug build, which crashes on assertions instead of
discarding them.
---
 srcpkgs/OpenRCT2/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/OpenRCT2/template b/srcpkgs/OpenRCT2/template
index c5256b65287e..6d28d6ff951b 100644
--- a/srcpkgs/OpenRCT2/template
+++ b/srcpkgs/OpenRCT2/template
@@ -5,10 +5,11 @@ pkgname=OpenRCT2
 _objects_version=1.0.21
 _titles_version=0.1.2c
 version=0.3.3
-revision=1
+revision=2
 build_style=cmake
 configure_args="
  -DOPENRCT2_VERSION_TAG=${version}
+ -DCMAKE_BUILD_TYPE=RelWithDebInfo
  -DDOWNLOAD_TITLE_SEQUENCES=0
  -DDOWNLOAD_OBJECTS=0
  -DDISABLE_DISCORD_RPC=1

Re: [PR REVIEW] OpenRCT2: fix build type

[sgn]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/30201#discussion_r612510744

Comment:
Would you please check with `CXXFLAGS="-DNDEBUG"` instead?

Re: [PR REVIEW] OpenRCT2: fix build type

[Skirmisher]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New review comment by Skirmisher on void-packages repository

https://github.com/void-linux/void-packages/pull/30201#discussion_r612641893

Comment:
How is that preferable to setting it via CMake build type?

Re: [PR REVIEW] OpenRCT2: fix build type

[sgn]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/30201#discussion_r612849551

Comment:
Some people want to build their own package with `-O1` or `-O3` and/or disable `-g`, I suppose.
Anyway, I don't know which kitchen sink would be added into `RelWithDebInfo` in the future by CMake.

Re: [PR PATCH] [Updated] OpenRCT2: fix build type

[Skirmisher]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

There is an updated pull request by Skirmisher against master on the void-packages repository

https://github.com/Skirmisher/void-packages upstream-master
https://github.com/void-linux/void-packages/pull/30201

OpenRCT2: fix build type
By default it produces a debug build, which crashes on assertions insetad of discarding them.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/30201.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-upstream-master-30201.patch --]
[-- Type: text/x-diff, Size: 1066 bytes --]

From 6f4b5cdd2c8c063cf5c2c5d5e669f3a4ad395253 Mon Sep 17 00:00:00 2001
From: Will Springer <skirmisher@protonmail.com>
Date: Tue, 13 Apr 2021 01:17:10 -0700
Subject: [PATCH] OpenRCT2: fix build type

By default it produces a debug build, which crashes on assertions instead of
discarding them.
---
 srcpkgs/OpenRCT2/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/OpenRCT2/template b/srcpkgs/OpenRCT2/template
index c5256b65287e..749349b79a31 100644
--- a/srcpkgs/OpenRCT2/template
+++ b/srcpkgs/OpenRCT2/template
@@ -5,7 +5,7 @@ pkgname=OpenRCT2
 _objects_version=1.0.21
 _titles_version=0.1.2c
 version=0.3.3
-revision=1
+revision=2
 build_style=cmake
 configure_args="
  -DOPENRCT2_VERSION_TAG=${version}
@@ -15,6 +15,7 @@ configure_args="
  -DDISABLE_GOOGLE_BENCHMARK=1
  $(vopt_if multiplayer '' '-DDISABLE_NETWORK=1')
  $(vopt_if scripting '-DENABLE_SCRIPTING=1' '')"
+CFLAGS="-DNDEBUG"
 make_build_target="all g2"
 hostmakedepends="pkg-config unzip"
 makedepends="SDL2-devel fontconfig-devel freetype-devel libzip-devel

Re: [PR PATCH] [Updated] OpenRCT2: fix build type

[Skirmisher]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

There is an updated pull request by Skirmisher against master on the void-packages repository

https://github.com/Skirmisher/void-packages upstream-master
https://github.com/void-linux/void-packages/pull/30201

OpenRCT2: fix build type
By default it produces a debug build, which crashes on assertions insetad of discarding them.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/30201.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-upstream-master-30201.patch --]
[-- Type: text/x-diff, Size: 1010 bytes --]

From d071cd35ee79f30d2145f4c50d77e98777a35133 Mon Sep 17 00:00:00 2001
From: Will Springer <skirmisher@protonmail.com>
Date: Tue, 13 Apr 2021 01:17:10 -0700
Subject: [PATCH] OpenRCT2: fix build type

By default it produces a debug build, which crashes on assertions instead of
discarding them.
---
 srcpkgs/OpenRCT2/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/OpenRCT2/template b/srcpkgs/OpenRCT2/template
index c5256b65287e..fdf2d2d3b2ea 100644
--- a/srcpkgs/OpenRCT2/template
+++ b/srcpkgs/OpenRCT2/template
@@ -5,7 +5,7 @@ pkgname=OpenRCT2
 _objects_version=1.0.21
 _titles_version=0.1.2c
 version=0.3.3
-revision=1
+revision=2
 build_style=cmake
 configure_args="
  -DOPENRCT2_VERSION_TAG=${version}
@@ -37,6 +37,8 @@ skip_extraction="objects.zip title-sequences.zip"
 
 replaces="OpenRCT2-data>=0"
 
+CFLAGS="-DNDEBUG"
+
 build_options="multiplayer scripting"
 build_options_default="multiplayer scripting"
 desc_option_multiplayer="Enable multiplayer support"

Re: [PR REVIEW] OpenRCT2: fix build type

[Skirmisher]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New review comment by Skirmisher on void-packages repository

https://github.com/void-linux/void-packages/pull/30201#discussion_r612859658

Comment:
Ah, I researched more and I understand the problem now. Unfortunate that CMake does not deal with compiler flag precedence well.

Re: [PR PATCH] [Updated] OpenRCT2: fix build type

[Skirmisher]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

There is an updated pull request by Skirmisher against master on the void-packages repository

https://github.com/Skirmisher/void-packages upstream-master
https://github.com/void-linux/void-packages/pull/30201

OpenRCT2: fix build type
By default it produces a debug build, which crashes on assertions insetad of discarding them.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/30201.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-upstream-master-30201.patch --]
[-- Type: text/x-diff, Size: 1012 bytes --]

From e1e7628c84ae0ba99314c65f867cf8e3ac35b465 Mon Sep 17 00:00:00 2001
From: Will Springer <skirmisher@protonmail.com>
Date: Tue, 13 Apr 2021 01:17:10 -0700
Subject: [PATCH] OpenRCT2: fix build type

By default it produces a debug build, which crashes on assertions instead of
discarding them.
---
 srcpkgs/OpenRCT2/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/OpenRCT2/template b/srcpkgs/OpenRCT2/template
index c5256b65287e..03766a01fadd 100644
--- a/srcpkgs/OpenRCT2/template
+++ b/srcpkgs/OpenRCT2/template
@@ -5,7 +5,7 @@ pkgname=OpenRCT2
 _objects_version=1.0.21
 _titles_version=0.1.2c
 version=0.3.3
-revision=1
+revision=2
 build_style=cmake
 configure_args="
  -DOPENRCT2_VERSION_TAG=${version}
@@ -37,6 +37,8 @@ skip_extraction="objects.zip title-sequences.zip"
 
 replaces="OpenRCT2-data>=0"
 
+CXXFLAGS="-DNDEBUG"
+
 build_options="multiplayer scripting"
 build_options_default="multiplayer scripting"
 desc_option_multiplayer="Enable multiplayer support"

Re: [PR PATCH] [Updated] OpenRCT2: fix build type

[Skirmisher]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

There is an updated pull request by Skirmisher against master on the void-packages repository

https://github.com/Skirmisher/void-packages upstream-master
https://github.com/void-linux/void-packages/pull/30201

OpenRCT2: fix build type
By default it produces a debug build, which crashes on assertions insetad of discarding them.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/30201.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-upstream-master-30201.patch --]
[-- Type: text/x-diff, Size: 1258 bytes --]

From 53a3931ee178fe1dad1bb8aa2ebd723c54d21d04 Mon Sep 17 00:00:00 2001
From: Will Springer <skirmisher@protonmail.com>
Date: Tue, 13 Apr 2021 01:17:10 -0700
Subject: [PATCH] OpenRCT2: fix build type

By default it produces a debug build, which crashes on assertions instead of
discarding them.
---
 srcpkgs/OpenRCT2/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/OpenRCT2/template b/srcpkgs/OpenRCT2/template
index c5256b65287e..9705491f8f27 100644
--- a/srcpkgs/OpenRCT2/template
+++ b/srcpkgs/OpenRCT2/template
@@ -5,7 +5,7 @@ pkgname=OpenRCT2
 _objects_version=1.0.21
 _titles_version=0.1.2c
 version=0.3.3
-revision=1
+revision=2
 build_style=cmake
 configure_args="
  -DOPENRCT2_VERSION_TAG=${version}
@@ -37,6 +37,8 @@ skip_extraction="objects.zip title-sequences.zip"
 
 replaces="OpenRCT2-data>=0"
 
+CXXFLAGS="-DNDEBUG"
+
 build_options="multiplayer scripting"
 build_options_default="multiplayer scripting"
 desc_option_multiplayer="Enable multiplayer support"
@@ -48,7 +50,7 @@ fi
 
 if [ "$CROSS_BUILD" ]; then
 	hostmakedepends+=" OpenRCT2"
-	CXXFLAGS="-DHAVE_IMMINTRIN_H=false -DSDL_DISABLE_IMMINTRIN_H=1"
+	CXXFLAGS+=" -DHAVE_IMMINTRIN_H=false -DSDL_DISABLE_IMMINTRIN_H=1 "
 fi
 
 pre_configure() {

Re: [PR REVIEW] OpenRCT2: fix build type

[Skirmisher]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by Skirmisher on void-packages repository

https://github.com/void-linux/void-packages/pull/30201#discussion_r612865392

Comment:
Okay, I confirmed `-NDEBUG` works properly.

Re: [PR PATCH] [Updated] OpenRCT2: fix build type

[Skirmisher]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

There is an updated pull request by Skirmisher against master on the void-packages repository

https://github.com/Skirmisher/void-packages upstream-master
https://github.com/void-linux/void-packages/pull/30201

OpenRCT2: fix build type
By default it produces a debug build, which crashes on assertions insetad of discarding them.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

A patch file from https://github.com/void-linux/void-packages/pull/30201.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-upstream-master-30201.patch --]
[-- Type: text/x-diff, Size: 1257 bytes --]

From ee228bbae16cad7f5695dc6cfa9f587863f1575b Mon Sep 17 00:00:00 2001
From: Will Springer <skirmisher@protonmail.com>
Date: Tue, 13 Apr 2021 01:17:10 -0700
Subject: [PATCH] OpenRCT2: fix build type

By default it produces a debug build, which crashes on assertions instead of
discarding them.
---
 srcpkgs/OpenRCT2/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/OpenRCT2/template b/srcpkgs/OpenRCT2/template
index c5256b65287e..b36795aa9f76 100644
--- a/srcpkgs/OpenRCT2/template
+++ b/srcpkgs/OpenRCT2/template
@@ -5,7 +5,7 @@ pkgname=OpenRCT2
 _objects_version=1.0.21
 _titles_version=0.1.2c
 version=0.3.3
-revision=1
+revision=2
 build_style=cmake
 configure_args="
  -DOPENRCT2_VERSION_TAG=${version}
@@ -37,6 +37,8 @@ skip_extraction="objects.zip title-sequences.zip"
 
 replaces="OpenRCT2-data>=0"
 
+CXXFLAGS="-DNDEBUG"
+
 build_options="multiplayer scripting"
 build_options_default="multiplayer scripting"
 desc_option_multiplayer="Enable multiplayer support"
@@ -48,7 +50,7 @@ fi
 
 if [ "$CROSS_BUILD" ]; then
 	hostmakedepends+=" OpenRCT2"
-	CXXFLAGS="-DHAVE_IMMINTRIN_H=false -DSDL_DISABLE_IMMINTRIN_H=1"
+	CXXFLAGS+=" -DHAVE_IMMINTRIN_H=false -DSDL_DISABLE_IMMINTRIN_H=1"
 fi
 
 pre_configure() {

Re: [PR PATCH] [Merged]: OpenRCT2: fix build type

[q66]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

There's a merged pull request on the void-packages repository

OpenRCT2: fix build type
https://github.com/void-linux/void-packages/pull/30201

Description:
By default it produces a debug build, which crashes on assertions insetad of discarding them.

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR