[PR PATCH] wren-cli: remove package

[PR PATCH] wren-cli: remove package

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1818 bytes --]

There is a new pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages wren
https://github.com/void-linux/void-packages/pull/29966

wren-cli: remove package
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

---

My reasoning for suggesting the removal of this package is that I don't believe anyone uses it and its full functionality cannot be accessed without compiling a library that we cannot distribute because it isn't versioned.


A patch file from https://github.com/void-linux/void-packages/pull/29966.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wren-29966.patch --]
[-- Type: text/x-diff, Size: 1279 bytes --]

From 1e75366461ac316eb0c83fa092f4f5d252ddf6f0 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Fri, 2 Apr 2021 23:34:27 -0400
Subject: [PATCH] wren-cli: remove package

---
 srcpkgs/wren-cli/template | 28 ----------------------------
 1 file changed, 28 deletions(-)
 delete mode 100644 srcpkgs/wren-cli/template

diff --git a/srcpkgs/wren-cli/template b/srcpkgs/wren-cli/template
deleted file mode 100644
index e96411c0d3df..000000000000
--- a/srcpkgs/wren-cli/template
+++ /dev/null
@@ -1,28 +0,0 @@
-# Template file for 'wren-cli'
-pkgname=wren-cli
-version=0.3.0
-revision=1
-build_wrksrc=projects/make
-build_style=gnu-makefile
-make_build_args="config=release_${XBPS_TARGET_WORDSIZE}bit"
-checkdepends="python3"
-short_desc="Small, class-based, concurrent scripting language - CLI"
-maintainer="cinerea0 <cinerea0@protonmail.com>"
-license="MIT"
-homepage="http://wren.io/cli"
-distfiles="https://github.com/wren-lang/wren-cli/archive/${version}.tar.gz"
-checksum=a498d2ccb9a723e7163b4530efbaec389cc13e6baaf935e16cbd052a739b7265
-
-post_patch() {
-	vsed -i -e 's/ -m64 / /;s/ -m32 / /;s/ -O3//' wren_cli.make
-}
-
-do_check() {
-	cd ../..
-	python3 util/test.py
-}
-
-do_install() {
-	vbin ${wrksrc}/bin/wren_cli wren
-	vlicense ${wrksrc}/LICENSE
-}

Re: wren-cli: remove package

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29966#issuecomment-812811040

Comment:
Can you please include the reasoning in the commit message?

Do you think it isn't possible to improve packaging somehow? There was a lot of discussion in #23189, but maybe it can be revisited.

Re: wren-cli: remove package

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29966#issuecomment-812811040

Comment:
Can you please include the reasoning in the commit message? If you do decide to go ahead, please add it to `removed-packages` as well.

Do you think it isn't possible to improve packaging somehow? There was a lot of discussion in #23189, but maybe it can be revisited.

Re: wren-cli: remove package

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/29966#issuecomment-818391714

Comment:
My primary reasoning was that I don't think anyone actually uses the package, and because we haven't packaged wren. If there's some way to look at usage statistics, that may change my mind. As for wren, they just recently released version 0.4.0 of the library, but they haven't changed their build process at all. My issue regarding versioning the library (https://github.com/wren-lang/wren/issues/768) got no response, and after cloning and building I can confirm that they are still unversioned.

Re: wren-cli: remove package

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29966#issuecomment-819854761

Comment:
There is http://54.37.137.89/pkgs.void/package/wren-cli , but the amount of people running `popcorn` is very low, so it isn't really statistically significant.

Having the tool locally to be used while building things using `wren-lib` (not as a package) sounds reasonable to me, but if you prefer to remove it, we can go that way too.

Re: wren-cli: remove package

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/29966#issuecomment-839157489

Comment:
Your reasoning for keeping it has convinced me; I'll close this now.

Re: [PR PATCH] [Closed]: wren-cli: remove package

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

There's a closed pull request on the void-packages repository

wren-cli: remove package
https://github.com/void-linux/void-packages/pull/29966

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

---

My reasoning for suggesting the removal of this package is that I don't believe anyone uses it and its full functionality cannot be accessed without compiling a library that we cannot distribute because it isn't versioned.