Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] txr: update to 256.
@ 2021-04-12 15:48 natrys
  2021-04-17  6:24 ` [PR REVIEW] " ericonr
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: natrys @ 2021-04-12 15:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1582 bytes --]

There is a new pull request by natrys against master on the void-packages repository

https://github.com/natrys/void-packages txr-256
https://github.com/void-linux/void-packages/pull/30185

txr: update to 256.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30185.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-txr-256-30185.patch --]
[-- Type: text/x-diff, Size: 1322 bytes --]

From 7168e11a8cbf9e3f9c5c8a90f07afc90b75f8874 Mon Sep 17 00:00:00 2001
From: Imran Khan <imrankhan@teknik.io>
Date: Mon, 12 Apr 2021 21:42:11 +0600
Subject: [PATCH] txr: update to 256.

---
 srcpkgs/txr/template | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/txr/template b/srcpkgs/txr/template
index a05cb92f7fc1..02048a8ad26d 100644
--- a/srcpkgs/txr/template
+++ b/srcpkgs/txr/template
@@ -1,6 +1,6 @@
 # Template file for 'txr'
 pkgname=txr
-version=248
+version=256
 revision=1
 archs="x86_64* i686* aarch64* arm* ppc64* mips*"
 build_style=configure
@@ -13,7 +13,7 @@ license="BSD-2-Clause"
 homepage="http://www.nongnu.org/txr/"
 changelog="http://www.kylheku.com/cgit/txr/tree/RELNOTES?id=${pkgname}-${version}"
 distfiles="http://www.kylheku.com/cgit/txr/snapshot/${pkgname}-${version}.tar.bz2"
-checksum=58d04f9112b966f0b32e5ddf198622c97b4caaf990db23b5980eae7b44e3415e
+checksum=58e3e19bb7f3f9a440761f046fdacbc4d619b11c494a4ed9f8ad25c7a2974ddc
 nopie=yes
 
 if [ "$CROSS_BUILD" ]; then
@@ -26,11 +26,6 @@ pre_configure() {
 	fi
 }
 
-post_configure() {
-	vsed -i config.make -e "\#^PLATFORM_CFLAGS#s#:=.*\$#:= ${CFLAGS}#"
-	vsed -i config.make -e "\#^PLATFORM_LDFLAGS#s#:=.*\$#:= ${LDFLAGS}#"
-}
-
 post_install() {
 	vlicense LICENSE
 	vmkdir usr/share/vim/vimfiles/syntax

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] txr: update to 256.
  2021-04-12 15:48 [PR PATCH] txr: update to 256 natrys
@ 2021-04-17  6:24 ` ericonr
  2021-04-17  6:24 ` ericonr
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-04-17  6:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30185#discussion_r615214766

Comment:
```suggestion
changelog="http://www.kylheku.com/cgit/txr/tree/RELNOTES"
```

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] txr: update to 256.
  2021-04-12 15:48 [PR PATCH] txr: update to 256 natrys
  2021-04-17  6:24 ` [PR REVIEW] " ericonr
@ 2021-04-17  6:24 ` ericonr
  2021-04-17 14:15 ` natrys
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-04-17  6:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30185#discussion_r615215076

Comment:
I think this is still relevant... Why did you remove it?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] txr: update to 256.
  2021-04-12 15:48 [PR PATCH] txr: update to 256 natrys
  2021-04-17  6:24 ` [PR REVIEW] " ericonr
  2021-04-17  6:24 ` ericonr
@ 2021-04-17 14:15 ` natrys
  2021-04-17 14:16 ` [PR PATCH] [Updated] " natrys
  2021-04-18  0:28 ` [PR PATCH] [Merged]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: natrys @ 2021-04-17 14:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New review comment by natrys on void-packages repository

https://github.com/void-linux/void-packages/pull/30185#discussion_r615260181

Comment:
I think [upstream makefile](http://www.kylheku.com/cgit/txr/tree/Makefile#n34) respects the flags set by the build style now, I believe I put this long ago when it didn't use to.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] txr: update to 256.
  2021-04-12 15:48 [PR PATCH] txr: update to 256 natrys
                   ` (2 preceding siblings ...)
  2021-04-17 14:15 ` natrys
@ 2021-04-17 14:16 ` natrys
  2021-04-18  0:28 ` [PR PATCH] [Merged]: " ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: natrys @ 2021-04-17 14:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]

There is an updated pull request by natrys against master on the void-packages repository

https://github.com/natrys/void-packages txr-256
https://github.com/void-linux/void-packages/pull/30185

txr: update to 256.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30185.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-txr-256-30185.patch --]
[-- Type: text/x-diff, Size: 1497 bytes --]

From c3ae92acb7fc4b5bf07d2b92121da825c2d9116b Mon Sep 17 00:00:00 2001
From: Imran Khan <imrankhan@teknik.io>
Date: Mon, 12 Apr 2021 21:42:11 +0600
Subject: [PATCH] txr: update to 256.

---
 srcpkgs/txr/template | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/txr/template b/srcpkgs/txr/template
index a05cb92f7fc1..bcbe6d85b0d7 100644
--- a/srcpkgs/txr/template
+++ b/srcpkgs/txr/template
@@ -1,6 +1,6 @@
 # Template file for 'txr'
 pkgname=txr
-version=248
+version=256
 revision=1
 archs="x86_64* i686* aarch64* arm* ppc64* mips*"
 build_style=configure
@@ -11,9 +11,9 @@ short_desc="Programming language for convenient data munging"
 maintainer="Oliver Kiddle <okiddle@yahoo.co.uk>"
 license="BSD-2-Clause"
 homepage="http://www.nongnu.org/txr/"
-changelog="http://www.kylheku.com/cgit/txr/tree/RELNOTES?id=${pkgname}-${version}"
+changelog="http://www.kylheku.com/cgit/txr/tree/RELNOTES"
 distfiles="http://www.kylheku.com/cgit/txr/snapshot/${pkgname}-${version}.tar.bz2"
-checksum=58d04f9112b966f0b32e5ddf198622c97b4caaf990db23b5980eae7b44e3415e
+checksum=58e3e19bb7f3f9a440761f046fdacbc4d619b11c494a4ed9f8ad25c7a2974ddc
 nopie=yes
 
 if [ "$CROSS_BUILD" ]; then
@@ -26,11 +26,6 @@ pre_configure() {
 	fi
 }
 
-post_configure() {
-	vsed -i config.make -e "\#^PLATFORM_CFLAGS#s#:=.*\$#:= ${CFLAGS}#"
-	vsed -i config.make -e "\#^PLATFORM_LDFLAGS#s#:=.*\$#:= ${LDFLAGS}#"
-}
-
 post_install() {
 	vlicense LICENSE
 	vmkdir usr/share/vim/vimfiles/syntax

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: txr: update to 256.
  2021-04-12 15:48 [PR PATCH] txr: update to 256 natrys
                   ` (3 preceding siblings ...)
  2021-04-17 14:16 ` [PR PATCH] [Updated] " natrys
@ 2021-04-18  0:28 ` ericonr
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-04-18  0:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

There's a merged pull request on the void-packages repository

txr: update to 256.
https://github.com/void-linux/void-packages/pull/30185

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-04-18  0:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-12 15:48 [PR PATCH] txr: update to 256 natrys
2021-04-17  6:24 ` [PR REVIEW] " ericonr
2021-04-17  6:24 ` ericonr
2021-04-17 14:15 ` natrys
2021-04-17 14:16 ` [PR PATCH] [Updated] " natrys
2021-04-18  0:28 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).